kadircet added a comment.

In D128462#3793266 <https://reviews.llvm.org/D128462#3793266>, @beanz wrote:

> I think we had no expectation that DXC-mode would be supported by the tooling 
> APIs at this point.

Right, and as I mentioned in my previous comments this is completely fine, at 
least in the start. because as more and more developers start working with your 
toolchain, they'll also start using clang-tools and their bugs will be on us, 
rather than the maintainers of these toolchain/driver modes. which I believe 
puts the pressure on the wrong end, because we cannot even know what the 
intended way of handling these flags are, let alone knowing about the details 
of file discovery etc. that turns out to be a problem if not done properly.
My main complaint here's around **breaking** functionality for existing 
driver-modes/toolchains, and I am asking either getting OWNERS approvals going 
forward or being more through with the changes or changing the design overall 
to make these less complicated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128462/new/

https://reviews.llvm.org/D128462

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to