kadircet added a comment. In D133757#3792930 <https://reviews.llvm.org/D133757#3792930>, @nridge wrote:
> Thanks for the feedback! Yeah I'd be wary of introducing a corner case where > the user passes `--query-driver`, and there is in fact a driver available to > query in `PATH`, but we end up not querying it. Even if the outcome is the > same in cases we can think of, it feels like a footgun that's going to bite > some user somewhere. Just to give my perspective here to close the loop, I agree that there could be users effected from this I just wasn't sure if that would be common enough (+ we have workarounds by specifying the absolute path in config, database etc.) to justify both performing all the necessary review and maintenance afterwards. I think we've agreed on a somewhat less intrusive way for the change with Sam for the maintenance efforts, and we've already paid the review costs anyways. So I am also fine with going down this path, and hopefully not ending up seeing some surprises on dark corners of the universe. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133757/new/ https://reviews.llvm.org/D133757 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
