[PATCH] D132568: [clang][Sema] check default argument promotions for printf

inclyc updated this revision to Diff 455485. inclyc added a comment. Fix CI issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132568/new/ https://reviews.llvm.org/D132568 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/FormatStrin

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz added a comment. @sammccall Hello, is there any update required by me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127082/new/ https://reviews.llvm.org/D127082 ___ cfe-commits mailing list

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

Michael137 added a comment. In D128830#3746153 , @aprantl wrote: > I think we can "fix" the test with the following patch: > > diff --git a/lldb/test/API/functionalities/unused-inlined-parameters/main.c > b/lldb/test/API/functionalities/unused-inlined-

[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

h-vetinari added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:9-12 +else() + # ... unless explicily overridden + set(LIBCLANG_SOVERSION ${CLANG_VERSION_MAJOR}) +endif() Sorry I didn't get to comment in time, but now that the default was swit

[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

thieta added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:9-12 +else() + # ... unless explicily overridden + set(LIBCLANG_SOVERSION ${CLANG_VERSION_MAJOR}) +endif() h-vetinari wrote: > Sorry I didn't get to comment in time, but now that the

[clang] 879f511 - [Pipelines] Introduce DAE after ArgumentPromotion

Author: Pavel Samolysov Date: 2022-08-25T10:55:47+03:00 New Revision: 879f5118fc74657e4a5c4eff6810098e1eed75ac URL: https://github.com/llvm/llvm-project/commit/879f5118fc74657e4a5c4eff6810098e1eed75ac DIFF: https://github.com/llvm/llvm-project/commit/879f5118fc74657e4a5c4eff6810098e1eed75ac.dif

[clang] 5218a54 - [NFC] Fix a misleading comment CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

Author: Tobias Hieta Date: 2022-08-25T09:56:55+02:00 New Revision: 5218a542ac09ea97f78681f4f1b90a3b835c URL: https://github.com/llvm/llvm-project/commit/5218a542ac09ea97f78681f4f1b90a3b835c DIFF: https://github.com/llvm/llvm-project/commit/5218a542ac09ea97f78681f4f1b90a3b835c.diff

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov added a comment. Colleagues, thank you for the discussion. @aprantl @Michael137 Thank you very much for the patch and the test changes and confirmation. I've pushed the patch again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128830/n

[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

h-vetinari added a comment. I have another question, probably mainly for @tstellar (since I don't understand the `clang/tools/libclang/libclang.{exports,map}` infrastructure). Now that we're defaulting back to the equality case, would we need to reinstate `libclang.exports`? Repository: rG

[clang-tools-extra] ab9ee47 - [clang-tidy] Add test to cert-dcl58-cpp (NFC).

Author: Balázs Kéri Date: 2022-08-25T10:11:40+02:00 New Revision: ab9ee471dfda27b3cfb4a350e406576512ce9053 URL: https://github.com/llvm/llvm-project/commit/ab9ee471dfda27b3cfb4a350e406576512ce9053 DIFF: https://github.com/llvm/llvm-project/commit/ab9ee471dfda27b3cfb4a350e406576512ce9053.diff L

[PATCH] D131686: [clang-tidy] Add test to cert-dcl58-cpp (NFC).

This revision was automatically updated to reflect the committed changes. Closed by commit rGab9ee471dfda: [clang-tidy] Add test to cert-dcl58-cpp (NFC). (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131686/new/ https://revie

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

dblaikie added a comment. @MaskRay I think this change is probably the best point of comparison/demonstration of this patch direction (taking some minor liberties with this patch to simplify things somewhat in ways that have already been discussed/seem quite reasonable - specifically having `ge

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

CarlosAlbertoEnciso added a comment. @Ericson2314 It seems that these changes break building on Windows using Visual Studio 2019. There are 2 issues: - CMake now creates a directory `$(Configuration)` in the root build directory. $(Configuration)\lib\cmake\llvm Location before the changes:

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 created this revision. Herald added subscribers: carlosgalvezp, jeroen.dobbelaere, xazax.hun. Herald added a project: All. corona10 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fix modernize-use-emplace to support al

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke updated this revision to Diff 455516. Sockke added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/docs/ReleaseNo

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 added a comment. I am new to this project. I know that I need to write a test also likewise: https://github.com/llvm/llvm-project/blob/b8655f7ff286b9ebcd97cdd24b9c8eb5b89b9651/clang-tools-extra/test/clang-tidy/checkers/modernize/use-emplace.cpp#L872-L884 Please let me know how to generat

[PATCH] D131388: [docs] Add "Standard C++ Modules"

h-vetinari added a comment. In D131388#3748062 , @ChuanqiXu wrote: > Replace `C++20 Modules` with `Standard C++ Modules` since @ruoso pointed out > that `Modules` is not specific to certain versions of C++ (for example, > Modules may get some big change

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

sebastian-ne added a comment. This is probably caused by using `CMAKE_CFG_INTDIR` (indirectly) in more places. Seems like it expands to `$(Configuration)` for Visual Studio. Searching more about it, it’s only set at build time, but not at install time, which is a problem as well. On top of all,

[PATCH] D131501: [analyzer] Fix for incorrect handling of 0 length non-POD array construction

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3e9082b013b: [analyzer] Fix for incorrect handling of 0 length non-POD array construction (authored by isuckatcs). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[clang] e3e9082 - [analyzer] Fix for incorrect handling of 0 length non-POD array construction

Author: isuckatcs Date: 2022-08-25T12:42:02+02:00 New Revision: e3e9082b013ba948e3df6d4a2536df9d04656e76 URL: https://github.com/llvm/llvm-project/commit/e3e9082b013ba948e3df6d4a2536df9d04656e76 DIFF: https://github.com/llvm/llvm-project/commit/e3e9082b013ba948e3df6d4a2536df9d04656e76.diff LOG

[clang-tools-extra] 2d8e91a - [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Author: Sockke Date: 2022-08-25T18:47:38+08:00 New Revision: 2d8e91a5d3597461b5ae2a40d9362abde67b5e1f URL: https://github.com/llvm/llvm-project/commit/2d8e91a5d3597461b5ae2a40d9362abde67b5e1f DIFF: https://github.com/llvm/llvm-project/commit/2d8e91a5d3597461b5ae2a40d9362abde67b5e1f.diff LOG: [

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d8e91a5d359: [clang-tidy] Ignore other members in a union if any

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke added a comment. This patch has been around for a long time, I have added the release notes. There are users waiting for this fix and I committed it myself first. @LegalizeAdulthood I'm looking forward to your follow-up reply. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D132643: [OpenMP] Extend lit test for parallel for simd construct

animeshk-amd created this revision. animeshk-amd added reviewers: saiislam, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a project: All. animeshk-amd requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1.

[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

thakis added a comment. Was this reviewed by anyone on the original change? As far as I can tell, there was no agreement on the original change or here that reverting is the way to go. Was this discussed elsewhere? (I don't have an opinion on which approach is better myself.) Repository: rG

[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

thieta added a comment. In D132486#3748546 , @thakis wrote: > Was this reviewed by anyone on the original change? As far as I can tell, > there was no agreement on the original change or here that reverting is the > way to go. Was this discussed elsewhe

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

arichardson added inline comments. Comment at: cmake/Modules/GNUBinaryDirs.cmake:6 +if (NOT DEFINED CMAKE_BINARY_BINDIR) + set(CMAKE_BINARY_BINDIR "${CMAKE_BINARY_BINDIR}/bin") +endif() I find this name a bit confusing, maybe something like `CMAKE_BUILD_BINDIR`

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 updated this revision to Diff 455536. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132640/new/ https://reviews.llvm.org/D132640 Files: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp Index: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp ==

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

sebastian-ne added a comment. I’m not sure if it’s the case for all places (as `CMAKE_CFG_INTDIR` is not defined at install time), but I think the `CMAKE_BINARY_LIBDIR` introduced here serves the same purpose as the already existing `LLVM_LIBRARY_DIR`. Same for `CMAKE_BINARY_INCLUDEDIR`, which i

[PATCH] D108211: Emit sizeof/alignof values as notes when a static_assert fails

tbaeder added a comment. From looking at the output in the test cases, the additional diagnostics seem unnecessary to me in almost all cases...? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108211/new/ https://reviews.llvm.org/D108211

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

aaron.ballman added inline comments. Comment at: clang/include/clang/Frontend/SARIFDiagnostic.h:30-33 + SARIFDiagnostic & operator= ( const SARIFDiagnostic && ) = delete; + SARIFDiagnostic ( SARIFDiagnostic && ) = delete; + SARIFDiagnostic & operator= ( const SARIFDiagnostic

[PATCH] D108211: Emit sizeof/alignof values as notes when a static_assert fails

aaron.ballman added a comment. In D108211#3748595 , @tbaeder wrote: > From looking at the output in the test cases, the additional diagnostics > seem unnecessary to me in almost all cases...? +1; my observation is that the extra note repeats informati

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 updated this revision to Diff 455544. corona10 added a comment. Add unittest CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132640/new/ https://reviews.llvm.org/D132640 Files: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp clang-tools-extra/test/clang-tidy/check

[PATCH] D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check

carlosgalvezp updated this revision to Diff 455545. carlosgalvezp added a comment. Add a couple more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132461/new/ https://reviews.llvm.org/D132461 Files: clang-tools-extra/clang-tidy/cppcoregui

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

gchatelet added a comment. It also broke `llvm-exegesis` for 32 bits targets, see https://github.com/llvm/llvm-project/issues/57348 Reverting changes for the files in `tools/llvm-exegesis/` solves the compilation issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfdfc0dfa8ee3: [clang][Interp] Implement pointer (de)ref operators (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D132111

[clang] fdfc0df - [clang][Interp] Implement pointer (de)ref operators

Author: Timm Bäder Date: 2022-08-25T14:20:32+02:00 New Revision: fdfc0dfa8ee3dc3d39741ac03a975917f28dcb46 URL: https://github.com/llvm/llvm-project/commit/fdfc0dfa8ee3dc3d39741ac03a975917f28dcb46 DIFF: https://github.com/llvm/llvm-project/commit/fdfc0dfa8ee3dc3d39741ac03a975917f28dcb46.diff LO

[clang] 9be8630 - Add a missing override keyword. NFC.

Author: Benjamin Kramer Date: 2022-08-25T14:50:28+02:00 New Revision: 9be8630ca9445b3370385bdbce9b7919f267e38a URL: https://github.com/llvm/llvm-project/commit/9be8630ca9445b3370385bdbce9b7919f267e38a DIFF: https://github.com/llvm/llvm-project/commit/9be8630ca9445b3370385bdbce9b7919f267e38a.dif

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a subscriber: bkramer. zahiraam added a comment. Thanks @bkramer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 ___ cfe-commits mailing list cfe

[PATCH] D131388: [docs] Add "Standard C++ Modules"

ruoso added a comment. I just noticed that the document was implying that Header Units were separate from the Standard C++ Modules, but they are an integral part of the language in the specification of modules. The contrast that we do is between "Named Modules" and "Header Units". I did some ed

[PATCH] D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check

njames93 added a comment. The AllowWhileFlase option seems the wrong way to go about silencing do while(false) macros. Would it not make more sense to just ignore macros, or if you want more specificty don't warn on macros with a false condition? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check

carlosgalvezp added a comment. In D132461#3748812 , @njames93 wrote: > The AllowWhileFlase option seems the wrong way to go about silencing do > while(false) macros. Would it not make more sense to just ignore macros, or > if you want more specificty do

[PATCH] D132654: [clang-tidy] Fix false positive on `ArrayInitIndexExpr` inside `ProBoundsConstantArrayIndexCheck`

isuckatcs created this revision. isuckatcs added reviewers: aaron.ballman, LegalizeAdulthood, njames93. Herald added subscribers: carlosgalvezp, arphaman, kbarton, xazax.hun, nemanjai. Herald added a project: All. isuckatcs requested review of this revision. Herald added a project: clang-tools-extr

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

Ericson2314 added a comment. Let's just revert this. I'll do it later today if no one beats me to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 ___ cfe-co

[PATCH] D132617: [clang][deps] Minor ModuleDepCollector refactorings NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0a55121618b: [clang][deps] Minor ModuleDepCollector refactorings NFC (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] c0a5512 - [clang][deps] Minor ModuleDepCollector refactorings NFC

Author: Ben Langmuir Date: 2022-08-25T06:51:06-07:00 New Revision: c0a55121618b2f3f5db613cfb0d104a9ae2b700e URL: https://github.com/llvm/llvm-project/commit/c0a55121618b2f3f5db613cfb0d104a9ae2b700e DIFF: https://github.com/llvm/llvm-project/commit/c0a55121618b2f3f5db613cfb0d104a9ae2b700e.diff

[PATCH] D132659: PotentiallyEvaluatedContext in a ImmediateFunctionContext.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D132659 Files: clang/include/clang/Sema/Sema.h clan

[PATCH] D132661: [clang] Make guard(nocf) attribute available only for Windows

alvinhochun created this revision. alvinhochun added reviewers: rnk, ajpaverd, mstorsjo, aaron.ballman. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Control Flow Guard is only supported on Windows

[clang] bd28bd5 - [clang-cl] /kernel should toggle bit 30 in @feat.00

Author: David Majnemer Date: 2022-08-25T14:17:26Z New Revision: bd28bd59a3693b6abc12231f2140e02760c0ada0 URL: https://github.com/llvm/llvm-project/commit/bd28bd59a3693b6abc12231f2140e02760c0ada0 DIFF: https://github.com/llvm/llvm-project/commit/bd28bd59a3693b6abc12231f2140e02760c0ada0.diff LOG

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

aaron.ballman added subscribers: dexonsmith, rjmccall. aaron.ballman added a comment. In D132568#3747598 , @nickdesaulniers wrote: > In D132568#3746551 , @aaron.ballman > wrote: > >> Thank you for the patch, but

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki updated this revision to Diff 455579. yusuke-kadowaki marked 9 inline comments as done. yusuke-kadowaki added a comment. - Remove my comments - Update documentation - Sort Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132131/new/ ht

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/Format.cpp:649 IO.mapOptional("AlignOperands", Style.AlignOperands); -IO.mapOptional("AlignTrailingComment

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:20044 Style.Language = FormatStyle::LK_Cpp; - CHECK_PARSE_BOOL(AlignTrailingComments); CHECK_PARSE_BOOL(AllowAllArgumentsOnNextLine); don't remove Repository: rG LL

[PATCH] D132503: Add cxx scope if needed for requires clause.

ilya-biryukov added a subscriber: aaron.ballman. ilya-biryukov added a comment. Thanks for the fix. This looks ok to me, except that I am a bit suspicious of the fact that `DeclaratorScopeObj` is used somewhat rarely. I suspect we might want a different guard class for this, e.g. something simil

[clang] 34fe6dd - Revert "[CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited"

Author: John Ericson Date: 2022-08-25T11:13:46-04:00 New Revision: 34fe6ddce11e4e0e31a96669ab5f200e5fb8a747 URL: https://github.com/llvm/llvm-project/commit/34fe6ddce11e4e0e31a96669ab5f200e5fb8a747 DIFF: https://github.com/llvm/llvm-project/commit/34fe6ddce11e4e0e31a96669ab5f200e5fb8a747.diff

[PATCH] D132661: [clang] Make guard(nocf) attribute available only for Windows

aaron.ballman added a comment. Thanks for this! Can you also add test coverage for the change? Comment at: clang/include/clang/Basic/Attr.td:402 def TargetWebAssembly : TargetArch<["wasm32", "wasm64"]>; +def TargetHasCFGuard : TargetSpec { + let CustomCode = [{ Target.getTrip

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

inclyc added inline comments. Comment at: clang/test/FixIt/format.m:40 -void test_object_correction (id x) { +void test_object_correction (id x) { NSLog(@"%d", x); // expected-warning{{format specifies type 'int' but the argument has type 'id'}} aaron.bal

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

CarlosAlbertoEnciso added a comment. In D132316#3748845 , @Ericson2314 wrote: > Let's just revert this. I'll do it later today if no one beats me to it. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D127973: [analyzer] Eval construction of non POD type arrays.

steakhal added a comment. @isuckatcs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127973/new/ https://reviews.llvm.org/D127973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D127973: [analyzer] Eval construction of non POD type arrays.

steakhal added a comment. This patch broke the `exploded-graph-rewriter`. It prints this stack-trace, when I'm using the b032e3ff6121a969b2e90ad7bf493c2d5d7ac3a2 . The issue is still present at main. Traceback (most recent

[PATCH] D127973: [analyzer] Eval construction of non POD type arrays.

isuckatcs added a comment. @steakhal Can you send me a snippet please, which reproduces this issue? For me the egraph rewriter works fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127973/new/ https://reviews.llvm.org/D127973 ___

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

aaron.ballman added inline comments. Comment at: clang/test/FixIt/format.m:40 -void test_object_correction (id x) { +void test_object_correction (id x) { NSLog(@"%d", x); // expected-warning{{format specifies type 'int' but the argument has type 'id'}} in

[PATCH] D129570: [clang-tidy] Add new clang-tidy check to find implicit conversions from enum to integer.

pfultz2 added a comment. So can this be merged now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129570/new/ https://reviews.llvm.org/D129570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D132503: Add cxx scope if needed for requires clause.

aaron.ballman added reviewers: erichkeane, clang-language-wg. aaron.ballman added a comment. FWIW, I think this looks correct as well. I've added some reviewers just in case there's something I've missed regarding concepts. Comment at: clang/lib/Parse/ParseTemplate.cpp:293-301

[PATCH] D132503: Add cxx scope if needed for requires clause.

aaron.ballman added a comment. Also, don't forget to add a release note since this is fixing an issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132503/new/ https://reviews.llvm.org/D132503 ___ cfe-c

[PATCH] D131683: Diagnosing the Future Keywords

Codesbyusman updated this revision to Diff 455607. Codesbyusman added a comment. updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131683/new/ https://reviews.llvm.org/D131683 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/incl

[PATCH] D132503: Add cxx scope if needed for requires clause.

erichkeane added a comment. Like @ilya-biryukov , I don't really know enough of the uses of 'DeclaratorScopeObj ' to know if that is right, but other than Aaron's suggestions, I don't see anything to suggest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

inclyc added inline comments. Comment at: clang/lib/AST/FormatString.cpp:422 + case BuiltinType::Bool: +// Don't warn printf("%hd", [char]) +// https://reviews.llvm.org/D66186 aaron.ballman wrote: > The comment is talking about pa

[PATCH] D132592: [Clang] Implement function attribute nouwtable

aaron.ballman added a comment. Do we have any evidence that users need this level of control or will understand how to properly use the attribute? The command line option makes sense to me because it's an all-or-nothing flag, but I'm not certain I understand the need for per-function control. A

[PATCH] D128372: [Clang-Tidy] Empty Check

cjdb added a comment. This patch has been open for weeks without maintainer input, despite repeated requests, and @abrahamcd finishes his internship this Friday. We would very much appreciate direction on whether or not D128372 is ready to be merged. Reposit

[PATCH] D132286: [clang][Interp] Implement function calls

aaron.ballman added a comment. It looks like precommit CI found some relevant failures. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:614 + +if (Optional T = classify(E->getType())) { + // Put arguments on the stack. tbaeder wrote: > aaron.ballm

[clang] 22c477f - [HLSL] Initial codegen for SV_GroupIndex

Author: Chris Bieneman Date: 2022-08-25T11:17:54-05:00 New Revision: 22c477f934c4d1fa3f7d782d32a3e151f581c686 URL: https://github.com/llvm/llvm-project/commit/22c477f934c4d1fa3f7d782d32a3e151f581c686 DIFF: https://github.com/llvm/llvm-project/commit/22c477f934c4d1fa3f7d782d32a3e151f581c686.diff

[PATCH] D131203: [HLSL] Initial codegen for SV_GroupIndex

This revision was automatically updated to reflect the committed changes. Closed by commit rG22c477f934c4: [HLSL] Initial codegen for SV_GroupIndex (authored by beanz). Changed prior to commit: https://reviews.llvm.org/D131203?vs=454677&id=455616#toc Repository: rG LLVM Github Monorepo CHAN

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

inclyc marked 2 inline comments as done. inclyc added inline comments. Comment at: clang/lib/AST/FormatString.cpp:367 +case BuiltinType::Char_U: +case BuiltinType::Bool: + return Match; aaron.ballman wrote: > Isn't this a match promotion

[PATCH] D132670: [clang] Add cxx scope if needed for requires clause.

luken-google created this revision. Herald added a project: All. luken-google requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes issue #55216. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D132670 Files: clang/docs

[PATCH] D132503: Add cxx scope if needed for requires clause.

luken-google updated this revision to Diff 455620. luken-google added a comment. Responding to feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132503/new/ https://reviews.llvm.org/D132503 Files: clang/docs/ReleaseNotes.rst clang/lib/Pa

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

aaron.ballman added inline comments. Comment at: clang/lib/AST/FormatString.cpp:422 + case BuiltinType::Bool: +// Don't warn printf("%hd", [char]) +// https://reviews.llvm.org/D66186 inclyc wrote: > aaron.ballman wrote: > > The co

[PATCH] D132503: Add cxx scope if needed for requires clause.

luken-google marked 2 inline comments as done. luken-google added a comment. Thanks for the feedback and the code review. I've uploaded a new revision with the requested changes, PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132503/new/ http

[PATCH] D132670: [clang] Add cxx scope if needed for requires clause.

luken-google abandoned this revision. luken-google added a comment. Uploaded by mistake, kindly ignore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132670/new/ https://reviews.llvm.org/D132670 ___ cfe-

[PATCH] D132503: Add cxx scope if needed for requires clause.

erichkeane added inline comments. Comment at: clang/lib/Parse/ParseTemplate.cpp:293 +if (Tok.is(tok::kw_requires)) { + CXXScopeSpec ScopeSpec = DeclaratorInfo.getCXXScopeSpec(); + DeclaratorScopeObj DeclScopeObj(*this, ScopeSpec); Not sure about thi

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

aaron.ballman added inline comments. Comment at: clang/lib/AST/FormatString.cpp:367 +case BuiltinType::Char_U: +case BuiltinType::Bool: + return Match; inclyc wrote: > aaron.ballman wrote: > > Isn't this a match promotion as well? e.g. `p

[PATCH] D132503: [clang] Add cxx scope if needed for requires clause.

luken-google updated this revision to Diff 455622. luken-google retitled this revision from "Add cxx scope if needed for requires clause." to "[clang] Add cxx scope if needed for requires clause.". luken-google added a comment. Make ScopeSpec a reference. Repository: rG LLVM Github Monorepo

[PATCH] D131639: [OpenMP] Remove 'stdbool.h' from OpenMP header wrappers

ivanrodriguez3753 added a comment. This looks good to me, and I agree we should document what this is fixing. Any update on if/when this will land? In my opinion, there's nothing broken about the user code (definitely contrived, though). They didn't ask for `stdbool.h` so there should not be a

[PATCH] D132503: [clang] Add cxx scope if needed for requires clause.

luken-google added inline comments. Comment at: clang/lib/Parse/ParseTemplate.cpp:293 +if (Tok.is(tok::kw_requires)) { + CXXScopeSpec ScopeSpec = DeclaratorInfo.getCXXScopeSpec(); + DeclaratorScopeObj DeclScopeObj(*this, ScopeSpec); erichkeane wrote

[PATCH] D131639: [OpenMP] Remove 'stdbool.h' from OpenMP header wrappers

jhuber6 added a comment. In D131639#3749408 , @ivanrodriguez3753 wrote: > This looks good to me, and I agree we should document what this is fixing. > Any update on if/when this will land? > > In my opinion, there's nothing broken about the user code (d

[PATCH] D132661: [clang] Make guard(nocf) attribute available only for Windows

rnk added inline comments. Comment at: clang/include/clang/Basic/Attr.td:373-375 // Specifies Operating Systems for which the target applies, based off the // OSType enumeration in Triple.h list OSes; Do we need customcode? Can we not use the OS list her

[PATCH] D132659: PotentiallyEvaluatedContext in a ImmediateFunctionContext.

shafik added a comment. This looks good to me but I want another set of eyes on this. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:942 +} // namespace GH51182 \ No newline at end of file Please add a newline Repository: rG LLVM Github Monorepo CHANG

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

inclyc updated this revision to Diff 455626. inclyc added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132568/new/ https://reviews.llvm.org/D132568 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/FormatS

[PATCH] D132600: [llvm-profdata] Handle internal linkage functions in profile supplementation

xur added inline comments. Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:606 +} else { + StaticFuncMap[NewName] = "---"; +} davidxl wrote: > define a macro for the marker string. Will do. Comment at: llvm/tools/llvm-profda

[PATCH] D132672: [Docs] [HLSL] Documenting HLSL Entry Functions

beanz created this revision. beanz added reviewers: tex3d, pow2clk, bob80905, bogner, python3kgae, gracejennings. Herald added a subscriber: Anastasia. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. This document describes the basic usage and

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

nickdesaulniers added a comment. In D132568#3747971 , @inclyc wrote: >> Do we want to encode that in `test_promotion` in >> `clang/test/Sema/format-strings.c`? Seems like tests on shorts are missing. > > Tests for short and char "incompatibility" could b

[PATCH] D132659: PotentiallyEvaluatedContext in a ImmediateFunctionContext.

shafik added a subscriber: cor3ntin. shafik added a comment. CC @cor3ntin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132659/new/ https://reviews.llvm.org/D132659 ___ cfe-commits mailing list cfe-commi

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

inclyc added inline comments. Comment at: clang/lib/AST/FormatString.cpp:401 + if (const auto *BT = argTy->getAs()) { +if (!Ptr) { + switch (BT->getKind()) { nickdesaulniers wrote: > aaron.ballman wrote: > > It's a bit strange that we have t

[PATCH] D131639: [OpenMP] Remove 'stdbool.h' from OpenMP header wrappers

ivanrodriguez3753 added a comment. The user didn't define any `__` or `_[A-Z]` identifiers, though? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131639/new/ https://reviews.llvm.org/D131639 ___ cfe-comm

[PATCH] D131639: [OpenMP] Remove 'stdbool.h' from OpenMP header wrappers

jhuber6 added a comment. In D131639#3749563 , @ivanrodriguez3753 wrote: > The user didn't define any `__` or `_[A-Z]` identifiers, though? Am I misunderstanding the test input? /* Visual Studio < 2013 does not have stdbool.h so here it is a replaceme

[PATCH] D132592: [Clang] Implement function attribute nouwtable

ychen added a comment. Thanks for taking a look! In D132592#3749261 , @aaron.ballman wrote: > Do we have any evidence that users need this level of control or will > understand how to properly use the attribute? The command line option makes > sense t

[PATCH] D132600: [llvm-profdata] Handle internal linkage functions in profile supplementation

xur updated this revision to Diff 455640. xur added a comment. Integrated David's review commends. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132600/new/ https://reviews.llvm.org/D132600 Files: clang/lib/CodeGen/CodeGenModule.cpp llvm/include/llvm/ProfileData/SampleProf.h llvm

[PATCH] D131639: [OpenMP] Remove 'stdbool.h' from OpenMP header wrappers

ivanrodriguez3753 added a comment. They are defining their own `bool`, which aliases to the built-in `_Bool` (which is reserved, as you noted with `_[A-Z]`). I thought `bool` was fair game unless they included `stdbool.h`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D132659: PotentiallyEvaluatedContext in a ImmediateFunctionContext.

cor3ntin added a comment. Yes, this looks good to me too. Thanks for working on this. Can you modify ReleaseNotes.rst to mention the fixed issue? Comment at: clang/include/clang/Sema/Sema.h:1355 + InImmediateFunctionContext) || + // [expr.const#def:imm

[PATCH] D132659: PotentiallyEvaluatedContext in a ImmediateFunctionContext.

aaron.ballman added reviewers: cor3ntin, aaron.ballman, clang-language-wg. aaron.ballman added a comment. Adding a few more reviewers just in case, but this is generally looking good. Please also add a release note for the fix! Comment at: clang/include/clang/Sema/Sema.h:1355

  1   2   >