aaron.ballman added a comment. Thanks for this! Can you also add test coverage for the change?
================ Comment at: clang/include/clang/Basic/Attr.td:402 def TargetWebAssembly : TargetArch<["wasm32", "wasm64"]>; +def TargetHasCFGuard : TargetSpec { + let CustomCode = [{ Target.getTriple().isOSWindows() }]; ---------------- How about we name this one `TargetWindows` instead of making it specific to just one attribute? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132661/new/ https://reviews.llvm.org/D132661 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits