xur added inline comments.
================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:606
+ } else {
+ StaticFuncMap[NewName] = "---";
+ }
----------------
davidxl wrote:
> define a macro for the marker string.
Will do.
================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:655
const sampleprof::FunctionSamples &FS = PD.second;
auto It = InstrProfileMap.find(FContext.toString());
+ if (It == InstrProfileMap.end()) {
----------------
davidxl wrote:
> Skip to the next (using continue) when FS is not interesting (cold etc)
OK.
================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:667
+ }
+ if (FS.getMaxCountInside() > ColdSampleThreshold &&
It != InstrProfileMap.end() &&
----------------
davidxl wrote:
> continue when Itr == end or when Itr is not cold
Will change.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132600/new/
https://reviews.llvm.org/D132600
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
