[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

tejohnson added a comment. Looked into this a bit and the change does also seem correct to me. One comment: I see a test checking the upgrade behavior from the old Error type, but not for the upgrade from Max to Min. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:613 +result = EmitUnpromotion(promotionTy, E->getSubExpr()->getType(), result); + return result; +} You should unpromote only if we're not in a promoted context, which is to say,

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 453712. royjacobson added a comment. Add disclaimer to cxx_status about the standing DRs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619 Files: clang/docs/Rele

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson added inline comments. Comment at: clang/docs/ReleaseNotes.rst:494-497 +- Implemented "Conditionally Trivial Special Member Functions" (`P0848 `_). + Note: The handling of deleted functions is not yet compliant, as Clang + does not implem

[PATCH] D131677: [clang][RISCV] Fix incorrect ABI lowering for inherited structs under hard-float ABIs

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/riscv-abi.cpp:98 + +// Check for correct lowering in the presence of diamoned inheritance. + diamoned -> diamond CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131677/new/ https://

[PATCH] D132144: [Clang][BPF] Support record argument with direct values

anakryiko added a comment. Are there any restrictions about number of struct arguments that can be passed in? Kernel changes were assuming at most 2, should we have a test that tests passing 3 structs that fit into 5 input registers and another test that passes 3 structs that do not fit in 5 in

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453723. ckissane added a comment. - fix static initialization skip errors in getCompressionSpec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 Files: clang-tools-

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

vaibhav.y added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:155 +break; + } +} Does this need an `llvm_unreachable` after the switch? Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:177 + // original path as

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. There's a whole ton of test coverage missing from this (no actual sema tests, no AST dumping tests for text or JSON) not to mention a ton of situational tests that are

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane marked an inline comment as done. ckissane added inline comments. Comment at: llvm/include/llvm/Object/Decompressor.h:52-53 uint64_t DecompressedSize; + compression::CompressionSpecRef CompressionScheme = + compression::CompressionSpecRefs::Zlib; }; ---

[PATCH] D132144: [Clang][BPF] Support record argument with direct values

yonghong-song added a comment. In D132144#3732685 , @anakryiko wrote: > Are there any restrictions about number of struct arguments that can be > passed in? Kernel changes were assuming at most 2, should we have a test that > tests passing 3 structs tha

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

vaibhav.y added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnosticPrinter.cpp:71 + // other infrastructure necessary when emitting more rich diagnostics. + if (!Info.getLocation().isValid()) { // TODO: What is this case? +// SARIFDiag->addDiagnosticWithoutLoca

[PATCH] D132144: [Clang][BPF] Support record argument with direct values

yonghong-song added a comment. The compiler only counted the total number of registers won't exceed 5. You could have 5 struct arguments (each one register), or 2 struct arguments (with two registers each) and one integer register. Whether to pass by value or by reference is a ABI issue, not rel

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

oleg.smolsky updated this revision to Diff 453740. oleg.smolsky added a comment. Add AST matchers for the `if` statements and improve the actual check implementation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131985/new/ https://reviews.llvm.org/D131985 Files: clang-tools-extra/

[PATCH] D132144: [Clang][BPF] Support record argument with direct values

yonghong-song added a comment. > Kernel changes were assuming at most 2 My new version code allows all 5 parameters to be a structure argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132144/new/ https://reviews.llvm.org/D132144 ___

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

psoni2628 updated this revision to Diff 453745. psoni2628 added a comment. - Simplify expression based on reviewer comments - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131526/new/ https://reviews.llvm.org/D131526 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenM

[PATCH] D131708: [RISCV] Change how mtune aliases are implemented.

craig.topper updated this revision to Diff 453746. craig.topper added a comment. Add release note about sifive-7-rv32/64 being removed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131708/new/ https://reviews.llvm.org/D131708 Files: clang/docs/R

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 453747. python3kgae added a comment. Update to work around arc error when land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.org/D124753 Files: clang/include/clang/Drive

[clang] 8564e2f - [Inlining] Add a clang option to limit inlining of functions

Author: Wolfgang Pieb Date: 2022-08-18T11:56:24-07:00 New Revision: 8564e2fea559c58fecab3c7c01acf498bbe7820a URL: https://github.com/llvm/llvm-project/commit/8564e2fea559c58fecab3c7c01acf498bbe7820a DIFF: https://github.com/llvm/llvm-project/commit/8564e2fea559c58fecab3c7c01acf498bbe7820a.diff

[PATCH] D131986: [inlining] Add a clang option to control inlining of functions based on stack size

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8564e2fea559: [Inlining] Add a clang option to limit inlining of functions (authored by wolfgangp). Herald added a project: clang. Changed prior to

[clang] 140b0bf - [HLSL] Set main as default entry.

Author: Xiang Li Date: 2022-08-18T11:57:36-07:00 New Revision: 140b0bf89902845be14a4a710289bee49e0d1fc5 URL: https://github.com/llvm/llvm-project/commit/140b0bf89902845be14a4a710289bee49e0d1fc5 DIFF: https://github.com/llvm/llvm-project/commit/140b0bf89902845be14a4a710289bee49e0d1fc5.diff LOG:

[PATCH] D124753: [HLSL] Set main as default entry.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG140b0bf89902: [HLSL] Set main as default entry. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D132147: [clang][dataflow] Refactor `TestingSupport.h`

gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:60 +/// Arguments for building the dataflow analysis. +template struct AnalysisArguments { + /// Input code that is analyzed. AnalysisInputs? ===

[clang] ca6d70b - [LinkerWrapper][NFC] Clean-up error handling

Author: Joseph Huber Date: 2022-08-18T15:01:01-04:00 New Revision: ca6d70b32effe51a8d1654efe93154e7b96dcc23 URL: https://github.com/llvm/llvm-project/commit/ca6d70b32effe51a8d1654efe93154e7b96dcc23 DIFF: https://github.com/llvm/llvm-project/commit/ca6d70b32effe51a8d1654efe93154e7b96dcc23.diff

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:613 +result = EmitUnpromotion(promotionTy, E->getSubExpr()->getType(), result); + return result; +} rjmccall wrote: > You should unpromote only if we're not in a promoted context

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

joanahalili added a comment. We have a translation unit, on which we see an increase of compilation time and clang memory allocation from 11GB to 14GB. We are working on an isolated case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128113/new/ h

[PATCH] D132098: [clang][Interp] Implement inv and neg unary operations

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:131 + + return this->emitNE(*T, SubExpr); +} Can you explain this line? Comment at: clang/lib/AST/Interp/Interp.h:183 + + S.Stk.push(Val); + return tr

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

arda updated this revision to Diff 453751. arda added a comment. Add a clang Driver test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131618/new/ https://reviews.llvm.org/D131618 Files: clang/include/clang/Basic/CodeGenOptions.def clang/inclu

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

aaron.ballman added a comment. Precommit CI found a relevant failure. Comment at: clang/lib/Frontend/SARIFDiagnosticPrinter.cpp:71 + // other infrastructure necessary when emitting more rich diagnostics. + if (!Info.getLocation().isValid()) { // TODO: What is this case? +

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7a33090a910: [cmake] Use `CMAKE_INSTALL_LIBDIR` too (authored by

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

cor3ntin added a comment. @aaron.ballman I think this looks good, you want to double check? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619 ___ cfe-commits mail

[PATCH] D132098: [clang][Interp] Implement inv and neg unary operations

aaron.ballman added a comment. I'd appreciate if we handled unary `~` and `+` soon after this Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:620 + case UO_Deref: // *x + case UO_Not:// ~x + case UO_Real: // __real x This is reachable and will al

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov updated this revision to Diff 453757. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128095/new/ https://reviews.llvm.org/D128095 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h clang/include/clang/Sema/SemaInternal.

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbce94ea551ae: [OMPIRBuilder] Add support for safelen clause (authored by psoni2628). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] bce94ea - [OMPIRBuilder] Add support for safelen clause

Author: Prabhdeep Singh Soni Date: 2022-08-18T15:43:08-04:00 New Revision: bce94ea551ae775805824d62944aa585c4f831b6 URL: https://github.com/llvm/llvm-project/commit/bce94ea551ae775805824d62944aa585c4f831b6 DIFF: https://github.com/llvm/llvm-project/commit/bce94ea551ae775805824d62944aa585c4f831b

[clang] 377dddf - [clang][Driver] Pass correct reproduce flag to lld-link

Author: Alex Brachet Date: 2022-08-18T20:12:23Z New Revision: 377dddf4a08335a79180dd1d7907cb98ceaa641a URL: https://github.com/llvm/llvm-project/commit/377dddf4a08335a79180dd1d7907cb98ceaa641a DIFF: https://github.com/llvm/llvm-project/commit/377dddf4a08335a79180dd1d7907cb98ceaa641a.diff LOG:

[PATCH] D131214: [clang][Driver] Pass correct reproduce flag to lld-link

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. abrachet marked an inline comment as done. Closed by commit rG377dddf4a083: [clang][Driver] Pass correct reproduce flag to lld-link (authored by abrachet). Herald added

[PATCH] D132144: [Clang][BPF] Support record argument with direct values

ast added a comment. clang -target bpf -O2 -S t3.c t3.c:1:5: error: defined with too many args this will be the case when backend needs to emit the code, but if the function is always_inline it can have more than 5 arguments, right? Would be good to have a test for that to make sure when BPF_KPRO

[PATCH] D131708: [RISCV] Change how mtune aliases are implemented.

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/docs/ReleaseNotes.rst:197 + +- ``sifive-7-rv32`` and ``sifive-7-rv64`` are no longer supported for `-mcpu`. + Can you given any guidan

[PATCH] D132098: [clang][Interp] Implement inv and neg unary operations

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:131 + + return this->emitNE(*T, SubExpr); +} shafik wrote: > Can you explain this line? Nevermind, I get it, you are emitting a `0` and then doing a not equal to zero to

[PATCH] D132098: [clang][Interp] Implement inv and neg unary operations

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:620 + case UO_Deref: // *x + case UO_Not:// ~x + case UO_Real: // __real x aaron.ballman wrote: > This is reachable and will always return true thanks to the magic of in

[PATCH] D131980: [Passes] Don't run tail-call-elim in -O1

aeubanks abandoned this revision. aeubanks added a comment. will use Eli's suggestion instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131980/new/ https://reviews.llvm.org/D131980 ___ cfe-commits ma

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453774. ckissane marked an inline comment as done. ckissane added a comment. - CompressionImplementation member on Decompressor instead of Spec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https:/

[PATCH] D131214: [clang][Driver] Pass correct reproduce flag to lld-link

thakis added a comment. The removal of the explicit target broke the test on Mac: http://45.33.8.238/macm1/42754/step_7.txt (Just need to be more permissive about leading underscores) Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane marked an inline comment as done. ckissane added a comment. @dblaikie I've handled most of your comments, can you take another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 __

[clang] c175d80 - [clang][test] Recognize leading unscore for macos

Author: Alex Brachet Date: 2022-08-18T21:03:28Z New Revision: c175d80be2ed496debb98d47f315aa5e60116768 URL: https://github.com/llvm/llvm-project/commit/c175d80be2ed496debb98d47f315aa5e60116768 DIFF: https://github.com/llvm/llvm-project/commit/c175d80be2ed496debb98d47f315aa5e60116768.diff LOG:

[PATCH] D131214: [clang][Driver] Pass correct reproduce flag to lld-link

abrachet added a comment. In D131214#3733317 , @thakis wrote: > The removal of the explicit target broke the test on Mac: > http://45.33.8.238/macm1/42754/step_7.txt > > (Just need to be more permissive about leading underscores) > > Please take a look a

[clang] 0ac597f - [NFC] Move DXC driver tests

Author: Chris Bieneman Date: 2022-08-18T16:06:41-05:00 New Revision: 0ac597f3cacf60479ffd36b03766fa7462dabd78 URL: https://github.com/llvm/llvm-project/commit/0ac597f3cacf60479ffd36b03766fa7462dabd78 DIFF: https://github.com/llvm/llvm-project/commit/0ac597f3cacf60479ffd36b03766fa7462dabd78.diff

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 453779. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov marked 3 inline comments as done. mizvekov added a comment. In D111283#3721905 , @davrec wrote: > But instead of defining it and getting into details it might be clearer, and > certainly would have saved me the most time, for the description to

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

dblaikie added inline comments. Comment at: llvm/include/llvm/Object/Decompressor.h:52-53 uint64_t DecompressedSize; + compression::CompressionSpecRef CompressionScheme = + compression::CompressionSpecRefs::Zlib; }; ckissane wrote: > dblaikie wrote: > >

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 453788. abrahamcd added a comment. Commented out unfinished test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files: clang/include/clang/Frontend/SARIFDia

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

v.g.vassilev added a comment. Thanks for working on this! I left some comments. I did not look very deep in the patch but it seems quite consistent to the rest of the code in Sema. Can you provide some performance numbers for this patch. I believe that the less confident reviewers will be more

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

shafik added a comment. This mostly makes sense to me but I will let @tahonermann review it as well. Comment at: clang/test/AST/Interp/literals.cpp:41 + +constexpr const int* getIntPointer() { + return &m; What are these functions testing? CHANGES SINCE LAS

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:14938 + + if (E->getType().isNull()) +return false; Curious why these two checks don't go w/ the `::Evaluate(Result, Info, E)` below. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453803. ckissane added a comment. - shorten compression related variable names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 Files: clang-tools-extra/clangd/inde

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:613 +result = EmitUnpromotion(promotionTy, E->getSubExpr()->getType(), result); + return result; +} zahiraam wrote: > rjmccall wrote: > > You should unpromote only if we're not i

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane marked 2 inline comments as done. ckissane added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:38-39 + +CompressionSpecRef getCompressionSpec(uint8_t Kind); +CompressionSpecRef getCompressionSpec(CompressionKind Kind); +CompressionSpecRef getScheme

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

paulkirth added inline comments. Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:5080 + +void llvm::embedBitcodeInFatObject(llvm::Module &M, llvm::MemoryBufferRef Buf) { + // Save llvm.compiler.used and remove it. Since this has been merged into this comm

[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

MaskRay updated this revision to Diff 453806. MaskRay added a comment. add Bitcode/upgrade-pic-level.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130531/new/ https://reviews.llvm.org/D130531 Files: clang/test/CodeGen/piclevels.c llvm/lib/I

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

nathanchance added a comment. I can no longer do a two stage build on Fedora after this change. $ cmake \ -B build/stage1 \ -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_C_COMPILER=$(command -v clang) \ -DCMAKE_CXX_COMPILER=$(command -v clang++) \ -DLLVM_ENABLE_PROJECTS="clang;lld" \ -DLLVM_

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd added a comment. In D131632#3733068 , @aaron.ballman wrote: > Precommit CI found a relevant failure. I think this was just from the unfinished unit test. I can go ahead and remove `clang/unittests/Frontend/SARIFDiagnosticTest.cpp` entirely if

[PATCH] D132142: [analyzer] Prefer wrapping SymbolicRegions by ElementRegions

NoQ added a comment. Like I vaguely mentioned in the thread, I'm really curious whether it's possible to canonicalize the *absence* of element regions instead, as it allows modeling pointer casts as no-op and avoids problems like D38797 where results of even ve

[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130531/new/ https://reviews.llvm.org/D130531 _

[PATCH] D132144: [Clang][BPF] Support record argument with direct values

yonghong-song added a comment. > but if the function is always_inline it can have more than 5 arguments, > right? That is correct. Will add a test case for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132144/new/ https://reviews.llvm.org

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 453824. mizvekov marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-too

[PATCH] D132186: Clang add front flags for Wmisnoinline

iamarchit123 created this revision. Herald added subscribers: mtrofin, ormris, ChuanqiXu, haicheng, hiraditya. Herald added a project: All. iamarchit123 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Test Plan: Reposito

[PATCH] D132188: Add documentation and test cases for Wmisnoinline

iamarchit123 created this revision. Herald added a subscriber: wenlei. Herald added a project: All. iamarchit123 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Test Plan: Repository: rG LLVM Github Monorepo https://r

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. In D111283#3733415 , @v.g.vassilev wrote: > Thanks for working on this! I left some comments. I did not look very deep in > the patch but it seems quite consistent to the rest of the code in Sema. Thanks! > Can you provide so

[PATCH] D132186: Clang add front flags for Wmisnoinline

iamarchit123 updated this revision to Diff 453828. iamarchit123 added a comment. Herald added a subscriber: wenlei. update commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132186/new/ https://reviews.llvm.org/D132186 Files: clang/docs/MisNoI

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 453829. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

craig.topper added a comment. I seem to be unable to pass `check-clang` after this. A lot of tests fail because they can't find headers they need. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586

[PATCH] D132189: [clang-format] Don't put `noexcept` on empty line following constructor

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With the AlwaysBreakTemplateDeclarations option

[clang] 37c47b2 - [RISCV] Change how mtune aliases are implemented.

Author: Craig Topper Date: 2022-08-18T16:22:25-07:00 New Revision: 37c47b2cacae99d65b4b82eb41655f0820100677 URL: https://github.com/llvm/llvm-project/commit/37c47b2cacae99d65b4b82eb41655f0820100677 DIFF: https://github.com/llvm/llvm-project/commit/37c47b2cacae99d65b4b82eb41655f0820100677.diff

[PATCH] D131708: [RISCV] Change how mtune aliases are implemented.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG37c47b2cacae: [RISCV] Change how mtune aliases are implemented. (authored by craig.topper). Changed prior to commit: https://reviews.llvm.org/D131

[clang] c2a3888 - [IR] Use Min behavior for module flag "PIC Level"

Author: Fangrui Song Date: 2022-08-18T16:28:55-07:00 New Revision: c2a38887932e3a46aa3bee35f3f5568ac68282f4 URL: https://github.com/llvm/llvm-project/commit/c2a38887932e3a46aa3bee35f3f5568ac68282f4 DIFF: https://github.com/llvm/llvm-project/commit/c2a38887932e3a46aa3bee35f3f5568ac68282f4.diff

[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2a38887932e: [IR] Use Min behavior for module flag "PIC Level" (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D130531?v

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

MaskRay added a comment. Both D131638 and this patch want to use classes with inheritance to support different compression algorithms. There have been many versions but I think I have never received a convincing argument how such an inheritance based design loo

[PATCH] D132189: [clang-format] Don't put `noexcept` on empty line following constructor

rymiel added a comment. Note for reviewing: The criteria for reaching this misformat are extremely specific, requiring a single-character type or a type of a type consisting of all-uppercase letter, which are poor style on their own. I am also unsure how often this all-uppercase macro-like attri

[PATCH] D119296: KCFI sanitizer

MaskRay added a comment. > OK, so we could just not make the symbols weak and end up failing at link > time if there's a mismatch. That sounds reasonable to me. For `STB_WEAK SHN_ABS` `__kcfi_typeid_*`, there is no duplicate definition error. Is this behavior intentional? Note: I don't think we

[PATCH] D119296: KCFI sanitizer

MaskRay added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp:330 + // comparing the hashes. + unsigned ScratchRegs[] = {AArch64::W16, AArch64::W17}; + const? Comment at: llvm/lib/Target/AArch64/AArch64AsmPrinter.cp

[PATCH] D132144: [Clang][BPF] Support record argument with direct values

yonghong-song updated this revision to Diff 453835. yonghong-song added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. add two llvm/test/CodeGen/BPF tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132144/new/

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov added a comment. In D128113#3733051 , @joanahalili wrote: > We have a translation unit, on which we see an increase of compilation time > and clang memory allocation from 11GB to 14GB. We are working on an isolated > case. Thanks for looking

[PATCH] D132066: [clang][deps] Allow switching between lazily/eagerly loaded PCMs

jansvoboda11 updated this revision to Diff 453836. jansvoboda11 added a comment. Stop duplicating worker state, fix context hash computation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132066/new/ https://reviews.llvm.org/D132066 Files: clang

[clang] 89167e3 - [OpenMP][NFC] Refactor code for interop parts of 'init' and 'append_args' clauses

Author: Mike Rice Date: 2022-08-18T17:13:30-07:00 New Revision: 89167e3c5b008b44f1fa8a222652e7bdc62cfa8a URL: https://github.com/llvm/llvm-project/commit/89167e3c5b008b44f1fa8a222652e7bdc62cfa8a DIFF: https://github.com/llvm/llvm-project/commit/89167e3c5b008b44f1fa8a222652e7bdc62cfa8a.diff LOG

[PATCH] D132171: [OpenMP][NFC] Refactor code for interop parts of 'init' and 'append_args' clauses

This revision was automatically updated to reflect the committed changes. Closed by commit rG89167e3c5b00: [OpenMP][NFC] Refactor code for interop parts of 'init' and 'append_args'… (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLV

[PATCH] D119296: KCFI sanitizer

samitolvanen added a comment. In D119296#3733753 , @MaskRay wrote: > For `STB_WEAK SHN_ABS` `__kcfi_typeid_*`, there is no duplicate definition > error. Is this behavior intentional? Yes, this is by design. Multiple translation units must be able to tak

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

smeenai added a comment. This is breaking our build setup. It causes e.g. the Clang resource headers to be installed to `lib64/clang` instead of `lib/clang`. Given this and the other breakages, can we revert for now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D132192: [RISCV] Add '32bit' feature to rv32 only builtins.

craig.topper created this revision. craig.topper added reviewers: asb, luismarques, reames, kito-cheng. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinM

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added inline comments. Comment at: clang/test/Sema/Float16.c:13 - -#ifdef HAVE _Complex _Float16 a; rjmccall wrote: > I don't know why these test changes are in this patch. My understanding is > that we already committed a patch to enable `_Float16`, a

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. That sounds right to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D132197: [RISCV] Use Triple::isRISCV/isRISCV32/isRISCV64 helps in some places. NFC

craig.topper created this revision. craig.topper added reviewers: kito-cheng, asb, luismarques, reames, gbenyei. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult

[clang] 481d67d - [Clang][BPF] Support record argument with direct values

Author: Yonghong Song Date: 2022-08-18T19:11:50-07:00 New Revision: 481d67d310a7a4213da72f838d6bafaa52ed01d3 URL: https://github.com/llvm/llvm-project/commit/481d67d310a7a4213da72f838d6bafaa52ed01d3 DIFF: https://github.com/llvm/llvm-project/commit/481d67d310a7a4213da72f838d6bafaa52ed01d3.diff

[PATCH] D132144: [Clang][BPF] Support record argument with direct values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG481d67d310a7: [Clang][BPF] Support record argument with direct values (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

yubing updated this revision to Diff 453865. yubing added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141 Files: clang/lib/Headers/immintrin.h clang/test/CodeGen/X86/rdrand

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

yubing updated this revision to Diff 453866. yubing added a comment. fix a small issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141 Files: clang/lib/Headers/immintrin.h clang/test/CodeGen/X86/rdran

[PATCH] D131388: [docs] Add "C++20 Modules"

ChuanqiXu added a comment. If no objection (not comments) come in, I want to land this in next Friday (8.25) since I want to backport this to 15.x and 15.x is going to release in September. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131388/new/ https://reviews.llvm.org/D131388 ___

[libunwind] e941b03 - Revert "[cmake] Use `CMAKE_INSTALL_LIBDIR` too"

Author: John Ericson Date: 2022-08-18T22:46:32-04:00 New Revision: e941b031d316f74267350fe2373d30e28b3a2c2e URL: https://github.com/llvm/llvm-project/commit/e941b031d316f74267350fe2373d30e28b3a2c2e DIFF: https://github.com/llvm/llvm-project/commit/e941b031d316f74267350fe2373d30e28b3a2c2e.diff

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 added a comment. Sorry. I have reverted this. I see why the `lib` and `lib64` mixup could be caused by this, but I am baffled how the missing headers could be. Headers search paths should be unaffected? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D131953: [PowerPC][Coroutines] Add tail-call check with context information for coroutines

shchenz accepted this revision as: shchenz. shchenz added a comment. This LGTM. Although `supportsTailCallFor` is not completely equal to how PPC backend checks tail call support, we can continuously improve this when we have more caller of `supportsTailCallFor()` in future. Repository: rG L

<    1   2   3   >