shafik added inline comments.
================ Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:131 + + return this->emitNE(*T, SubExpr); + } ---------------- shafik wrote: > Can you explain this line? Nevermind, I get it, you are emitting a `0` and then doing a not equal to zero to determine the result. I feel like a comment explaining what is going on would be helpful for anyone not familiar with the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132098/new/ https://reviews.llvm.org/D132098 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits