zahiraam added inline comments.
================ Comment at: clang/lib/CodeGen/CGExprComplex.cpp:613 + result = EmitUnpromotion(promotionTy, E->getSubExpr()->getType(), result); + return result; +} ---------------- rjmccall wrote: > You should unpromote only if we're not in a promoted context, which is to > say, only if the `PromotionType` that was passed in is null. oh! right. The promotionTy is not even used in the function. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
