[PATCH] D130964: [X86][BF16] Enable __bf16 for x86 targets.

2022-08-02 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer added a comment. In D130964#3694473 , @rjmccall wrote: > How are you actually implementing `__bf16` on these targets? There isn't > even hardware support for conversions. `bf16` -> `float` is really just a bit shift. The other direction gets lo

[PATCH] D130811: [Clang] Fix handling of Max from getValueRange(...) in IntExprEvaluator::VisitCastExpr(...)

2022-08-02 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:13540 ED->getValueRange(Max, Min); +--Max; erichkeane wrote: > shafik wrote: > > erichkeane wrote: > > > I don't think this is the correct answer. Even though the other u

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

2022-08-02 Thread Dominic Chen via Phabricator via cfe-commits
ddcc added inline comments. Comment at: clang/lib/Headers/__clang_cuda_builtin_vars.h:37 -#if __cplusplus >= 201103L +#if defined(__cplusplus) && __cplusplus >= 201103L #define __DELETE =delete tra wrote: > Are there actual use cases where CUDA headers are use

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

2022-08-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:400-401 +CXX20_KEYWORD(concept , 0) +CXX20_KEYWORD(requires , 0) // Not a CXX20_KEYWORD because it is disabled by -fno-char8_t. KEYWORD(char8_t

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

2022-08-02 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. I think this looks good. It took me a while to appreciate the new approach; I miss some of the compactness of the previous presentation, but this approach looks more likely to ensure

[PATCH] D131012: No longer place const volatile global variables in a read only section

2022-08-02 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the patch. I've asked some of my colleagues who work on libabigail their thoughts on the implications of this change. Due to timezones, it may take some time to h

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

2022-08-02 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. In D120175#3693458 , @probinson wrote: > There is now cross-project-tests which would seem to be the appropriate place > for a test that wants to run both clang and lld. Thanks for pointing that out. I'll look into moving the t

[PATCH] D130934: [clang] Update code that assumes FileEntry::getName is absolute NFC

2022-08-02 Thread Florian Mayer via Phabricator via cfe-commits
fmayer added a comment. This CL seems to have an MSAN violation: https://lab.llvm.org/buildbot/#/builders/74/builds/12529/steps/11/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130934/new/ https://reviews.llvm.org/D130934 _

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

2022-08-02 Thread Erich Keane via Phabricator via cfe-commits
erichkeane marked 3 inline comments as done. erichkeane added inline comments. Comment at: clang/lib/Basic/IdentifierTable.cpp:169 + case KEYALTIVEC: +return LangOpts.AltiVec ? KS_Enabled : KS_Unknown; + case KEYBORLAND: aaron.ballman wrote: > Should this o

[PATCH] D131012: No longer place const volatile global variables in a read only section

2022-08-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D131012#3694502 , @rjmccall wrote: > I think this is fine for the ABI; the section is generally a > definition-specific property and doesn't affect use sites. > > Do we also need to check for volatile fields of records?

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

2022-08-02 Thread Dominic Chen via Phabricator via cfe-commits
ddcc updated this revision to Diff 449403. ddcc added a comment. Error out on undef __cplusplus in CUDA headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130800/new/ https://reviews.llvm.org/D130800 Files: clang/lib/Headers/__clang_cuda_buil

[PATCH] D131012: No longer place const volatile global variables in a read only section

2022-08-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman updated this revision to Diff 449405. aaron.ballman added a comment. Rebased to get precommit CI to look at it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131012/new/ https://reviews.llvm.org/D131012 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/CodeGenModul

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

2022-08-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM once nits are fixed (take or leave them). Comment at: clang/lib/Basic/IdentifierTable.cpp:169 + case KEYALTIVEC: +return LangOpts.AltiVec ? KS_Enabled : KS_Unknown; + case KEYBORLAND: --

[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

2022-08-02 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6350 + if (Args.hasArg(options::OPT_mindirect_branch_cs_prefix)) +CmdArgs.push_back("-mindirect-branch-cs-prefix"); This is not needed with the TableGen CC1Option change. Re

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

2022-08-02 Thread Erich Keane via Phabricator via cfe-commits
erichkeane updated this revision to Diff 449404. erichkeane added a comment. Add underlying type to TokenKey, plus did all of Aaron's review comments. In general, I think we dont' have a good definition of Extension vs Enabled here, and someone should probably think that through. I'll review an

[PATCH] D131017: Fix use-after-free in clang-apply-replacements

2022-08-02 Thread Ben Langmuir via Phabricator via cfe-commits
benlangmuir created this revision. benlangmuir added reviewers: bnbarham, fmayer. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Accidentally introduced a dangling StringRef in b4c6dc2e6

[PATCH] D130934: [clang] Update code that assumes FileEntry::getName is absolute NFC

2022-08-02 Thread Ben Langmuir via Phabricator via cfe-commits
benlangmuir added a comment. @fmayer thanks, fix is: https://reviews.llvm.org/D131017 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130934/new/ https://reviews.llvm.org/D130934 ___ cfe-commits mailing li

[PATCH] D129097: [clang][dataflow] Handle null pointers of type std::nullptr_t

2022-08-02 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:96 /// /// `Type` must not be null. StorageLocation &getStableStorageLocation(QualType Type); This is inconsistent with the change introduced

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

2022-08-02 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. > there didn't already exist a PS4 lit feature that I could mark as unsupported. ? I believe `UNSUPPORTED: ps4` should work, because UNSUPPORTED will look at the default target triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D131017: Fix use-after-free in clang-apply-replacements

2022-08-02 Thread Ben Langmuir via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54110b8aa010: Fix use-after-free in clang-apply-replacements (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang-tools-extra] 54110b8 - Fix use-after-free in clang-apply-replacements

2022-08-02 Thread Ben Langmuir via cfe-commits
Author: Ben Langmuir Date: 2022-08-02T13:34:20-07:00 New Revision: 54110b8aa01073c428c636951511c2dc710c4a32 URL: https://github.com/llvm/llvm-project/commit/54110b8aa01073c428c636951511c2dc710c4a32 DIFF: https://github.com/llvm/llvm-project/commit/54110b8aa01073c428c636951511c2dc710c4a32.diff

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

2022-08-02 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann accepted this revision. tahonermann added a comment. Accepting again. New changes suggested by Aaron are a clear improvement. Except maybe for the rename of `LSB` to `LSSB`. `LSSB` is what? Low-Speed Serial Bus? Law School Student Body? Lone Star Symphonic Band? Maybe just call it `

[PATCH] D130933: Add docs for function attributes hot/cold

2022-08-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Thank you for adding the docs! I'm not well-versed enough in hot/cold behavior and PGO to comment on the documentation accuracy, so I'm hopeful someone can sign off on that bit. Comment at: clang/include/clang/Basic/Attr.td:1077 - let Documenta

[PATCH] D131007: [NFCI] Refactor how KeywordStatus is calculated

2022-08-02 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D131007#3694684 , @tahonermann wrote: > Accepting again. New changes suggested by Aaron are a clear improvement. > Except maybe for the rename of `LSB` to `LSSB`. `LSSB` is what? Low-Speed > Serial Bus? Law School Studen

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

2022-08-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added subscribers: mikerice, ABataev. aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9060 continue; - const VarDecl *VD = LC.getCapturedVar(); + const VarDecl *VD = cast(LC.getCapturedVar()); if (LC.g

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

2022-08-02 Thread Artem Belevich via Phabricator via cfe-commits
tra added a subscriber: yaxunl. tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_builtin_vars.h:14 +#ifndef __cplusplus +#error CUDA header must be used from C++ +#endif Nit: the error message sounds a bit odd. Perhaps rephrase it as `This CU

[PATCH] D130516: [llvm] compression classes

2022-08-02 Thread Cole Kissane via Phabricator via cfe-commits
ckissane updated this revision to Diff 449421. ckissane added a comment. - compression api: greatly simplify implementation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files: clang-tools-extra/clang

[PATCH] D131020: Reland "[lldb/Fuzzer] Add fuzzer for expression evaluator"

2022-08-02 Thread Chelsea Cassanova via Phabricator via cfe-commits
cassanova created this revision. cassanova added reviewers: JDevlieghere, mib. cassanova added a project: LLDB. Herald added a subscriber: mgorny. Herald added a project: All. cassanova requested review of this revision. Herald added a project: clang. Herald added subscribers: lldb-commits, cfe-com

[clang-tools-extra] 95a9299 - Adds the NSDateFormatter checker to clang-tidy

2022-08-02 Thread Rashmi Mudduluru via cfe-commits
Author: Rashmi Mudduluru Date: 2022-08-02T13:57:44-07:00 New Revision: 95a92995d45fc6fada43ecd91eba3e7aea90487a URL: https://github.com/llvm/llvm-project/commit/95a92995d45fc6fada43ecd91eba3e7aea90487a DIFF: https://github.com/llvm/llvm-project/commit/95a92995d45fc6fada43ecd91eba3e7aea90487a.di

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

2022-08-02 Thread Rashmi Mudduluru via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95a92995d45f: Adds the NSDateFormatter checker to clang-tidy (auth

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

2022-08-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Thank you for working on this, this is heading in the right direction! Please be sure to also add a release note so users know about the new functionality. Comment at: clang/lib/Sema/SemaChecking.cpp:8509 + if (E->EvaluateAsRValue(Result, S.Cont

[PATCH] D131020: Reland "[lldb/Fuzzer] Add fuzzer for expression evaluator"

2022-08-02 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/CMakeLists.txt:51-56 +add_custom_target(fuzz-lldb-expression + COMMENT "Running the LLDB expression evaluator fuzzer..." + WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/fuzzer-art

[PATCH] D130794: [Docs] Add HLSL ResourceType documentation

2022-08-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130794/new/ https://reviews.llvm.org/D130794

[PATCH] D131021: [clang][dataflow] Rename member to make it clear that it isn't stable

2022-08-02 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2, wyt. Herald added subscribers: martong, tschuett, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. Rename `DataflowAnal

[PATCH] D131021: [clang][dataflow] Rename member to make it clear that it isn't stable

2022-08-02 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev updated this revision to Diff 449436. sgatev added a comment. Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131021/new/ https://reviews.llvm.org/D131021 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnaly

[PATCH] D131014: [clang][dataflow] Make the type of the post visit callback consistent

2022-08-02 Thread Sam Estep via Phabricator via cfe-commits
samestep added a comment. Seems reasonable 👍 I'm curious though, why does this not require `clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp` to be updated? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131014/new/ https://r

[PATCH] D131024: Fix assert in the call to isOpenMPRebuildMemberExpr

2022-08-02 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 created this revision. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This is to fix https://github.com/llvm/ll

[PATCH] D131014: [clang][dataflow] Make the type of the post visit callback consistent

2022-08-02 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev updated this revision to Diff 449449. sgatev added a comment. Herald added a subscriber: carlosgalvezp. Herald added a project: clang-tools-extra. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131014/new/ https://reviews.llv

[clang] f7872cd - CommandLine: add and use cl::SubCommand::get{All, TopLevel}

2022-08-02 Thread Nicolai Hähnle via cfe-commits
Author: Nicolai Hähnle Date: 2022-08-02T23:49:16+02:00 New Revision: f7872cdce1102a5c12633dad462a1d9763a578d3 URL: https://github.com/llvm/llvm-project/commit/f7872cdce1102a5c12633dad462a1d9763a578d3 DIFF: https://github.com/llvm/llvm-project/commit/f7872cdce1102a5c12633dad462a1d9763a578d3.diff

[PATCH] D129118: CommandLine: add and use cl::SubCommand::get{All,TopLevel}

2022-08-02 Thread Nicolai Hähnle via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7872cdce110: CommandLine: add and use cl::SubCommand::get{All,TopLevel} (authored by nhaehnle). Changed prior to commit: https://reviews.llvm.org

[PATCH] D131014: [clang][dataflow] Make the type of the post visit callback consistent

2022-08-02 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev added a comment. In D131014#3694852 , @samestep wrote: > Seems reasonable 👍 I'm curious though, why does this not require > `clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp` to > be updated? It does, thanks! Fixed. Repos

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

2022-08-02 Thread Dominic Chen via Phabricator via cfe-commits
ddcc added inline comments. Comment at: clang/lib/Headers/__clang_hip_cmath.h:381 // decltype is only available in C++11 and above. -#if __cplusplus >= 201103L +#if defined(__cplusplus) && __cplusplus >= 201103L // __hip_promote tra wrote: > HIP headers are als

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

2022-08-02 Thread Dominic Chen via Phabricator via cfe-commits
ddcc updated this revision to Diff 449458. ddcc added a comment. Drop changes to CUDA/HIP/OpenMP headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130800/new/ https://reviews.llvm.org/D130800 Files: clang/lib/Headers/float.h clang/lib/Head

[PATCH] D130794: [Docs] Add HLSL ResourceType documentation

2022-08-02 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. I'll assume that you have done `ninja docs-clang-html`:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130794/new/ https://reviews.llvm.org/D130794 __

[PATCH] D130807: [InstrProf] Add the omitprofile attribute

2022-08-02 Thread Ellis Hoag via Phabricator via cfe-commits
ellis updated this revision to Diff 449463. ellis added a comment. Rename `omitprofile` => `skipprofile` since this seems slightly better to me. Of course I'm still open to more suggestions. Also, fix the `profile-function-groups.c` test. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D130516: [llvm] compression classes

2022-08-02 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. > Yes, I can continue to trim down the implementation! I agree with your > sentiment. Thanks! This update helps - though I think we'll still want to further isolate the different pieces of this change/reduce this further. > I agree with some of this, I have some stron

[PATCH] D131012: No longer place const volatile global variables in a read only section

2022-08-02 Thread Andrii Nakryiko via Phabricator via cfe-commits
anakryiko added a comment. This will severly break BPF users, as we have a heavy reliance on `const volatile` variables being allocated to `.rodata`, which are passed to BPF verifier in Linux kernel as read-only values. This is critical for BPF Complie Once - Run Everywhere approach of writing

[PATCH] D130808: [InstrProf] Add new format for -fprofile-list=

2022-08-02 Thread Ellis Hoag via Phabricator via cfe-commits
ellis updated this revision to Diff 449469. ellis added a comment. Rebase and rename `omitprofile` => `skipprofile`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130808/new/ https://reviews.llvm.org/D130808 Files: clang/docs/UsersManual.rst c

[PATCH] D124435: [X86] Always extend the integer parameters in callee

2022-08-02 Thread James Y Knight via Phabricator via cfe-commits
jyknight added a comment. Thinking more about the naming issue, I think the real issue is that the proposed options are an implementation detail, not what we should expose to users. I realize that the non-boolean option was proposed by rjmmccall before, but I'd suggest that we go back to someth

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

2022-08-02 Thread Ian Anderson via Phabricator via cfe-commits
iana added inline comments. Comment at: clang/lib/Headers/stdint.h:99-100 typedef __UINT64_TYPE__ uint64_t; +# undef __int_least64_t # define __int_least64_t int64_t +# undef __uint_least64_t What are you seeing that's defining `__int_least64_t` and all these o

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

2022-08-02 Thread Ian Anderson via Phabricator via cfe-commits
iana added inline comments. Comment at: clang/lib/Headers/stdint.h:99-100 typedef __UINT64_TYPE__ uint64_t; +# undef __int_least64_t # define __int_least64_t int64_t +# undef __uint_least64_t iana wrote: > What are you seeing that's defining `__int_least64_t` a

[PATCH] D131039: [clang][dataflow] Add cache of `ControlFlowContext`s for function decls.

2022-08-02 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel created this revision. ymandel added reviewers: xazax.hun, samestep, sgatev, gribozavr. Herald added subscribers: martong, tschuett, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch mod

[PATCH] D131021: [clang][dataflow] Rename member to make it clear that it isn't stable

2022-08-02 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel accepted this revision. ymandel added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131021/new/ https://reviews.llvm.org/D131021 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D130964: [X86][BF16] Enable __bf16 for x86 targets.

2022-08-02 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added a comment. In D130964#3694473 , @rjmccall wrote: > How are you actually implementing `__bf16` on these targets? There isn't > even hardware support for conversions. We support `float` -> `bf16` in `AVX512BF16`. https://www.intel.com/cont

[PATCH] D130964: [X86][BF16] Enable __bf16 for x86 targets.

2022-08-02 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe added a comment. In D130964#3694540 , @bkramer wrote: > In D130964#3694473 , @rjmccall > wrote: > >> How are you actually implementing `__bf16` on these targets? There isn't >> even hardware support fo

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

2022-08-02 Thread YingChi Long via Phabricator via cfe-commits
inclyc updated this revision to Diff 449510. inclyc added a comment. Now only checks functions calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130906/new/ https://reviews.llvm.org/D130906 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/S

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

2022-08-02 Thread YingChi Long via Phabricator via cfe-commits
inclyc updated this revision to Diff 449511. inclyc added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130906/new/ https://reviews.llvm.org/D130906 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaChecking.cpp clang/t

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

2022-08-02 Thread YingChi Long via Phabricator via cfe-commits
inclyc added a comment. The previous version of this patch checked constant string literals before checking various types of statements, while the current version only checks for compile-time evaluation literals after function calls, and now other regression tests remain as they are. Reposito

[PATCH] D130906: [clang] format string checking for conpile-time evaluated str literal

2022-08-02 Thread YingChi Long via Phabricator via cfe-commits
inclyc updated this revision to Diff 449517. inclyc added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130906/new/ https://reviews.llvm.org/D130906 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaChecking.cpp clang/test/S

[PATCH] D130888: [Clang] Introduce -fexperimental-sanitize-metadata=

2022-08-02 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:5502 MarshallingInfoFlag>; +def fexperimental_sanitize_metadata_covered +: Flag<["-"], "fexperimental-sanitize-metadata-covered">, Let CC1 options use the same spelling as

[PATCH] D130800: [clang][Headers] Avoid compiler warnings in builtin headers

2022-08-02 Thread Dominic Chen via Phabricator via cfe-commits
ddcc added inline comments. Comment at: clang/lib/Headers/stdint.h:99-100 typedef __UINT64_TYPE__ uint64_t; +# undef __int_least64_t # define __int_least64_t int64_t +# undef __uint_least64_t iana wrote: > iana wrote: > > What are you seeing that's defining `__

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

2022-08-02 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9060 continue; - const VarDecl *VD = LC.getCapturedVar(); + const VarDecl *VD = cast(LC.getCapturedVar()); if (LC.getCaptureKind() != LCK_ByRef && !VD->getType()->isPointerT

[PATCH] D131024: Fix assert in the call to isOpenMPRebuildMemberExpr

2022-08-02 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131024/new/ https://reviews.llvm.org/D131024 ___

[PATCH] D131039: [clang][dataflow] Add cache of `ControlFlowContext`s for function decls.

2022-08-02 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h:34 + /// Builds a ControlFlowContext from an AST node. `D` is the function in which + /// `S` resides. All arguments must be non-null. static llvm::Expected build(const

[clang] c44c718 - [clang][dataflow] Make the type of the post visit callback consistent

2022-08-02 Thread Stanislav Gatev via cfe-commits
Author: Stanislav Gatev Date: 2022-08-03T05:58:38Z New Revision: c44c71843f3eca71ef109d2e0730722a6d8e5675 URL: https://github.com/llvm/llvm-project/commit/c44c71843f3eca71ef109d2e0730722a6d8e5675 DIFF: https://github.com/llvm/llvm-project/commit/c44c71843f3eca71ef109d2e0730722a6d8e5675.diff LO

[PATCH] D131014: [clang][dataflow] Make the type of the post visit callback consistent

2022-08-02 Thread Stanislav Gatev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc44c71843f3e: [clang][dataflow] Make the type of the post visit callback consistent (authored by sgatev). Repository: rG LLVM Github Monorepo CHA

[PATCH] D131046: [clang-tools-extra]Replace find/insert with try_emplace

2022-08-02 Thread ppenguin via Phabricator via cfe-commits
prehistoric-penguin created this revision. prehistoric-penguin added reviewers: Sockke, avogelsgesang, njames93, harlanhaskins, hokein, alexfh. Herald added a project: All. prehistoric-penguin requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[clang-tools-extra] 9ef1161 - Add foldings for multi-line comment.

2022-08-02 Thread Utkarsh Saxena via cfe-commits
Author: Utkarsh Saxena Date: 2022-08-03T08:19:12+02:00 New Revision: 9ef11616b228fc2f69cd8fe7f7fd3e821d74c182 URL: https://github.com/llvm/llvm-project/commit/9ef11616b228fc2f69cd8fe7f7fd3e821d74c182 DIFF: https://github.com/llvm/llvm-project/commit/9ef11616b228fc2f69cd8fe7f7fd3e821d74c182.diff

[PATCH] D130081: Add foldings for multi-line comment.

2022-08-02 Thread Utkarsh Saxena via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9ef11616b228: Add foldings for multi-line comment. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130081/new/ https://reviews.llvm.o

[clang] 817dd5e - [clang][dataflow] Rename member to make it clear that it isn't stable

2022-08-02 Thread Stanislav Gatev via cfe-commits
Author: Stanislav Gatev Date: 2022-08-03T06:25:02Z New Revision: 817dd5e3fd6bdad584728843c72892f0fae058cd URL: https://github.com/llvm/llvm-project/commit/817dd5e3fd6bdad584728843c72892f0fae058cd DIFF: https://github.com/llvm/llvm-project/commit/817dd5e3fd6bdad584728843c72892f0fae058cd.diff LO

[PATCH] D131021: [clang][dataflow] Rename member to make it clear that it isn't stable

2022-08-02 Thread Stanislav Gatev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG817dd5e3fd6b: [clang][dataflow] Rename member to make it clear that it isn't stable (authored by sgatev). Repository: rG LLVM Github Monorepo CHA

<    1   2