sgatev added inline comments.
================ Comment at: clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h:34 + /// Builds a ControlFlowContext from an AST node. `D` is the function in which + /// `S` resides. All arguments must be non-null. static llvm::Expected<ControlFlowContext> build(const Decl *D, Stmt *S, ---------------- Can we make them references? ================ Comment at: clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h:50 private: - ControlFlowContext(std::unique_ptr<CFG> Cfg, + // `D` must not be null. + ControlFlowContext(const Decl *D, std::unique_ptr<CFG> Cfg, ---------------- Can we make it a reference? ================ Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:369 + + // Keyed on the function's fully qualified name. No leading "::". + llvm::StringMap<ControlFlowContext> FunctionModels; ---------------- Can we make the keys `FunctionDecl *` and use `FunctionDecl::getDefinition` in `getControlFlowContext` to obtain a canonical pointer? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131039/new/ https://reviews.llvm.org/D131039 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
