[clang] 6cf8348 - [NFC][clang] Fix typo

Author: Sheng Date: 2022-06-11T15:59:05+08:00 New Revision: 6cf83480ea631b05bdab8b32a5903728685a6c2a URL: https://github.com/llvm/llvm-project/commit/6cf83480ea631b05bdab8b32a5903728685a6c2a DIFF: https://github.com/llvm/llvm-project/commit/6cf83480ea631b05bdab8b32a5903728685a6c2a.diff LOG: [N

[clang] 05d7710 - [clang-format] Fix a bug in RemoveBracesLLVM

Author: owenca Date: 2022-06-11T01:12:11-07:00 New Revision: 05d771021ad9de12f3e657d464d18731a13578ab URL: https://github.com/llvm/llvm-project/commit/05d771021ad9de12f3e657d464d18731a13578ab DIFF: https://github.com/llvm/llvm-project/commit/05d771021ad9de12f3e657d464d18731a13578ab.diff LOG: [

[PATCH] D127532: [clang-format] Fix a bug in RemoveBracesLLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05d771021ad9: [clang-format] Fix a bug in RemoveBracesLLVM (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 781dc34 - [clang][docs] Fix typo in code-block declaration

Author: Simon Pilgrim Date: 2022-06-11T09:28:38+01:00 New Revision: 781dc344f5e13b163818fa851f278233d53724c3 URL: https://github.com/llvm/llvm-project/commit/781dc344f5e13b163818fa851f278233d53724c3 DIFF: https://github.com/llvm/llvm-project/commit/781dc344f5e13b163818fa851f278233d53724c3.diff

[PATCH] D126291: [flang][Driver] Update link job on windows

mmuetzel added a comment. Possible alternative version of `linker-flags-windows.f90` that also tests MinGW and takes the feedback by @mstorsjo into account: ! Verify that the Fortran runtime libraries are present in the linker ! invocation. These libraries are added on top of other standard

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

xbolva00 added inline comments. Comment at: clang/test/CodeGen/attr-optimize.c:16 + +__attribute__((optimize("Oz"))) void f4(void) {} +// O2: @f4{{.*}}[[ATTR_OPTSIZE]] For -Os, clang adds optsize. For -Oz, clang adds optsize and minsize. So tests should check it

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

steakhal updated this revision to Diff 436124. steakhal added a comment. - Add the new `diag::warn_analyzer_deprecated_option` warning to the `"deprecated-static-analyzer-flag"` `DiagGroup` to prevent breaking the `clang/test/Misc/warning-flags.c` test file. I'm also adding @thakis to review th

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

philnik updated this revision to Diff 436126. philnik added a comment. Rebased to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127313/new/ https://reviews.llvm.org/D127313 Files: libcxx/docs/ReleaseNotes.rst libcxx/docs/Status/Cxx17Pap

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

aaron.ballman added a comment. We saw the same thing at Intel FWIW. When I investigated it, all of the symlinks were being created as `name}` instead of whatever you'd expect the symlink to be named. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D123674: Clang-Repl Error Recovery Bug Fix

Purva-Chaudhari updated this revision to Diff 436129. Purva-Chaudhari added a comment. Fix asan test fail CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123674/new/ https://reviews.llvm.org/D123674 Files: clang/lib/Interpreter/IncrementalParser.cpp clang/test/Interpreter/errorRecove

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 436133. cor3ntin added a comment. - Rebase - The generator code is more consistent with LLVM style guides. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064 Files: c

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin added a comment. @tstellar I saw you say in another path that you got confirmation from lawyers that it's okay to include UnicodeData.txt (which this patch doesn't do) and derived data (which this patch does). Can you confirm? Thanks Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

nikic added inline comments. Comment at: clang/cmake/modules/AddClang.cmake:178 # Always generate install targets - llvm_install_symlink(${name} ${dest} ALWAYS_GENERATE) + llvm_install_symlink(CLANG name} ${dest} ALWAYS_GENERATE) endmacro() Yeah, there's a

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 436137. cor3ntin added a comment. Use utohexstr and revert the changes that put to_hexString in StringExtras. I'll remove to_hexString entierly in a separate NFC change to avoid duplication and further confusion. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 436142. cor3ntin added a comment. Do not hardcode the list of generated code points ranges in the generator code to ease maintainance burden. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://r

[clang] 45b278f - [Clang][Doc][SafeStack] Fix deadlink (NFC)

Author: ksyx Date: 2022-06-11T10:59:51-04:00 New Revision: 45b278f195b25e012fe441db13715cfecb377fce URL: https://github.com/llvm/llvm-project/commit/45b278f195b25e012fe441db13715cfecb377fce DIFF: https://github.com/llvm/llvm-project/commit/45b278f195b25e012fe441db13715cfecb377fce.diff LOG: [Cl

[clang] ff80dc8 - [X86] Add __extension__ to f16c macro intrinsics to suppress warnings about compound literals

Author: Craig Topper Date: 2022-06-11T08:34:37-07:00 New Revision: ff80dc85449307d90e5276cd8f41825ace9b8594 URL: https://github.com/llvm/llvm-project/commit/ff80dc85449307d90e5276cd8f41825ace9b8594 DIFF: https://github.com/llvm/llvm-project/commit/ff80dc85449307d90e5276cd8f41825ace9b8594.diff

[PATCH] D127390: [clang-format][NFC] Remove unused FormatStyle members

MyDeveloperDay added a comment. If we remove it from here, then it will get removed from the documentation F23403281: image.png Also if you remove it, then the ClangFormatStyleOptions.rst needs to be regenerated. But somehow I think we need that comment no?

[PATCH] D127484: [clang-format] Use tabs on GNU style

MyDeveloperDay added a comment. We get heavily criticized for changing defaults between versions, I think if someone want to use GNU style, and they choose to now have this option set it should be done so in their own .clang-format file On reflection, I think its wrong of us to change that now

[PATCH] D127270: [clang-format] Add space in placement new expression

MyDeveloperDay added a comment. Thank you for the patch, was there a github issue for this? Can we just validate that those requirements are covered here too while we are at it? https://github.com/llvm/llvm-project/issues/54703 https://github.com/llvm/llvm-project/issues/41501 ( I know this is

[PATCH] D127270: [clang-format] Add space in placement new expression

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:3498 +/// \endcode +bool AfterPlacementNew; /// If ``true``, put a space between operator overloading and opening HazardyKnusperkeks wrote: > Please sort after `Aft

[PATCH] D127393: [Driver] Don't add -lresolv on FreeBSD

MaskRay accepted this revision. MaskRay added a comment. Perhaps change to `isOSLinux() && isGNUEnvironment()` now. I suspect other *BSD don't need this, either. musl definitely doesn't need this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12739

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 reopened this revision. Ericson2314 added a comment. This revision is now accepted and ready to land. Thanks for finding this and sorry for the disruption. Hope the revert didn't come to slowly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 updated this revision to Diff 436152. Ericson2314 added a comment. Fix typo Thank you @aaron.ballman and @nikic for finding the culprit! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/ https://reviews.llvm.org/D117977 Files:

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 marked an inline comment as done. Ericson2314 added inline comments. Comment at: openmp/tools/CMakeLists.txt:1-3 +set(OPENMP_TOOLS_INSTALL_DIR "${CMAKE_INSTALL_BINDIR}" CACHE PATH +"Path for binary subdirectory (defaults to '${CMAKE_INSTALL_BINDIR}')") +mark_as_ad

[clang] 5ee3876 - Use isa instead of dyn_cast (NFC)

Author: Kazu Hirata Date: 2022-06-11T11:15:52-07:00 New Revision: 5ee387690568979fbb8c973eeb61e1a66ee6cc61 URL: https://github.com/llvm/llvm-project/commit/5ee387690568979fbb8c973eeb61e1a66ee6cc61 DIFF: https://github.com/llvm/llvm-project/commit/5ee387690568979fbb8c973eeb61e1a66ee6cc61.diff L

[clang] 439a675 - Use getValueOr (NFC)

Author: Kazu Hirata Date: 2022-06-11T11:24:57-07:00 New Revision: 439a675a5a7d8a61014863b2fbb75cb291cad6a0 URL: https://github.com/llvm/llvm-project/commit/439a675a5a7d8a61014863b2fbb75cb291cad6a0 DIFF: https://github.com/llvm/llvm-project/commit/439a675a5a7d8a61014863b2fbb75cb291cad6a0.diff L

[PATCH] D127351: clang: fix early substitution of alias templates

mizvekov updated this revision to Diff 436155. mizvekov added a comment. - much smaller patch, puts the new flag as a mutable member of MultiLevelTemplateArgumentList Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127351/new/ https://reviews.llvm.o

[PATCH] D127351: clang: fix early substitution of alias templates

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1872 QualType Result = getSema().Context.getTemplateTypeParmType( - T->getDepth() - TemplateArgs.getNumSubstitutedLevels(), T->getIndex(), - T->isParameterPack(), NewTTPDecl); +

[clang-tools-extra] 65299c9 - [clang-tidy][docs] Use std::optional instead of absl::optional in examples

Author: Dmitri Gribenko Date: 2022-06-11T21:03:43+02:00 New Revision: 65299c9c652f3ce4958011ffe28119d0eff0f38d URL: https://github.com/llvm/llvm-project/commit/65299c9c652f3ce4958011ffe28119d0eff0f38d DIFF: https://github.com/llvm/llvm-project/commit/65299c9c652f3ce4958011ffe28119d0eff0f38d.dif

[clang-tools-extra] 11f75e0 - [clang-tidy][docs] Remove an unintentional paragraph break

Author: Dmitri Gribenko Date: 2022-06-11T21:03:43+02:00 New Revision: 11f75e0a2dfa1455eee097dfa72686d8a4dc7802 URL: https://github.com/llvm/llvm-project/commit/11f75e0a2dfa1455eee097dfa72686d8a4dc7802 DIFF: https://github.com/llvm/llvm-project/commit/11f75e0a2dfa1455eee097dfa72686d8a4dc7802.dif

[PATCH] D127390: [clang-format][NFC] Remove unused FormatStyle members

owenpan added a comment. In D127390#3575628 , @MyDeveloperDay wrote: > If we remove it from here, then it will get removed from the documentation > > F23403281: image.png > > Also if you remove it, then the ClangForm

[PATCH] D127545: Remove Itanium EH ABI workaround to allow modifying a pointer caught by-reference.

rjmccall added a comment. Should we just diagnose this and report an error that catching pointers by non-const reference is unsupported on Itanium? We don't support it properly for class pointers anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

rjmccall added a comment. The cleanups arise from expressions in the constraints, right? There are a number of places where `ExprWithCleanups` does not mean the cleanups are independently nested within that expression; it's notably not how it works ever for something as basic as a variable ini

[PATCH] D127578: [clang-format] Handle deprecated options in dump_format_style.py

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also add two d

[PATCH] D127390: [clang-format][NFC] Remove unused FormatStyle members

owenpan added a comment. See D127578 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127390/new/ https://reviews.llvm.org/D127390 ___ cfe-commits mailing list cfe-commit

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

iliya-diyachkov created this revision. iliya-diyachkov added reviewers: Anastasia, bader, svenvh. Herald added a subscriber: Naghasan. Herald added a project: All. iliya-diyachkov requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. It's

[PATCH] D123493: Support the min of module flags when linking, use for AArch64 BTI/PAC-RET

danielkiss added a comment. In D123493#3569025 , @MaskRay wrote: > This behavior requires that all participating modules have the module flag. > In the absence of the module flag, what should be behavior be? > > For module flags like `"sign-return-addres

[clang] 5f57ca2 - fix comment typo to cycle bots

Author: Nico Weber Date: 2022-06-11T18:55:40-04:00 New Revision: 5f57ca208b41ea6f70089ab9c5104b6f8ecc13f4 URL: https://github.com/llvm/llvm-project/commit/5f57ca208b41ea6f70089ab9c5104b6f8ecc13f4 DIFF: https://github.com/llvm/llvm-project/commit/5f57ca208b41ea6f70089ab9c5104b6f8ecc13f4.diff LO

[clang] 140ad7d - [Clang][VE][NFC] Fix a comment

Author: Kazushi (Jam) Marukawa Date: 2022-06-12T10:27:30+09:00 New Revision: 140ad7d37813e525a202f38ceac64d7e12b38930 URL: https://github.com/llvm/llvm-project/commit/140ad7d37813e525a202f38ceac64d7e12b38930 DIFF: https://github.com/llvm/llvm-project/commit/140ad7d37813e525a202f38ceac64d7e12b38

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d2da259c872: [X86][RFC] Enable `_Float16` type support on X86 following the psABI (authored by pengfei). Changed prior to commit: https://reviews

[PATCH] D127393: [Driver] Don't add -lresolv on FreeBSD

brad added a comment. I was just looking at the same diff for OpenBSD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127393/new/ https://reviews.llvm.org/D127393 ___ cfe-commits mailing list cfe-commits@

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 added a comment. Hmm, are all those errors from running out of file system space, or might there be another issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/ https://reviews.llvm.org/D117977

[PATCH] D127484: [clang-format] Use tabs on GNU style

a4lg marked an inline comment as done. a4lg added a comment. Interesting. I measured some development branch (targeting `*.c`, `*.cc`, `*.cpp` and `*.h`): | Program | prefix: 8 spaces | prefix: 1 tab | 8sp percentage | | Coreutils | 23494| 461 | 98.08% | | Binutil