owenpan added a comment.

In D127390#3575628 <https://reviews.llvm.org/D127390#3575628>, @MyDeveloperDay 
wrote:

> If we remove it from here, then it will get removed from  the documentation
>
> F23403281: image.png <https://reviews.llvm.org/F23403281>
>
> Also if you remove it, then the ClangFormatStyleOptions.rst needs to be 
> regenerated.

Good catch! I will regenerate it.

> But somehow I think we need that comment no? incase someone is looking up 
> their legacy options when migrating?

IIRC there were other deprecated options that were removed from Format.h. These 
two options were old enough and IMO we left them in Format.h long enough. 
Nevertheless, I will see if we can add the comments back without keeping the 
`FormatStyle` members.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127390/new/

https://reviews.llvm.org/D127390

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to