danielkiss added a comment. In D123493#3569025 <https://reviews.llvm.org/D123493#3569025>, @MaskRay wrote:
> This behavior requires that all participating modules have the module flag. > In the absence of the module flag, what should be behavior be? > > For module flags like `"sign-return-address"`, I see that you just emit the > flag unconditionally (which can be zero). Absence of the `"branch-target-enforcement" and `"sign-return-address"` means features are off. So the flag merger will take an existing flag and the feature could be turned on, which is bad. AutoUpdater should insert the attributes with zero value if they are missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123493/new/ https://reviews.llvm.org/D123493 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
