[PATCH] D124637: [clangd][ObjC] Filter ObjC method completions on the remaining selector

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry about the delay :-( Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1989 CodeCompletion Item; Item.Name = Name.str() + "="; Item.Kind = Compl

[PATCH] D125949: [clang-tidy] modernize-avoid-bind: Fix crash when method name is not a simple identifier

jspam created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. jspam requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The following assertion fails when referencing an operator membe

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:418 + if (const auto *ME = dyn_cast(E)) +if (const auto *TE = dyn_cast(ME->getB

[PATCH] D125403: [Serialization] Delta-encode consecutive SourceLocations in TypeLoc

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/include/clang/Serialization/SourceLocationEncoding.h:144 + // enclosing sequence instead of establishing a new one. + Root(SourceLocationSequence *Parent = nullptr) + : Seq(Paren

[clang] 4df795b - [Serialization] Delta-encode consecutive SourceLocations in TypeLoc

Author: Sam McCall Date: 2022-05-19T09:40:44+02:00 New Revision: 4df795bff75289941508d07bbe9105b93b098105 URL: https://github.com/llvm/llvm-project/commit/4df795bff75289941508d07bbe9105b93b098105 DIFF: https://github.com/llvm/llvm-project/commit/4df795bff75289941508d07bbe9105b93b098105.diff LO

[PATCH] D125403: [Serialization] Delta-encode consecutive SourceLocations in TypeLoc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG4df795bff752: [Serialization] Delta-encode consecutive SourceLocations in TypeLoc (authored by sammccall)

[libunwind] d3a6f57 - [libunwind] Remove -Wsign-conversion warning

Author: Daniel Kiss Date: 2022-05-19T09:41:42+02:00 New Revision: d3a6f5739130409602edac1b6588613c458d7321 URL: https://github.com/llvm/llvm-project/commit/d3a6f5739130409602edac1b6588613c458d7321 DIFF: https://github.com/llvm/llvm-project/commit/d3a6f5739130409602edac1b6588613c458d7321.diff L

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder updated this revision to Diff 430597. tbaeder marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125862/new/ https://reviews.llvm.org/D125862 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/unittests/Driver/ToolChainTest.cpp Index: clang/unittes

[PATCH] D125952: [Serialization] Delta encode locations in expansion sloc entries

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a 1.9% reduction in PCH size in my measurements. In abbreviated reco

[clang] 4816915 - [Serialization] Add missing includes for CHAR_BIT

Author: Sam McCall Date: 2022-05-19T10:04:25+02:00 New Revision: 481691572d1fa6ad56ab24c73000396fd8babef8 URL: https://github.com/llvm/llvm-project/commit/481691572d1fa6ad56ab24c73000396fd8babef8 DIFF: https://github.com/llvm/llvm-project/commit/481691572d1fa6ad56ab24c73000396fd8babef8.diff LO

[PATCH] D125952: [Serialization] Delta encode locations in expansion sloc entries

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125952/new/ https://reviews.llvm.org/D125952 _

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

kiranchandramohan added a comment. In D125788#3523408 , @shraiysh wrote: >> With this change the flang driver will not generate an executable unless it >> is built with an option. > > Okay, thank you for the clarification. Is this a cmake option and? Are

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski updated this revision to Diff 430604. awarzynski added a comment. Update documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125788/new/ https://reviews.llvm.org/D125788 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/To

[PATCH] D125892: [analyzer] Implement assumeInclusiveRange in terms of assumeInclusiveRangeDual

martong added a comment. In D125892#3523296 , @steakhal wrote: > Okay, it took me a while to get what's going on. > Do you have anything in mind to express it by slightly less indirection, > references, templates and well, virtual functions xD Okay, I s

[PATCH] D125892: [analyzer] Implement assumeInclusiveRange in terms of assumeInclusiveRangeDual

martong updated this revision to Diff 430611. martong added a comment. - Split into two patches, this first patch will be just the no-brainer copy-paste from assumeDual implementaton. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125892/new/ https

[PATCH] D125954: [analyzer][NFC] Factor out the copy-paste code repetition of assumeDual and assumeInclusiveRangeDual

martong created this revision. martong added reviewers: NoQ, steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project:

[PATCH] D125635: Move NumStmts from CompoundStmtBitfields to fields of CompoundStmt

sepavloff updated this revision to Diff 430613. sepavloff added a comment. Move NumStmts back to CompoundStmtBitfields Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125635/new/ https://reviews.llvm.org/D125635 Files: clang/include/clang/AST/Stmt

[PATCH] D125957: [flang][driver] Make driver accept `-module-dir`

awarzynski created this revision. awarzynski added a reviewer: rovka. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. `-module-dir` is Flang's equiv

[PATCH] D125892: [analyzer] Implement assumeInclusiveRange in terms of assumeInclusiveRangeDual

steakhal added a comment. Now I see, the summary confused me. > This includes the refactoring of the common assumle*Dual logic into the > function template assumeDualImpl. I felt like this is a refactoring change, but it was not. It's about fixing the behavior by using the `cloneAsPosteriorlyOv

[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

khchen added a comment. I think we have no consensus in https://github.com/riscv-non-isa/rvv-intrinsic-doc/issues/18#issuecomment-817890161, and most people disagree the current naming, maybe we need to have more followup discussion before landing this patch. For example, maybe `_Float16` shoul

[PATCH] D125957: [flang][driver] Make driver accept `-module-dir`

rovka accepted this revision. rovka added a comment. This revision is now accepted and ready to land. Seems legit, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125957/new/ https://reviews.llvm.org/D125957 __

[clang-tools-extra] 43c0f90 - [clangd] NFC: Clarify the Include Cleaner warning

Author: Kirill Bobyrev Date: 2022-05-19T11:59:00+02:00 New Revision: 43c0f90dd6eb1d3481a4d5e384a33d0d99b7aa86 URL: https://github.com/llvm/llvm-project/commit/43c0f90dd6eb1d3481a4d5e384a33d0d99b7aa86 DIFF: https://github.com/llvm/llvm-project/commit/43c0f90dd6eb1d3481a4d5e384a33d0d99b7aa86.diff

[clang-tools-extra] 4f5a421 - [clangd] Update the test after diagnostic message change

Author: Kirill Bobyrev Date: 2022-05-19T12:03:31+02:00 New Revision: 4f5a4215bfc896362adab89abc69f0e69de200ef URL: https://github.com/llvm/llvm-project/commit/4f5a4215bfc896362adab89abc69f0e69de200ef DIFF: https://github.com/llvm/llvm-project/commit/4f5a4215bfc896362adab89abc69f0e69de200ef.diff

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

Sockke updated this revision to Diff 430621. Sockke added a comment. rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116593/new/ https://reviews.llvm.org/D116593 Files: clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp clang-tools-extra/docs/ReleaseNote

[PATCH] D125925: Add an option to fill container for ref

kadircet added a comment. Can you also update the remote-index protos & marshalling logic in: - clang-tools-extra/clangd/index/remote/Index.proto - clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp Comment at: clang-tools-extra/clangd/index/Index.h:75 llvm::

[PATCH] D125959: [clang-format] Fix a bug in "AfterControlStatement: MultiLine"

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke added a comment. Hi, Could anyone please review this diff? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D125961: [clang-format] Don't break lines after pragma region

thieta created this revision. Herald added a project: All. thieta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We have autogenerated pragma regions in our code which where awkwardly broken up like this: #pragma region foo(bar : hello)

[clang] 6bec3e9 - [APInt] Remove all uses of zextOrSelf, sextOrSelf and truncOrSelf

Author: Jay Foad Date: 2022-05-19T11:23:13+01:00 New Revision: 6bec3e9303d68b8b264de3a02ca943d9dd752004 URL: https://github.com/llvm/llvm-project/commit/6bec3e9303d68b8b264de3a02ca943d9dd752004 DIFF: https://github.com/llvm/llvm-project/commit/6bec3e9303d68b8b264de3a02ca943d9dd752004.diff LOG:

[PATCH] D125557: [APInt] Remove all uses of zextOrSelf, sextOrSelf and truncOrSelf

This revision was automatically updated to reflect the committed changes. Closed by commit rG6bec3e9303d6: [APInt] Remove all uses of zextOrSelf, sextOrSelf and truncOrSelf (authored by foad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125557/new/

[PATCH] D125920: [analyzer][NFC] Remove the unused LocAsInteger::getPersistentLoc()

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM. Are there any other `getPersistentLoc` function definitions in other SVals? Might they be also unused? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

tcanabrava added a comment. This affects all released versions of llvm14, and potentially llvm13 too (I got a crash today on llvm13 hitting this exact code). yet, this is not backported to llvm14 on the current 14.x github branch. Please backport so this is released on the next tarball. Reposi

[PATCH] D125892: [analyzer] Implement assumeInclusiveRange in terms of assumeInclusiveRangeDual

martong updated this revision to Diff 430637. martong marked an inline comment as done. martong edited the summary of this revision. martong added a comment. - Move SimpleConstraintManager's assume*Internal functions to be protected Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D125892: [analyzer] Implement assumeInclusiveRange in terms of assumeInclusiveRangeDual

martong added a comment. In D125892#3524453 , @steakhal wrote: > Now I see, the summary confused me. > >> This includes the refactoring of the common assumle*Dual logic into the >> function template assumeDualImpl. > > I felt like this is a refactoring ch

[clang] f820625 - [flang][driver] Make driver accept `-module-dir`

Author: Andrzej Warzynski Date: 2022-05-19T11:13:35Z New Revision: f820625503744472be8312bb70ee0da197816067 URL: https://github.com/llvm/llvm-project/commit/f820625503744472be8312bb70ee0da197816067 DIFF: https://github.com/llvm/llvm-project/commit/f820625503744472be8312bb70ee0da197816067.diff

[PATCH] D125957: [flang][driver] Make driver accept `-module-dir`

This revision was automatically updated to reflect the committed changes. Closed by commit rGf82062550374: [flang][driver] Make driver accept `-module-dir` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125957/new/ ht

[PATCH] D125547: [analyzer][solver] Handle UnarySymExpr in SMTConv

martong added a comment. There are Z3 refutation related assertions on open-source projects once the patch stack is applied. Interestingly it happens in `fromBinOp`. clang-14: ../../git/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/SMTConv.h:96: static const llvm::SMTExp

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

aaron.ballman added a comment. In D123667#3524614 , @tcanabrava wrote: > This affects all released versions of llvm14, and potentially llvm13 too (I > got a crash today on llvm13 hitting this exact code). > yet, this is not backported to llvm14 on the c

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

Sockke added a comment. I'm not quite sure why the test case is not passing on Windows, could you please check this problem? @flx CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116593/new/ https://reviews.llvm.org/D116593 ___ cfe-commits mail

[PATCH] D125620: [Clang] Fix diagnostics formatting

aaron.ballman added a comment. Thank you for this! Is there a way to add test coverage for this change? Also, this should come with a release note as it's fixing a bug someone reported. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125620/new/ htt

[PATCH] D125863: [clangd] Dont mark terminating PP-directives as skipped

hokein added a comment. In D125863#3522384 , @kadircet wrote: > In D125863#3522025 , @hokein wrote: > >> sorry, I might be lack of the context, where is the user complaint? I'm not >> sure which cases are improve

[PATCH] D125311: [pseudo] Share the underly payload when stripping comments for a token stream

hokein updated this revision to Diff 430646. hokein added a comment. add addPayload method, and share payload in cook as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125311/new/ https://reviews.llvm.org/D125311 Files: clang-tools-extra/pse

[PATCH] D125311: [pseudo] Share the underly payload when stripping comments for a token stream

hokein added a comment. In D125311#3524190 , @sammccall wrote: > In D125311#3523388 , @hokein wrote: > >> In D125311#3503452 , @sammccall >> wrote: >> >>> This looks good

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

ymandel added a comment. Thanks! Looks good overall, just the one question about loops. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:596-598 + MergedEnv.makeOr( + MergedEnv.makeAnd(Env1.getFlowConditionToken(), *HasValueVal

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

aaron.ballman updated this revision to Diff 430648. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Fixes failed AST matching unit test and speculatively fixes a CodeGen test, all found via precommit CI testing. CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

aaron.ballman added a comment. In D125919#3523441 , @rjmccall wrote: > We definitely don't want ObjC to differ here; thanks for the CC. Excellent, thank you for the confirmation! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125919/new/ https:

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

JonChesterfield created this revision. JonChesterfield added reviewers: arsenm, rampitec, sdesmalen, rjmccall, rnk, aaron.ballman. Herald added subscribers: kosarev, kerbowa, t-tye, Anastasia, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added a project: All. JonChesterfield requested review

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added a comment. Herald added a reviewer: dang. @rsmith pointed out https://eel.is/c++draft/temp#friend-9 which I think is supposed to fix the friend function issues: > A non-template friend declaration with a requires-clause shall be a > definition. > A friend function template with

[PATCH] D125925: Add an option to fill container for ref

usaxena95 updated this revision to Diff 430657. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125925/new/ https://reviews.llvm.org/D125925 Files: clang-to

[PATCH] D125925: Add an option to fill container for ref

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125925/new/ https://reviews.llvm.org/D125925 __

[PATCH] D125925: Add an option to fill container for ref

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5bbf6ad5b64c: Add an option to fill container for ref (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang-tools-extra] 5bbf6ad - Add an option to fill container for ref

Author: Utkarsh Saxena Date: 2022-05-19T16:05:38+02:00 New Revision: 5bbf6ad5b64c2b3cc669ce7698e1bbf5a7f09539 URL: https://github.com/llvm/llvm-project/commit/5bbf6ad5b64c2b3cc669ce7698e1bbf5a7f09539 DIFF: https://github.com/llvm/llvm-project/commit/5bbf6ad5b64c2b3cc669ce7698e1bbf5a7f09539.diff

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

amyk added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-fnabs.ll:46 +; RUN: -mattr=-vsx < %s | FileCheck %s --check-prefix=CHECK-NOVSX + +declare double @llvm.ppc.fnabs(double) lei wrote: > nit: same as before no need to test all

[PATCH] D125974: Limit bitcode option ignorelist to Darwin

MichielDerhaeg created this revision. MichielDerhaeg added reviewers: steven_wu, compnerd. Herald added a project: All. MichielDerhaeg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This ignore list prevents embedding of bitcode fo

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

amyk updated this revision to Diff 430671. amyk added a comment. - Add a P6 +VSX run line and remove extra P7 /P8 lines for backend test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang] e601b2a - [flang][driver] Add support for generating executables on MacOSX/Darwin

Author: Andrzej Warzynski Date: 2022-05-19T15:47:59+01:00 New Revision: e601b2a1542710789395ab1121b1ccc7076e39d1 URL: https://github.com/llvm/llvm-project/commit/e601b2a1542710789395ab1121b1ccc7076e39d1 DIFF: https://github.com/llvm/llvm-project/commit/e601b2a1542710789395ab1121b1ccc7076e39d1.d

[PATCH] D125628: [flang][driver] Add support for generating executables on MacOSX/Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rGe601b2a15427: [flang][driver] Add support for generating executables on MacOSX/Darwin (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D125628?vs=429528&id=430679#toc Reposit

[libunwind] a5f3625 - [libunwind] Remove unused _LIBUNWIND_HAS_NO_THREADS macro in tests

Author: Louis Dionne Date: 2022-05-19T10:58:13-04:00 New Revision: a5f36259a20533d9c970ab6a5faab7cf341ca1c9 URL: https://github.com/llvm/llvm-project/commit/a5f36259a20533d9c970ab6a5faab7cf341ca1c9 DIFF: https://github.com/llvm/llvm-project/commit/a5f36259a20533d9c970ab6a5faab7cf341ca1c9.diff

[PATCH] D125954: [analyzer][NFC] Factor out the copy-paste code repetition of assumeDual and assumeInclusiveRangeDual

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Okay, it still looks a bit odd, but this is definitely an increment. Comment at: clang/lib/StaticAnalyzer/Core/ConstraintManager.cpp:48 +ConstraintManager::assumeDualImpl

[PATCH] D125773: [Driver] Do not auto-enable header modules with -std=c++20

jyknight added a comment. In D125773#3523459 , @rsmith wrote: > Header modules are part of the C++20 standard (where they are called "header > units"), and module maps are an intended way for Clang to provide this > functionality in C++20 mode. I don't

[PATCH] D125635: Move NumStmts from CompoundStmtBitfields to fields of CompoundStmt

sepavloff added a comment. In D125635#3514607 , @rjmccall wrote: > On the one hand, I'm not sure 8M statements in a block — or 1M, for that > matter — is an unreasonable implementation limit. On the other hand, this > patch looks like it only changes o

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman updated this revision to Diff 430686. MosheBerman marked an inline comment as not done. MosheBerman added a comment. My IDE auto-formatted away some whitespace, causing a merge conflict for the test CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman updated this revision to Diff 430691. MosheBerman added a comment. Missed a whitespace. (Looks like there may be another merge conflict, in NullabilityChecker.cpp:117, but not sure if that's the issue. Let's try this just in case it's not.) Repository: rG LLVM Github Monorepo CH

[PATCH] D125773: [Driver] Do not auto-enable header modules with -std=c++20

ilya-biryukov planned changes to this revision. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. Richard, thanks for course correcting. I was under impression that header modules are not in the standard, my mistake. It looks like this particular change actually brea

[PATCH] D122126: [LoopVectorize] Don't interleave when the number of runtime checks exceeds the threshold

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3ed9f603fd59: [LoopVectorize] Don't interleave when the number of runtime checks exceeds the… (authored by TiehuZhang, committed by mdchen). Change

[PATCH] D125773: [Driver] Do not auto-enable header modules with -std=c++20

tahonermann added a comment. > So the proposal is that -fheader-modules=parse would parse #include of header > unit in the same TU, and import .pcm on import, right? Per cpp.includep7 , "If the header identified by the //header-name// denotes an importable

[PATCH] D125949: [clang-tidy] modernize-avoid-bind: Fix crash when method name is not a simple identifier

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-avoid-bind.cpp:367 +// CHECK-MESSAGES: :[[@LINE-1]]:16: warning: prefer a lambda to std::bind +// CHECK-FIXES: auto EEE = [d] { d->operator()(1, 2); } + Fixi

[PATCH] D125829: [clang] Fix __has_builtin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGcefe472c51fb: [clang] Fix __has_builtin (authored by yaxunl). Herald added a project: clang. Changed prior t

[clang] cefe472 - [clang] Fix __has_builtin

Author: Yaxun (Sam) Liu Date: 2022-05-19T11:34:42-04:00 New Revision: cefe472c51fbcd1aed4d4a090709f25a12a8bc2c URL: https://github.com/llvm/llvm-project/commit/cefe472c51fbcd1aed4d4a090709f25a12a8bc2c DIFF: https://github.com/llvm/llvm-project/commit/cefe472c51fbcd1aed4d4a090709f25a12a8bc2c.dif

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

njames93 added a comment. Tbh the whole testing infrastructure for clang-tidy is a mess. When I have wanted to verify fixes and diagnostics for header files, I find manually invoking clang-tidy is better than using the check_clang_tidy script. I don't have the time right now, but a verify mode l

[PATCH] D125986: [clang][ASTImporter] Add support for import of UsingPackDecl.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a subs

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124776/new/ https://reviews.llvm.org/D124776 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:596-598 + MergedEnv.makeOr( + MergedEnv.makeAnd(Env1.getFlowConditionToken(), *HasValueVal1), + MergedEnv.makeAnd(Env2.getFlowConditionTok

[clang] 559b8fc - [AMDGPU] emit macro __GFX9__ etc

Author: Yaxun (Sam) Liu Date: 2022-05-19T12:06:56-04:00 New Revision: 559b8fc17ef6f5a65ccf9a11fce5f91c0a011b00 URL: https://github.com/llvm/llvm-project/commit/559b8fc17ef6f5a65ccf9a11fce5f91c0a011b00 DIFF: https://github.com/llvm/llvm-project/commit/559b8fc17ef6f5a65ccf9a11fce5f91c0a011b00.dif

[PATCH] D125909: [AMDGPU] emit macro __GFX9__ etc

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG559b8fc17ef6: [AMDGPU] emit macro __GFX9__ etc (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D125909?vs=

[PATCH] D125912: [Clang][[OpenMP5.1] Initial parser/sema for default(private) clause

jyu2 updated this revision to Diff 430715. jyu2 added a comment. Thanks Alexey for the review. This is fix the nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125912/new/ https://reviews.llvm.org/D125912 Files: clang/docs/LibASTMatchersRefer

[clang] c35ca3a - [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

Author: Amy Kwan Date: 2022-05-19T11:28:40-05:00 New Revision: c35ca3a1c78f693b749ad11742350b7fc6c5cd89 URL: https://github.com/llvm/llvm-project/commit/c35ca3a1c78f693b749ad11742350b7fc6c5cd89 DIFF: https://github.com/llvm/llvm-project/commit/c35ca3a1c78f693b749ad11742350b7fc6c5cd89.diff LOG:

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc35ca3a1c78f: [PowerPC] Implement XL compat __fnabs and __fnabss builtins. (authored by amyk). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

LegalizeAdulthood added a comment. In D125771#3525252 , @njames93 wrote: > Tbh the whole testing infrastructure for clang-tidy is a mess. When I have > wanted to verify fixes and diagnostics for header files, I find manually > invoking clang-tidy is bet

[clang] 5fc9449 - [DeadArgElim] Use poison instead of undef as placeholder for dead arguments

Author: Nuno Lopes Date: 2022-05-19T18:00:24+01:00 New Revision: 5fc9449c962a0703a658aa8e29162e00dc2fecf1 URL: https://github.com/llvm/llvm-project/commit/5fc9449c962a0703a658aa8e29162e00dc2fecf1 DIFF: https://github.com/llvm/llvm-project/commit/5fc9449c962a0703a658aa8e29162e00dc2fecf1.diff LO

[PATCH] D125983: [DeadArgElim] Use poison instead of undef as placeholder for dead arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5fc9449c962a: [DeadArgElim] Use poison instead of undef as placeholder for dead arguments (authored by nlopes). Herald added subscribers: cfe-commits

[clang] d374b65 - Drop qualifiers from return types in C (DR423)

Author: Aaron Ballman Date: 2022-05-19T13:06:50-04:00 New Revision: d374b65f2da1bdd3d9a7e9ac8ed4ad5467c882f9 URL: https://github.com/llvm/llvm-project/commit/d374b65f2da1bdd3d9a7e9ac8ed4ad5467c882f9 DIFF: https://github.com/llvm/llvm-project/commit/d374b65f2da1bdd3d9a7e9ac8ed4ad5467c882f9.diff

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd374b65f2da1: Drop qualifiers from return types in C (DR423) (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D125769: [clang-tidy] Introduce the CheckHeaderFile option to modernize-deprecated-headers

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/DeprecatedHeadersCheck.h:63 std::vector IncludesToBeProcessed; + bool WarnIntoHeaders; }; whisperity wrote: > LegalizeAdulthood wrote: > > 1) How is this different fr

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

paulkirth added a comment. We noticed when building Fuchsia using ToT LLVM that CGo has trouble with the new changes to DWARF introduced in this patch. It appears as if CGo is confused because it found a `DW_TAG_variable` that doesn't have a name, which is allowed by the DWARF standard. This

[PATCH] D125947: [RISCV] Add default ABI for archs with only F extension

jrtc27 added a comment. It's currently this way in order to be compatible with GCC. Changing this requires consensus from both toolchains to ensure compatibility is preserved. See https://github.com/riscv-non-isa/riscv-toolchain-conventions/issues/13 for some discussion on this. Repository:

[PATCH] D125947: [RISCV] Add default ABI for archs with only F extension

jrtc27 added a comment. Also, the tests where you have codegen changes rather than preserving a soft-float ABI should probably be put up for review separately by adding an explicit hard single-float ABI, as those seem worthwhile for reducing noise Repository: rG LLVM Github Monorepo CHANGES

[clang] d640442 - [NFC] Fix a couple of whitespace issues.

Author: Paul Walker Date: 2022-05-19T17:27:09Z New Revision: d640442518d5b095cbf10d4c8eae569425f0506e URL: https://github.com/llvm/llvm-project/commit/d640442518d5b095cbf10d4c8eae569425f0506e DIFF: https://github.com/llvm/llvm-project/commit/d640442518d5b095cbf10d4c8eae569425f0506e.diff LOG: [

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. Summary updated :) In D125788#3524338 , @kiranchandramohan wrote: > I think it is a driver flag `-flang-experimental-exec`. I was only requesting > the add this information to the patch summary. If you feel it should be > p

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. In D123534#3525533 , @paulkirth wrote: > We noticed when building Fuchsia using ToT LLVM that CGo has trouble with the > new changes to DWARF introduced in this patch. It appears as if CGo is > confused because it found a `DW_TAG_

[PATCH] D125974: [clang] Limit bitcode option ignorelist to Darwin

steven_wu added a comment. LGTM. Can you add a test for your usecase? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125974/new/ https://reviews.llvm.org/D125974 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

xazax.hun added a comment. Actually, I think in most cases we want to consistent how to merge bool values. So I wonder whether instead of reimplementing the merge operation in this check we should just call a function that does the work. And the same function should be used within the engine to

[PATCH] D126002: [clang] Fixing arm-common, windows only and openmp header install targets

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: craig.topper, DavidSpickett, nemanjai. qiongsiwu1 added a project: clang. Herald added subscribers: StephenFan, guansong, kristof.beyls, yaxunl, mgorny. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald ad

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:537 + FILES ${openmp_wrapper_files} + DESTINATION ${header_install_dir} + EXCLUDE_FROM_ALL craig.topper wrote: > Should this be ${header_install_dir}/openmp_wrappers Oh good catch!

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:421 install( FILES ${ppc_wrapper_files} craig.topper wrote: > qiongsiwu1 wrote: > > craig.topper wrote: > > > qiongsiwu1 wrote: > > > > craig.topper wrote: > > > > > There appear

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124836/new/ https://reviews.llvm.org/D124836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Don't forget to rebase this on top of https://reviews.llvm.org/D125421. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124836/ne

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

yaxunl added a comment. need a codegen test to make sure amdgpu_kernel ABI is used in C/C++ for functions with this attribute. https://github.com/llvm/llvm-project/blob/main/clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu#L64 may be used as an example. Repository: rG LLVM Github Mo

[clang] 7aa9c39 - [Clang][[OpenMP5.1] Initial parser/sema for default(private) clause

Author: Jennifer Yu Date: 2022-05-19T12:43:13-07:00 New Revision: 7aa9c39381989134e5d36ec1ea859dc6dc44d8eb URL: https://github.com/llvm/llvm-project/commit/7aa9c39381989134e5d36ec1ea859dc6dc44d8eb DIFF: https://github.com/llvm/llvm-project/commit/7aa9c39381989134e5d36ec1ea859dc6dc44d8eb.diff L

[PATCH] D125912: [Clang][[OpenMP5.1] Initial parser/sema for default(private) clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7aa9c3938198: [Clang][[OpenMP5.1] Initial parser/sema for default(private) clause (authored by jyu2). Changed prior to commit: https://reviews.llv

  1   2   >