steakhal added a comment. Now I see, the summary confused me.
> This includes the refactoring of the common assumle*Dual logic into the > function template assumeDualImpl. I felt like this is a refactoring change, but it was not. It's about fixing the behavior by using the `cloneAsPosteriorlyOverconstrained()`. Please reword the summary. ================ Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SimpleConstraintManager.h:42-46 + ProgramStateRef assumeInclusiveRangeInternal(ProgramStateRef State, + NonLoc Value, + const llvm::APSInt &From, + const llvm::APSInt &To, + bool InRange) override; ---------------- Why is this in the `public:` section, if the name of it suggests its a detail? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125892/new/ https://reviews.llvm.org/D125892 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
