awarzynski added a comment.

Summary updated :)

In D125788#3524338 <https://reviews.llvm.org/D125788#3524338>, 
@kiranchandramohan wrote:

> I think it is a driver flag `-flang-experimental-exec`. I was only requesting 
> the add this information to the patch summary. If you feel it should be 
> present somewhere else then please add a separate comment.

The flag is deliberately not being "advertised" - that was the compromise that 
we agreed on in https://reviews.llvm.org/D122008. Personally, I would really 
like to document it and make it more visible, but I don't want anyone to feel 
that their reservations are being ignored.

In D125788#3524338 <https://reviews.llvm.org/D125788#3524338>, 
@kiranchandramohan wrote:

> Some users might have been blindly running `flang` before without being aware 
> that the script was calling an external compiler to generated code/executable.

A while back we added documentation to clarify this.  The bash script (which is 
the most confusing part) is documented here 
<https://github.com/llvm/llvm-project/blob/main/flang/docs/FlangDriver.md#the-flang-script>
 (that's being updated here). I'm not sure whether there's anything else that 
we could improve 🤔.

In D125788#3523443 <https://reviews.llvm.org/D125788#3523443>, @rouson wrote:

> I think this is an exciting step.

Thank you!

> Although it's technically true that this could appear to be a regression for 
> current flang script users, the ultimate compilation currently happens by 
> invoking an external compiler so most current flang script users can 
> eliminate the regression by simply calling the external compiler.

I agree :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125788/new/

https://reviews.llvm.org/D125788

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to