[PATCH] D123836: [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123836/new/ https://reviews.llvm.org/D123836 _

[PATCH] D123836: [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

jpienaar accepted this revision. jpienaar added a comment. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123836/new/ https://reviews.llvm.org/D123836 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D123831: [POC][WIP] Use relative include in extract-api

dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:65 + // Matches framework include patterns + const llvm::Regex Rule("/(.+)\\.framework/(.+)?Headers/(.+)"); + StringRef WorkingDir = CI.getFileSystemOpts().WorkingDir; This doe

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire created this revision. junaire added reviewers: aaron.ballman, rsmith, erichkeane, dblaikie, rjmccall. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Because lambda will create its own scope, so

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

MaskRay added inline comments. Comment at: clang/test/Sema/init-randomized-struct.c:30 +} __attribute__((randomize_layout)); + +struct other_test t5 = { .a = foo, .b[0] = foo }; // Okay Perhaps test an empty struct with randomize_layout and a struct with one fiel

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

ChuanqiXu updated this revision to Diff 423030. ChuanqiXu added a comment. Fix tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123837/new/ https://reviews.llvm.org/D123837 Files: clang/include/clang/Basic/Module.h clang/lib/Sema/SemaLookup.cpp clang/test/CXX/module/module.imp

[clang] 5206c2c - [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

Author: Brad Smith Date: 2022-04-15T03:55:59-04:00 New Revision: 5206c2c167ed8826bf233d0e424a87c5e11bc807 URL: https://github.com/llvm/llvm-project/commit/5206c2c167ed8826bf233d0e424a87c5e11bc807 DIFF: https://github.com/llvm/llvm-project/commit/5206c2c167ed8826bf233d0e424a87c5e11bc807.diff LO

[PATCH] D123836: [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5206c2c167ed: [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault… (authored by brad). Repository: rG LLVM Github Monore

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

bowang added a comment. > Hi, this patch is just part-1 of Windows SEH feature support. Part-2 work > had been sitting in https://reviews.llvm.org/D102817/new/ since last May > 2021. It's been reviewed, and feedbacks had been addressed. but nobody has > approved it. To handle Hardware Except

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu updated this revision to Diff 423044. ChuanqiXu marked 18 inline comments as done. ChuanqiXu added a comment. Herald added a subscriber: MaskRay. Address @rsmith's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113545/new/ https://reviews.llvm.org/D113545 Files: cl

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu added a comment. @rsmith Thanks for your valuable input! Comment at: clang/lib/Sema/SemaLookup.cpp:2000-2004 + // Class and enumeration member names can be found by name lookup in any + // context in which a definition of the type is reachable. + if (auto *ECD = dy

[PATCH] D123850: [Clang] Fix Unevaluated Lambdas Backport to Clang 14.0.1

cor3ntin created this revision. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Unlike other types, when lambdas are instanciated, th

[PATCH] D123850: [Clang] Fix Unevaluated LambdasBackport to Clang 14.0.1

cor3ntin added a comment. @tstellar I wasn't sure what the procedure was for backporting fixes, so I made a PR. I think your suggestion of keeping the old signature works well. This also modifies the serialized AST, is that an issue for backports? (If it is, I'm not sure i see a way to move forw

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

glandium added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Is it expected that `__FLT_EVAL_METHOD__` is not set at all anymore by default after this change? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 _

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D123345#3452933 , @rsmith wrote: > In D123345#3452496 , @aaron.ballman > wrote: > >> Do you

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3452994 , @rsmith wrote: > In D122983#3451920 , @erichkeane > wrote: > >> I think Aaron's approach provides a proper 'depreciation' period in our >> compiler, as best as

[PATCH] D123826: Fix size of flexible array initializers, and re-enable assertions.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Couple nits, otherwise LGTM. Comment at: clang/lib/AST/Decl.cpp:2731 +return false; + auto *List = dyn_cast(getInit()->IgnoreParens()); + if (!List) ---

[clang] 33d3fc4 - [C89/C2x] Diagnose calls to a function without a prototype but passes arguments

Author: Aaron Ballman Date: 2022-04-15T09:08:54-04:00 New Revision: 33d3fc4466479285121cbb1a62db249454da0bda URL: https://github.com/llvm/llvm-project/commit/33d3fc4466479285121cbb1a62db249454da0bda DIFF: https://github.com/llvm/llvm-project/commit/33d3fc4466479285121cbb1a62db249454da0bda.diff

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:358 + assert(!isEmpty()); + return begin()->From().isUnsigned(); +} martong wrote: > Probably it is unrelated to this patch, but > Could it happen that `(+

[clang] f263dac - [clang][parse] NFCI: Use FileEntryRef in Parser::ParseModuleImport()

Author: Jan Svoboda Date: 2022-04-15T15:16:17+02:00 New Revision: f263dac4465c251e37af9787baf5e9f56138e369 URL: https://github.com/llvm/llvm-project/commit/f263dac4465c251e37af9787baf5e9f56138e369 DIFF: https://github.com/llvm/llvm-project/commit/f263dac4465c251e37af9787baf5e9f56138e369.diff L

[clang] 99b4874 - [clang] NFCI: Use DirectoryEntryRef in collectIncludePCH

Author: Jan Svoboda Date: 2022-04-15T15:16:17+02:00 New Revision: 99b4874a53cf4cd39a164a63b5505baace825d7c URL: https://github.com/llvm/llvm-project/commit/99b4874a53cf4cd39a164a63b5505baace825d7c DIFF: https://github.com/llvm/llvm-project/commit/99b4874a53cf4cd39a164a63b5505baace825d7c.diff L

[clang] 9d98f58 - [clang][CodeGen] NFCI: Use FileEntryRef

Author: Jan Svoboda Date: 2022-04-15T15:16:17+02:00 New Revision: 9d98f58959b12b6ddab5ac10453e1464bb830e96 URL: https://github.com/llvm/llvm-project/commit/9d98f58959b12b6ddab5ac10453e1464bb830e96 DIFF: https://github.com/llvm/llvm-project/commit/9d98f58959b12b6ddab5ac10453e1464bb830e96.diff L

[PATCH] D123767: [clang][parse] NFCI: Use FileEntryRef in Parser::ParseModuleImport()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf263dac4465c: [clang][parse] NFCI: Use FileEntryRef in Parser::ParseModuleImport() (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[clang] 713e716 - [clang] NFCI: Use FileEntryRef in FileManagerTest

Author: Jan Svoboda Date: 2022-04-15T15:16:17+02:00 New Revision: 713e716cdaef1ee069f27bb71fd232a782565e0a URL: https://github.com/llvm/llvm-project/commit/713e716cdaef1ee069f27bb71fd232a782565e0a DIFF: https://github.com/llvm/llvm-project/commit/713e716cdaef1ee069f27bb71fd232a782565e0a.diff L

[clang] 0b09b5d - [clang][lex] NFC: Use FileEntryRef in PreprocessorLexer::getFileEntry()

Author: Jan Svoboda Date: 2022-04-15T15:16:17+02:00 New Revision: 0b09b5d44837ea71c6bf017607b33f283c4417c6 URL: https://github.com/llvm/llvm-project/commit/0b09b5d44837ea71c6bf017607b33f283c4417c6 DIFF: https://github.com/llvm/llvm-project/commit/0b09b5d44837ea71c6bf017607b33f283c4417c6.diff L

[PATCH] D123768: [clang][CodeGen] NFCI: Use FileEntryRef

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d98f58959b1: [clang][CodeGen] NFCI: Use FileEntryRef (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123769: [clang] NFCI: Use DirectoryEntryRef in collectIncludePCH

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG99b4874a53cf: [clang] NFCI: Use DirectoryEntryRef in collectIncludePCH (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D123770: [clang] NFCI: Use FileEntryRef in FileManagerTest

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG713e716cdaef: [clang] NFCI: Use FileEntryRef in FileManagerTest (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D123772: [clang][lex] NFC: Use FileEntryRef in PreprocessorLexer::getFileEntry()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b09b5d44837: [clang][lex] NFC: Use FileEntryRef in PreprocessorLexer::getFileEntry() (authored by jansvoboda11). Repository: rG LLVM Github Monor

[clang] 57a4f9b - Fix failing test case found by bots:

Author: Aaron Ballman Date: 2022-04-15T09:20:16-04:00 New Revision: 57a4f9bd493bca0dc78b16951c7d3f3fadfbc2f2 URL: https://github.com/llvm/llvm-project/commit/57a4f9bd493bca0dc78b16951c7d3f3fadfbc2f2 DIFF: https://github.com/llvm/llvm-project/commit/57a4f9bd493bca0dc78b16951c7d3f3fadfbc2f2.diff

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire added a comment. Hi @erichkeane , thanks for accepting this! But do you think we need to add a release note about it? (I'm a totally beginner so sometimes I'm confused about when we should do it.) Also, Do you have any concerns about the wording? In fact, I am pretty embarrassed by the

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

erichkeane added a comment. Ah, right, we SHOULD have a release note, please add one and I'll help review the wording. Commit message is fine for a commit message, particularly with a good release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()

jansvoboda11 marked 5 inline comments as done. jansvoboda11 added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:339 // Search for a module map file in this directory. -if (loadModuleMapFile(Dir.getDir(), IsSystem, +if (loadModuleMapFile(*Dir.getDirRef()

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire updated this revision to Diff 423079. junaire added a comment. Add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123840/new/ https://reviews.llvm.org/D123840 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/IdentifierR

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire added a comment. In D123840#3453903 , @erichkeane wrote: > Ah, right, we SHOULD have a release note, please add one and I'll help review > the wording. Commit message is fine for a commit message, particularly with > a good release note. Than

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions

ASDenysPetrov updated this revision to Diff 423080. ASDenysPetrov added a comment. Updated according to suggestions. @martong thank you for the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103094/new/ https://reviews.llvm.org/D103094 Files: clang/include/clang/StaticAnalyzer

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

aaron.ballman added a comment. In D109239#3453770 , @glandium wrote: > Is it expected that `__FLT_EVAL_METHOD__` is not set at all anymore by > default after this change? Can you give a bit more details about what you're seeing? "not set at all" sounds

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire added a comment. I also find the code below really awkward: S->getParent()->getFlags() & Scope::ControlScope I find that we have helpers like `Scope::isBlockScope()` `Scope::isisTryScope()` and etc, but no `Scope::isControlScope` and `Scope::isFnTryCatchScope` I will add these helpe

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

erichkeane added a comment. >> I will add these helpers as a NFC patch after this one, that won't need a >> release note or review right? I found that awkward as well, and almost requested that you fix this, but decided against it. I'm ok with this being an NFC patch. It would be nice to grep

[PATCH] D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()

jansvoboda11 updated this revision to Diff 423084. jansvoboda11 marked 5 inline comments as done. jansvoboda11 added a comment. Rebase, address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123771/new/ https://reviews.llvm.org/D1237

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire updated this revision to Diff 423085. junaire added a comment. Fix bad wording. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123840/new/ https://reviews.llvm.org/D123840 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/IdentifierReso

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:123 +- Clang should no longer incorrectly diagnose a variable declaration inside of + a lambda expression inside the scope of a if/while/for/switch init statement + as a redeclaration. So

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire marked an inline comment as done. junaire added inline comments. Comment at: clang/docs/ReleaseNotes.rst:122 This fixes Issue `Issue 54817 `_. +- No longer produce a wrong redefinition error if variables are defined i

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

junaire updated this revision to Diff 423086. junaire marked an inline comment as done. junaire added a comment. Update release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123840/new/ https://reviews.llvm.org/D123840 Files: clang/docs/Re

[PATCH] D123853: [clang] NFCI: Use DirectoryEntryRef in FrontendAction::BeginSourceFile()

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes use of the deprecated `DirectoryEntry::getN

[clang] be0905a - [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

Author: Jun Zhang Date: 2022-04-15T21:54:39+08:00 New Revision: be0905a333d6f7c4d7f5c70c18211463e53473cd URL: https://github.com/llvm/llvm-project/commit/be0905a333d6f7c4d7f5c70c18211463e53473cd DIFF: https://github.com/llvm/llvm-project/commit/be0905a333d6f7c4d7f5c70c18211463e53473cd.diff LOG

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe0905a333d6: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement (authored by junaire). Repository: rG LLVM Github Monorepo

[PATCH] D121984: [RISCV] Moving RVV intrinsic type related util to clang/Support

kito-cheng added a comment. > Thank you for the explanation. I still don't think this is really "Support" > material, but I'm also struggling to think of a better place to put it in an > existing directory in Clang aside from Basic, but that would still be a bit > of a layering violation it fee

[PATCH] D123854: [clang][lex] NFCI: Use DirectoryEntryRef in FrameworkCacheEntry

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the member of `FrameworkCacheEntry` from `c

[PATCH] D123856: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::diagnoseHeaderInclusion()

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes uses of the deprecated `DirectoryEntry::get

[clang] 7ed01ba - [clang][deps] NFC: Inline function with single caller

Author: Jan Svoboda Date: 2022-04-15T16:24:40+02:00 New Revision: 7ed01ba88d67a0eb79663547f9ec21d106f7b281 URL: https://github.com/llvm/llvm-project/commit/7ed01ba88d67a0eb79663547f9ec21d106f7b281 DIFF: https://github.com/llvm/llvm-project/commit/7ed01ba88d67a0eb79663547f9ec21d106f7b281.diff L

[clang] 26b0ecb - [clang][deps] NFC: Update documentation

Author: Jan Svoboda Date: 2022-04-15T16:24:41+02:00 New Revision: 26b0ecb8985b7e76a5ca0965d3d464611eda14f0 URL: https://github.com/llvm/llvm-project/commit/26b0ecb8985b7e76a5ca0965d3d464611eda14f0 DIFF: https://github.com/llvm/llvm-project/commit/26b0ecb8985b7e76a5ca0965d3d464611eda14f0.diff L

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3453770 , @glandium wrote: > Is it expected that `__FLT_EVAL_METHOD__` is not set at all anymore by > default after this change? @glandium would you mind giving a reproducer. We might have missed a flow path where t

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04000c2f928a: [clang] Implement Change scope of lambda trailing-return-type (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES S

[clang] 04000c2 - [clang] Implement Change scope of lambda trailing-return-type

Author: Corentin Jabot Date: 2022-04-15T16:50:52+02:00 New Revision: 04000c2f928a7adc32138a664d167f01b642bef3 URL: https://github.com/llvm/llvm-project/commit/04000c2f928a7adc32138a664d167f01b642bef3 DIFF: https://github.com/llvm/llvm-project/commit/04000c2f928a7adc32138a664d167f01b642bef3.diff

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Ensure that the expressions associated with terminators are asso

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson updated this revision to Diff 423116. royjacobson marked an inline comment as not done. royjacobson added a comment. Update for look inside FunctionParamTypesAreEqual to be index based and simpler. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:2967 + "parameters!"); + for (FunctionProtoType::param_type_iterator + O = OldType->param_type_begin(), erichkeane wrote: > Thanks for the clarification on 'Reversed

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:2967 + "parameters!"); + for (FunctionProtoType::param_type_iterator + O = OldType->param_type_begin(), royjacobson wrote: > erichkeane wrote: > > Thanks for the clar

[clang] 52e6a27 - Clean up `OMPAtomicDirective::Create`

Author: Shilei Tian Date: 2022-04-15T11:41:26-04:00 New Revision: 52e6a27690ca8e5f07cc646716c3736475b7746b URL: https://github.com/llvm/llvm-project/commit/52e6a27690ca8e5f07cc646716c3736475b7746b DIFF: https://github.com/llvm/llvm-project/commit/52e6a27690ca8e5f07cc646716c3736475b7746b.diff L

[clang] c7d4a05 - Properly identify builtins in a diagnostic note

Author: Aaron Ballman Date: 2022-04-15T11:46:13-04:00 New Revision: c7d4a05228090cb6b1b7f6e5d300f197897ac756 URL: https://github.com/llvm/llvm-project/commit/c7d4a05228090cb6b1b7f6e5d300f197897ac756 DIFF: https://github.com/llvm/llvm-project/commit/c7d4a05228090cb6b1b7f6e5d300f197897ac756.diff

[PATCH] D123627: Correctly diagnose prototype redeclaration errors in C

aaron.ballman added a comment. In D123627#3452491 , @efriedma wrote: >> The reason you get the weird behavior with the note pointing to the same >> line as the declaration is because rintf() is a predefined builtin: >> https://godbolt.org/z/j3W759M7a (n

[PATCH] D123826: Fix size of flexible array initializers, and re-enable assertions.

efriedma added inline comments. Comment at: clang/lib/AST/Decl.cpp:2735 + const Expr *FlexibleInit = List->getInit(List->getNumInits() - 1); + auto InitTy = Ctx.getAsConstantArrayType(FlexibleInit->getType()); + if (!InitTy) erichkeane wrote: > Same here You w

[PATCH] D123826: Fix size of flexible array initializers, and re-enable assertions.

erichkeane added inline comments. Comment at: clang/lib/AST/Decl.cpp:2735 + const Expr *FlexibleInit = List->getInit(List->getNumInits() - 1); + auto InitTy = Ctx.getAsConstantArrayType(FlexibleInit->getType()); + if (!InitTy) efriedma wrote: > erichkeane wrot

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson updated this revision to Diff 423120. royjacobson added a comment. Split the 'can compare constraints' code into a static function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 Files: cla

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson marked 2 inline comments as done. royjacobson added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9829 + bool CanCompareConstraints = false; + if (Cand1.Function && Cand2.Function && Cand1.Function->hasPrototype() && + Cand2.Function->hasPrototyp

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I'm happy with this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 ___

[PATCH] D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()

bnbarham accepted this revision. bnbarham added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Lex/HeaderSearch.cpp:1583 +::getTopFrameworkDir(FileMgr, FrameworkName, SubmodulePath); +assert(TopFrameworkDir && "Could not find t

[PATCH] D121984: [RISCV] Moving RVV intrinsic type related util to clang/Support

aaron.ballman accepted this revision. aaron.ballman added a reviewer: rsmith. aaron.ballman added a subscriber: rsmith. aaron.ballman added a comment. In D121984#3453976 , @kito-cheng wrote: >> Thank you for the explanation. I still don't think this is r

[PATCH] D123854: [clang][lex] NFCI: Use DirectoryEntryRef in FrameworkCacheEntry

bnbarham accepted this revision. bnbarham added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Lex/HeaderSearch.cpp:584 // If it is known and in some other directory, fail. - if (CacheEntry.Directory && CacheEntry.Directory != getFrame

[PATCH] D123856: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::diagnoseHeaderInclusion()

bnbarham accepted this revision. bnbarham added a comment. This revision is now accepted and ready to land. Shadowing of `FE` almost tripped me up there 😅 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123856/new/ https://reviews.llvm.org/D123856 _

[PATCH] D123300: [Clang] Enable opaque pointers by default

aeubanks added a comment. $ cat /tmp/a.ll target triple = "thumbv8-unknown-linux-gnueabihf" define void @zot() { bb: br label %bb1 bb1: ; preds = %bb1, %bb %tmp = phi ptr [ null, %bb ], [ %tmp2, %bb1 ] store ptr %tmp, ptr %t

[PATCH] D123642: [clang codegen] Assume arguments of __atomic_* are aligned.

efriedma added a comment. > Have we verified that this is the rule that GCC uses? Is it true even if e.g. > the pointer expression is the address of a variable with a known alignment, > or if the pointer has an explicitly-aligned type (e.g. with an aligned > typedef)? As far as I can tell, if

[PATCH] D123862: [Clang][OpenMP] Use bitfields for flags in `OMPAtomicDirective`

tianshilei1992 created this revision. tianshilei1992 added reviewers: ABataev, jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repos

[PATCH] D123649: Allow flexible array initialization in C++.

nickdesaulniers added a comment. For posterity, posting the link to the failure this caused in Linaro's TCWG's CI of kernel builds w/ clang: https://lore.kernel.org/llvm/906914372.14298.1650022522881@jenkins.jenkins/. I'm guessing D123826 fixes this? Reposit

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 updated this revision to Diff 423132. tianshilei1992 added a comment. Herald added a project: All. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120290/new/ https://reviews.llvm.org/D120290 Files: clang/include/clang/AST/St

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 marked 3 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:2835-2847 bool IsXLHSInRHSPart = false; /// Used for 'atomic update' or 'atomic capture' constructs. They may /// have atomic expressio

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

aaron.ballman added inline comments. Comment at: clang/test/Sema/init-randomized-struct.c:30 +} __attribute__((randomize_layout)); + +struct other_test t5 = { .a = foo, .b[0] = foo }; // Okay MaskRay wrote: > Perhaps test an empty struct with randomize_layout and

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

dblaikie added a comment. This seems like it would significantly introduce debug info size for at least some kinds of code - have you done any size measurements of this change? What does the resulting DWARF look like? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D123862: [Clang][OpenMP] Use bitfields for flags in `OMPAtomicDirective`

ABataev added a comment. What about ASTStmtWriter? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123862/new/ https://reviews.llvm.org/D123862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] 8fd3b5d - Fix an edge case in determining is a function has a prototype

Author: Aaron Ballman Date: 2022-04-15T14:04:07-04:00 New Revision: 8fd3b5de3f96300189a2841278e6c7b6654bffc5 URL: https://github.com/llvm/llvm-project/commit/8fd3b5de3f96300189a2841278e6c7b6654bffc5 DIFF: https://github.com/llvm/llvm-project/commit/8fd3b5de3f96300189a2841278e6c7b6654bffc5.diff

[PATCH] D123862: [Clang][OpenMP] Use bitfields for flags in `OMPAtomicDirective`

tianshilei1992 added a comment. In D123862#3454380 , @ABataev wrote: > What about ASTStmtWriter? It's using accessor function `isXLHSInRHSPart()` and so on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3452994 , @rsmith wrote: > I think we should just make this an error by default in C99 onwards; Out of curiosity -- do you think we should remove the `DefaultIgnore` in C89 mode so that we warn by default there

[PATCH] D123862: [Clang][OpenMP] Use bitfields for flags in `OMPAtomicDirective`

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123862/new/ https://reviews.llvm.org/D123862 ___

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

void updated this revision to Diff 423139. void added a comment. Add tests for empty and single element structs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123763/new/ https://reviews.llvm.org/D123763 Files: clang/include/clang/Basic/Diagnost

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for adding some guard rails for this new feature! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123763/new/ https:

[PATCH] D123642: [clang codegen] Assume arguments of __atomic_* are aligned.

jyknight added a comment. In D123642#3450110 , @efriedma wrote: >> I disagree with this on principle -- IMO, it is basically a historical bug >> in GCC that it ignores the type alignment, and we should NOT try to match >> that -- it's dangerous. > > gcc

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

MaskRay accepted this revision. MaskRay added a comment. LGTM, too. It may be worthwhile adding a file-level comment at the header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123763/new/ https://reviews.llvm.org/D123763 ___

[PATCH] D123649: Allow flexible array initialization in C++.

efriedma added a comment. 6cf0b1b3 was a temporary fix to stop the crash. D123826 is the full fix to make the assertion actually work correctly. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

jyknight added a comment. In D122983#3454406 , @aaron.ballman wrote: > In D122983#3452994 , @rsmith wrote: > >> I think we should just make this an error by default in C99 onwards; > > Out of curiosity -- do you

[clang] 4802edd - Fix size of flexible array initializers, and re-enable assertions.

Author: Eli Friedman Date: 2022-04-15T12:09:57-07:00 New Revision: 4802edd1ac7a5aea8c8488b5baec221d722cbdde URL: https://github.com/llvm/llvm-project/commit/4802edd1ac7a5aea8c8488b5baec221d722cbdde DIFF: https://github.com/llvm/llvm-project/commit/4802edd1ac7a5aea8c8488b5baec221d722cbdde.diff

[PATCH] D123826: Fix size of flexible array initializers, and re-enable assertions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4802edd1ac7a: Fix size of flexible array initializers, and re-enable assertions. (authored by efriedma). Changed prior to commit: https://reviews.

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3454494 , @jyknight wrote: > In D122983#3454406 , @aaron.ballman > wrote: > >> In D122983#3452994 , @rsmith wrote: >> >>> I thin

[clang] 721651b - [HLSL][clang][Driver] Support target profile command line option.

Author: Xiang Li Date: 2022-04-15T14:18:18-05:00 New Revision: 721651be246e26efd767c3ec55c8f06c7b5a9a3d URL: https://github.com/llvm/llvm-project/commit/721651be246e26efd767c3ec55c8f06c7b5a9a3d DIFF: https://github.com/llvm/llvm-project/commit/721651be246e26efd767c3ec55c8f06c7b5a9a3d.diff LOG:

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG721651be246e: [HLSL][clang][Driver] Support target profile command line option. (authored by python3kgae, committed by beanz). Changed prior to comm

[clang] aed923b - [randstruct] Enforce using a designated init for a randomized struct

Author: Bill Wendling Date: 2022-04-15T12:29:32-07:00 New Revision: aed923b1246ac38335b222b89594516fcf0d6385 URL: https://github.com/llvm/llvm-project/commit/aed923b1246ac38335b222b89594516fcf0d6385 DIFF: https://github.com/llvm/llvm-project/commit/aed923b1246ac38335b222b89594516fcf0d6385.diff

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaed923b1246a: [randstruct] Enforce using a designated init for a randomized struct (authored by void). Changed prior to commit: https://reviews.ll

[PATCH] D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C.

dblaikie added a comment. This might've caused a regression? (https://github.com/llvm/llvm-project/issues/54892) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121959/new/ https://reviews.llvm.org/D121959 __

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

dblaikie added a comment. In D123345#3453037 , @rnk wrote: > Generally speaking, this sounds like a good idea to me. One time in 2019 I > used -ftime-trace+ClangBuildAnalyzer and it told me that std::unique_ptr was > the most expensive template >

[PATCH] D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C.

tahonermann added a comment. > This might've caused a regression? > (https://github.com/llvm/llvm-project/issues/54892) @dblaikie, it most definitely did. Note that I'm the author of the patch that introduced the regression, the reporter of the regression, and the assignee for fixing the regre

  1   2   >