[clang] 2121dc5 - [llvm-lto] Remove support for legacy pass manager

Author: Nikita Popov Date: 2022-04-11T09:40:17+02:00 New Revision: 2121dc5b158b0d11667a5d8c39f0121b869ca1c5 URL: https://github.com/llvm/llvm-project/commit/2121dc5b158b0d11667a5d8c39f0121b869ca1c5 DIFF: https://github.com/llvm/llvm-project/commit/2121dc5b158b0d11667a5d8c39f0121b869ca1c5.diff

[PATCH] D123376: [llvm-lto] Remove support for legacy pass manager

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2121dc5b158b: [llvm-lto] Remove support for legacy pass manager (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-co

[PATCH] D123479: [clang-tidy] Support parenthesized literals in modernize-macro-to-enum

njames93 added a comment. Would it not be better if these parens were stripped in the fixit as they are unnecessary in the enum value decl? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123479/new/ https://reviews.llvm.org/D123479 ___

[PATCH] D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups

kadircet updated this revision to Diff 421847. kadircet added a comment. - Address comments and more cleanups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123289/new/ https://reviews.llvm.org/D123289 Files: clang-tools-extra/clangd/index/Symbol

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Th

[clang] 92fed06 - [C++20][Modules] Remove an empty statement [NFC].

Author: Iain Sandoe Date: 2022-04-11T10:06:23+01:00 New Revision: 92fed06f800aa2d0fd29f9e3eac8323cba64b167 URL: https://github.com/llvm/llvm-project/commit/92fed06f800aa2d0fd29f9e3eac8323cba64b167 DIFF: https://github.com/llvm/llvm-project/commit/92fed06f800aa2d0fd29f9e3eac8323cba64b167.diff L

[clang] 69f7f15 - [Clang] Add -no-opaque-pointers to recently added test (NFC)

Author: Nikita Popov Date: 2022-04-11T11:13:38+02:00 New Revision: 69f7f15683c451378dbe9029a0bd2dbd029bcf3a URL: https://github.com/llvm/llvm-project/commit/69f7f15683c451378dbe9029a0bd2dbd029bcf3a DIFF: https://github.com/llvm/llvm-project/commit/69f7f15683c451378dbe9029a0bd2dbd029bcf3a.diff

[clang] 702d5de - [Clang] Enable opaque pointers by default

Author: Nikita Popov Date: 2022-04-11T11:13:45+02:00 New Revision: 702d5de4380b1e1554e5b90863093c3a57f76f70 URL: https://github.com/llvm/llvm-project/commit/702d5de4380b1e1554e5b90863093c3a57f76f70 DIFF: https://github.com/llvm/llvm-project/commit/702d5de4380b1e1554e5b90863093c3a57f76f70.diff

[PATCH] D123300: [Clang] Enable opaque pointers by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG702d5de4380b: [Clang] Enable opaque pointers by default (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups

kadircet updated this revision to Diff 421855. kadircet marked 6 inline comments as done. kadircet edited the summary of this revision. kadircet added a comment. - Get rid of leftovers and update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:710 // FIXME: Populate container information for macro references. -MacroRefs[ID].push_back({Loc, Roles, /*Container=*/nullptr}); +// FIXME: All macro references are marked

[PATCH] D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:189 + clang::Token Tok; + if (clang::Lexer::getRawToken(Loc, Tok, SM, LO)) +return false; You've changed this from tokenizing t

[PATCH] D123478: [clangd] Fix incorrect operator< impl for HighlightingToken

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Oopsy :/ Thanks for the fix! Regarding the test, if you came looking for this piece due to a particular issue, it might be nice to have that included in the test suite (assuming it can be

[PATCH] D122525: [clang][ASTImporter] Fix an import error handling related bug.

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8792-8794 +if (!isa(FromDi)) + if (auto *FromDiDC = dyn_cast(FromDi)) +if (FromDiDC->containsDecl(PrevFromDi)) balazske wrote: > martong wrote: > > We should ele

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

hokein updated this revision to Diff 421856. hokein added a comment. add a unittest for template name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123127/new/ https://reviews.llvm.org/D123127 Files: clang-tools-extra/clangd/DumpAST.cpp clang

[PATCH] D123397: [clang][ASTImporter] Add import of attribute 'enable_if'.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123397/new/ https://reviews.llvm.org/D123397 _

[PATCH] D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:189 + clang::Token Tok; + if (clang::Lexer::getRawToken(Loc, Tok, SM, LO)) +return false; sammccall wrote: > You've changed this from tokenizing the file with a c

[clang] 02cccdc - [AST] Remove a duplicated getDecl method in TemplateName, NFC.

Author: Haojian Wu Date: 2022-04-11T11:51:28+02:00 New Revision: 02cccdcab25eac735831b405b5ab712543b16950 URL: https://github.com/llvm/llvm-project/commit/02cccdcab25eac735831b405b5ab712543b16950 DIFF: https://github.com/llvm/llvm-project/commit/02cccdcab25eac735831b405b5ab712543b16950.diff LO

[clang] b72fd1a - [CGCall] Check store type in findDominatingStoreToReturnValue()

Author: Nikita Popov Date: 2022-04-11T12:08:29+02:00 New Revision: b72fd1a84d33e19f9f7fa6b7fdcaea57dc51aee4 URL: https://github.com/llvm/llvm-project/commit/b72fd1a84d33e19f9f7fa6b7fdcaea57dc51aee4 DIFF: https://github.com/llvm/llvm-project/commit/b72fd1a84d33e19f9f7fa6b7fdcaea57dc51aee4.diff

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

iains marked an inline comment as done. iains added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:814-815 +diagExportedUnnamedDecl(S, UnnamedDeclKind::Namespace, D, BlockStart); + else +; // We allow an empty named namespace decl. +} else if

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/TemplateName.cpp:246 TemplateNameDependenceScope::DependentInstantiation) Template->printQualifiedName(OS, Policy

[clang] bb6f8d9 - [OpenCL] Add device enqueue guards for DSE builtins

Author: Sven van Haastregt Date: 2022-04-11T11:27:51+01:00 New Revision: bb6f8d9a93ef0172f227b04c92e7bbb703641a79 URL: https://github.com/llvm/llvm-project/commit/bb6f8d9a93ef0172f227b04c92e7bbb703641a79 DIFF: https://github.com/llvm/llvm-project/commit/bb6f8d9a93ef0172f227b04c92e7bbb703641a79.

[clang] bdadf1c - [C++20][Modules] Add testcases from section 10.2 dependent on header units.

Author: Iain Sandoe Date: 2022-04-11T11:30:45+01:00 New Revision: bdadf1c2ecb452ca41f23caa87415bc1f9a8431b URL: https://github.com/llvm/llvm-project/commit/bdadf1c2ecb452ca41f23caa87415bc1f9a8431b DIFF: https://github.com/llvm/llvm-project/commit/bdadf1c2ecb452ca41f23caa87415bc1f9a8431b.diff L

[PATCH] D122124: [C++20][Modules] Add testcases from section 10.2 dependent on header units.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbdadf1c2ecb4: [C++20][Modules] Add testcases from section 10.2 dependent on header units. (authored by iains). Repository: rG LLVM Github Monorepo

[PATCH] D122728: [OpenCL] opencl-c.h: Add const to get_image_num_samples

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122728/new/ https://reviews.llvm.org/D122728 _

[PATCH] D123452: [Clang] Override method ModuleImportRead in MultiplexASTDeserializationListener

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. LG Do you have commit permission, or do you want me to land this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123452/new/ https://rev

[clang] b00d0fa - [Clang] Add -no-opaque-pointers to native powerpc test (NFC)

Author: Nikita Popov Date: 2022-04-11T13:15:46+02:00 New Revision: b00d0fa2c7f0a187867c535b3f7006376420d58f URL: https://github.com/llvm/llvm-project/commit/b00d0fa2c7f0a187867c535b3f7006376420d58f DIFF: https://github.com/llvm/llvm-project/commit/b00d0fa2c7f0a187867c535b3f7006376420d58f.diff

[PATCH] D123452: [Clang] Override method ModuleImportRead in MultiplexASTDeserializationListener

lgxbslgx added a comment. @thakis Thanks for the review. I don't have the commit permission. Please use `Guoxiong Li ` to commit the change. Thanks for your help. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123452/new/ https://reviews.llvm.org/

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski added inline comments. Comment at: flang/test/Driver/mllvm_vs_mmlir.f90:17 +! MLLVM: flang (LLVM option parsing) [options] +! MLLVM: --print-ir-after-all +! MLLVM-NOT: --mlir-{{.*}} awarzynski wrote: > rriddle wrote: > > awarzynski wrote: > > > awarzyn

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115620/new/ https://reviews.llvm.org/D115620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123296: [llvm][AArch64] Generate getExtensionFeatures from the list of extensions

tmatheson accepted this revision. tmatheson added inline comments. This revision is now accepted and ready to land. Comment at: llvm/unittests/Support/TargetParserTest.cpp:1474 EXPECT_FALSE(AArch64::getExtensionFeatures(AArch64::AEK_INVALID, Features)); EXPECT_TRUE(!Feature

[clang] d29f8a5 - [Clang] Override method ModuleImportRead in MultiplexASTDeserializationListener

Author: Guoxiong Li Date: 2022-04-11T08:38:37-04:00 New Revision: d29f8a5f83501f69621687c09ba4b3c75033bada URL: https://github.com/llvm/llvm-project/commit/d29f8a5f83501f69621687c09ba4b3c75033bada DIFF: https://github.com/llvm/llvm-project/commit/d29f8a5f83501f69621687c09ba4b3c75033bada.diff L

[PATCH] D123452: [Clang] Override method ModuleImportRead in MultiplexASTDeserializationListener

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd29f8a5f8350: [Clang] Override method ModuleImportRead in MultiplexASTDeserializationListener (authored by lgxbslgx, committed by thakis). Repositor

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:4889-4890 return T->isArrayType(); + case UTT_IsBoundedArray: +return T->isArrayType() && !T->isIncompleteArrayType(); + case UTT_IsUnboundedArray: Is a VLA a bounded array

[PATCH] D123452: [Clang] Override method ModuleImportRead in MultiplexASTDeserializationListener

thakis added a comment. Thanks for the patch1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123452/new/ https://reviews.llvm.org/D123452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D123452: [Clang] Override method ModuleImportRead in MultiplexASTDeserializationListener

thakis added a comment. ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123452/new/ https://reviews.llvm.org/D123452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: jsji, daltenty, nemanjai. qiongsiwu1 added a project: clang. Herald added subscribers: steven.zhang, pengfei, mgorny, dschuff. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: cfe-commi

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

hokein updated this revision to Diff 421891. hokein marked 2 inline comments as done. hokein added a comment. address remaining comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123127/new/ https://reviews.llvm.org/D123127 Files: clang-too

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

simon_tatham added inline comments. Comment at: llvm/lib/Target/ARM/ARMFixCortexA57AES1742098Pass.cpp:12-19 +// The intention is this: +// - Any 128-bit or 64-bit writes to the neon input register of an AES fused +// pair are safe (the inputs are to the AESE/AESD instruction).

Re: [PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

Somehow this entire thread seems to have dropped the mailing lists and the review in question, so top-posting to ensure the discussion at least makes it to the mailing lists. ~Aaron On Mon, Apr 11, 2022 at 9:10 AM Aaron Ballman wrote: > > On Mon, Apr 11, 2022 at 8:25 AM Joerg Sonnenberger wrote

[PATCH] D123296: [llvm][AArch64] Generate getExtensionFeatures from the list of extensions

DavidSpickett updated this revision to Diff 421909. DavidSpickett added a comment. Added check that NONE does not return any feature names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123296/new/ https://reviews.llvm.org/D123296 Files: clang/t

[PATCH] D123296: [llvm][AArch64] Generate getExtensionFeatures from the list of extensions

DavidSpickett updated this revision to Diff 421910. DavidSpickett added a comment. Fix a spelling mistake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123296/new/ https://reviews.llvm.org/D123296 Files: clang/test/Preprocessor/aarch64-target-f

[clang] 55b6a31 - [llvm][AArch64] Generate getExtensionFeatures from the list of extensions

Author: David Spickett Date: 2022-04-11T13:42:24Z New Revision: 55b6a3186cfa8b85a1defe05861d73f447e4c990 URL: https://github.com/llvm/llvm-project/commit/55b6a3186cfa8b85a1defe05861d73f447e4c990 DIFF: https://github.com/llvm/llvm-project/commit/55b6a3186cfa8b85a1defe05861d73f447e4c990.diff LOG

[PATCH] D123296: [llvm][AArch64] Generate getExtensionFeatures from the list of extensions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG55b6a3186cfa: [llvm][AArch64] Generate getExtensionFeatures from the list of extensions (authored by DavidSpickett). Repository: rG LLVM Github Mo

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Type.h:6535 + const auto *F = Self.getAs(); + return F == nullptr || + (F->getMethodQuals().empty() && F->getRefQualifier() == RQ_None); You can turn this into an assert that `F` i

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

jsji added a comment. @qiongsiwu1 Please also add reviewers from other targets. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D123498 ___ cfe-commits mailing

[clang] 918c5a9 - [Clang] Avoid legacy PM in some tests (NFC)

Author: Nikita Popov Date: 2022-04-11T16:15:57+02:00 New Revision: 918c5a926090214bc6843854afb4750673b4c3ae URL: https://github.com/llvm/llvm-project/commit/918c5a926090214bc6843854afb4750673b4c3ae DIFF: https://github.com/llvm/llvm-project/commit/918c5a926090214bc6843854afb4750673b4c3ae.diff

[PATCH] D123405: [dllexport] odr-use constexpr default args for constructor closures

hans added a comment. I think @thakis's review is sufficient. I am of course happy to follow up on any extra review with follow-up patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123405/new/ https://reviews.llvm.org/D123405 ___

[clang] 40ad667 - [dllexport] odr-use constexpr default args for constructor closures

Author: Hans Wennborg Date: 2022-04-11T16:23:01+02:00 New Revision: 40ad6670138ab8130a426432b0e94544b5e03642 URL: https://github.com/llvm/llvm-project/commit/40ad6670138ab8130a426432b0e94544b5e03642 DIFF: https://github.com/llvm/llvm-project/commit/40ad6670138ab8130a426432b0e94544b5e03642.diff

[PATCH] D123405: [dllexport] odr-use constexpr default args for constructor closures

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40ad6670138a: [dllexport] odr-use constexpr default args for constructor closures (authored by hans). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D123447: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you for the fix! Can you add a release note for it as well? LGTM aside from a minor nit with some comment wording and a testing suggestion. Comment at: c

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Config.h:105 + +/// IncludeCleaner will not diagnose usages of these headers matched by +/// these regexes. Config is supposed to be cheap to create. The regex should be created during

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

joerg added a comment. The patch contains at least one user visible change that would be quite surprising: it is no longer possible to intentionally set a break point on `std::move`. Thinking more about it, what about a slightly different implementation strategy? Provide a compiler built-in `_

[PATCH] D123422: [AST] Cleanup on getting the underlying decl of using-shdow decl.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This looks OK, though I'm not sure the value of encoding this assumption further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123422/new

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme updated this revision to Diff 421930. mboehme marked 2 inline comments as done. mboehme added a comment. Various changes in response to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111548/new/ https://reviews.llvm.org/D111

[PATCH] D121915: [RISCV] CLZ Instruction

joker881 updated this revision to Diff 421931. joker881 added a comment. Herald added subscribers: sunshaoce, StephenFan. [RISCV]CLZ instruction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121915/new/ https://reviews.llvm.org/D121915 Files: cl

[PATCH] D122069: [Object] Add binary format for bundling offloading metadata

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122069/new/ https://reviews.llvm.org/D122069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

dang updated this revision to Diff 421932. dang added a comment. Address code review feedback. Introduce `has_function_signature` type trait to distinguish records that have a function signatures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12330

[PATCH] D121375: [clang] NFC, move the utility function CompilerInvocation::setLangDefaults to LangOptions.h

sammccall accepted this revision. sammccall added inline comments. Comment at: clang/include/clang/Basic/LangStandard.h:141 static Kind getLangKind(StringRef Name); + static Kind getLangKind(clang::Language Lang, const llvm::Triple &T); + this makes it sound

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

dang added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:495 +if (const auto *Method = dyn_cast(Member.get())) + serializeObject(*MemberRecord, "functionSignature", zixuw wrote: > I'd prefer not to use `dyn_c

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme marked 4 inline comments as done. mboehme added a comment. In D111548#3439039 , @aaron.ballman wrote: > Also, you should add a release note about the new attribute Done. and check the Precommit CI pipeline failure out: > Failed Tests (1): > >

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

ldionne added a comment. I actually think that `[[no_unique_address]]` and `__attribute__((no_unique_address))` should be equivalent. Similarly, we should be able to do `[[msvc::no_unique_address]]` and `__attribute__((msvc::no_unique_address))`, and both should be equivalent. Which one we pic

[clang-tools-extra] 001e88a - [clangd] Performance improvements and cleanup

Author: Kadir Cetinkaya Date: 2022-04-11T17:15:25+02:00 New Revision: 001e88ac83b5c3a4d4f4e61480953ebcabc82b88 URL: https://github.com/llvm/llvm-project/commit/001e88ac83b5c3a4d4f4e61480953ebcabc82b88 DIFF: https://github.com/llvm/llvm-project/commit/001e88ac83b5c3a4d4f4e61480953ebcabc82b88.dif

[PATCH] D122215: [WebAssembly] Initial support for reference types in clang

pmatos updated this revision to Diff 421936. pmatos added a comment. Herald added subscribers: asavonic, jholewinski. Moved the attribute handling to the border between clang and llvm. In the frontend, there's no special handling of address spaces for funcref, but this is added when converting the

[PATCH] D122215: [WebAssembly] Initial support for reference types in clang

pmatos planned changes to this revision. pmatos added a comment. This still requires some changes, as there are a few unhandled cases where funcref attribute is not handled properly at the edge. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 421939. cor3ntin added a comment. Add a test for `\o' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clan

[PATCH] D122931: [CMake][compiler-rt] Support for using in-tree libc++

ldionne added a comment. I like this, however IMO it would be better to instead have something like COMPILER_RT_CXX_LIBRARY="libc++|system-libc++|libstdc++|..." That way, this can be extended to support other C++ libraries without having to add new boolean options, and without forcing folks t

[PATCH] D123479: [clang-tidy] Support parenthesized literals in modernize-macro-to-enum

LegalizeAdulthood added a comment. In D123479#3442062 , @njames93 wrote: > Would it not be better if these parens were stripped in the fixit as they are > unnecessary in the enum value decl? I prefer checks to do one thing only in a straightforward mann

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

aaron.ballman added reviewers: aaron.ballman, tahonermann, clang-language-wg. aaron.ballman added subscribers: tstellar, lattner. aaron.ballman added a comment. Thank you for this functionality! I did a pretty quick pass over it and have some comments. Comment at: clang/includ

Re: [PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

On Mon, Apr 11, 2022 at 10:50 AM Joerg Sonnenberger via Phabricator wrote: > > joerg added a comment. > > The patch contains at least one user visible change that would be quite > surprising: it is no longer possible to intentionally set a break point on > `std::move`. Thank you, that is a real

[PATCH] D121915: [RISCV] CLZ Instruction

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18910 +case RISCV::BI__builtin_riscv_clz_32: +case RISCV::BI__builtin_riscv_clz_64:{ + Function *F = CGM.getIntrinsic(Intrinsic::ctlz, Ops[0]->getType()); Add a space bef

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

lattner added a comment. Yeah, we should discuss this, thanks for raising this Aaron. I'm not sure exactly what is being pulled in: @cor3ntin can you please email a summary of the situation to bo...@llvm.org and we'll discuss it and run it by Heather as needed? Thanks -Chris Repository:

[PATCH] D107636: [analyzer][solver] Compute adjustment for unsupported symbols as well

ASDenysPetrov added a comment. Herald added a project: All. I checked the tests file on the latest sources. It passes even without your changes. Maybe this patch is already outdated. Comment at: clang/lib/StaticAnalyzer/Core/RangedConstraintManager.cpp:82-86 if (IsExpec

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

tlively added a comment. No concerns about the WebAssembly changes. Will the default installation for folks who don't touch `LLVM_DISTRIBUTION_COMPONENTS` change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D

[PATCH] D122243: [analyzer][NFC] Introduce the checker package separator character

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122243/new/ https://reviews.llvm.org/D122243 ___ cfe-commits mailing list cfe-commi

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:495 +if (const auto *Method = dyn_cast(Member.get())) + serializeObject(*MemberRecord, "functionSignature", dang wrote: > zixuw wrote: > > I'd prefer

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added a comment. In D123498#3443108 , @tlively wrote: > No concerns about the WebAssembly changes. Will the default installation for > folks who don't touch `LLVM_DISTRIBUTION_COMPONENTS` change? Thanks Thomas! No, the default installations t

[PATCH] D121375: [clang] NFC, move the utility function CompilerInvocation::setLangDefaults to LangOptions.h

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM once @sammccall 's new comments are addressed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121375/new/ https://reviews.llvm.org/D

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 421956. cor3ntin marked 17 inline comments as done. cor3ntin added a comment. Address Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064 Files: clang

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 421958. cor3ntin added a comment. Cleanup generated code header comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064 Files: clang/include/clang/Basic/Diagnostic

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

dang marked an inline comment as done. dang added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:495 +if (const auto *Method = dyn_cast(Member.get())) + serializeObject(*MemberRecord, "functionSignature", zixu

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. this LGTM from a systemz perspective! thanks for refactoring Comment at: clang/lib/Headers/CMakeLists.txt:173 __wmmintrin_pclmul.h x86

[PATCH] D123468: [Driver] Simplify hasFlag pattern with addOptInFlag/addOptOutFlag helpers

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Nice! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123468/new/ https://reviews.llvm.org/D123468

[PATCH] D123398: [VFS] RedirectingFileSystem only replace path if not already mapped

dexonsmith added a comment. In D123398#3439946 , @bnbarham wrote: > Does `clang/test/VFS/external-names-multi-overlay.c` need to be formatted or > is it fine? It uses split-file so I'd really like to avoid the format here > (makes it pretty silly). See

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123304/new/ https://reviews.llvm.org/D123304 ___

[PATCH] D123398: [VFS] RedirectingFileSystem only replace path if not already mapped

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123398/new/ https://reviews.llvm.org/D123398 __

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:238 + diag::err_delimited_escape_missing_brace) +<< std::string(1, 'o'); aaron.ballman wrote: > Can you use `"o"` instead of constructing a `std::string` for it

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

aaron.ballman added inline comments. Comment at: llvm/include/llvm/ADT/StringExtras.h:329 +std::string to_hexString(uint64_t Value, bool UpperCase = true); + cor3ntin wrote: > aaron.ballman wrote: > > `utohexstr()` already exists on line 152 -- any reason we ca

[PATCH] D123526: [clang][ExtractAPI][NFC] Fix sed delimiter in test

zixuw created this revision. Herald added a reviewer: dang. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix path replacement in sed (properly this time) using lit regex_replacement. Repository: rG

[clang] 236b6a0 - [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

Author: Daniel Grumberg Date: 2022-04-11T19:05:24+01:00 New Revision: 236b6a0eb41a163510e65664e2160f599287326b URL: https://github.com/llvm/llvm-project/commit/236b6a0eb41a163510e65664e2160f599287326b DIFF: https://github.com/llvm/llvm-project/commit/236b6a0eb41a163510e65664e2160f599287326b.dif

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dang marked an inline comment as done. Closed by commit rG236b6a0eb41a: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods. (authored by dang). Repo

[PATCH] D123479: [clang-tidy] Support parenthesized literals in modernize-macro-to-enum

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D123479#3442968 , @LegalizeAdulthood wrote: > In D123479#3442062 , @njames93 > wrote: > >>

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

dexonsmith added a comment. In D123104#3439261 , @bnbarham wrote: > Looks like there's more changes required for modulemap-collision.m to > actually pass. I'll try figure those out when I have the time. Capturing `clang -check` error since the build log

[PATCH] D123479: [clang-tidy] Support parenthesized literals in modernize-macro-to-enum

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added a comment. In D123479#3443401 , @aaron.ballman wrote: > In D123479#3442968 , > @LegalizeAdulthood wrote: > >> In D123479#3442062

[PATCH] D123479: [clang-tidy] Support parenthesized literals in modernize-macro-to-enum

LegalizeAdulthood updated this revision to Diff 421990. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123479/new/ https://reviews.llvm.org/D123479 Files: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp clang

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

dexonsmith added subscribers: jansvoboda11, vsapsai, Bigcheese. dexonsmith added a comment. In D123104#3443448 , @dexonsmith wrote: > I wonder if > https://github.com/apple/llvm-project/commit/67c70038bcc0d771e2e39c875ad7d69e329c7fc4 > could be related

[PATCH] D123479: [clang-tidy] Support parenthesized literals in modernize-macro-to-enum

LegalizeAdulthood updated this revision to Diff 421991. LegalizeAdulthood added a comment. - Update documentation to reflect multiple pairs of matching parens CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123479/new/ https://reviews.llvm.org/D123479 Files: clang-tools-extra/clang-tid

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Anonymous enums without a typedef should have a "(anonymous)" identifier.

[PATCH] D122673: Add kcfi_unchecked attribute

aaron.ballman added a comment. In D122673#3414650 , @samitolvanen wrote: > Note that this was split from D119296 . > > In the previous discussion, @joaomoreira pointed out that this is very > similar to `nocf_check` an

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim created this revision. hctim added reviewers: echristo, cmtice. Herald added a project: All. hctim requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An upcoming patch will extend llvm-symbolizer to provide the source line information fo

  1   2   >