LegalizeAdulthood added a comment.

In D123479#3442062 <https://reviews.llvm.org/D123479#3442062>, @njames93 wrote:

> Would it not be better if these parens were stripped in the fixit as they are 
> unnecessary in the enum value decl?

I prefer checks to do one thing only in a straightforward manner.

It's easier to place things before and after the macro expansion rather than 
modify the contents
of the expansion.

It doesn't feel like the responsibility of this check is to decide which 
parentheses are necessary or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123479/new/

https://reviews.llvm.org/D123479

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to