kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

Oopsy :/ Thanks for the fix!

Regarding the test, if you came looking for this piece due to a particular 
issue, it might be nice to have that included in the test suite (assuming it 
can be minimized).
If not, I think it would still be valuable to include a simple unittest that 
just tests `operator<` by creating `HighlightingTokens` to make sure we don't 
make similar mistakes in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123478/new/

https://reviews.llvm.org/D123478

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to