[PATCH] D123447: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling

junaire updated this revision to Diff 421696. junaire added a comment. Update the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123447/new/ https://reviews.llvm.org/D123447 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseD

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers updated this revision to Diff 421706. vabridgers added a comment. update per @steakhal's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/D122841 Files: clang/docs/analyzer/checkers.rst cla

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers marked 3 inline comments as done. vabridgers added a comment. I believe all points have been addressed. Thanks for the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/D122841

[PATCH] D123436: [Clang] Pass llvm::BitstreamCursor by reference. NFC

RKSimon added inline comments. Comment at: clang/lib/Serialization/GlobalModuleIndex.cpp:130 std::unique_ptr IndexBuffer, -llvm::BitstreamCursor Cursor) +llvm::BitstreamCursor &Cursor) : Buffer(std::move(IndexBuffer)), IdentifierIndex(), NumIdentifierLookups(),

[clang] e4903d8 - [CUDA/HIP] Remove argument from module ctor/dtor signatures

Author: Jonas Hahnfeld Date: 2022-04-09T12:34:41+02:00 New Revision: e4903d8be399864cc978236fc4a28087f91c20fe URL: https://github.com/llvm/llvm-project/commit/e4903d8be399864cc978236fc4a28087f91c20fe DIFF: https://github.com/llvm/llvm-project/commit/e4903d8be399864cc978236fc4a28087f91c20fe.diff

[PATCH] D123370: [CUDA/HIP] Remove argument from module ctor/dtor signatures

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4903d8be399: [CUDA/HIP] Remove argument from module ctor/dtor signatures (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123370/new/

[PATCH] D123450: [clang-format] Parse Verilog if statements

sstwcw created this revision. sstwcw added reviewers: MyDeveloperDay, HazardyKnusperkeks, curdeius, owenpan. Herald added a subscriber: mgorny. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch m

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. No major issues left. Comment at: clang/lib/StaticAnalyzer/Checkers/DereferenceChecker.cpp:331 + auto *Chk = mgr.registerChecker(); + // auto *Chk = mgr.getChecker(); +

[PATCH] D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst.

sstwcw added a comment. It looks like you forgot to chmod +x. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121916/new/ https://reviews.llvm.org/D121916 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D123450: [clang-format] Parse Verilog if statements

sstwcw added inline comments. Comment at: clang/lib/Format/FormatToken.h:1157 +VerilogExtraKeywords = std::unordered_set( +{kw_always, kw_always_comb, kw_always_ff,kw_always_latch, + kw_assert, kw_assign, kw_assume, kw_automatic, -

[PATCH] D123452: [Clang] Override method ModuleImportRead in MultiplexASTDeserializationListener

lgxbslgx created this revision. Herald added a project: All. lgxbslgx requested review of this revision. Herald added a project: clang. Fixes https://github.com/llvm/llvm-project/issues/54521 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D123452 Files: clang/include/clang/Fr

[PATCH] D123436: [Clang] Pass llvm::BitstreamCursor by reference. NFC

junaire added inline comments. Comment at: clang/lib/Serialization/GlobalModuleIndex.cpp:130 std::unique_ptr IndexBuffer, -llvm::BitstreamCursor Cursor) +llvm::BitstreamCursor &Cursor) : Buffer(std::move(IndexBuffer)), IdentifierIndex(), NumIdentifierLookups(),

[PATCH] D123447: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling

junaire updated this revision to Diff 421719. junaire added a comment. Rename an argument for consistency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123447/new/ https://reviews.llvm.org/D123447 Files: clang/include/clang/Parse/Parser.h cla

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 421721. cor3ntin added a comment. - Add tests - Cleanups - Optimization of nearestMatchesForCodepointName to only allocate when necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://rev

[PATCH] D121556: [randstruct] Add randomize structure layout support

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4244 + if (const Arg *A = Args.getLastArg(OPT_frandomize_layout_seed_file_EQ)) { +std::ifstream SeedFile(A->getValue(0)); MaskRay wrote: > void wrote: > > MaskRay wr

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 421723. cor3ntin added a comment. Fix in nameToCodepointLoose Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064 Files: clang/include/clang/Basic/DiagnosticLexKinds.t

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

aaron.ballman added a comment. Thank you for this, it's a great improvement! I think it's generally correct, but I did have some minor questions. > Most of these improvements are very small, but I measured a 3% decrease in > -O0 object file size for a simple C++ source file using the standard l

[PATCH] D123353: [CUDA][HIP] Externalize kernels in anonymous name space

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/test/CodeGenCUDA/kernel-in-anon-ns.cu:13 + +// CHECK: define weak_odr {{.*}}void @[[KERN:_ZN12_GLOBAL__N_16kernelEv\.anon\..*]]( +// CHECK: @[[STR:.*]] = {{.*}} c"[[KERN]]\00" --

[clang] f67e3f6 - [clang-format] Add execute permission to dump_format_help.py

Author: owenca Date: 2022-04-09T07:58:33-07:00 New Revision: f67e3f6e8c566928c88262df5664ac6e679753d2 URL: https://github.com/llvm/llvm-project/commit/f67e3f6e8c566928c88262df5664ac6e679753d2 DIFF: https://github.com/llvm/llvm-project/commit/f67e3f6e8c566928c88262df5664ac6e679753d2.diff LOG: [

[PATCH] D123456: [C89/C2x] Diagnose calls to a function without a prototype but passes arguments

aaron.ballman created this revision. aaron.ballman added reviewers: jyknight, hubert.reinterpretcast, delcypher, erichkeane, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. This catches places where a function without

[PATCH] D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst.

owenpan added a comment. In D121916#3440831 , @sstwcw wrote: > It looks like you forgot to chmod +x. Added in f67e3f6 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D123456: [C89/C2x] Diagnose calls to a function without a prototype but passes arguments

cor3ntin accepted this revision as: cor3ntin. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM except a couple of nitpicks Comment at: clang/lib/Sema/SemaExpr.cpp:7052 +// the call, diagnose this as calling a function without a prototype. +

[PATCH] D123456: [C89/C2x] Diagnose calls to a function without a prototype but passes arguments

aaron.ballman updated this revision to Diff 421738. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updated based on review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123456/new/ https://reviews.llvm.org/D123456 Files: clang/docs/ReleaseNot

[PATCH] D123456: [C89/C2x] Diagnose calls to a function without a prototype but passes arguments

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7052 +// the call, diagnose this as calling a function without a prototype. +// However, if we found a function declaration, check to see if the strict +// uses without a prototype warning wa

[PATCH] D123456: [C89/C2x] Diagnose calls to a function without a prototype but passes arguments

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7052 +// the call, diagnose this as calling a function without a prototype. +// However, if we found a function declaration, check to see if the strict +// uses without a prototype warning was dis

[libunwind] 958251e - Add some prototypes to fix -Wstrict-prototypes. NFC

Author: Fangrui Song Date: 2022-04-09T09:46:39-07:00 New Revision: 958251ef76db60dba6f0bb48c50a7cc9b9e9c4f1 URL: https://github.com/llvm/llvm-project/commit/958251ef76db60dba6f0bb48c50a7cc9b9e9c4f1 DIFF: https://github.com/llvm/llvm-project/commit/958251ef76db60dba6f0bb48c50a7cc9b9e9c4f1.diff

[PATCH] D121556: [randstruct] Add randomize structure layout support

MaskRay added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4244 + if (const Arg *A = Args.getLastArg(OPT_frandomize_layout_seed_file_EQ)) { +std::ifstream SeedFile(A->getValue(0)); aaron.ballman wrote: > MaskRay wrote: > > void wr

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

rjmccall added a comment. I'm totally fine with a specifier that removes all qualifiers; I just think we can't use it for `std::remove_cv`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116203/new/ https://reviews.llvm.org/D116203 ___

[clang] 7aa8c38 - [randstruct] Add randomize structure layout support

Author: Connor Kuehl Date: 2022-04-09T13:15:36-07:00 New Revision: 7aa8c38a9e190aea14116028c38b1d9f54cbb0b3 URL: https://github.com/llvm/llvm-project/commit/7aa8c38a9e190aea14116028c38b1d9f54cbb0b3 DIFF: https://github.com/llvm/llvm-project/commit/7aa8c38a9e190aea14116028c38b1d9f54cbb0b3.diff

[PATCH] D121556: [randstruct] Add randomize structure layout support

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7aa8c38a9e19: [randstruct] Add randomize structure layout support (authored by connorkuehl, committed by void). Repositor

[clang] 77e71bc - [randstruct] NFC change to use static

Author: Bill Wendling Date: 2022-04-09T13:25:25-07:00 New Revision: 77e71bcfde7264466849babaa0e9ccbec51a8a08 URL: https://github.com/llvm/llvm-project/commit/77e71bcfde7264466849babaa0e9ccbec51a8a08 DIFF: https://github.com/llvm/llvm-project/commit/77e71bcfde7264466849babaa0e9ccbec51a8a08.diff

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers planned changes to this revision. vabridgers added a comment. Thanks for the the comments. I'll make the changes and resubmit. Please let me know your preferences for the test case (default vs pinned x86 or same). Best! Comment at: clang/lib/StaticAnalyzer/Checkers

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser updated this revision to Diff 421758. clemenswasser added a comment. Hi, today I found some more time to play/progress with this patch. I'm generally optimistic that most of the basic lsan stuff should already be working on Windows. However without some help of you, I'm unable to g

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers updated this revision to Diff 421759. vabridgers added a comment. This revision is now accepted and ready to land. update per @steakhal's latest comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers marked 3 inline comments as done. vabridgers added a comment. The two small issues are addressed, I think the only outstanding issue is the question about the test case. Please let me know a preference and I'll implement accordingly. Best! Repository: rG LLVM Github Monorepo CHAN

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

joerg added a comment. As is, I think this conflicts with `-ffreestanding` assumptions or at the very least the spirit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123345/new/ https://reviews.llvm.org/D123345 ___

[PATCH] D123460: [OpenMP] Make generating offloading entries more generic

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ABataev. Herald added subscribers: guansong, hiraditya, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1.

[PATCH] D123460: [OpenMP] Make generating offloading entries more generic

jhuber6 updated this revision to Diff 421764. jhuber6 added a comment. clang format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123460/new/ https://reviews.llvm.org/D123460 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOp

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 421768. cor3ntin added a comment. Add missing header in generated code to fix windows CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064 Files: clang/include/clan