RKSimon added inline comments.
================ Comment at: clang/lib/Serialization/GlobalModuleIndex.cpp:130 std::unique_ptr<llvm::MemoryBuffer> IndexBuffer, - llvm::BitstreamCursor Cursor) + llvm::BitstreamCursor &Cursor) : Buffer(std::move(IndexBuffer)), IdentifierIndex(), NumIdentifierLookups(), ---------------- You're not passing this as a const, so the calling function's Cursor will be updated - this doesn't sound generally safe to me - what about a move? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123436/new/ https://reviews.llvm.org/D123436 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits