aaron.ballman added inline comments.
================ Comment at: clang/lib/Sema/SemaExpr.cpp:7052 + // the call, diagnose this as calling a function without a prototype. + // However, if we found a function declaration, check to see if the strict + // uses without a prototype warning was disabled where the function was ---------------- cor3ntin wrote: > I have a hard time parsing this sentence. I suspect words or punctuation are > missing I reworded to mention the warning group specifically; that hopefully clears up the confusion. ================ Comment at: clang/lib/Sema/SemaExpr.cpp:7065 + Diag(LParenLoc, diag::warn_strict_uses_without_prototype) + << (bool)FDecl << FDecl; + ---------------- cor3ntin wrote: > `!= nullptr` may be cleaner Sure! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123456/new/ https://reviews.llvm.org/D123456 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
