[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

steakhal added a comment. In D102669#3395364 , @OikawaKirie wrote: > IMO, maybe we can just leave a FIXME or something else in the test case and > commit this patch to fix the original problem we want to fix. > (of course, re-submit to rerun the test ca

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

dmgreen added a reviewer: simon_tatham. dmgreen added a comment. > I'm very out of my depth with tablegen, let me know if there's a more elegant > way of doing this I think this sounds OK. Providing all the tests pass it looks OK (but I'm not a big expert myself) Repository: rG LLVM Github

[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

cor3ntin updated this revision to Diff 416835. cor3ntin marked 11 inline comments as done. cor3ntin added a comment. Tidy up the tests again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/

[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

cor3ntin updated this revision to Diff 416838. cor3ntin added a comment. Add ifdef around tests that should not run in c++20 mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/docs/Releas

[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

cor3ntin updated this revision to Diff 416839. cor3ntin added a comment. Switch variable names (non_literal_ko/non_literal_ok) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/docs/ReleaseNo

[PATCH] D122075: [clang-tidy] Skip parentheses in `readability-make-member-function-const`

mgehre-amd added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122075/new/ https://reviews.llvm.org/D122075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D118837: Methods visited for a special class must have an identifier.

Fznamznon added a comment. Herald added a project: All. Was this one submitted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118837/new/ https://reviews.llvm.org/D118837 ___ cfe-commits mailing list cfe

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FS.h:71 +/// Used for tracking time spent in FS operations. Like llvm::Timer, but only +/// tracks wall time, which is much cheaper. adamcz wrote: > kadircet wrote: > > kadircet wrote: > > > I

[PATCH] D121095: [C++20][Modules][HU 1/5] Introduce header units as a module type.

iains updated this revision to Diff 416841. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121095/new/ https://reviews.llvm.org/D121095 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Basic/La

[PATCH] D121096: [C++20][Modules][HU 2/5] Support searching Header Units in user or system search paths.

iains updated this revision to Diff 416842. iains added a comment. rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121096/new/ https://reviews.llvm.org/D121096 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clan

[PATCH] D121097: [C++20][Modules][HU 3/5] Emit module macros for header units.

iains updated this revision to Diff 416845. iains added a comment. rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121097/new/ https://reviews.llvm.org/D121097 Files: clang/include/clang/Basic/Module.h clang/include/clang/Serialization/

[PATCH] D121286: [clangd] Handle case insensitive file systems in header/source switch

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121286/new/ https://reviews.llvm.org/D121286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

jansvoboda11 updated this revision to Diff 416846. jansvoboda11 added a comment. Introduce `-driver-only` to avoid running `-cc1`s. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121997/new/ https://reviews.llvm.org/D121997 Files: clang/include/c

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

iains updated this revision to Diff 416847. iains added a comment. rebased, added test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121098/new/ https://reviews.llvm.org/D121098 Files: clang/lib/Frontend/FrontendAction.cpp clang/lib/Sema/Sema

[PATCH] D121099: [C++20][Modules][HU 5/5] Add fdirectives-only mode for preprocessing output.

iains updated this revision to Diff 416850. iains added a comment. rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121099/new/ https://reviews.llvm.org/D121099 Files: clang/include/clang/Driver/Options.td clang/include/clang/Frontend/Pr

[PATCH] D121588: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

iains updated this revision to Diff 416853. iains added a comment. rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121588/new/ https://reviews.llvm.org/D121588 Files: clang/include/clang/Driver/Types.def clang/lib/Driver/Driver.cpp cl

[PATCH] D121589: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=

iains updated this revision to Diff 416854. iains added a comment. rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121589/new/ https://reviews.llvm.org/D121589 Files: clang/include/clang/Driver/Driver.h clang/include/clang/Driver/Option

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

krasimir added a comment. This appears to have broken a relatively common pattern we see in text proto comments where sections use a style like this: # Big section name ##

[PATCH] D121590: [C++20][Modules][Driver][HU 3/N] Handle foo.h with -fmodule-header and/or C++ invocation.

iains updated this revision to Diff 416855. iains added a comment. rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121590/new/ https://reviews.llvm.org/D121590 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/cxx20-header-units-02.c

[PATCH] D121591: [C++20][Modules][Driver][HU 4/N] Add fdirectives-only mode for preprocessing output.

iains updated this revision to Diff 416856. iains added a comment. rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121591/new/ https://reviews.llvm.org/D121591 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/Clang.cpp c

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

curdeius added a comment. In D121451#3395578 , @krasimir wrote: > This appears to have broken a relatively common pattern we see in text proto > comments where sections use a style like this: > > > #

[PATCH] D122075: [clang-tidy] Skip parentheses in `readability-make-member-function-const`

njames93 accepted this revision. njames93 added a comment. Mostly LGTM, just a few nits Comment at: clang-tools-extra/clang-tidy/readability/MakeMemberFunctionConstCheck.cpp:69 + const Stmt *getParentStmt(const Expr *E) { return getParent(E); } + This chang

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

krasimir added a comment. In D121451#3395611 , @curdeius wrote: > In D121451#3395578 , @krasimir > wrote: > >> This appears to have broken a relatively common pattern we see in text proto >> comments where secti

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie updated this revision to Diff 416861. OikawaKirie edited the summary of this revision. OikawaKirie added a comment. - Add FIXME in test case. - Add discourse topic link in summary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102669/new/ https://reviews.llvm.org/D102669 Fi

[clang] 9dad527 - [clang-format] Use range-for loop with drop_end. NFC.

Author: Marek Kurdej Date: 2022-03-21T10:05:06+01:00 New Revision: 9dad527fc048e9f6df6783abb1d6251e77f12199 URL: https://github.com/llvm/llvm-project/commit/9dad527fc048e9f6df6783abb1d6251e77f12199 DIFF: https://github.com/llvm/llvm-project/commit/9dad527fc048e9f6df6783abb1d6251e77f12199.diff

[PATCH] D121707: [llvm][AArch64] Insert "bti j" after call to setjmp

danielkiss accepted this revision. danielkiss added a comment. This revision is now accepted and ready to land. Add to the commit message `Fixes #4` to make the connection on github. LGTM Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:480-481 +

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

iains created this revision. Herald added a project: All. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains added a subscriber: clang-modules. iains published this revision for review. iains added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. this covers

[clang] 73a15ad - [clang-format] [doc] Improve BraceWrapping documentation.

Author: Marek Kurdej Date: 2022-03-21T10:25:12+01:00 New Revision: 73a15ad567071c13e761fd6d593e2b66164865e2 URL: https://github.com/llvm/llvm-project/commit/73a15ad567071c13e761fd6d593e2b66164865e2 DIFF: https://github.com/llvm/llvm-project/commit/73a15ad567071c13e761fd6d593e2b66164865e2.diff

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. Whereas I'm familiar with this code but not with the opaque-pointers effort, so I had to look up the //other// half of what was going on :-) If I've understood this correctly, the

[PATCH] D122121: [clang][dataflow] Add action caching support to MatchSwitch

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. Enable default caching of actionsin `MatchSwitch` so t

[PATCH] D122075: [clang-tidy] Skip parentheses in `readability-make-member-function-const`

Izaron updated this revision to Diff 416870. Izaron added a comment. Fixed as suggested by njames93. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122075/new/ https://reviews.llvm.org/D122075 Files: clang-tools-extra/clang-tidy/readab

[PATCH] D113874: [clang] Propagate requires-clause from constructor template to implicit deduction guide

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Fantastic, thank you! Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:794 +TEST(DiagnosticsTest, ConstrainedImplicitDeductionGuides) { + Annotati

[PATCH] D122124: [C++20][Modules] Add testcases from section 10.2 dependent on header units.

iains created this revision. Herald added a project: All. iains added a reviewer: ChuanqiXu. iains published this revision for review. iains added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. there might be more cases to add here, from later sections in the sta

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk updated this revision to Diff 416876. kwk marked an inline comment as done. kwk added a comment. - Address review comments on grouping and main headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

krasimir added a comment. This is getting more fun: the reason why `///` isn't broken up is because the first character `/` after the comment leader `//` is considered punctuation per isPunctuation's CHAR_RAWDEL, which includes all these `{}[]#<>%:;?*+-/^&|~!=,"'`: - https://github.com/llvm/l

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk updated this revision to Diff 416877. kwk added a comment. - Fix: int -> bool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 Files: clang/lib/Format/Format.cpp clang/lib/Tooling/Inclusions/Header

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk added a comment. In D121370#3387175 , @HazardyKnusperkeks wrote: > In D121370#3383574 , > @HazardyKnusperkeks wrote: > >> Some test with a main header and blocks would be nice. > > This one please. :) Done.

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk added a comment. In the current state, some tests in `SortIncludesTest.SupportAtImportLines` are failing. This is strange, because I've tested it with this `.clang-format` file: BasedOnStyle: LLVM IncludeBlocks: Regroup NOTE: for each test I've change the `Regroup` to `Preserve` resp

[PATCH] D121286: [clangd] Handle case insensitive file systems in header/source switch

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/support/Path.h:50 +/// If \p Prefix doesn't match, leaves \p Path untouched and returns false. +bool pathConsumeFront(PathRef &

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk updated this revision to Diff 416878. kwk added a comment. - Fix test but unsure if correct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 Files: clang/lib/Format/Format.cpp clang/lib/Tooling/Inc

[PATCH] D121707: [llvm][AArch64] Insert "bti j" after call to setjmp

DavidSpickett updated this revision to Diff 416885. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121707/new/ https://reviews.llvm.org/D121707 Files: clang/docs/ClangCommandLineReference.rst clang/docs/Rel

[clang] b6f85d8 - [CodeGen][OpenMP] Use correct type in EmitLoadOfPointer()

Author: Nikita Popov Date: 2022-03-21T12:08:05+01:00 New Revision: b6f85d8539455d82870bc275ef0de9a7973ccb17 URL: https://github.com/llvm/llvm-project/commit/b6f85d8539455d82870bc275ef0de9a7973ccb17 DIFF: https://github.com/llvm/llvm-project/commit/b6f85d8539455d82870bc275ef0de9a7973ccb17.diff

[PATCH] D121829: [clang][AArc64][SVE] Implement vector-scalar operators

DavidTruby updated this revision to Diff 416889. DavidTruby added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121829/new/ https://reviews.llvm.org/D121829 Files: clang/include/clang/Sema/Sema.h clang/lib/CodeGen/CGExprScala

[clang-tools-extra] fc354d3 - [clang-tidy] Skip parentheses in `readability-make-member-function-const`

Author: Evgeny Shulgin Date: 2022-03-21T14:18:17+03:00 New Revision: fc354d375232c22bbc13b80e4e339d8925ae2c70 URL: https://github.com/llvm/llvm-project/commit/fc354d375232c22bbc13b80e4e339d8925ae2c70 DIFF: https://github.com/llvm/llvm-project/commit/fc354d375232c22bbc13b80e4e339d8925ae2c70.diff

[PATCH] D122075: [clang-tidy] Skip parentheses in `readability-make-member-function-const`

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc354d375232: [clang-tidy] Skip parentheses in `readability-make-member-function-const` (authored by Izaron). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

MyDeveloperDay added a comment. > But we can: https://gcc.godbolt.org/z/8Mb1xo7oP This is what I love about you all, you push me to learn more about C++, its a slippery br Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121754/new/ https://rev

[clang] afbe54f - [clang] Fix wrong -Wunused-local-typedef warning within a template function

Author: Kristina Bessonova Date: 2022-03-21T13:21:25+02:00 New Revision: afbe54f2feb0ed3a4d4c03c6107fcdffd21a8394 URL: https://github.com/llvm/llvm-project/commit/afbe54f2feb0ed3a4d4c03c6107fcdffd21a8394 DIFF: https://github.com/llvm/llvm-project/commit/afbe54f2feb0ed3a4d4c03c6107fcdffd21a8394.

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

This revision was automatically updated to reflect the committed changes. Closed by commit rGafbe54f2feb0: [clang] Fix wrong -Wunused-local-typedef warning within a template function (authored by krisb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

pcwang-thead added a comment. In D70401#3395340 , @kito-cheng wrote: > Last LLVM sync-up call @asb has raise the discussion about the ILP32E issue, > so here is note from my site: > > RISC-V psABI doc still say "we don't guarantee the stability of `ILP32

[PATCH] D121584: [clang-format] Correctly recognize arrays in template parameter list.

krasimir added a comment. It appears that this regressed some ObjC patterns: % cat test.m # before: good void f() { // BOOL a = [b.c count] > 1; int b = a; } % clang-format -style=google test.m # after: bad, statements joined on the same line void f() { // BOOL a

[PATCH] D118837: Methods visited for a special class must have an identifier.

zahiraam added a comment. In D118837#3395529 , @Fznamznon wrote: > Was this one submitted? Yes it was. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118837/new/ https://reviews.llvm.org/D118837 _

[PATCH] D121584: [clang-format] Correctly recognize arrays in template parameter list.

curdeius added a comment. In D121584#3395937 , @krasimir wrote: > It appears that this regressed some ObjC patterns: > > % cat test.m # before: good > void f() { > // > BOOL a = [b.c count] > 1; > int b = a; > } > % clang-format -styl

[PATCH] D122129: [clang][dataflow] Model the behavior of optional and std swap

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D122121: [clang][dataflow] Add action caching support to MatchSwitch

ymandel added a comment. What is the motivation for stashing the results of a match on a statement? Do we expect to encounter the same statement often? I thought the concern was more specific to re-matching particular types, like `std::optional`. For that, we could lazily store the declaration

[PATCH] D122121: [clang][dataflow] Add action caching support to MatchSwitch

sgatev updated this revision to Diff 416906. sgatev added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122121/new/ https://reviews.llvm.org/D122121 Files: clang/include/clang/Analysis/FlowSensitive/MatchSwitch.h c

[clang] 73e1888 - [OpenCL] Guard write_only image3d_t with TypeExtension

Author: Sven van Haastregt Date: 2022-03-21T12:45:58Z New Revision: 73e1888e530afefd4a9a774ef9c29bf24baca3d4 URL: https://github.com/llvm/llvm-project/commit/73e1888e530afefd4a9a774ef9c29bf24baca3d4 DIFF: https://github.com/llvm/llvm-project/commit/73e1888e530afefd4a9a774ef9c29bf24baca3d4.diff

[PATCH] D122121: [clang][dataflow] Add action caching support to MatchSwitch

sgatev marked an inline comment as done. sgatev added a comment. In D122121#3396022 , @ymandel wrote: > What is the motivation for stashing the results of a match on a statement? Do > we expect to encounter the same statement often? The matcher is evalu

[PATCH] D121958: [clang] NFC: Remove forced type merging in multiversion function checks.

erichkeane accepted this revision. erichkeane added a comment. Still OK to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121958/new/ https://reviews.llvm.org/D121958 ___ cfe-commits mailing list cfe-

[PATCH] D119655: [Driver][NetBSD] -r: imply -nostdlib like GCC

uabelho added inline comments. Herald added a project: All. Comment at: clang/test/Driver/netbsd.c:477 +// RELOCATABLE-NOT: "-l +// RELOCATABLE-NOT: crt{{[^.]+}}.o Hi, I see this CHECK-NOT fail every now and then due to bad luck: 13:48:46 /repo/bbiswjenk/fem2s

[clang-tools-extra] 1f92f44 - [pseudo] fix typo'd test assertions

Author: Sam McCall Date: 2022-03-21T14:05:21+01:00 New Revision: 1f92f44ec9d0164abe028c8d1e5a1d4f677a9c11 URL: https://github.com/llvm/llvm-project/commit/1f92f44ec9d0164abe028c8d1e5a1d4f677a9c11 DIFF: https://github.com/llvm/llvm-project/commit/1f92f44ec9d0164abe028c8d1e5a1d4f677a9c11.diff LO

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Okay, let's give it another shot. Please monitor any buildbot failures and revert promptly if needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102669/new/ https://reviews.ll

[PATCH] D122029: Change __auto_type behavior with qualifiers to match GCC behavior

aaron.ballman updated this revision to Diff 416911. aaron.ballman added a comment. Updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122029/new/ https://reviews.llvm.org/D122029 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Type.h clang/

[PATCH] D122029: Change __auto_type behavior with qualifiers to match GCC behavior

aaron.ballman added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:10290 +// information. +if (const auto *AT = LHS->getAs()) { + if (AT->getKeyword() == AutoTypeKeyword::GNUAutoType) erichkeane wrote: > So do we care if BOTH sides are thi

[PATCH] D122029: Change __auto_type behavior with qualifiers to match GCC behavior

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:1929 + const auto *AT = dyn_cast(T); + if (!AT || AT->isGNUAutoType()) { +DiagID = diag::err_typecheck_invalid_restrict_not_pointer; The RHS here should NEVER be true. I

[clang] afb9cbb - [OpenMP] Regenerate test checks (NFC)

Author: Nikita Popov Date: 2022-03-21T14:25:02+01:00 New Revision: afb9cbb324df096fb55a2067be08d36c1eb7dab5 URL: https://github.com/llvm/llvm-project/commit/afb9cbb324df096fb55a2067be08d36c1eb7dab5 DIFF: https://github.com/llvm/llvm-project/commit/afb9cbb324df096fb55a2067be08d36c1eb7dab5.diff

[PATCH] D122133: [LTO] Add configuartion option to use default optimization pipeline

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan

[PATCH] D122121: [clang][dataflow] Add action caching support to MatchSwitch

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Much clearer now, thanks for the changes! The only real question I have is what's the best design for the cache -- lambda or explicit pair. I leave it up to you. In D122121#3396096

[PATCH] D122029: Change __auto_type behavior with qualifiers to match GCC behavior

xbolva00 added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:10294 +} +if (const auto *AT = LHS->getAs()) { + if (AT->isGNUAutoType()) Same? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122029/new/ https://reviews.llvm.org/D12

[PATCH] D122029: Change __auto_type behavior with qualifiers to match GCC behavior

erichkeane added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:10294 +} +if (const auto *AT = LHS->getAs()) { + if (AT->isGNUAutoType()) xbolva00 wrote: > Same? Oooh, good catch! Looks like it should be RHS->getAs CHANGES SINCE LAST AC

[PATCH] D122129: [clang][dataflow] Model the behavior of optional and std swap

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/UncheckedOptionalAccessModelTest.cpp:1961 + )", + UnorderedElementsAre(Pair("check-1", "safe"), +

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 416917. quinnp added a comment. Fixing a failing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D121637 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeG

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel added a comment. Thanks, Gabor -- that's a really helpful summary! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121797/new/ https://reviews.llvm.org/D121797 ___ cfe-commits mailing list cfe-comm

[PATCH] D121911: [Clang] Add DriverKit support

egorzhdan updated this revision to Diff 416920. egorzhdan added a comment. Fix clang-format warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121911/new/ https://reviews.llvm.org/D121911 Files: clang/include/clang/Analysis/RetainSummaryMana

[clang] 062b1ae - Reapply [Utils] Fix %S substitution

Author: Nikita Popov Date: 2022-03-21T15:15:34+01:00 New Revision: 062b1ae7e0ca61c81b0f8d097279268336a7efd7 URL: https://github.com/llvm/llvm-project/commit/062b1ae7e0ca61c81b0f8d097279268336a7efd7 DIFF: https://github.com/llvm/llvm-project/commit/062b1ae7e0ca61c81b0f8d097279268336a7efd7.diff

[PATCH] D122029: Change __auto_type behavior with qualifiers to match GCC behavior

aaron.ballman updated this revision to Diff 416928. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122029/new/ https://reviews.llvm.org/D122029 Files: clang/docs/ReleaseNot

[clang] 7a2e12e - [CodeGen][OpenMP] Use correct type in EmitLoadOfPointer()

Author: Nikita Popov Date: 2022-03-21T15:22:37+01:00 New Revision: 7a2e12e0a7132739bb2c609477093d2b26ee4f3a URL: https://github.com/llvm/llvm-project/commit/7a2e12e0a7132739bb2c609477093d2b26ee4f3a DIFF: https://github.com/llvm/llvm-project/commit/7a2e12e0a7132739bb2c609477093d2b26ee4f3a.diff

[PATCH] D122139: [pseudo] Introduce parse forest.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: mgorny. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. Parse forest is the output of the GLR pars

[PATCH] D122139: [pseudo] Introduce parse forest.

hokein updated this revision to Diff 416936. hokein added a comment. small tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122139/new/ https://reviews.llvm.org/D122139 Files: clang-tools-extra/pseudo/include/clang-pseudo/Forest.h clang-t

[PATCH] D121150: [pseudo][WIP] Implement a GLR parser.

hokein marked 13 inline comments as done. hokein added a comment. splitting the forest data structure to https://reviews.llvm.org/D122139, comments around Forest.h/.cpp should be addressed. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Forest.h:57 + }; + uint32_t sta

[PATCH] D122089: [CUDA] Add getTargetFeatures for the NVPTX toolchain

jdoerfert added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:635 + const llvm::opt::ArgList &Args, + std::vector &Features, + Optional CudaVersion) { ---

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaStmtAsm.cpp:622 +if (InTy->isIntegerType() || InTy->isPointerType() || +InTy->isStructureType() || InTy->isConstantArrayType()) InputDomain = AD_Int; pengfei wrote: > jyu2 wrote: > > Ar

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang updated this revision to Diff 416942. dang added a comment. Rebase on top of main to bring latest fixes to ExtractAPIAction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121936/new/ https://reviews.llvm.org/D121936 Files: clang/include/clan

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

dblaikie added inline comments. Comment at: clang/utils/TableGen/MveEmitter.cpp:1197 +const Type *Ty = nullptr; +if (auto *DI = dyn_cast(D->getArg(0))->getOperator()) + if (auto *PTy = dyn_cast(getType(DI, Param))) nikic wrote: > Should be either `ca

[PATCH] D121678: [pseudo] Split greatergreater token.

hokein added a comment. Thanks for the report and revert, and sorry for the failures and the late response (was OOO on Friday). > One of our guys speculates that because some allocations are "owned" by the > returned TokenStream, but the returned TokenStream is a temporary, the > lifetimes mig

[PATCH] D122089: [CUDA] Add getTargetFeatures for the NVPTX toolchain

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:635 + const llvm::opt::ArgList &Args, + std::vector &Features, + Optional CudaVersion) { -

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

simon_tatham added inline comments. Comment at: clang/utils/TableGen/MveEmitter.cpp:1197 +const Type *Ty = nullptr; +if (auto *DI = dyn_cast(D->getArg(0))->getOperator()) + if (auto *PTy = dyn_cast(getType(DI, Param))) dblaikie wrote: > nikic wrote:

[PATCH] D122104: [X86][regcall] Support passing / returning structures

pengfei updated this revision to Diff 416945. pengfei added a comment. Address Yuanke's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122104/new/ https://reviews.llvm.org/D122104 Files: clang/include/clang/CodeGen/CGFunctionInfo.h cla

[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

martong added inline comments. Comment at: clang/utils/TableGen/ClangSACheckersEmitter.cpp:90-91 + + return (llvm::Twine("https://clang.llvm.org/docs/analyzer/checkers.html#";) + + CheckerFullName) .str(); > This patch will ensure that the doc ur

[PATCH] D122141: [clang][extract-api] Suppprt for the module name property in SymbolGraph

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds `--product-name=` flag to the clang driver. This gets forwarded to cc

[PATCH] D122143: [clang][dataflow] Add support for disabling warnings on smart pointers.

ymandel created this revision. ymandel added reviewers: sgatev, xazax.hun. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch provides the user with the ability to disable all che

[PATCH] D121627: [IROutliner][NFC] Fix typo in doc of findOrCreatePHIInBlock

hkmatsumoto added a comment. Since I don't have commit access, can you land this patch for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121627/new/ https://reviews.llvm.org/D121627 ___ cfe-commits m

[PATCH] D115622: [Debugify] Optimize debugify original mode

StephenTozer accepted this revision. StephenTozer added a comment. Latest change makes sense, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115622/new/ https://reviews.llvm.org/D115622 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D122077: [InstCombine] Fold (ctpop(X) == 1) | (X == 0) into ctpop(X) < 2

spatel added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:916 +/// fold (icmp ne ctpop(X) 1) & (icmp ne X 0) into (icmp uge ctpop(X) 2). +static Value *foldOrOfCtpop(ICmpInst *Cmp0, ICmpInst *Cmp1, bool IsAnd, +I

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

fhahn added a comment. In D117829#3389241 , @RKSimon wrote: > In D117829#3386398 , @fhahn wrote: > >> @RKSimon are you planning on pushing this patch through? From my >> perspective, it looks good with splitting

[PATCH] D122129: [clang][dataflow] Model the behavior of optional and std swap

sgatev updated this revision to Diff 416953. sgatev added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122129/new/ https://reviews.llvm.org/D122129 Files: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAcc

[PATCH] D122089: [CUDA] Add getTargetFeatures for the NVPTX toolchain

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122089/new/ https://reviews.llvm.org/D122089 ___

[PATCH] D122147: Remove the clang/INPUTS directory; NFC

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, erichkeane, jcranmer, jdoerfert, lebedev.ri. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. This directory seems to be unused. At least, when I remove it, I ca

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

adamcz updated this revision to Diff 416964. adamcz marked 3 inline comments as done. adamcz added a comment. more review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121712/new/ https://reviews.llvm.org/D121712 Files: clang-tools-extr

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

adamcz added inline comments. Comment at: clang-tools-extra/clangd/FS.h:91 +IntrusiveRefCntPtr +getTimeTrackingFS(std::shared_ptr Timer, + IntrusiveRefCntPtr FS); kadircet wrote: > adamcz wrote: > > kadircet wrote: > > > kadircet wrote: > > > > i

[PATCH] D122147: Remove the clang/INPUTS directory; NFC

erichkeane added a comment. I tried to intentionally break one of these tests as well, and I have no evidence that these are used/tested at all either. @rsmith is the last one to have modified these in a way that looks like they were actually USED, so unless he says otherwise (or precommit co

  1   2   3   >