jhuber6 added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:635
+ const llvm::opt::ArgList &Args,
+ std::vector<StringRef> &Features,
+ Optional<clang::CudaVersion> CudaVersion) {
----------------
jdoerfert wrote:
> Why std::vector. looks like this only returns 1 anyway, no?
That's how the rest of these functions are used in `getTargetFeatures` above.
If I had a different method it wouldn't be easy to insert there.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122089/new/
https://reviews.llvm.org/D122089
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
