krasimir added a comment.

In D121451#3395611 <https://reviews.llvm.org/D121451#3395611>, @curdeius wrote:

> In D121451#3395578 <https://reviews.llvm.org/D121451#3395578>, @krasimir 
> wrote:
>
>> This appears to have broken a relatively common pattern we see in text proto 
>> comments where sections use a style like this:
>>
>>   
>> ################################################################################
>>   # Big section name
>>   
>> ################################################################################
>
> That's a pity.
> Do you think that just doing a different thing (what we had before) for Proto 
> (and if possible other languages where `#` is used in a similar way) should 
> be enough?

I was thinking about something a bit more sophisticated, where if the first 
character looks like a continuation of the comment leader we keep them together 
(effectively generalizing whatever keeps `////` together), but have to look how 
this is actually handled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121451/new/

https://reviews.llvm.org/D121451

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to