[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder updated this revision to Diff 413279. tbaeder marked 3 inline comments as done. tbaeder added a comment. Thanks for the links to the papers. What's the best way of updating https://clang.llvm.org/c_status.html#c2x with the new papers? I added the changes to `stdbool.h`, but I haven't bee

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder added inline comments. Comment at: clang/docs/ReleaseNotes.rst:113 - Implemented `WG14 N2674 The noreturn attribute `_. - Implemented `WG14 N2418 Adding the u8 character prefix

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, owenpan. MyDeveloperDay added projects: clang, clang-format. Herald added a project: All. MyDeveloperDay requested review of this revision. I have lost count of the number of times this has been rep

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

MyDeveloperDay updated this revision to Diff 413286. MyDeveloperDay added a comment. Update to always use the first row number of columns or unit tests crash CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121069/new/ https://reviews.llvm.org/D121069 Files: clang/lib/Format/WhitespaceM

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

MyDeveloperDay updated this revision to Diff 413288. MyDeveloperDay added a comment. Add more producers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121069/new/ https://reviews.llvm.org/D121069 Files: clang/lib/Format/WhitespaceManager.cpp clang/lib/Format/WhitespaceManager.h cl

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

sstwcw added a comment. About chained assignments, the current program does not attempt to align them in a consistent way. And this revision doesn't change it. Both before and after this revision, the output depend on the order of the statements. Foo = Bar = 5; Int Baz = 5; Int Baz

[PATCH] D117836: Fix obvious typo

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. Herald added a project: All. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117836/new/ https://reviews.llvm.org/D117836 ___

[PATCH] D121049: [Clang][VE] Add vector load intrinsics

kaz7 updated this revision to Diff 413295. kaz7 added a comment. Add intrinsics for not only VLD instructions but also VLD2D instructions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121049/new/ https://reviews.llvm.org/D121049 Files: clang/inc

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

kaz7 added a comment. Herald added a project: All. At the beginning, this implementation extends `vector_type` attribute which is GCC's attribute. So, this may cause future conflicts with GCC when they extend it. But, now this patch uses it's own `ext_vector_type` attribute. So, basically th

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

curdeius added inline comments. Comment at: clang/lib/Format/WhitespaceManager.h:204 +// of columns as the first row +bool IsSquare() { + if (CellCounts.empty()) Don't really like the name... Some suggestions: - HasEqualRows - HasEqualRowLengths - Ha

[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/NullPtrInterferenceChecker.cpp:166 +/// child is a sink node. +static bool unconditionallyLeadsHere(const ExplodedNode *N) { + size_t NonSinkNodeCount = llvm::count_if( xazax.hun wrot

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16800 + Alignment)); +} + sstwcw wrote: > HazardyKnusperkeks wrote: > > Can you test it with `AlignConsecutiveDeclarations`? > Do you mean like the forma

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

steakhal added a comment. Land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119601/new/ https://reviews.llvm.org/D119601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D121072: [X86][Experiment] Mangle global variable for inline assembly

pengfei created this revision. Herald added a project: All. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is an experiment inspired by @efriedma 's suggestion on D120887 . It seems a more co

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I would probably query the opcode only once and reuse it, but is also fine. Btw whats your intention making this change? Do you plan greater refactorings/cleanups? Repository: rG LLVM

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM (though I'd also be fine if we only wanted to call `getOpcode()` once). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121045/new/ https://reviews.llvm.org/D121045 __

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

MyDeveloperDay updated this revision to Diff 413298. MyDeveloperDay added a comment. Fix review comments and clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121069/new/ https://reviews.llvm.org/D121069 Files: clang/lib/Format/WhitespaceManager.cpp clang/lib/Format/Whites

[PATCH] D121072: [X86][Experiment] Mangle global variable for inline assembly

pengfei added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2555-2556 +M.getNameWithPrefix(MangleName, GV, /*CannotUsePrivateLabel=*/true); +AsmString.replace(AsmString.find("$" + std::to_string(I)), 2, + MangleName.c_str()); +

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

HazardyKnusperkeks added a comment. There should also be a warning or at least note on the option description about the current limitations. Comment at: clang/lib/Format/WhitespaceManager.h:202-203 + +// Determine if the array is "Square" i.e. every row has the same number

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

MyDeveloperDay updated this revision to Diff 413299. MyDeveloperDay marked 4 inline comments as done. MyDeveloperDay added a comment. Lets get the comment aligned with the code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121069/new/ https://reviews.llvm.org/D121069 Files: clang/lib

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

phyBrackets added a comment. In D121045#3362373 , @steakhal wrote: > I would probably query the opcode only once and reuse it, but is also fine. > > Btw whats your intention making this change? Do you plan greater > refactorings/cleanups? Yeah, I think

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

phyBrackets updated this revision to Diff 413300. phyBrackets added a comment. query the opcode only once and reuse it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121045/new/ https://reviews.llvm.org/D121045 Files: clang/docs/DataFlowAnalysisI

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

phyBrackets added a comment. Sorry but Idk why that DataFlowAnalysisIntro typo change also commited , I only add the deadstorechecker file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121045/new/ https://reviews.llvm.org/D121045 ___

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

MyDeveloperDay added a comment. NOTE: I've tried to collate all the reported crashing examples and run this fix through them (both Left and Right) all pass except this one below void foo() { auto thing = test{ { {something}, //A } }; } This is not related to i

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Nits only. +1 for adding a note in the option documentation. Comment at: clang/lib/Format/WhitespaceManager.h:203 +// Determine if every row in the the array +//

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

MyDeveloperDay updated this revision to Diff 413301. MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. There were no checks for if the cell would run off the end of the CellDescs structure, this is part of the reason for the crashes that the PrevIter->Index becomes

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:1118 Changes[CellIter->Index].Spaces = CellDescs.InitialSpaces; ++CellIter; + for (auto i = 1U; i < CellDescs.CellCounts[0]; i++, ++CellIter) { I don't understand in

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

feg208 accepted this revision. feg208 added a comment. I have been watching the issues pile up around this but work has prevented me from focusing on them. This seems like a reasonable compromise but the note of disabling this feature is also reasonable. Given where it had to be placed in the f

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

MyDeveloperDay added a comment. @feg208 I could do with some clarity on the algorithm, am I correct in thinking it requires that the first row, contain at least the maximum number of columns for the rest of the array. I sort of noticed it was fine if the first row was larger { {1,2,3 }

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

MyDeveloperDay added a comment. In D121069#3362448 , @feg208 wrote: >> This seems like a reasonable compromise I kind of feel this might be the best initial option, I don't want to disable it completely because it looks like people are trying to use it,

[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/NullPtrInterferenceChecker.cpp:166 +/// child is a sink node. +static bool unconditionallyLeadsHere(const ExplodedNode *N) { + size_t NonSinkNodeCount = llvm::count_if( Szelethus wrot

[PATCH] D120984: [clang][dataflow] Extend flow conditions from block terminators

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:154 + + // `X v (X ^ Y ^ ...)` is logically equivalent to `X`. The common conditions + // have al

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

curdeius added inline comments. Comment at: clang/lib/Format/WhitespaceManager.h:318 Next = Next->NextColumnElement) { + if (RowCount > MaxRowCount) { +break; You can elide braces. Personally I use RemoveBraces locally. CHANGES SINCE LAST

[PATCH] D120989: Support debug info for alias variable

dblaikie added a comment. Broad question about debug info for aliases: How's this proposed solution compare/contrast to GCC's behavior? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120989/new/ https://reviews.llvm.org/D120989 ___

[PATCH] D120989: Support debug info for alias variable

dblaikie added a comment. In D120989#3362490 , @dblaikie wrote: > Broad question about debug info for aliases: How's this proposed solution > compare/contrast to GCC's behavior? Aaand, I see that was described in thhe patch description. Sorry for not r

[PATCH] D121061: [OpenMPIRBuilder] Allocate temporary at the correct block in a nested parallel

wsmoses updated this revision to Diff 413309. wsmoses added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121061/new/ https://reviews.llvm.org/D121061

[PATCH] D121077: Simplify OpenMP Lambda use

dblaikie created this revision. dblaikie added a reviewer: ABataev. Herald added subscribers: guansong, yaxunl. Herald added a project: All. dblaikie requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang

Re: [clang] 1d1b089 - Fix more unused lambda capture warnings, NFC

On Mon, Feb 28, 2022 at 10:12 AM Reid Kleckner wrote: > I agree, but clearly this person chose a particular style, and I wasn't > trying to revise their code style, just to fix some the Bazel build, which > uses -Werror. > Oh, wow, yeah, this file/corner of the codebase is deep into lambdas, wow

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny created this revision. SimplyDanny added a reviewer: tonic. Herald added subscribers: libcxx-commits, arphaman. Herald added a reviewer: sscalpone. Herald added projects: libunwind, Flang, All. Herald added a reviewer: libunwind. SimplyDanny requested review of this revision. Herald add

[PATCH] D120187: [clang-tidy] Allow newline characters as separators for checks in Clang-Tidy configurations

SimplyDanny added a comment. Herald added a project: All. What else can be done to get this change approved, @njames93? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120187/new/ https://reviews.llvm.org/D120187

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

feg208 added a comment. In D121069#3362450 , @MyDeveloperDay wrote: > @feg208 I could do with some clarity on the algorithm, am I correct in > thinking it requires that the first row, to contain at least the maximum > number of columns for the rest of

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

sstwcw updated this revision to Diff 413313. sstwcw added a comment. remove `int` in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/c

[PATCH] D121061: [OpenMPIRBuilder] Allocate temporary at the correct block in a nested parallel

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, two nits. Comment at: llvm/include/llvm/Transforms/Utils/CodeExtractor.h:127 /// extraction of blocks containing alloca instructions would be possible, //

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

owenpan added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:1073 + auto *Start = + (Cells.begin() + RowCount * CellDescs.CellCounts[RowCount]); auto *End = Start + Offset; Can we use `CellCounts[0]` instead?

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

owenpan added a comment. In D121069#3362424 , @MyDeveloperDay wrote: > NOTE: I've tried to collate all the reported crashing examples and run this > fix through them (both Left and Right) all pass except this one below > > > > void foo() > { > aut

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

owenpan added inline comments. Comment at: clang/lib/Format/WhitespaceManager.h:318 Next = Next->NextColumnElement) { + if (RowCount > MaxRowCount) { +break; owenpan wrote: > curdeius wrote: > > You can elide braces. Personally I use Remove

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

owenpan added inline comments. Comment at: clang/lib/Format/WhitespaceManager.h:321 + } auto Start = (CellStart + RowCount * CellCount); auto End = Start + Offset; MyDeveloperDay wrote: > Ultimately these calculations are incorrect unless every

[clang] 87ec6f4 - [OpenMPIRBuilder] Allocate temporary at the correct block in a nested parallel

Author: William S. Moses Date: 2022-03-06T18:34:25-05:00 New Revision: 87ec6f41bba6d72a3408e71cf19ae56feff523bc URL: https://github.com/llvm/llvm-project/commit/87ec6f41bba6d72a3408e71cf19ae56feff523bc DIFF: https://github.com/llvm/llvm-project/commit/87ec6f41bba6d72a3408e71cf19ae56feff523bc.di

[PATCH] D121061: [OpenMPIRBuilder] Allocate temporary at the correct block in a nested parallel

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. wsmoses marked an inline comment as done. Closed by commit rG87ec6f41bba6: [OpenMPIRBuilder] Allocate temporary at the correct block in a nested parallel (authored by w

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

ChuanqiXu added a comment. In D118352#3359626 , @urnathan wrote: > In D118352#3358864 , @ChuanqiXu > wrote: > >> If I don't misread the codes, it looks like `mangleModuleInitializer` is not >> called. > > > >> N

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

ChuanqiXu added a comment. In D120540#3359454 , @iains wrote: > In D120540#3359446 , @ChuanqiXu > wrote: > >> In D120540#3359394 , @iains wrote: >> >>> 1. I agree 100% th

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu added a comment. @urnathan It looks @rsmith is not available this time. Would you like to accept this one? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/ https://reviews.llvm.org/D118034 ___ cfe-commits mailing list cfe-

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf updated this revision to Diff 41. qiucf marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116015/new/ https://reviews.llvm.org/D116015 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/PowerPC/buil

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf added inline comments. Comment at: clang/test/CodeGen/PowerPC/builtins-ppc-xlcompat-math.c:98 // CHECK-NEXT:store double [[D:%.*]], double* [[D_ADDR]], align 8 +// CHECK-COUNT-3:load double, double* [[D_ADDR]], align 8 // CHECK-NEXT:[[TMP0:%.*]] = load double,

[clang] b2497e5 - [PowerPC] Add generic fnmsub intrinsic

Author: Qiu Chaofan Date: 2022-03-07T13:00:06+08:00 New Revision: b2497e54356d454d0e16d8f44086bf6db6aff0e3 URL: https://github.com/llvm/llvm-project/commit/b2497e54356d454d0e16d8f44086bf6db6aff0e3 DIFF: https://github.com/llvm/llvm-project/commit/b2497e54356d454d0e16d8f44086bf6db6aff0e3.diff L

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2497e54356d: [PowerPC] Add generic fnmsub intrinsic (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D120307: [X86] Add helper enum for ternary intrinsics

pengfei added a comment. Herald added a project: All. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120307/new/ https://reviews.llvm.org/D120307 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf updated this revision to Diff 413336. qiucf added a comment. Herald added a project: All. Add P10 tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119407/new/ https://reviews.llvm.org/D119407 Files: clang

[PATCH] D119476: Generalize and harmonize sub-expression traversal

kimgr added a comment. Herald added a project: All. Gentle weekly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119476/new/ https://reviews.llvm.org/D119476 ___ cfe-commits mailing list cfe-commits@

[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

kimgr added a comment. Herald added a project: All. Gentle weekly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119477/new/ https://reviews.llvm.org/D119477 ___ cfe-commits mailing list cfe-commits@

[PATCH] D120857: WIP [randstruct] Create basis for unit test module

void updated this revision to Diff 413343. void added a comment. Fix assert from use of null pointer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120857/new/ https://reviews.llvm.org/D120857 Files: clang/include/clang/AST/Decl.h clang/includ

[clang] 7b969b0 - [clang][parser] Stop dragging an EndLoc around when parsing attributes

Author: Timm Bäder Date: 2022-03-07T08:16:39+01:00 New Revision: 7b969b0bb53e5dcf23e0ddba977031fb104b63ec URL: https://github.com/llvm/llvm-project/commit/7b969b0bb53e5dcf23e0ddba977031fb104b63ec DIFF: https://github.com/llvm/llvm-project/commit/7b969b0bb53e5dcf23e0ddba977031fb104b63ec.diff LO

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b969b0bb53e: [clang][parser] Stop dragging an EndLoc around when parsing attributes (authored by tbaeder). Repository: rG LLVM Github Monorepo C

[PATCH] D120307: [X86] Add helper enum for ternary intrinsics

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, but pls wait for 1 or 2 days to see if there are any comments from others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120307/new/

[PATCH] D120989: Support debug info for alias variable

kavitha-natarajan updated this revision to Diff 413347. kavitha-natarajan added a comment. Rebased and applied pre-merge check formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120989/new/ https://reviews.llvm.org/D120989 Files: clang/li

[PATCH] D120989: Support debug info for alias variable

kavitha-natarajan added a comment. In D120989#3362491 , @dblaikie wrote: > In D120989#3362490 , @dblaikie > wrote: > >> Broad question about debug info for aliases: How's this proposed solution >> compare/contra