feg208 added a comment.
In D121069#3362450 <https://reviews.llvm.org/D121069#3362450>, @MyDeveloperDay
wrote:
> @feg208 I could do with some clarity on the algorithm, am I correct in
> thinking it requires that the first row, to contain at least the maximum
> number of columns for the rest of the array. I sort of noticed it was fine if
> the first row was larger
>
> {
> {1,2,3 }
> {4,5}
> {6}
> }
Honestly it really is best with the square option. The assumption is an array
of simple initializers though default args to constructors complicate that in
the case of an array of single constructors. I think that you are seeing it be
okay with the maximum as the first row is just an accident of the
implementation. The direction I was heading in in the bug I picked up was to
start restricting the set of things it would consider as array of initializers.
Does that answer your question?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121069/new/
https://reviews.llvm.org/D121069
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
