[clang] a29f8db - [C++20][Modules][8/8] Amend module visibility rules for partitions.

Author: Iain Sandoe Date: 2022-03-01T08:29:05Z New Revision: a29f8dbb7f3e816344a7be75996eea3ab5a0b5a3 URL: https://github.com/llvm/llvm-project/commit/a29f8dbb7f3e816344a7be75996eea3ab5a0b5a3 DIFF: https://github.com/llvm/llvm-project/commit/a29f8dbb7f3e816344a7be75996eea3ab5a0b5a3.diff LOG: [

[PATCH] D118599: [C++20][Modules][8/8] Amend module visibility rules for partitions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. iains marked an inline comment as done. Closed by commit rGa29f8dbb7f3e: [C++20][Modules][8/8] Amend module visibility rules for partitions. (authored by iains). Repos

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

ChuanqiXu updated this revision to Diff 411996. ChuanqiXu added a comment. Add test in CodeGen. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120397/new/ https://reviews.llvm.org/D120397 Files: clang/lib/AST/Decl.cpp clang/test/CodeGenCXX/inconsistent-export-template.cpp clang/te

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker added a comment. @JonasToth Could you please review it? Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:236 'each source file in its parent directories.') + parser.add_argument('-config-file', default=None, +

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

ChuanqiXu added inline comments. Comment at: clang/test/CodeGenCXX/inconsistent-export-template.cpp:8 + +// CHECK: void @_Z1fIiEvv +template <> The mangled name should contain module name if D118352 is ready. Comment at: clang/test/Modules/inco

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

iains added inline comments. Comment at: clang/test/Modules/inconsist-export-template.cpp:19-23 +// FIXME: We should reject following specialization, +// since it tries to export a name which is already introduced. +export template <> +void f1() { + ChuanqiXu wro

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

rovka added a comment. This passes on Windows on Arm if you add a forward declaration for `class PassInstrumentation` here . This is necessary because otherwise cl

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

iains added inline comments. Comment at: clang/test/Modules/inconsist-export-template.cpp:19-23 +// FIXME: We should reject following specialization, +// since it tries to export a name which is already introduced. +export template <> +void f1() { + iains wrote:

[PATCH] D105408: [clang-format] Pass a TextDiagnosticPrinter when we can not create tempory file.

MyDeveloperDay added a comment. This is no longer needed, please abanson Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105408/new/ https://reviews.llvm.org/D105408 ___ cfe-commits mailing list cfe-commit

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

awarzynski updated this revision to Diff 412008. awarzynski added a comment. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. Add a forward declaration for `class PassInstrumentation` (thank you @rovka!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

tyb0807 updated this revision to Diff 412010. tyb0807 added a comment. Taking into account remarks from @tmatheson, I'm reverting my latest changes consisting in caching architecture feature into a variable, which makes the `getAArch64ArchFeaturesFrom*` interfaces more complicated. I'd propose we

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

ChuanqiXu added inline comments. Comment at: clang/test/Modules/inconsist-export-template.cpp:19-23 +// FIXME: We should reject following specialization, +// since it tries to export a name which is already introduced. +export template <> +void f1() { + iains wro

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

nikic added a comment. I've been looking into the compile-time regressions. The large regression on sqlite3 is due to differences in inlining behavior. The inlining cost model is slightly different for PIC builds, because GEPs that are based on a global and have a variable offset are no longer

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

steakhal added a comment. You should copy the `mempcpy14`, `mempcpy15` test cases into a separate file, and cut the `top`; while disabling this `alpha.unix.cstring.UninitializedRead` checker in the existing test file(s) and explicitly enable in the new separated file. This way it wouldn't inter

[PATCH] D120499: [NVPTX] Fix nvvm.match.sync*.i64 intrinsics return type (i64 -> i32)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57aaab3b17f0: [NVPTX] Fix nvvm.match.sync*.i64 intrinsics return type (i64 -> i32) (authored by krisb). Changed prior to commit: https://reviews.l

[clang] 57aaab3 - [NVPTX] Fix nvvm.match.sync*.i64 intrinsics return type (i64 -> i32)

Author: Kristina Bessonova Date: 2022-03-01T12:26:16+02:00 New Revision: 57aaab3b17f02a0904b823278035afe555f6f99a URL: https://github.com/llvm/llvm-project/commit/57aaab3b17f02a0904b823278035afe555f6f99a DIFF: https://github.com/llvm/llvm-project/commit/57aaab3b17f02a0904b823278035afe555f6f99a.

[PATCH] D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring.

whisperity added a reviewer: whisperity. whisperity added a comment. Herald added a subscriber: rnkovacs. This generally looks good, and thank you! I have a few minor comments (mostly presentation and documentation). Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHand

[PATCH] D120499: [NVPTX] Fix nvvm.match.sync*.i64 intrinsics return type (i64 -> i32)

krisb added a comment. @tra thank you for looking at this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120499/new/ https://reviews.llvm.org/D120499 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:509 + TargetRegistry::lookupTarget(theTriple, error); + assert(theTarget && "Failed to create Target"); + rovka wrote: > Shouldn't this be a diagnostic? People could be try

[clang-tools-extra] 9485091 - [NFC][clang-tidy][docs] Remove mention of backported fix of `readability-suspicious-call-argument` from `ReleaseNotes`

Author: Whisperity Date: 2022-03-01T12:06:59+01:00 New Revision: 94850918274c20c15c6071dc52314df51ed2a357 URL: https://github.com/llvm/llvm-project/commit/94850918274c20c15c6071dc52314df51ed2a357 DIFF: https://github.com/llvm/llvm-project/commit/94850918274c20c15c6071dc52314df51ed2a357.diff LO

[PATCH] D120710: [clang-format] QualifierOrder does not reorder template arguments

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/53981 Reorder the qualifiers inside the template ar

[PATCH] D120555: [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments without name-like identifier

whisperity added a comment. In D120555#3345707 , @njames93 wrote: > If you backport, the release notes change on trunk should then be reverted. Release Notes entry of current development tree reverted in rG94850918274c20c15c6071dc52314df51ed2a357

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs, mgorny. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

sgatev updated this revision to Diff 412034. sgatev added a comment. Minor changes to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120711/new/ https://reviews.llvm.org/D120711 Files: clang/include/clang/Analysis/FlowSensitive/Dataflow

[PATCH] D120712: [clang-format][docs] handle explicit enum values

kwk created this revision. kwk added a reviewer: FederAndInk. kwk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If there was this enum definition before: struct FormatStyle { //... /// Different styles for aligning after ope

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

whisperity added a reviewer: whisperity. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:142-149 Finder->addMatcher( callExpr(callee(SignalFunction), hasArgument(1, HandlerExpr)) .bind("register_call"

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

rovka added a comment. I don't have any other comments, I'll let Eric take it from here :) Comment at: flang/lib/Frontend/FrontendActions.cpp:509 + TargetRegistry::lookupTarget(theTriple, error); + assert(theTarget && "Failed to create Target"); + awarzyn

[PATCH] D120713: [clangd] Make dexp command line options sticky

yrouban created this revision. yrouban added reviewers: jhenderson, lattner, jpienaar, mehdi_amini. yrouban added a project: clang. Herald added subscribers: usaxena95, kadircet, arphaman. yrouban requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Hera

[PATCH] D120111: [AArch64] Default HBC/MOPS features in clang

tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. LGTM, please give @nickdesaulniers some time to respond though. I do agree that iterating over the features repeatedly is less than ideal, but also that this patch is probably not the pl

[PATCH] D120710: [clang-format] QualifierOrder does not reorder template arguments

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this! Comment at: clang/lib/Format/QualifierAlignmentFixer.cpp:344-346 + // If the template closer is closing the requires clause + // t

[clang] 3cdc1c1 - [Clang] Add `-funstable` flag to enable unstable and experimental features

Author: Egor Zhdan Date: 2022-03-01T12:35:20Z New Revision: 3cdc1c155b40897a17d7fd61092d2f6fd21fb7ef URL: https://github.com/llvm/llvm-project/commit/3cdc1c155b40897a17d7fd61092d2f6fd21fb7ef DIFF: https://github.com/llvm/llvm-project/commit/3cdc1c155b40897a17d7fd61092d2f6fd21fb7ef.diff LOG: [C

[PATCH] D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3cdc1c155b40: [Clang] Add `-funstable` flag to enable unstable and experimental features (authored by egorzhdan). Repository: rG LLVM Github Monor

[PATCH] D120712: [clang-format][docs] handle explicit enum values

MyDeveloperDay added a comment. I'm not quite sure how I feel about adding functionality that doesn't actually do anything. Comment at: clang/docs/tools/dump_format_style.py:174-175 return '* ``%s`` (in configuration: ``%s``)\n%s' % ( -self.name, -re.sub('

[PATCH] D116439: [clang-tidy] Fix `readability-const-return-type` for pure virtual function.

Sockke updated this revision to Diff 412056. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116439/new/ https://reviews.llvm.org/D116439 Files: clang-tools-extra/clang-tidy/readability/ConstReturnTypeCheck.cpp clang-tools-extra/docs/ReleaseNotes.rst clang-tools-extra/test/clang-tidy

[PATCH] D120369: [analyzer] Add more propagations to Taint analysis

gamesh411 updated this revision to Diff 412057. gamesh411 marked 17 inline comments as done. gamesh411 added a comment. Herald added a subscriber: manas. - remove vscanf and co. - use debug.ExprInspection for test cases - fix semantic issues for modeled functions Repository: rG LLVM Github Mon

[PATCH] D120369: [analyzer] Add more propagations to Taint analysis

gamesh411 added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2361 Default propagations defined by ``GenericTaintChecker``: -``atoi``, ``atol``, ``atoll``, ``fgetc``, ``fgetln``, ``fgets``, ``fscanf``, ``sscanf``, ``getc``, ``getc_unlocked``, ``getdelim``, ``get

[PATCH] D116439: [clang-tidy] Fix `readability-const-return-type` for pure virtual function.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba54ebeb5eba: [clang-tidy] Fix `readability-const-return-type` for pure virtual function. (authored by Sockke). Repository: rG LLVM Github Monorep

[clang-tools-extra] ba54ebe - [clang-tidy] Fix `readability-const-return-type` for pure virtual function.

Author: Sockke Date: 2022-03-01T20:55:28+08:00 New Revision: ba54ebeb5eba0f63de8ce2d73a85e9bf508008f6 URL: https://github.com/llvm/llvm-project/commit/ba54ebeb5eba0f63de8ce2d73a85e9bf508008f6 DIFF: https://github.com/llvm/llvm-project/commit/ba54ebeb5eba0f63de8ce2d73a85e9bf508008f6.diff LOG: [

[PATCH] D120369: [analyzer] Add more propagations to Taint analysis

steakhal accepted this revision. steakhal added a reviewer: NoQ. steakhal added a comment. This revision is now accepted and ready to land. Looks good to me. Check the docs if they are still in sync. Also, postpone this for two days to let others block this if they have objections. Other than tha

[PATCH] D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.

Meinersbur added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1505 + /// valid in the condition block (i.e., defined in the preheader) and is + /// interpreted as an unsigned integer. + void setTripCount(Value *TripCount); peix

[PATCH] D120720: [clang][AVR] Implement standard calling convention for AVR and AVRTiny

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D120697: [clang-offload-bundler] HIP and OpenMP comaptibility for linking heterogeneous archive library

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120697/new/ https://reviews.llvm.org/D120697 __

[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

jchlanda marked an inline comment as done. jchlanda added a comment. @tra thank you for landing the patches, it seems that the clang part (builtin declarations and tests) have been dropped, only `llvm` dir changes made it through. Is there any way I could fix it (same goes for the other two patc

[PATCH] D120723: [pseudo] Fix an out-of-bound error in LRTable::find.

hokein created this revision. hokein added a reviewer: sammccall. hokein requested review of this revision. Herald added a project: clang. The linear scan should not escape the TargetedStates range. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120723 Files: clang/lib/Tooli

[PATCH] D120723: [pseudo] Fix an out-of-bound error in LRTable::find.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/Pseudo/LRTable.cpp:115 TargetedStates, [&Src](LRTable::StateID S) { return S < Src; }); - if (It == TargetedStates.end(

[PATCH] D120724: [pseudo] Add a print-grammar option in the tool

hokein created this revision. hokein added a reviewer: sammccall. hokein requested review of this revision. Herald added a project: clang. This is helpful for debugging purposes. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120724 Files: clang/tools/clang-pseudo/ClangPseud

[PATCH] D120159: [Clang] Implement __builtin_source_location.

jyknight updated this revision to Diff 412087. jyknight marked an inline comment as done. jyknight added a comment. Fix and test __impl lookup within the definition of std::source_location. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120159/new/

[clang] 8f4ea36 - [clang] Improve laziness of resolving module map headers.

Author: Adam Czachorowski Date: 2022-03-01T15:56:23+01:00 New Revision: 8f4ea36bfe4caf7d08f9778ee2a347b78f02bc0f URL: https://github.com/llvm/llvm-project/commit/8f4ea36bfe4caf7d08f9778ee2a347b78f02bc0f DIFF: https://github.com/llvm/llvm-project/commit/8f4ea36bfe4caf7d08f9778ee2a347b78f02bc0f.d

[PATCH] D120569: [clang] Improve laziness of resolving module map headers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f4ea36bfe4c: [clang] Improve laziness of resolving module map headers. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne created this revision. Herald added a subscriber: arichardson. ldionne requested review of this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. This patch overhauls how we pick up the ABI library. Inste

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. Fix one nit and ship Comment at: clang-tools-extra/clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp:74 + PrintingPolicyWithSupressedTag.P

[PATCH] D120132: [HIP] Fix HIP include path

yaxunl added a comment. In D120132#3350020 , @tra wrote: > In D120132#3349936 , @yaxunl wrote: > >> Users may use clang driver to compile HIP program and C++ program with one >> clang driver invocation, e.g. >> >

[PATCH] D120712: [clang-format][docs] handle explicit enum values

kwk added a comment. In D120712#3351014 , @MyDeveloperDay wrote: > I'm not quite sure how I feel about adding functionality that doesn't > actually do anything. I hear you. My reasoning was that I'm going to introduce an explicit enum value sometime s

[PATCH] D120729: Promote addInstantiatedParametersToScope to a private Sema function

erichkeane created this revision. erichkeane added a reviewer: aaron.ballman. erichkeane requested review of this revision. This is used a few places in SemaTeplateInstantiateDecl, but is going to be useful in SemaConcept.cpp as well. This patch switches it to be a private function in Sema. http

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a testing nit, this LGTM! Comment at: clang/include/clang/Basic/CharInfo.h:199-200 +return "\\t"; + case '\v': +return "\\v"; + } -

[PATCH] D120712: [clang-format][docs] handle explicit enum values

kwk added inline comments. Comment at: clang/docs/tools/dump_format_style.py:174-175 return '* ``%s`` (in configuration: ``%s``)\n%s' % ( -self.name, -re.sub('.*_', '', self.config), +self.clean_name, +self.clean_config, doxygen2rst(i

[clang-tools-extra] ac616fb - [Clang-tidy] Check the existence of ElaboratedType's qualifiers

Author: Jun Zhang Date: 2022-03-01T23:52:44+08:00 New Revision: ac616fbb05b8c0e8f85144d54d5295d2d663c5b7 URL: https://github.com/llvm/llvm-project/commit/ac616fbb05b8c0e8f85144d54d5295d2d663c5b7 DIFF: https://github.com/llvm/llvm-project/commit/ac616fbb05b8c0e8f85144d54d5295d2d663c5b7.diff LOG

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rGac616fbb05b8: [Clang-tidy] Check the existence of ElaboratedType's qualifiers (authored by junaire). Changed prior to commit: https://reviews.llvm.org/D119949?vs=409511&id=412111#toc Repository: rG L

[PATCH] D120646: [clang][scan-build] Change mode of installation for scan-build.1

manas updated this revision to Diff 412112. manas added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120646/new/ https://reviews.llvm.org/D120646 Files: clang/tools/scan-build/CMakeLists.txt Index: clang/tools/scan-build/CMa

[PATCH] D120646: [clang][scan-build] Change mode of installation for scan-build.1

manas added a comment. I rebased to see if it satisfies the buildbot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120646/new/ https://reviews.llvm.org/D120646 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D119876: [nfc][codegen] Move RegisterBank[Info].h under CodeGen

mtrofin added a comment. As this is a follow-up of a refactoring, I assume I can just land it (short of file header comments, there was nothing really this patch did more intelligently) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119876/new/ ht

[clang] 32ac21d - [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs

Author: Kristóf Umann Date: 2022-03-01T17:13:04+01:00 New Revision: 32ac21d04909da0d50d3b24100d5d9ab30b29a95 URL: https://github.com/llvm/llvm-project/commit/32ac21d04909da0d50d3b24100d5d9ab30b29a95 DIFF: https://github.com/llvm/llvm-project/commit/32ac21d04909da0d50d3b24100d5d9ab30b29a95.diff

[PATCH] D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32ac21d04909: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs (authored by Szelethus). Repository: rG LLVM Github Monorepo CH

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:377 + if (Access == AccessKind::read) { +if (StInBound->getSVal(ER).isUndef()) { + emitUninitializedReadBug(C, StInBound, Buffer.Expression); You should mak

[PATCH] D120729: [NFC] Promote addInstantiatedParametersToScope to a private Sema function

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120729/new/ https://reviews.llvm.org/D120729 ___ cfe-commits mailing lis

[clang] c601377 - [NFC]Promote addInstantiatedParametersToScope to a private Sema function

Author: Erich Keane Date: 2022-03-01T08:31:51-08:00 New Revision: c601377b23767ede02fe5bbe880c05d420b53250 URL: https://github.com/llvm/llvm-project/commit/c601377b23767ede02fe5bbe880c05d420b53250 DIFF: https://github.com/llvm/llvm-project/commit/c601377b23767ede02fe5bbe880c05d420b53250.diff L

[PATCH] D120729: [NFC] Promote addInstantiatedParametersToScope to a private Sema function

This revision was automatically updated to reflect the committed changes. Closed by commit rGc601377b2376: [NFC]Promote addInstantiatedParametersToScope to a private Sema function (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D120404: [NFC][Lexer] Remove getLangOpts function from Lexer

yurai007 updated this revision to Diff 412120. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120404/new/ https://reviews.llvm.org/D120404 Files: clang/include/clang/Lex/Lexer.h clang/lib/Lex/Lexer.cpp clang/lib/Lex/ModuleMap.cpp Index: clang

[PATCH] D120404: [NFC][Lexer] Remove getLangOpts function from Lexer

yurai007 added a comment. Rebased to https://reviews.llvm.org/D120334 and simplified by removing non-static Lexer::getSpelling function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120404/new/ https://reviews.llvm.org/D120404 __

[PATCH] D120498: [AST] Test RecursiveASTVisitor's current traversal of templates.

sammccall added a comment. Thought about this some more, and talked to @hokein offline. I want to make sure there's consensus on "desired behavior" before documenting it, to avoid too much confusion. https://discourse.llvm.org/t/template-representation-in-ast-and-rav-with-explicit-instantiations

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:41 + /// + /// `Slvr` must not be null. + DataflowAnalysisContext(std::unique_ptr

[PATCH] D119816: [SanitizerBounds] Add support for NoSanitizeBounds function

ztong0001 added a comment. Hi Marco, @melver, Could you please help me landing it? I don't have write permission to the repo. Please use Tong Zhang Thanks, Tong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119816/new/ https://reviews.llvm.org/D1

[PATCH] D119876: [nfc][codegen] Move RegisterBank[Info].h under CodeGen

myhsu accepted this revision. myhsu added a comment. This revision is now accepted and ready to land. since D119053 was accepted, I don't see any reason why this patch shouldn't be :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D119876: [nfc][codegen] Move RegisterBank[Info].h under CodeGen

myhsu added inline comments. Comment at: llvm/lib/Target/ARM/ARMTargetMachine.cpp:43 #include "llvm/Pass.h" +#include "llvm/Support/ARMTargetParser.h" #include "llvm/Support/CodeGen.h" Hmm...did you use clang-format-diff.py? I wonder why this was changed (altho

[PATCH] D120132: [HIP] Fix HIP include path

tra added a comment. In D120132#3351391 , @yaxunl wrote: > > If any input file is HIP program, clang driver will use HIP offload kind for > all inputs. This behavior is similar as cuda-clang. I do not think this is the case as illustrated by the exa

[PATCH] D119816: [SanitizerBounds] Add support for NoSanitizeBounds function

melver added a comment. In D119816#3349076 , @ztong0001 wrote: > Hi Marco, > @melver, Could you please help me landing it? I don't have write permission > to the repo. > Please use Tong Zhang Sure. I had already applied the patch locally to test, but th

[clang] 17ce89f - [SanitizerBounds] Add support for NoSanitizeBounds function

Author: Tong Zhang Date: 2022-03-01T18:47:02+01:00 New Revision: 17ce89fa8016758be2ec879c5560e506cad4c362 URL: https://github.com/llvm/llvm-project/commit/17ce89fa8016758be2ec879c5560e506cad4c362 DIFF: https://github.com/llvm/llvm-project/commit/17ce89fa8016758be2ec879c5560e506cad4c362.diff LO

[PATCH] D119816: [SanitizerBounds] Add support for NoSanitizeBounds function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17ce89fa8016: [SanitizerBounds] Add support for NoSanitizeBounds function (authored by ztong0001, committed by melver). Changed prior to commit: h

[PATCH] D120712: [clang-format][docs] handle explicit enum values

MyDeveloperDay added a comment. > My reasoning was that I'm going to introduce an explicit enum value Any reason why? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120712/new/ https://reviews.llvm.org/D120712 _

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:41 + /// + /// `Slvr` must not be null. + DataflowAnalysisContext(std::unique_ptr Slvr) ymandel wrote: > I think `S` would be easier to read. I

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

flx added a comment. I'm still seeing build failures. Could you resolve them? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116593/new/ https://reviews.llvm.org/D116593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D120712: [clang-format][docs] handle explicit enum values

MyDeveloperDay added inline comments. Comment at: clang/docs/tools/dump_format_style.py:174-175 return '* ``%s`` (in configuration: ``%s``)\n%s' % ( -self.name, -re.sub('.*_', '', self.config), +self.clean_name, +self.clean_config, do

[PATCH] D120712: [clang-format][docs] handle explicit enum values

kwk added a comment. In D120712#3351889 , @MyDeveloperDay wrote: >> My reasoning was that I'm going to introduce an explicit enum value > > Any reason why? Yes, I but where's the fun if I told you now ;) . Just kidding. I don't want to go into the deta

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

MyDeveloperDay added a comment. Before this lands can we have a discussion about what clarity this gives us?, because I think it makes the code more unreadable, but surely we are saving just 7x(3 bytes) (the difference between and int and a unsigned char for 7 enums) Is saving 21 bytes valuabl

[PATCH] D120132: [HIP] Fix HIP include path

yaxunl added a comment. In D120132#3351853 , @tra wrote: > In D120132#3351391 , @yaxunl wrote: > >> > > > >> If any input file is HIP program, clang driver will use HIP offload kind for >> all inputs. This behav

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

Quuxplusone added a comment. In D120398#3351998 , @MyDeveloperDay wrote: > Before this lands can we have a discussion about what clarity this gives us?, > because I think it makes the code more unreadable, but surely we are saving > just 7x(3 bytes) (t

[PATCH] D120712: [clang-format][docs] handle explicit enum values

MyDeveloperDay added subscribers: HazardyKnusperkeks, owenpan, curdeius. MyDeveloperDay added a comment. Does it need to be so "cloak and dagger"? ;-) We always welcome patches, but please think about logging the idea in github issues (and assigning it to yourself), and use the good will of the

[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

tra added a comment. In D117887#3351257 , @jchlanda wrote: > @tra thank you for landing the patches, it seems that the clang part (builtin > declarations and tests) have been dropped, only `llvm` dir changes made it > through. Is there any way I could f

[PATCH] D118525: [modules] Merge ObjC interface ivars with anonymous types.

rsmith added a comment. The modules side of this looks good to me, and logically changing the lexical decl context in an interface to be that interface makes a lot of sense, but I agree with @rjmccall that it's hard to predict what the consequences of that change might be. Can you also test thi

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

sgatev updated this revision to Diff 412160. sgatev marked 8 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120711/new/ https://reviews.llvm.org/D120711 Files: clang/in

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:41 + /// + /// `Slvr` must not be null. + DataflowAnalysisContext(std::unique_ptr Slvr) xazax.hun wrote: > ymandel wrote: > > I think `S` would be

[PATCH] D119876: [nfc][codegen] Move RegisterBank[Info].h under CodeGen

mtrofin marked an inline comment as done. mtrofin added inline comments. Comment at: llvm/lib/Target/ARM/ARMTargetMachine.cpp:43 #include "llvm/Pass.h" +#include "llvm/Support/ARMTargetParser.h" #include "llvm/Support/CodeGen.h" myhsu wrote: > Hmm...did you use

[PATCH] D120437: [HWASAN] erase lifetime intrinsics if tag is outside.

fmayer added inline comments. Comment at: clang/test/CodeGen/lifetime-sanitizer.c:9 +// RUN: %clang -target aarch64-linux-gnu -S -emit-llvm -o /dev/null -O0 \ +// RUN: -fsanitize=hwaddress -mllvm -print-before=hwasan %s 2>&1 | \ // RUN: FileCheck %s -check-prefix=LIFETIM

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

MyDeveloperDay added a comment. In my own area I gave FormatStyle a copy constructor and made it private, it hardly caused any issues, this isn't something that we tend copy about very much, we tend copy construct it only when we do getLLVMStyle() to make another style say like google style sur

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

sgatev updated this revision to Diff 412162. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120711/new/ https://reviews.llvm.org/D120711 Files: clang/include/clang/Analysis/FlowSensitive/Datafl

[PATCH] D120437: [HWASAN] erase lifetime intrinsics if tag is outside.

eugenis added inline comments. Comment at: clang/test/CodeGen/lifetime-sanitizer.c:9 +// RUN: %clang -target aarch64-linux-gnu -S -emit-llvm -o /dev/null -O0 \ +// RUN: -fsanitize=hwaddress -mllvm -print-before=hwasan %s 2>&1 | \ // RUN: FileCheck %s -check-prefix=LIFETI

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp:43 + + auto Res = ConjunctionVals.try_emplace( + std::move(Key), As far as I understand, we need to do the double loo

[clang] 7a6d692 - [NVPTX] Expose float tys min, max, abs, neg as builtins

Author: Jakub Chlanda Date: 2022-03-01T11:07:11-08:00 New Revision: 7a6d692b3b11e80fd19e7c9b65e1e6f70035c676 URL: https://github.com/llvm/llvm-project/commit/7a6d692b3b11e80fd19e7c9b65e1e6f70035c676 DIFF: https://github.com/llvm/llvm-project/commit/7a6d692b3b11e80fd19e7c9b65e1e6f70035c676.diff

[clang] a895182 - [NVPTX] Add more FMA intriniscs/builtins

Author: Jakub Chlanda Date: 2022-03-01T11:07:11-08:00 New Revision: a8951823024b38c455e839d40656ad533b4aa8ff URL: https://github.com/llvm/llvm-project/commit/a8951823024b38c455e839d40656ad533b4aa8ff DIFF: https://github.com/llvm/llvm-project/commit/a8951823024b38c455e839d40656ad533b4aa8ff.diff

[clang] 510fd28 - [NVPTX] Add ex2.approx.f16/f16x2 support

Author: Nicolas Miller Date: 2022-03-01T11:07:11-08:00 New Revision: 510fd283fda2d7c5118ae1b451a1f2365cfc3f27 URL: https://github.com/llvm/llvm-project/commit/510fd283fda2d7c5118ae1b451a1f2365cfc3f27 DIFF: https://github.com/llvm/llvm-project/commit/510fd283fda2d7c5118ae1b451a1f2365cfc3f27.diff

  1   2   >