kwk added a comment.

In D120712#3351014 <https://reviews.llvm.org/D120712#3351014>, @MyDeveloperDay 
wrote:

> I'm not quite sure how I feel about adding functionality that doesn't 
> actually do anything.

I hear you. My reasoning was that I'm going to introduce an explicit enum value 
sometime soon and when I have that value and this patch in one together with 
the added logic it would be harder to review. Whereas with my upcoming changes 
I'm simply updating the `clang/docs/ClangFormatStyleOptions.rst` by 
regenerating it with this script and you can just approve it. Essentially I 
want to make the review process as easy as it could be.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120712/new/

https://reviews.llvm.org/D120712

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to