[PATCH] D118893: [C++20][Modules] Track valid import state.

iains created this revision. iains updated this revision to Diff 408755. iains added a comment. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains updated this revision to Diff 408803. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-com

[PATCH] D114714: [C++20][Modules] Add enumerations for partition modules and stream them.

iains created this revision. Herald added a subscriber: dexonsmith. iains updated this revision to Diff 404447. iains added a comment. iains retitled this revision from "[modules] Add enumerations for partition modules and stream them." to "[C++20][Modules] Add enumerations for partition modules

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

aprantl created this revision. aprantl added reviewers: dexonsmith, arphaman. aprantl requested review of this revision. This patch adds a new Darwin clang driver environment variable in the spirit of RC_DEBUG_OPTIONS, called RC_DEBUG_PREFIX_MAP, which allows a meta build tool to add one additio

[PATCH] D118586: [C++20][Modules] Initial handling for module partitions.

iains created this revision. iains updated this revision to Diff 405588. iains added a comment. iains updated this revision to Diff 405590. iains updated this revision to Diff 408760. iains updated this revision to Diff 408855. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains published thi

[PATCH] D118587: [C++20][Modules] Handle generation of partition implementation CMIs.

iains created this revision. iains updated this revision to Diff 405593. iains added a comment. iains updated this revision to Diff 408762. iains updated this revision to Diff 408862. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains published this revision for review. Herald added a projec

[PATCH] D118588: [C++20][Modules] Diagnose wrong import/export for partition CMIs.

iains created this revision. iains updated this revision to Diff 404484. iains added a comment. iains updated this revision to Diff 405594. iains updated this revision to Diff 405595. iains updated this revision to Diff 408763. iains updated this revision to Diff 408864. iains added reviewers: rsmi

[PATCH] D118589: [C++20][Modules] Record direct module imports.

iains created this revision. iains updated this revision to Diff 404485. iains added a comment. iains updated this revision to Diff 405596. iains updated this revision to Diff 408764. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains published this revision for review. Herald added a projec

[PATCH] D118598: [C++20][Modules] Find the primary interface name for a module.

iains created this revision. Herald added a subscriber: dexonsmith. iains updated this revision to Diff 405600. iains added a comment. iains updated this revision to Diff 408765. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains published this revision for review. Herald added a project: cl

[clang] d1e3235 - [libTooling] Change Tranformer's consumer to take multiple changes

Author: Eric Li Date: 2022-02-15T16:34:36Z New Revision: d1e3235f604d65a62d25842305f54e43bd36681f URL: https://github.com/llvm/llvm-project/commit/d1e3235f604d65a62d25842305f54e43bd36681f DIFF: https://github.com/llvm/llvm-project/commit/d1e3235f604d65a62d25842305f54e43bd36681f.diff LOG: [libT

[PATCH] D119745: [libTooling] Change Tranformer's consumer to take multiple changes

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1e3235f604d: [libTooling] Change Tranformer's consumer to take multiple changes (authored by li.zhe.hua, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D119095: [clang] Fix redundant functional cast in ConstantExpr

kimgr added a comment. Thanks for the heads-up! I'm a little busy this week, but I need to think about potential interference between these two changes. Off the top of my head it looks like they should get along fine, but there may be subtleties. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D118599: [C++20][Modules] Amend module visibility rules for partitions.

iains created this revision. iains updated this revision to Diff 405601. iains added a comment. iains updated this revision to Diff 408766. iains updated this revision to Diff 408866. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains updated this revision to Diff 408892. iains published thi

[PATCH] D119613: [OpenMP] Add support for CPU offloading in new driver

jhuber6 updated this revision to Diff 408904. jhuber6 added a comment. Add test for the arguments passed to the linker wrapper when doing host offloading. It will be more difficult to do a unit test for the internal operation of the linker wrapper because it is reactive to the data contained in th

[clang] e21db15 - [clang-format] Honour PointerAlignment in statements with initializers.

Author: Marek Kurdej Date: 2022-02-15T18:06:32+01:00 New Revision: e21db15be8126004304b813e5ff87c7ecbed06bf URL: https://github.com/llvm/llvm-project/commit/e21db15be8126004304b813e5ff87c7ecbed06bf DIFF: https://github.com/llvm/llvm-project/commit/e21db15be8126004304b813e5ff87c7ecbed06bf.diff

[PATCH] D119814: [clang-format] Honour PointerAlignment in statements with initializers.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe21db15be812: [clang-format] Honour PointerAlignment in statements with initializers. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

arphaman added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:686 +return; + if (!StringRef(GlobalRemapEntry).contains('=')) +D.Diag(diag::err_drv_invalid_argument_to_option) Suggestion: It might be good to factor out the code that ve

[PATCH] D119785: [clang-format] Fix formatting of struct-like records followed by variable declaration.

curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:735 // We don't merge short records. -FormatToken *RecordTok = Line.First; -// Skip record modifiers. -while (RecordTok->Next && - RecordTok->isO

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman updated this revision to Diff 408928. dgoldman marked an inline comment as done. dgoldman added a comment. Add tests and public accessors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119363/new/ https://reviews.llvm.org/D119363 Files:

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman added inline comments. Comment at: clang/include/clang/AST/TypeLoc.h:2621 + /// Evaluates true when this protocol loc is valid/non-empty. + explicit operator bool() const { return Protocol; } +}; sammccall wrote: > will we ever have invalid instances?

[PATCH] D119823: [Modules] Add module structure output to -module-file-info.

iains updated this revision to Diff 408930. iains added a comment. address review comment, fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119823/new/ https://reviews.llvm.org/D119823 Files: clang/lib/Frontend/FrontendActions.cpp

[PATCH] D119858: [OpenCL] Guard 64-bit atomic types

svenvh created this revision. svenvh added reviewers: Anastasia, haonanya. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Until now, overloads with a 64-bit atomic type argument we

[clang-tools-extra] d7b1c84 - [clangd][NFC] includes missing headers

Author: Christopher Di Bella Date: 2022-02-15T17:44:47Z New Revision: d7b1c840ba4e1f8c04fe1c5455242629893c7e3a URL: https://github.com/llvm/llvm-project/commit/d7b1c840ba4e1f8c04fe1c5455242629893c7e3a DIFF: https://github.com/llvm/llvm-project/commit/d7b1c840ba4e1f8c04fe1c5455242629893c7e3a.dif

[PATCH] D119806: [clangd][NFC] includes missing headers

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7b1c840ba4e: [clangd][NFC] includes missing headers (authored by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119806/new/ https://reviews.llvm.org/

[PATCH] D119366: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support

dgoldman updated this revision to Diff 408937. dgoldman added a comment. Rebase on top of latest ProtocolLoc changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119366/new/ https://reviews.llvm.org/D119366 Files: clang-tools-extra/clangd/FindT

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman added a comment. PTAL, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119363/new/ https://reviews.llvm.org/D119363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D119613: [OpenMP] Add support for CPU offloading in new driver

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119613/new/ https://reviews.llvm.org/D119613 ___

[PATCH] D119858: [OpenCL] Guard 64-bit atomic types

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! I imagine this is another change to align with `opencl-c.h`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119858/new/ http

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

aprantl updated this revision to Diff 408944. aprantl added a comment. Refactored code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119850/new/ https://reviews.llvm.org/D119850 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

aprantl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:686 +return; + if (!StringRef(GlobalRemapEntry).contains('=')) +D.Diag(diag::err_drv_invalid_argument_to_option) arphaman wrote: > Suggestion: It might be good to factor out

[PATCH] D119858: [OpenCL] Guard 64-bit atomic types

svenvh added a comment. In D119858#3323565 , @Anastasia wrote: > LGTM! Thanks! > > I imagine this is another change to align with `opencl-c.h`? Yes. This addresses the issue of D119398 for tablegen (although the proble

[PATCH] D102614: [index] Add support for type of pointers to class members

akyrtzi added a comment. > What do you think about this patch? Can it be landed now? Or I should debug > the crash in the Windows version detected with the previous version of my > patch. Is your change introducing the crash or is the crash triggered with the test file without your changes as

[PATCH] D118753: [PowerPC] Fix __builtin_pdepd and __builtin_pextd to be 64-bit and P10 only.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5dc0a1657be1: [PowerPC] Fix __builtin_pdepd and __builtin_pextd to be 64-bit and P10 only. (authored by amyk). Repository: rG LLVM Github Monorepo

[clang] 5dc0a16 - [PowerPC] Fix __builtin_pdepd and __builtin_pextd to be 64-bit and P10 only.

Author: Amy Kwan Date: 2022-02-15T12:30:50-06:00 New Revision: 5dc0a1657be14df68bfc33deb2fb75476acdaec8 URL: https://github.com/llvm/llvm-project/commit/5dc0a1657be14df68bfc33deb2fb75476acdaec8 DIFF: https://github.com/llvm/llvm-project/commit/5dc0a1657be14df68bfc33deb2fb75476acdaec8.diff LOG:

[PATCH] D117989: [RISCV] Add the passthru operand for RVV nomask binary intrinsics.

craig.topper added a comment. LGTM other than what I think is an unnecessary include. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:15 #include "RISCVISelLowering.h" +#include "MCTargetDesc/RISCVBaseInfo.h" #include "MCTargetDesc/RISCVMatInt.h" This

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

sammccall added a comment. I'm a bit concerned about the parent map vs ASTMatchFinder's view being out of sync: we'll have a ProtocolLoc node that has a parent but the parent doesn't have the child. I'm not sure this breaks anything immediately, but I think we should also make these nodes visi

[PATCH] D118893: [C++20][Modules] Track valid import state.

urnathan added a comment. Looks right to me -- I also implemented such a state machine in GCC's parser. There are a bunch of formatting issues to fix of course. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1543 +def err_import_not_allowed_here : Error< + "im

[PATCH] D114714: [C++20][Modules] Add enumerations for partition modules and stream them.

urnathan added inline comments. Comment at: clang/include/clang/Basic/Module.h:109 -/// This is a C++ Modules TS module interface unit. +/// This is a C++ Modules TS or C++20 module interface unit. ModuleInterfaceUnit, I think it's confusing to con

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman updated this revision to Diff 408970. dgoldman marked 4 inline comments as done. dgoldman added a comment. Template and variable casing fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119363/new/ https://reviews.llvm.org/D119363 Files

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman added a comment. In D119363#3323778 , @sammccall wrote: > I'm a bit concerned about the parent map vs ASTMatchFinder's view being out > of sync: we'll have a ProtocolLoc node that has a parent but the parent > doesn't have the child. > > I'm no

[PATCH] D119785: [clang-format] Fix formatting of struct-like records followed by variable declaration.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:735 // We don't merge short records. -FormatToken *RecordTok = Line.First; -// Skip record modifiers. -while (RecordTok->Next && - Reco

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

sammccall added a comment. In D119363#3323867 , @dgoldman wrote: > In D119363#3323778 , @sammccall > wrote: > >> I'm a bit concerned about the parent map vs ASTMatchFinder's view being out >> of sync: we'll have

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

jdoerfert added a subscriber: arsenm. jdoerfert added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8195 + // Get the AMDGPU math libraries. + // FIXME: This method is bad, remove once AMDGPU has a proper math library. + for (auto &I : llvm::make_range(Ope

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8195 + // Get the AMDGPU math libraries. + // FIXME: This method is bad, remove once AMDGPU has a proper math library. + for (auto &I : llvm::make_range(OpenMPTCRange.first, OpenMPTCRange.second))

[PATCH] D119876: [nfc][codegen] Move RegisterBank[Info].h under CodeGen

mtrofin created this revision. mtrofin added a reviewer: qcolombet. Herald added subscribers: foad, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, niosHD, sabu

[clang] 1ea3266 - DebugInfo: Don't simplify template names using _BitInt(N)

Author: David Blaikie Date: 2022-02-15T11:58:40-08:00 New Revision: 1ea326634b582f5574e0b22b85e5b0c631b30dcf URL: https://github.com/llvm/llvm-project/commit/1ea326634b582f5574e0b22b85e5b0c631b30dcf DIFF: https://github.com/llvm/llvm-project/commit/1ea326634b582f5574e0b22b85e5b0c631b30dcf.diff

[PATCH] D119876: [nfc][codegen] Move RegisterBank[Info].h under CodeGen

mtrofin added inline comments. Comment at: llvm/include/llvm/CodeGen/RegisterBankInfo.h:220 : ID(ID), Cost(Cost), OperandsMapping(OperandsMapping), - NumOperands(NumOperands) { -} + NumOperands(NumOperands) {} ah - `clang-format`

[PATCH] D118893: [C++20][Modules] Track valid import state.

iains added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1543 +def err_import_not_allowed_here : Error< + "imports must be contiguous and immediately follow the module declaration">; +def err_import_in_global_fragment : Error< u

[clang] 24ecafb - [OpenMP] Add support for CPU offloading in new driver

Author: Joseph Huber Date: 2022-02-15T15:05:30-05:00 New Revision: 24ecafb4132704db513d550f2edfe875d353287f URL: https://github.com/llvm/llvm-project/commit/24ecafb4132704db513d550f2edfe875d353287f DIFF: https://github.com/llvm/llvm-project/commit/24ecafb4132704db513d550f2edfe875d353287f.diff

[PATCH] D119613: [OpenMP] Add support for CPU offloading in new driver

This revision was automatically updated to reflect the committed changes. Closed by commit rG24ecafb41327: [OpenMP] Add support for CPU offloading in new driver (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119613/new/ https:/

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

Izaron updated this revision to Diff 408999. Izaron added a comment. Fix Scope::dumpImpl with more precise log Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119792/new/ https://reviews.llvm.org/D119792 Files: clang/include/clang/Sema/Scope.h c

[clang] 73b2293 - [CUDA][HIP] Do not promote constexpr var with non-constant initializer

Author: Yaxun (Sam) Liu Date: 2022-02-15T15:15:55-05:00 New Revision: 73b22935a7a863679021598db6a45fcfb62cd321 URL: https://github.com/llvm/llvm-project/commit/73b22935a7a863679021598db6a45fcfb62cd321 DIFF: https://github.com/llvm/llvm-project/commit/73b22935a7a863679021598db6a45fcfb62cd321.dif

[PATCH] D119615: [CUDA][HIP] Do not promote constexpr var with non-constant initializer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG73b22935a7a8: [CUDA][HIP] Do not promote constexpr var with non-constant initializer (authored by yaxunl). H

[PATCH] D118893: [C++20][Modules] Track valid import state.

urnathan added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1543 +def err_import_not_allowed_here : Error< + "imports must be contiguous and immediately follow the module declaration">; +def err_import_in_global_fragment : Error< ---

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman updated this revision to Diff 409005. dgoldman marked 3 inline comments as done. dgoldman added a comment. Template fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119363/new/ https://reviews.llvm.org/D119363 Files: clang/include/cl

[PATCH] D114714: [C++20][Modules] Add enumerations for partition modules and stream them.

iains added inline comments. Comment at: clang/include/clang/Basic/Module.h:109 -/// This is a C++ Modules TS module interface unit. +/// This is a C++ Modules TS or C++20 module interface unit. ModuleInterfaceUnit, urnathan wrote: > I think it's c

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman added a comment. In D119363#3324024 , @sammccall wrote: > In D119363#3323867 , @dgoldman > wrote: > >> In D119363#3323778 , @sammccall >> wrote: >> >>> I'm a bi

[PATCH] D114714: [C++20][Modules] Add enumerations for partition modules and stream them.

urnathan added inline comments. Comment at: clang/include/clang/Basic/Module.h:109 -/// This is a C++ Modules TS module interface unit. +/// This is a C++ Modules TS or C++20 module interface unit. ModuleInterfaceUnit, iains wrote: > urnathan wrote

[clang] bcd1e46 - [clang-format] Further improve support for requires expressions

Author: Björn Schäpers Date: 2022-02-15T21:37:35+01:00 New Revision: bcd1e4612f4fa2d12a51f0708c619ae3b2deaa2b URL: https://github.com/llvm/llvm-project/commit/bcd1e4612f4fa2d12a51f0708c619ae3b2deaa2b DIFF: https://github.com/llvm/llvm-project/commit/bcd1e4612f4fa2d12a51f0708c619ae3b2deaa2b.diff

[clang] b786a4a - [clang-format] Extend SpaceBeforeParens for requires

Author: Björn Schäpers Date: 2022-02-15T21:37:36+01:00 New Revision: b786a4aefedaf68eb7710d9c01a18ad1d0c820b7 URL: https://github.com/llvm/llvm-project/commit/b786a4aefedaf68eb7710d9c01a18ad1d0c820b7 DIFF: https://github.com/llvm/llvm-project/commit/b786a4aefedaf68eb7710d9c01a18ad1d0c820b7.diff

[clang] 8da319f - [clang-format][NFC] Give State.Stack.back() a meaningful name

Author: Björn Schäpers Date: 2022-02-15T21:37:38+01:00 New Revision: 8da319fe770b21d342a534bf02d2b88fffe667cc URL: https://github.com/llvm/llvm-project/commit/8da319fe770b21d342a534bf02d2b88fffe667cc DIFF: https://github.com/llvm/llvm-project/commit/8da319fe770b21d342a534bf02d2b88fffe667cc.diff

[PATCH] D119138: [clang-format] Further improve support for requires expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGbcd1e4612f4f: [clang-format] Further improve support for requires expressions (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb786a4aefeda: [clang-format] Extend SpaceBeforeParens for requires (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm

[PATCH] D119597: [clang-format][NFC] Give State.Stack.back() a meaningful name

This revision was automatically updated to reflect the committed changes. Closed by commit rG8da319fe770b: [clang-format][NFC] Give State.Stack.back() a meaningful name (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

Quuxplusone added a reviewer: mizvekov. Quuxplusone added a comment. The code is above my pay grade, but FWIW, I super support the intent of this patch! Let's get p2025 support into Clang! :) > The collection of common cases contains 20 examples: §4.1. Examples. Here is > the current status of

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10322 ABIArgInfo SPIRVABIInfo::classifyKernelArgumentType(QualType Ty) const { - if (getContext().getLangOpts().HIP) { + if (getContext().getLangOpts().CUDAIsDevice) { // Coerce pointer arguments w

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen added a comment. In D118428#3312621 , @ychen wrote: > In D118428#3312440 , @paulkirth > wrote: > >> Hi, >> >> We have two failing test cases on Fuchsia's clang canary builder on Windows >> x64. >> >> LLVM

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

JonChesterfield added a comment. I'm not confident it's only attributes that we rely on mlink-builtin-bitcode patching up, that could be poor phrasing on my part. Making the pipeline robust to underspecified IR input may be easier (and arguably more useful) than changing the rocm library to be

[PATCH] D119651: [clang] Fix evaluation context type for consteval function calls in instantiations

Izaron updated this revision to Diff 409035. Izaron added a comment. I've added an assert that will prevent similar bugs. Let's look if we're good with this one? Here is the list of eval contexts: https://github.com/llvm/llvm-project/blob/87b218b42b14e392aa0363a413d440b77bf04bd4/clang/include/cla

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

Izaron added a comment. In D119792#3324354 , @Quuxplusone wrote: > I think it would be an extremely good idea to commit all 20 of these test > cases to clang/test/CodeGenCXX/, with their current behavior, as a > preliminary patch. Then, D119792

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

jdoerfert added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8205 +if (llvm::find(LibraryArgs, "m") == LibraryArgs.end() && !D.CCCIsCXX()) + continue; + JonChesterfield wrote: > jhuber6 wrote: > > jdoerfert wrote: > > > I'd switch t

[PATCH] D119841: [OpenMP] Pass AMDGPU math libraries into the linker wrapper

jhuber6 updated this revision to Diff 409043. jhuber6 added a comment. Removing `-lm` semantics so it is linked by default. Also adding the flag to the tested output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119841/new/ https://reviews.llvm.or

[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

aeubanks abandoned this revision. aeubanks added a comment. I posted an RFC a while back for basically removing size levels from optimization levels but never seriously looked into it: https://groups.google.com/g/llvm-dev/c/NrZsR8OZTts/m/P5t14TKaAQAJ Repository: rG LLVM Github Monorepo CHAN

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting updated this revision to Diff 409046. pkasting added a comment. Fix test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 Files: clang/docs/tools/clang-formatted-files.txt clang/lib/D

[clang] 4bafe65 - Add support for floating-point option `ffp-eval-method` and for

Author: Zahira Ammarguellat Date: 2022-02-15T13:59:27-08:00 New Revision: 4bafe65c2b2f1ce745894a509a6d80c87fb1c335 URL: https://github.com/llvm/llvm-project/commit/4bafe65c2b2f1ce745894a509a6d80c87fb1c335 DIFF: https://github.com/llvm/llvm-project/commit/4bafe65c2b2f1ce745894a509a6d80c87fb1c335

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. Ping @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, curdeius, MyDeveloperDay, JohelEGP. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D119178: Add support for generating debug-info for structured bindings of structs and arrays

shafik updated this revision to Diff 409056. shafik marked 5 inline comments as done. shafik added a comment. Addressed comments on SmallVector size and fixed test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119178/new/ https://reviews.llvm.org/D119178 Files: clang/lib/CodeGen/CGD

[PATCH] D119178: Add support for generating debug-info for structured bindings of structs and arrays

shafik added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4647 +const bool UsePointerValue) { + assert(CGM.getCodeGenOpts().hasReducedDebugInfo()); + assert(!LexicalBlockStack.empty() && "Region stack mismatch, s

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

sylvestre.ledru added a comment. Could you please stop with the pings? and chat directly ? (It seems that you are colleagues?!) I would like to follow what is happening here but not get flooded. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663

Re: [clang] 4bafe65 - Add support for floating-point option `ffp-eval-method` and for

Where was this reviewed? On Wed, Feb 16, 2022 at 12:59 AM Zahira Ammarguellat via cfe-commits wrote: > > > Author: Zahira Ammarguellat > Date: 2022-02-15T13:59:27-08:00 > New Revision: 4bafe65c2b2f1ce745894a509a6d80c87fb1c335 > > URL: > https://github.com/llvm/llvm-project/commit/4bafe65c2b2f1ce

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. In D110663#3324598 , @sylvestre.ledru wrote: > Could you please stop with the pings? and chat directly ? (It seems that you > are colleagues?!) > > I would like to follow what is happening here but not get flooded. (I don't min

[PATCH] D119893: [clang-format] Fixed handling of requires clauses followed by attributes

Quuxplusone added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3018-3019 do { +bool LambdaThisTimeAllowed = LambdaNextTimeAllowed; +LambdaNextTimeAllowed = false; + Nit: For this pattern, consider `bool LambdaThisTimeAllowed =

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

lebedev.ri added a comment. I'm personally ignoring this review because quite honestly i was horrified of just how nonchalantly dismissive/accusative the reaction was to the problem i raised during the revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D119184: [clang] [concepts] Check constrained-auto return types for void-returning functions

Quuxplusone updated this revision to Diff 409090. Quuxplusone added a comment. Rebase; fix the clang-format nit; reinsert a missing `FD->setInvalidDecl()` that seemed to be causing crashes in Modules code under libcxx/test/ but otherwise doesn't seem to be tested in clang/test/ :( Repository:

[PATCH] D119778: [clang] Add a note "deducing return type for 'foo'"

Quuxplusone updated this revision to Diff 409095. Quuxplusone added a comment. Rebase; adjust more expected output in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119778/new/ https://reviews.llvm.org/D119778 Files: clang/include/clang/Ba

[PATCH] D119778: [clang] Add a note "deducing return type for 'foo'"

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3805 +if (DAR != DAR_Succeeded) { + if (OrigResultType.getBeginLoc().isValid()) +Diag(OrigResultType.getBeginLoc(), diag::note_deducing_return_type_for) > I am curious abo

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

phosek added a comment. In D110663#3271084 , @MaskRay wrote: > No worries! Thanks for the reply. > > I use Debian and want it to work well and support the > `-DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on` direction. > Currently, `-DLLVM_DEFAULT_TARGET_TRIPLE=a

[PATCH] D119778: [clang] Add a note "deducing return type for 'foo'"

rsmith added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3804-3809 +if (DAR != DAR_Succeeded) { + if (OrigResultType.getBeginLoc().isValid()) +Diag(OrigResultType.getBeginLoc(), diag::note_deducing_return_type_for) +<< FD << OrigResultTyp

[clang] 13b6f31 - Fix crash when deserializing a lambda expression in a decltype.

Author: Richard Smith Date: 2022-02-15T17:56:45-08:00 New Revision: 13b6f31548784452990da6dba555af8d7a061958 URL: https://github.com/llvm/llvm-project/commit/13b6f31548784452990da6dba555af8d7a061958 DIFF: https://github.com/llvm/llvm-project/commit/13b6f31548784452990da6dba555af8d7a061958.diff

[PATCH] D117087: [C++20] [Coroutines] Implement return value optimization for get_return_object

ChuanqiXu added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:654 +cast(Ret)->setRetValue(nullptr); EmitStmt(Ret); + } junparser wrote: > I mean, remove the if statements here since the retuen expr is null. We couldn't. Since we need em

[PATCH] D119772: [clang] [NFC] More exhaustive tests for deducing void return types

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119772/new/ https://reviews.llvm.org/D119772

[PATCH] D119823: [Modules] Add module structure output to -module-file-info.

ChuanqiXu added inline comments. Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26 + +#if TU == 1 + According to [[ http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p1857r3.html | P1857R3 ]], it might not be good to add macro declarative befor

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen created this revision. ychen added reviewers: hans, rnk, aganea, JDevlieghere, labath. Herald added a subscriber: hiraditya. ychen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The motivation is to enable the MSVC-

[PATCH] D117087: [C++20] [Coroutines] Implement return value optimization for get_return_object

junparser added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:654 +cast(Ret)->setRetValue(nullptr); EmitStmt(Ret); + } ChuanqiXu wrote: > junparser wrote: > > I mean, remove the if statements here since the retuen expr is null. > We cou

[PATCH] D117989: [RISCV] Add the passthru operand for RVV nomask binary intrinsics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7847199044e: [RISCV] Add the passthru operand for RVV nomask binary intrinsics. (authored by khchen). Herald added a subscriber: qcolombet. Changed

[PATCH] D118893: [C++20][Modules] Track valid import state.

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1543 +def err_import_not_allowed_here : Error< + "imports must be contiguous and immediately follow the module declaration">; +def err_import_in_global_fragment : Error< --

[PATCH] D118893: [C++20][Modules] Track valid import state.

ChuanqiXu added a comment. BTW, I guess it would be helpful to add the index in the series in the title. Like `[C++20][Modules] Track valid import state (1/8)`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118893/new/ https://reviews.llvm.org/D11

[clang] 25cdf87 - [NFC] Update new warning to test

Author: Chuanqi Xu Date: 2022-02-16T10:51:56+08:00 New Revision: 25cdf87b13eb990eb84d31211280f4b0d5d470b3 URL: https://github.com/llvm/llvm-project/commit/25cdf87b13eb990eb84d31211280f4b0d5d470b3 DIFF: https://github.com/llvm/llvm-project/commit/25cdf87b13eb990eb84d31211280f4b0d5d470b3.diff LO

[PATCH] D119727: [RISCV] Add the policy operand for nomask vector Multiply-Add IR intrinsics.

monkchiang accepted this revision. monkchiang added a comment. This revision is now accepted and ready to land. LGTM, Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119727/new/ https://reviews.llvm.org/D119727 __

[PATCH] D112094: Add support for floating-point option `ffp-eval-method` and for `pragma clang fp eval_method`.

ChuanqiXu added a comment. Herald added a subscriber: pcwang-thead. It looks this landed without being approved: https://github.com/llvm/llvm-project/commit/4bafe65c2b2f1ce745894a509a6d80c87fb1c335. It broke the test. If we need to revert it, we need to revert https://github.com/llvm/llvm-proje

<    1   2   3   >