aprantl added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:686
+ return;
+ if (!StringRef(GlobalRemapEntry).contains('='))
+ D.Diag(diag::err_drv_invalid_argument_to_option)
----------------
arphaman wrote:
> Suggestion: It might be good to factor out the code that verifies the value
> and either produces an error or adds an argument into some common helper as
> it's used right above this codepath as well.
Good idea! Done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119850/new/
https://reviews.llvm.org/D119850
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
