[PATCH] D118921: [Format] Don't derive pointers right based on space before method ref-qualifiers

sammccall added inline comments. Comment at: clang/lib/Format/Format.cpp:1949 continue; +// Don't treat space in `void foo() &&` as evidence. +if (const auto *Prev = Tok->getPreviousNonComment()) { benhamilton wrote: > Do we also need t

[clang] ca0d970 - [clang-format] Avoid merging macro definitions.

Author: Marek Kurdej Date: 2022-02-03T18:54:46+01:00 New Revision: ca0d97072e79f8d7159c50db616647eeb1b094b8 URL: https://github.com/llvm/llvm-project/commit/ca0d97072e79f8d7159c50db616647eeb1b094b8 DIFF: https://github.com/llvm/llvm-project/commit/ca0d97072e79f8d7159c50db616647eeb1b094b8.diff

[PATCH] D118879: [clang-format] Avoid merging macro definitions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. curdeius marked 2 inline comments as done. Closed by commit rGca0d97072e79: [clang-format] Avoid merging macro definitions. (authored by curdeius). Changed prior to co

[PATCH] D118879: [clang-format] Avoid merging macro definitions.

curdeius added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118879/new/ https://reviews.llvm.org/D118879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D118921: [Format] Don't derive pointers right based on space before method ref-qualifiers

benhamilton accepted this revision. benhamilton added a comment. This revision is now accepted and ready to land. Got it, thanks. Comment at: clang/lib/Format/Format.cpp:1949 continue; +// Don't treat space in `void foo() &&` as evidence. +if (const a

[PATCH] D118924: [clang-format] Fix formatting of macro definitions with a leading comment.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/43206. Repository: rG LLVM

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood added a comment. In D117522#3290604 , @carlosgalvezp wrote: > This will conflict with `Enum.3` from `cppcoreguidelines` I went back and looked at Enum.3 Prefer class enums over “plain” enums

[clang] 28ab594 - [Clang][Docs] Add documention for new OpenMP offloading driver

Author: Joseph Huber Date: 2022-02-03T13:09:49-05:00 New Revision: 28ab5944cd75b790bc6a60ab82e80bc6d4972b63 URL: https://github.com/llvm/llvm-project/commit/28ab5944cd75b790bc6a60ab82e80bc6d4972b63 DIFF: https://github.com/llvm/llvm-project/commit/28ab5944cd75b790bc6a60ab82e80bc6d4972b63.diff

[PATCH] D118815: [Clang][Docs] Add documention for new OpenMP offloading driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28ab5944cd75: [Clang][Docs] Add documention for new OpenMP offloading driver (authored by jhuber6). Changed prior to commit: https://reviews.llvm.

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

Quuxplusone added a comment. In D117603#3292657 , @var-const wrote: > @Quuxplusone Now that it's landed, do we still need `__workaround_52970` in > libc++? (see > https://github.com/llvm/llvm-project/blob/167b623a6af26802af47f455aaa3806faaa9da9e/libcxx/

[PATCH] D118924: [clang-format] Fix formatting of macro definitions with a leading comment.

curdeius updated this revision to Diff 405702. curdeius added a comment. Add a test case. Use bool instead of Previous token. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118924/new/ https://reviews.llvm.org/D118924 Files: clang/lib/Format/Unwr

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 updated this revision to Diff 405703. tianshilei1992 added a comment. refine the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116637/new/ https://reviews.llvm.org/D116637 Files: clang/include/clang/Basic/DiagnosticSemaKinds.

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11027 + if (auto *CS = dyn_cast(Then)) { +if (CS->size() == 0) { + ErrorInfo.Error = ErrorTy::NoStmt; `body_empty()` Comment at: clang/lib/Sema/SemaOpenMP.cpp:11

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

ABataev added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:35 } +// omp50-error@+4 {{unexpected OpenMP clause 'compare' in directive '#pragma omp atomic'}} +// omp50-note@+4 {{expected an expression statement}} ast print tests are usual

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. @ABataev @jdoerfert I got a question about writing the test. `atomic compare` is supported from 5.1. Basically we have three ways to guard those `atomic compare` code: 1. Use macro `_OPENMP`. This pretty much works with one exception: we don't set the macro for

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:35 } +// omp50-error@+4 {{unexpected OpenMP clause 'compare' in directive '#pragma omp atomic'}} +// omp50-note@+4 {{expected an expression statement}} ABataev wrote: > a

[PATCH] D118911: [clang-format] regression from clang-format v13

MyDeveloperDay updated this revision to Diff 405705. MyDeveloperDay added a comment. Simply logic - review comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118911/new/ https://reviews.llvm.org/D118911 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/Forma

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

ABataev added a comment. In D116637#3294361 , @tianshilei1992 wrote: > @ABataev @jdoerfert I got a question about writing the test. `atomic compare` > is supported from 5.1. Basically we have three ways to guard those `atomic > compare` code: > > 1. Us

[PATCH] D118911: [clang-format] regression from clang-format v13

MyDeveloperDay updated this revision to Diff 405708. MyDeveloperDay added a comment. De'Morganed!! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118911/new/ https://reviews.llvm.org/D118911 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp Inde

[clang] 23fc20e - [clang-format] regression from clang-format v13

Author: mydeveloperday Date: 2022-02-03T18:37:43Z New Revision: 23fc20e06c088acff81a06ad546a848bee083051 URL: https://github.com/llvm/llvm-project/commit/23fc20e06c088acff81a06ad546a848bee083051 DIFF: https://github.com/llvm/llvm-project/commit/23fc20e06c088acff81a06ad546a848bee083051.diff LOG

[PATCH] D118911: [clang-format] regression from clang-format v13

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23fc20e06c08: [clang-format] regression from clang-format v13 (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen added a comment. In D118428#3292918 , @hans wrote: > It seems Phabricator ate my comment, but I meant to say: > > My understanding is still that IR passes generally live in Transforms/ and > that CodeGen/ deals with lower levels such as MachineInst

[PATCH] D118927: [clang-tidy] Fix invalid fix-it for cppcoreguidelines-prefer-member-initializer

njames93 created this revision. njames93 added reviewers: LegalizeAdulthood, aaron.ballman, alexfh. Herald added subscribers: carlosgalvezp, shchenz, kbarton, xazax.hun, nemanjai. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-c

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. In D116637#3294390 , @ABataev wrote: > In D116637#3294361 , > @tianshilei1992 wrote: > >> @ABataev @jdoerfert I got a question about writing the test. `atomic >> compare` is suppo

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

ABataev added a comment. In D116637#3294466 , @tianshilei1992 wrote: > In D116637#3294390 , @ABataev wrote: > >> In D116637#3294361 , >> @tianshilei1992 wrote: >> >>> @A

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. In D116637#3294474 , @ABataev wrote: > In D116637#3294466 , > @tianshilei1992 wrote: > >> In D116637#3294390 , @ABataev >> wrote: >> >>>

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

ABataev added a comment. In D116637#3294490 , @tianshilei1992 wrote: > In D116637#3294474 , @ABataev wrote: > >> In D116637#3294466 , >> @tianshilei1992 wrote: >> >>> In

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. In D116637#3294498 , @ABataev wrote: > In D116637#3294490 , > @tianshilei1992 wrote: > >> In D116637#3294474 , @ABataev >> wrote: >> >>>

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 updated this revision to Diff 405725. tianshilei1992 added a comment. update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116637/new/ https://reviews.llvm.org/D116637 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:10 +// RUN: %clang_cc1 -DOMP51 -verify=omp51 -fopenmp -fopenmp-version=51 -ast-print %s | FileCheck --check-prefixes=CHECK,CHECK-51 %s + +// RUN: %clang_cc1 -DOMP51 -verify=omp51 -fopenmp-si

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:964 + // CHECK-51-NEXT: } + // omp51-note@+1 {{in instantiation of function template specialization 'foo' requested here}} return foo(a); I cannot figure out why I have

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

jdoerfert added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:964 + // CHECK-51-NEXT: } + // omp51-note@+1 {{in instantiation of function template specialization 'foo' requested here}} return foo(a); tianshilei1992 wrote: > I cannot fi

[PATCH] D118924: [clang-format] Fix formatting of macro definitions with a leading comment.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3574 + // line. + FirstNonCommentOnLine |= FirstOnLine; +} else { I really don't like bitwise operations on bool. Hit some nasty bugs at my job. ===

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

Fznamznon created this revision. Fznamznon added a reviewer: bader. Herald added subscribers: Naghasan, Anastasia, ebevhan, yaxunl. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D118934: [OpenMP] Completely remove old device runtime

tianshilei1992 added inline comments. Comment at: clang/include/clang/Driver/Options.td:2470 Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; -defm openmp_target_new_runtime: BoolFOption<"openmp-target-new-runtime", - LangOpts<"OpenMPTargetNewRuntime">, DefaultTrue, -

[PATCH] D118934: [OpenMP] Completely remove old device runtime

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. I've read this closely and can't think of anywhere else that needs to be patched. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D118936: [test] Remove -fno-experimental-new-pass-manager -O1 from sanitize-address-field-padding.cpp

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. -O1 doesn't seem necessary here. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118936 Files: clang/test/CodeGen/sanitize-addres

[PATCH] D118934: [OpenMP] Completely remove old device runtime

jhuber6 added inline comments. Comment at: clang/include/clang/Driver/Options.td:2470 Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; -defm openmp_target_new_runtime: BoolFOption<"openmp-target-new-runtime", - LangOpts<"OpenMPTargetNewRuntime">, DefaultTrue,

[PATCH] D118934: [OpenMP] Completely remove old device runtime

JonChesterfield added inline comments. Comment at: clang/include/clang/Driver/Options.td:2470 Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; -defm openmp_target_new_runtime: BoolFOption<"openmp-target-new-runtime", - LangOpts<"OpenMPTargetNewRuntime">, DefaultTrue,

[clang] e0eeae9 - [lld][clang][cmake] Clean up a few things

Author: John Ericson Date: 2022-02-03T20:01:28Z New Revision: e0eeae9a447004cc346d9bf36c0d02f45e276a7c URL: https://github.com/llvm/llvm-project/commit/e0eeae9a447004cc346d9bf36c0d02f45e276a7c DIFF: https://github.com/llvm/llvm-project/commit/e0eeae9a447004cc346d9bf36c0d02f45e276a7c.diff LOG:

[PATCH] D118792: [lld][clang][cmake] Clean up a few things

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0eeae9a4470: [lld][clang][cmake] Clean up a few things (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118924: [clang-format] Fix formatting of macro definitions with a leading comment.

curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3574 + // line. + FirstNonCommentOnLine |= FirstOnLine; +} else { HazardyKnusperkeks wrote: > I really don't like bitwise operations on bool. Hit some nasty bugs at

[PATCH] D118924: [clang-format] Fix formatting of macro definitions with a leading comment.

curdeius planned changes to this revision. curdeius added a comment. I'll test it tomorrow but probably a define with a hash as the last character may do the job and show the faulty behaviour. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118924/ne

[PATCH] D118934: [OpenMP] Completely remove old device runtime

tianshilei1992 added a comment. If this patch can be back ported to 14, then it's totally fine to remove the argument. Otherwise keeping it sounds more reasonable. If we keep it, we'd better to emit a warning and then we could remove it in 15 or other version w/o any concern that we don't tell

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:964 + // CHECK-51-NEXT: } + // omp51-note@+1 {{in instantiation of function template specialization 'foo' requested here}} return foo(a)

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

dyung added a comment. Hi, your change is causing a test failure in the test attr-trivial-abi.cpp that you modified on the PS4 Windows box: https://lab.llvm.org/staging/#/builders/204/builds/758/steps/7/logs/FAIL__Clang__attr-trivial-abi_cpp TEST 'Clang :: SemaCXX/attr-tr

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

DmitryPolukhin added a comment. @ivanmurashko Overall looks good to me but please re-upload patch on top of some stable revision where failed test passes (it seems unrelated to your changes). `struct Include` is a light weight structure so having a copy seems to be the simplest solution. Rep

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nathanchance added a comment. This diff allows me to boot on bare metal as of v5.17-rc2: diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile index 6aef9ee28a39..8ee176dac669 100644 --- a/arch/x86/kernel/Makefile +++ b/arch/x86/kernel/Makefile @@ -125,6 +125,7 @@ obj-$(CONFI

[PATCH] D118781: Reduce dependencies on llvm/BinaryFormat/Dwarf.h

dblaikie added a comment. after: 10978519 before: 11245451 Doesn't appear to be a /huge/ win to me... but I don't mind too much. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118781/new/ https://reviews.llvm.org/D118781 __

[PATCH] D118782: clangd: Add a break for every case in the PopulateSwitch tweak

njames93 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp:208-209 Text.append({EnumD->getName(), "::"}); Text.append({EnumConstant.second.getEnumConstant()->getName(), ":"}); +Text += "break;"; }

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre added a comment. Oops, sorry about that. What is the correct way to test/reproduce the change? Do I / can I submit builds to the buildbot manually for testing? Also, should I be rolling back this change, or no? Not sure of the protocol here, this is my first change to Clang. P

[PATCH] D118781: Reduce dependencies on llvm/BinaryFormat/Dwarf.h

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118781/new/ https://reviews.llvm.org/D118781

[PATCH] D118858: [OpenMP] Don't use bound architecture when checking cache on the host

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118858/new/ https://reviews.llvm.org/D118858 ___

[PATCH] D118934: [OpenMP] Completely remove old device runtime

jdoerfert added a comment. Don't backport. Deprecate the flag and that's fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118934/new/ https://reviews.llvm.org/D118934 ___ cfe-commits mailing list cfe-

[PATCH] D118171: [HWASan] Add __hwasan_init to .preinit_array.

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118171/new/ https://reviews.llvm.org/D118171 ___ cfe-c

[clang] 95d609b - [HWASan] Add __hwasan_init to .preinit_array.

Author: Matt Morehouse Date: 2022-02-03T13:07:58-08:00 New Revision: 95d609b549bbdc3c1b7368eac427b9e6628f4ace URL: https://github.com/llvm/llvm-project/commit/95d609b549bbdc3c1b7368eac427b9e6628f4ace DIFF: https://github.com/llvm/llvm-project/commit/95d609b549bbdc3c1b7368eac427b9e6628f4ace.diff

[PATCH] D118171: [HWASan] Add __hwasan_init to .preinit_array.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95d609b549bb: [HWASan] Add __hwasan_init to .preinit_array. (authored by morehouse). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 502f14d - [VFS] Add a "redirecting-with" field to overlays

Author: Ben Barham Date: 2022-02-03T13:10:23-08:00 New Revision: 502f14d6f2eee10d2993ed22d820f12cf52462d6 URL: https://github.com/llvm/llvm-project/commit/502f14d6f2eee10d2993ed22d820f12cf52462d6 DIFF: https://github.com/llvm/llvm-project/commit/502f14d6f2eee10d2993ed22d820f12cf52462d6.diff LO

[PATCH] D117937: [VFS] Add a "redirecting-with" field to overlays

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG502f14d6f2ee: [VFS] Add a "redirecting-with" field to overlays (authored by bnbarham, committed by keith). Changed prior to commit: https://review

[PATCH] D118942: [Driver][Android] Removed obsoleted --warn-shared-textrel

MaskRay created this revision. MaskRay added reviewers: danalbert, srhines. Herald added a subscriber: danielkiss. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. --warn-shared-textrel is ignored in ld.lld and obsoleted in GNU ld (h

[PATCH] D118428: [clang-cl] Support the /JMC flag

rnk added a comment. In D118428#3294411 , @ychen wrote: > The passes in `lib/Transforms/Instrumentation` runs with > `EmitAssemblyHelper::RunOptimizationPipeline`. JMC pass runs with > `EmitAssemblyHelper::RunCodegenPipeline`. Sure, but that's a choice

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

LegalizeAdulthood added a comment. In D118104#3292862 , @JesApp wrote: > In general though, I think the script is complex enough to warrant some > testing. What is the feasibility of Python unit tests Instead of a heavy-weight `lit` oriented test? CH

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 405765. dgoldman added a comment. mergingEdit --> manual file checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 Files: clang-tools-extra/clangd/refactor/tweak

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen added a comment. In D118428#3294880 , @rnk wrote: > In D118428#3294411 , @ychen wrote: > >> The passes in `lib/Transforms/Instrumentation` runs with >> `EmitAssemblyHelper::RunOptimizationPipeline`. JMC pas

[PATCH] D118428: [clang-cl] Support the /JMC flag

rnk added a comment. In D118428#3294935 , @ychen wrote: > The instrumentation is per-function, ideally for each function that has > debuginfo and ends up in the executable. So I want it to happen the last in > the IR codegen pipeline (target could arran

[clang] 852afed - Revert "[clang] Mark `trivial_abi` types as "trivially relocatable"."

Author: Dmitri Gribenko Date: 2022-02-03T22:31:44+01:00 New Revision: 852afed5e0200b70047c28ccf4424a17089d17b0 URL: https://github.com/llvm/llvm-project/commit/852afed5e0200b70047c28ccf4424a17089d17b0 DIFF: https://github.com/llvm/llvm-project/commit/852afed5e0200b70047c28ccf4424a17089d17b0.dif

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

gribozavr2 added a comment. I rolled it back while @devin.jeanpierre investigates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114732/new/ https://reviews.llvm.org/D114732 ___ cfe-commits mailing list

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre added a comment. Thank you @gribozavr2 ! I'll hopefully have a roll-forward ready for you either today or tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114732/new/ https://reviews.llvm.org/D114732 __

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, Meinersbur. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The linker wrapper tool uses the 'nv

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam updated this revision to Diff 405775. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGenCXX/PR19955.cpp clang/test/CodeGenCXX/dllimport.cpp clang/test/SemaCXX/PR19955.cpp c

[clang] 88e4e6b - [clang-format] Use wider comment prefix space rule

Author: ksyx Date: 2022-02-03T21:49:10Z New Revision: 88e4e6be16ea400948c06f972f1b5f19478528df URL: https://github.com/llvm/llvm-project/commit/88e4e6be16ea400948c06f972f1b5f19478528df DIFF: https://github.com/llvm/llvm-project/commit/88e4e6be16ea400948c06f972f1b5f19478528df.diff LOG: [clang-f

[PATCH] D118869: [clang-format] Non-latin comment prefix whitespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88e4e6be16ea: [clang-format] Use wider comment prefix space rule (authored by ksyx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. In D110869#3294696 , @nathanchance wrote: > This diff allows me to boot on bare metal as of v5.17-rc2: > > diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile > index 6aef9ee28a39..8ee176dac669 100644 > --- a/arch

[clang] 3d0b619 - [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

Author: Björn Schäpers Date: 2022-02-03T22:55:27+01:00 New Revision: 3d0b619261392f5f24a7b9961b24cdd621829c13 URL: https://github.com/llvm/llvm-project/commit/3d0b619261392f5f24a7b9961b24cdd621829c13 DIFF: https://github.com/llvm/llvm-project/commit/3d0b619261392f5f24a7b9961b24cdd621829c13.diff

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. HazardyKnusperkeks marked an inline comment as done. Closed by commit rG3d0b61926139: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter (authored by HazardyKnus

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

Meinersbur added a comment. Thanks for the fix Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8151-8152 const char *LinkingOutput) const { + const auto &D = getToolChain().getDriver(); + const auto TheTriple = getToolChain().getTriple(); +

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

dyung added a comment. In D114732#3294794 , @devin.jeanpierre wrote: > Oops, sorry about that. What is the correct way to test/reproduce the change? > Do I / can I submit builds to the buildbot manually for testing? > > Also, should I be rolling back th

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8161-8162 + if (CudaInstallation.isValid()) +CmdArgs.push_back(Args.MakeArgString( +"-cuda-path=" + CudaInstallation.getInstallPath())); +} Meinersbur wr

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

jhuber6 updated this revision to Diff 405783. jhuber6 added a comment. Address style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118944/new/ https://reviews.llvm.org/D118944 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/tools/clang-lin

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

jhuber6 updated this revision to Diff 405785. jhuber6 added a comment. Decided to add break. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118944/new/ https://reviews.llvm.org/D118944 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/tools/cl

[clang] 9138d96 - [OpenMP] Don't use bound architecture when checking cache on the host

Author: Joseph Huber Date: 2022-02-03T17:17:38-05:00 New Revision: 9138d96f8b01605b213e8c4d587853a46cca3f44 URL: https://github.com/llvm/llvm-project/commit/9138d96f8b01605b213e8c4d587853a46cca3f44 DIFF: https://github.com/llvm/llvm-project/commit/9138d96f8b01605b213e8c4d587853a46cca3f44.diff

[PATCH] D118858: [OpenMP] Don't use bound architecture when checking cache on the host

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9138d96f8b01: [OpenMP] Don't use bound architecture when checking cache on the host (authored by jhuber6). Repository: rG LLVM Github Monorepo CH

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

tyb0807 updated this revision to Diff 405786. tyb0807 edited the summary of this revision. tyb0807 added a comment. Add more tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116153/new/ https://reviews.llvm.org/D116153 Files: clang/lib/Basic/Targets/ARM.cpp clang/lib/Driver/Tool

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

tianshilei1992 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8163 +CmdArgs.push_back(Args.MakeArgString( +"-cuda-path=" + CudaInstallation.getInstallPath())); + break; Would be better to keep aligned with `clang

[PATCH] D118904: [clang][CodeGen] Use memory type representation in `va_arg`

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGen/arm64-arguments.c:203 + __builtin_va_start(ap, i); + // TODO: Add proper checks here. + _Bool b = __builtin_va_arg(ap, _Bool);

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nathanchance added a comment. In D110869#3295012 , @void wrote: > In D110869#3294696 , @nathanchance > wrote: > >> This diff allows me to boot on bare metal as of v5.17-rc2: >> >> diff --git a/arch/x86/kernel/M

[PATCH] D118855: [modules] Add a flag for TagDecl if it was a definition demoted to a declaration.

vsapsai added a comment. `libomptarget :: x86_64-pc-linux-gnu :: mapping/delete_inf_refcount.c` has failed due to > /usr/bin/ld: final link failed: bad value As far as I can tell, it's not related to my change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

tyb0807 marked 2 inline comments as done. tyb0807 added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:937 case llvm::ARM::ArchKind::ARMV9_2A: getTargetDefinesARMV83A(Opts, Builder); break; SjoerdMeijer wrote: > Perhaps unrelated to thi

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim created this revision. hctim added a reviewer: eugenis. Herald added subscribers: dexonsmith, dang, arichardson, emaste. Herald added a reviewer: MaskRay. hctim requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Current

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. In D110869#3295147 , @nathanchance wrote: > > I tested this patch but it did not change the hang. Okay. We need to determine which function is failing. Could you do something like this: #define zcur __attribute__((zero_call

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

jhuber6 updated this revision to Diff 405799. jhuber6 added a comment. Use long version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118944/new/ https://reviews.llvm.org/D118944 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/tools/clang-

[PATCH] D118949: [HIP] Support code object v5

yaxunl created this revision. yaxunl added reviewers: tra, b-sumner. Herald added subscribers: dang, kerbowa, jvesely. yaxunl requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. New device library supporting v4 and v5 has abi_version_400.bc a

[PATCH] D118858: [OpenMP] Don't use bound architecture when checking cache on the host

thakis added a comment. Looks like this breaks tests on Mac: http://45.33.8.238/macm1/27158/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118858/new/ https://reviews.llvm

[PATCH] D118858: [OpenMP] Don't use bound architecture when checking cache on the host

jhuber6 added a comment. In D118858#3295210 , @thakis wrote: > Looks like this breaks tests on Mac: http://45.33.8.238/macm1/27158/step_7.txt > > Please take a look and revert for now if it takes a while to fix. This fixed it on the mac I got to test it

[clang] da20df2 - Revert "[OpenMP] Don't use bound architecture when checking cache on the host"

Author: Joseph Huber Date: 2022-02-03T17:43:10-05:00 New Revision: da20df21157f316648447b21f2ce6cf79a5ef57c URL: https://github.com/llvm/llvm-project/commit/da20df21157f316648447b21f2ce6cf79a5ef57c DIFF: https://github.com/llvm/llvm-project/commit/da20df21157f316648447b21f2ce6cf79a5ef57c.diff

[PATCH] D118858: [OpenMP] Don't use bound architecture when checking cache on the host

jhuber6 added a comment. In D118858#3295210 , @thakis wrote: > Looks like this breaks tests on Mac: http://45.33.8.238/macm1/27158/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Can you do me a favor and run the command

[PATCH] D118949: [HIP] Support code object v5

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Few nits, LGTM in general. Comment at: clang/lib/Driver/ToolChains/ROCm.h:27 +struct DeviceLibABIVersion { + unsigned Value = 0; + DeviceLibABIVersion(unsigned V) : Value(V) {} -

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko updated this revision to Diff 405814. ivanmurashko added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118755/new/ https://reviews.llvm.org/D118755 Files: clang-tools-extra/clangd/test/repeated_includes.test clan

[PATCH] D116987: [clang][utils] Remove StringRef lldb summary provider

kastiglione added a comment. The StringRef provider was improved in D117779 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116987/new/ https://reviews.llvm.org/D116987 ___

[clang] 65aa473 - [clang][utils] Remove StringRef lldb summary provider

Author: Dave Lee Date: 2022-02-03T15:16:31-08:00 New Revision: 65aa47301372b0f46d69977eb87aec60976e8246 URL: https://github.com/llvm/llvm-project/commit/65aa47301372b0f46d69977eb87aec60976e8246 DIFF: https://github.com/llvm/llvm-project/commit/65aa47301372b0f46d69977eb87aec60976e8246.diff LOG:

<    1   2   3   >