LegalizeAdulthood added a comment. In D117522#3290604 <https://reviews.llvm.org/D117522#3290604>, @carlosgalvezp wrote:
> This will conflict with `Enum.3` from `cppcoreguidelines` I went back and looked at Enum.3 Prefer class enums over “plain” enums <https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#enum3-prefer-class-enums-over-plain-enums>, and implementing that is the second-pass check I discussed earlier. This check is more about implementing Enum.1 Prefer enumerations over macros <https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#enum1-prefer-enumerations-over-macros>. This brings up the question of whether or not there should be a cppguidelines alias for this check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
