[PATCH] D118171: [HWASan] Add __hwasan_init to .preinit_array.

morehouse updated this revision to Diff 405435. morehouse marked 3 inline comments as done. morehouse added a comment. - Make __local_hwasan_preinit static. - Use HelperStaticRuntimes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118171/new/ https

[PATCH] D118171: [HWASan] Add __hwasan_init to .preinit_array.

morehouse added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:842 + if (!Args.hasArg(options::OPT_shared)) +SharedRuntimes.push_back("hwasan-preinit"); } eugenis wrote: > pcc wrote: > > Shouldn't it be added to `HelperS

[PATCH] D118171: [HWASan] Add __hwasan_init to .preinit_array.

pcc added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:842 + if (!Args.hasArg(options::OPT_shared)) +SharedRuntimes.push_back("hwasan-preinit"); } morehouse wrote: > eugenis wrote: > > pcc wrote: > > > Shouldn't it be

[PATCH] D118734: Added early exit for defaulted FunctionDecls. This prevents matching of defaulted comparison operators. fixes #53355

Febbe abandoned this revision. Febbe added a comment. Updated in https://reviews.llvm.org/D118847 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118734/new/ https://reviews.llvm.org/D118734 ___ cfe-commit

[PATCH] D117929: [XRay] Add support for RISCV

ashwin98 updated this revision to Diff 405432. ashwin98 added a comment. Updated the riscv64 sled function to get rid of the to fix the addition/shift operations and get rid of the superfluous slli and srli instructions. Cut out unnecessary comments in the ASM Printer. CHANGES SINCE LAST ACTIO

[PATCH] D117929: [XRay] Add support for RISCV

ashwin98 added inline comments. Comment at: llvm/test/CodeGen/RISCV/xray-attribute-instrumentation.ll:1-2 +; RUN: llc -mtriple=riscv32-unknown-elf -mattr=+d -verify-machineinstrs < %s | FileCheck --check-prefix=CHECK %s +; RUN: llc -mtriple=riscv32-unknown-linux-gnu -mattr=+d -v

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

ldionne added a comment. Hello, I know I'm not helping move this patch along because I'm not the right person to review this. However, I'd like to kindly reiterate that fixing this would be helpful for libc++. I just had to re-XFAIL one of our tuple tests because of this :-) Repository: rG

[PATCH] D118850: [PS4] Make __BIGGEST_ALIGNMENT__ 32bytes

ychen created this revision. ychen added a reviewer: probinson. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. So it matches `__STDCPP_DEFAULT_NEW_ALIGNMENT__`. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D11885

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added a comment. gentle ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115844/new/ https://reviews.llvm.org/D115844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst

bc-lee added a comment. Some changes in this patch were applied as https://reviews.llvm.org/D118759, so I'm re-uploading this patch to get rid of merge conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117924/new/ https://reviews.llvm.org/

[PATCH] D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst

bc-lee updated this revision to Diff 405461. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117924/new/ https://reviews.llvm.org/D117924 Files: clang/lib/Driver/ToolChains/Darwin.cpp clang/test/Driver/darwin-sanitizer-ld.c compiler-rt/cmake/bui

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

xbolva00 added a comment. >> Reintroducing an optimization like this with an additional check that the >> allocation size is large enough should be valid everywhere. Should not be hard, could you do it? Then LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

MaskRay added a comment. In D118804#3292176 , @xbolva00 wrote: >>> Reintroducing an optimization like this with an additional check that the >>> allocation size is large enough should be valid everywhere. > > Should not be hard, could you do it? Then LGT

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

dblaikie updated this revision to Diff 405468. dblaikie added a comment. - Create a separate sub-warning flag of -Wpacked (-Wpacked-non-pod), in case you're just interested in the ABI breaks here - Warn only when this produces a different alignment requirement for the field Repository: rG LLV

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

ychen added a comment. I don't see why the patch is wrong... It uses the target/platform-specific `NewAlign`. If the platform allows customized memory allocation that assumes weak alignment, it should set the `NewAlign` accordingly, no? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

xbolva00 added a comment. Can you also confirm that there is no similar related to op new? Yes, we “can” this assumption by removing it but.. there should be consensus whether just this code is problematic or problem is bigger (as we use NewAlign..) Repository: rG LLVM Github Monorepo CHAN

[PATCH] D118855: [modules] Add a flag for TagDecl if it was a definition demoted to a declaration.

vsapsai created this revision. vsapsai added reviewers: rsmith, v.g.vassilev, jansvoboda11. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For redeclaration chains we maintain an invariant of ha

[PATCH] D118855: [modules] Add a flag for TagDecl if it was a definition demoted to a declaration.

vsapsai added a comment. Relevant discussion on how this is used in Swift is in https://github.com/apple/swift/pull/41144 Also it contains links to various [successful] test runs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118855/new/ https://

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

xbolva00 added a comment. In D118804#3292179 , @MaskRay wrote: > In D118804#3292176 , @xbolva00 > wrote: > Reintroducing an optimization like this with an additional check that the allocation size is l

[PATCH] D110280: [modules] Fix IRGen assertion on accessing ObjC ivar inside a method.

vsapsai added a comment. In D110280#3289431 , @SharonXu wrote: > Hi @vsapsai, I checked out the apple `stable/20211026` llvm-project branch > at https://github.com/apple/llvm-project/tree/stable/20211026, and ran > check-clang locally, but the tested a

[PATCH] D118700: Add support to --gcc-toolchain flag for GCC compiled with --enable-version-specific-runtime-libs.

MaskRay added a comment. Thanks for the output. Seems like `addLibStdCXXIncludePaths` is needed, but the `addPathIfExists` library path seems unnecessary? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118700/new/ https://reviews.llvm.org/D118700 ___

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

jyknight added a comment. In D118804#3292185 , @ychen wrote: > I don't see why the patch is wrong... It uses the target/platform-specific > `NewAlign`. If the platform allows customized memory allocation that assumes > weak alignment, it should set the

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

Bigcheese updated this revision to Diff 405482. Bigcheese added a comment. - Fixed documentation typo. - Made missing '{' diagnostic more clear. - Use `ModuleMapParser::skipUntil`. Emitting an actual fixup is kind of difficult from `ModuleMapParser` because the way it handles tokens makes it har

[PATCH] D118858: [OpenMP] Don't use bound architecture when checking cache on the host

jhuber6 created this revision. jhuber6 added a reviewer: thakis. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. When we are creating jobs for

[PATCH] D118858: [OpenMP] Don't use bound architecture when checking cache on the host

jhuber6 added a comment. @thakis could you confirm that this works on your machine? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118858/new/ https://reviews.llvm.org/D118858 ___ cfe-commits mailing list

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:1549 SubobjectDesignator Designator; +const Expr *LExpr = nullptr; bool IsNullPtr : 1; I don't think this is an appropriate approach. A source expression is fundamentally not

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

ychen added a comment. In D118804#3292263 , @jyknight wrote: > In D118804#3292185 , @ychen wrote: > >> I don't see why the patch is wrong... It uses the target/platform-specific >> `NewAlign`. If the platform all

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

ychen accepted this revision. ychen added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118804/new/ https://reviews.llvm.org/D118804 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D118862: [clang][driver] add clang driver support for emitting macho files with two build version load commands

arphaman created this revision. arphaman added reviewers: ravikandhadai, egorzhdan, dexonsmith, steven_wu. Herald added subscribers: dang, ributzka. arphaman requested review of this revision. Herald added a project: clang. This patch extends clang driver to pass the right flags to the clang front

[clang] 30baa5d - PR45879: Fix assert when constant evaluating union assignment.

Author: Richard Smith Date: 2022-02-02T17:02:47-08:00 New Revision: 30baa5d2a450d5e302d8cba3fc7a26a59d4b7ae1 URL: https://github.com/llvm/llvm-project/commit/30baa5d2a450d5e302d8cba3fc7a26a59d4b7ae1 DIFF: https://github.com/llvm/llvm-project/commit/30baa5d2a450d5e302d8cba3fc7a26a59d4b7ae1.diff

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

rsmith added a comment. Alternative fix landed in rG30baa5d2a450d5e302d8cba3fc7a26a59d4b7ae1 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103395/new/ https://reviews.llvm.org/

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

rsmith added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1891 + llvm::Triple Target = Context.getTargetInfo().getTriple(); + bool FieldPacked = (Packed && (!FieldClass || FieldClass->isPOD() || + Context.getLangOpts().getCl

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:2029-2036 // The align if the field is not packed. This is to check if the attribute // was unnecessary (-Wpacked)

[PATCH] D118171: [HWASan] Add __hwasan_init to .preinit_array.

fmayer added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:842 + if (!Args.hasArg(options::OPT_shared)) +SharedRuntimes.push_back("hwasan-preinit"); } pcc wrote: > morehouse wrote: > > eugenis wrote: > > > pcc wrote: >

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

This revision was automatically updated to reflect the committed changes. Closed by commit rG19aa2db023c0: [clang] Mark `trivial_abi` types as "trivially relocatable". (authored by devin.jeanpierre, committed by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] 19aa2db - [clang] Mark `trivial_abi` types as "trivially relocatable".

Author: Devin Jeanpierre Date: 2022-02-02T17:42:20-08:00 New Revision: 19aa2db023c0128913da223d4fb02c474541ee22 URL: https://github.com/llvm/llvm-project/commit/19aa2db023c0128913da223d4fb02c474541ee22 DIFF: https://github.com/llvm/llvm-project/commit/19aa2db023c0128913da223d4fb02c474541ee22.di

[PATCH] D118428: [clang-cl] Support the /JMC flag

rnk added inline comments. Comment at: llvm/lib/CodeGen/JMCInstrumenter.cpp:145 + LLVMContext &Ctx = M.getContext(); + bool UseX86FastCall = Triple(M.getTargetTriple()).getArch() == Triple::x86; + ychen wrote: > ychen wrote: > > hans wrote: > > > I still worry

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre added a comment. W! Thank you for submitting, and thanks everyone for the kind and helpful reviews. 😀 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114732/new/ https://reviews.llvm.org/D114732

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. @aaron.ballman - can this land for Clang14, or does it have wait for 15? Are there any other reviewers that can approve this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 __

[PATCH] D118070: Make lld-link work in a non-MSVC shell

MaskRay added a comment. In D118070#3290194 , @aganea wrote: > In D118070#3289227 , @MaskRay wrote: > >> I know that you want a place to be accessed by both clang driver and >> lld-link but I am a bit nervous ab

[PATCH] D118869: [clang-format] Non-latin comment prefix whitespace

ksyx created this revision. ksyx added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius. ksyx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit changes the condition of requiring comment to start with alphabet characters to

[PATCH] D118869: [clang-format] Non-latin comment prefix whitespace

ksyx added subscribers: byronhe, CoelacanthusHex. ksyx added a comment. Related discussion: https://reviews.llvm.org/D92257#3252060 Proposed by @byronhe cc @CoelacanthusHex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118869/new/ https://reviews

[PATCH] D117306: [clang-tidy] Add new check 'shared-ptr-array-mismatch'.

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SmartPtrArrayMismatchCheck.h:40 + /// in this class. + virtual SmartPtrClassMatcher getSmartPointerClassMatcher() const = 0; + There's only one implementation of this ab

[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

var-const added a comment. @Quuxplusone Now that it's landed, do we still need `__workaround_52970` in libc++? (see https://github.com/llvm/llvm-project/blob/167b623a6af26802af47f455aaa3806faaa9da9e/libcxx/include/__concepts/class_or_enum.h#L28-L30) Repository: rG LLVM Github Monorepo CHANG

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen updated this revision to Diff 405520. ychen added a comment. - Remove a file that is included by accident. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118428/new/ https://reviews.llvm.org/D118428 Files: clang/docs/ReleaseNotes.rst clan

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen added inline comments. Comment at: llvm/lib/CodeGen/CommandFlags.cpp:462 + static cl::opt EnableJMCInstrument( + "enable-jmc-instrument", + cl::desc("Instrument functions with a call to __CheckForDebuggerJustMyCode"), ychen wrote: > hans wrote:

[PATCH] D118873: [clang-format] Revert a feature in RemoveBracesLLVM

owenpan created this revision. owenpan added reviewers: curdeius, MyDeveloperDay, HazardyKnusperkeks. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Revert the handling of a single-statement b

[PATCH] D118781: Reduce dependencies on llvm/BinaryFormat/Dwarf.h

serge-sans-paille added a comment. In D118781#3291801 , @MaskRay wrote: > $ clang++ -E -Iinclude -I../llvm/include > ../llvm/lib/Transforms/Scalar/*.cpp -std=c++14 -fno-rtti -fno-exceptions | wc > -l > before: 10978519 > after: 11245451 > > The nu

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 405531. void added a comment. Make sure we're zeroing the registers in the return block, not just some random block. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 File

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. In D110869#3289073 , @nickdesaulniers wrote: > Diff 405119 still kernel panics for me. This is building the linux-next tree. > > $ qemu-system-x86_64 --version > QEMU emulator version 6.2.0 (Debian 1:6.2+dfsg-1) Works now. PTAL

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

steakhal reopened this revision. steakhal added a comment. This revision is now accepted and ready to land. It broke some bots. I had to revert it in minutes it landed. Yet to be investigated how did it break something. Mind that I dont have any experience with objC. Repository: rG LLVM Githu

[PATCH] D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support

arphaman created this revision. arphaman added reviewers: ravikandhadai, dexonsmith. Herald added subscribers: ributzka, mgorny, dberris. arphaman requested review of this revision. This patch extends compiler-rt's cmake config to build macOS builtins with both macOS and Mac Catalyst support. Thi

[PATCH] D112353: [bazel] fixes for windows build

ychen added a comment. In D112353#3291381 , @GMNGeoffrey wrote: > If you'd like to rebase this and see what's still outstanding, I can take > another look :-) Thanks for getting around to this. I rebased the patch and reran the build. It seems the new

[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

linjamaki created this revision. Herald added a subscriber: yaxunl. linjamaki edited the summary of this revision. Herald added a subscriber: Anastasia. linjamaki published this revision for review. linjamaki added reviewers: Anastasia, yaxunl. Herald added a project: clang. Herald added a subscrib

[PATCH] D118879: [clang-format] Avoid merging macro definitions.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/42087. Repository: rG LLVM

[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

jchlanda updated this revision to Diff 405161. jchlanda edited the summary of this revision. jchlanda added a comment. Added xorsign.abs variant and test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117887/new/ https://reviews.llvm.org/D117887 F

[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

jchlanda added a comment. In D117887#3262024 , @tra wrote: > > Please do check that the generated PTX does get assembled by ptxas. `ptxas` is happy with asm generated from both `math-intrins-sm86-ptx72.ll` and `math-intrins-sm80-ptx70.ll` Reposito

[PATCH] D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo

tyb0807 created this revision. Herald added a subscriber: kristof.beyls. tyb0807 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This removes two feature flags from `AArch64TargetInfo` class: - `HasHBC`: this feature does not involve gener

[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

jchlanda marked 2 inline comments as done. jchlanda added inline comments. Comment at: clang/test/CodeGen/builtins-nvptx.c:822 + // CHECK_PTX70_SM80: call i16 @llvm.nvvm.fmin.bf16 + __nvvm_fmin_bf16(0x1234, 0x7FBF); + // CHECK_PTX70_SM80: call i16 @llvm.nvvm.fmin.nan.bf16

[PATCH] D118706: [clang-format] Correctly parse C99 digraphs: "<:", ":>", "<%", "%>", "%:", "%:%:".

curdeius added inline comments. Comment at: clang/lib/Format/Format.cpp:3246 + // Turning on digraphs in standards before C++0x is error-prone, because e.g. + // the sequence "<::" will be inconditionally treated as "[:". + // Cf. Lexer::LexTokenInternal. Haza

[clang] bc40b76 - [clang-format] Correctly parse C99 digraphs: "<:", ":>", "<%", "%>", "%:", "%:%:".

Author: Marek Kurdej Date: 2022-02-02T10:25:24+01:00 New Revision: bc40b76b5b95837e27217de6a446eeeace695f34 URL: https://github.com/llvm/llvm-project/commit/bc40b76b5b95837e27217de6a446eeeace695f34 DIFF: https://github.com/llvm/llvm-project/commit/bc40b76b5b95837e27217de6a446eeeace695f34.diff

[PATCH] D118706: [clang-format] Correctly parse C99 digraphs: "<:", ":>", "<%", "%>", "%:", "%:%:".

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc40b76b5b95: [clang-format] Correctly parse C99 digraphs: "<:", ":>", "<%", "%>", "%:", "%:%… (authored by curdeius). Changed prior to commit: https://reviews.llvm.org/D118706?vs=404945&id=405172#toc

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). ---

[PATCH] D118700: Add support to --gcc-toolchain flag for GCC compiled with --enable-version-specific-runtime-libs.

rpenacob added a comment. Sure! **GCC** With the `--enable-version-specific-runtime-libs` #include "..." search starts here: #include <...> search starts here: /home/rpenacob/.../gcc-rt-libs/install-rt/bin/../lib/gcc/x86_64-pc-linux-gnu/11.2.0/include /home/rpenacob/.../gcc-rt-libs/i

[PATCH] D118762: Remove -Wweak-template-vtables

hans created this revision. hans added a reviewer: dblaikie. hans requested review of this revision. Herald added a project: clang. as it was planned for removal in clang 15 and we're now past the branch point See https://github.com/llvm/llvm-project/issues/19107 Repository: rG LLVM G

[clang] e0e6f3a - [OpenCL] Test -fdeclare-opencl-builtins with CL3 and CLC++2021

Author: Sven van Haastregt Date: 2022-02-02T10:23:02Z New Revision: e0e6f3a6a2e13ee11b014ca45a48997e78d3efc5 URL: https://github.com/llvm/llvm-project/commit/e0e6f3a6a2e13ee11b014ca45a48997e78d3efc5 DIFF: https://github.com/llvm/llvm-project/commit/e0e6f3a6a2e13ee11b014ca45a48997e78d3efc5.diff

[clang] 9d6a615 - [analyzer] Prevent misuses of -analyze-function

Author: Balazs Benics Date: 2022-02-02T11:31:22+01:00 New Revision: 9d6a6159730171bc0faf78d7f109d6543f4c93c2 URL: https://github.com/llvm/llvm-project/commit/9d6a6159730171bc0faf78d7f109d6543f4c93c2 DIFF: https://github.com/llvm/llvm-project/commit/9d6a6159730171bc0faf78d7f109d6543f4c93c2.diff

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

This revision was automatically updated to reflect the committed changes. steakhal marked 3 inline comments as done. Closed by commit rG9d6a61597301: [analyzer] Prevent misuses of -analyze-function (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Chan

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

steakhal added a comment. Landed with the requested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118690/new/ https://reviews.llvm.org/D118690 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo

CarolineConcatto added a comment. Just passing by, but I was wondering when I saw this patch. Why you did not remove this also from lib/Driver/ToolChains/Arch/AArch64.cpp? And the ones in llvm (AArch64.td, AArch64InstrInfo.td)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] e99abc5 - Revert "[analyzer] Prevent misuses of -analyze-function"

Author: Balazs Benics Date: 2022-02-02T11:44:27+01:00 New Revision: e99abc5d8a3a730915933e9725fe585a46f51b18 URL: https://github.com/llvm/llvm-project/commit/e99abc5d8a3a730915933e9725fe585a46f51b18 DIFF: https://github.com/llvm/llvm-project/commit/e99abc5d8a3a730915933e9725fe585a46f51b18.diff

[PATCH] D118520: [clang-tidy] Output currently processing check and nodes on crash

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:239 + const ast_matchers::BoundNodes &Result) const { +if (CurrentlyProcessing) + CurrentlyProcessing->onProcessingCheckStart(CheckName, Re

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

john.brawn planned changes to this revision. john.brawn added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1484 + // of the vector comparison instructions. + setOperationAction(ISD::STRICT_FSETCCS, VT, Expand); + // FIXME: We could potentially m

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

nikic added inline comments. Comment at: lld/CMakeLists.txt:14 + set(LLVM_CONFIG_OUTPUT) + if(LLVM_CONFIG) +set (LLVM_CONFIG_FOUND 1) Is it intentional that lld now requires you to set LLVM_CONFIG instead of LLVM_CONFIG_PATH? Based on the deprecation, I wo

[clang] d919d02 - [scan-build] Fix deadlock at failures in libears/ear.c

Author: Balazs Benics Date: 2022-02-02T12:55:44+01:00 New Revision: d919d027ba2a41df5d51ce82ae7f2fb64d2cba41 URL: https://github.com/llvm/llvm-project/commit/d919d027ba2a41df5d51ce82ae7f2fb64d2cba41 DIFF: https://github.com/llvm/llvm-project/commit/d919d027ba2a41df5d51ce82ae7f2fb64d2cba41.diff

[PATCH] D118439: [scan-build] Fix deadlock at failures in libears/ear.c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd919d027ba2a: [scan-build] Fix deadlock at failures in libears/ear.c (authored by steakhal). Herald added a project: clang. Herald added a subscriber

[PATCH] D118439: [scan-build] Fix deadlock at failures in libears/ear.c

steakhal added a comment. Submitted for backporting to 13.0.1: https://github.com/llvm/llvm-project/issues/53541 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118439/new/ https://reviews.llvm.org/D118439 __

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

john.brawn updated this revision to Diff 405213. john.brawn added a comment. Update based on review comments and adjust formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117795/new/ https://reviews.llvm.org/D117795 Files: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp llvm

[clang] 61f09bc - [clang-format] Use llvm::seq instead of std::iota. NFC.

Author: Marek Kurdej Date: 2022-02-02T14:00:50+01:00 New Revision: 61f09bcf11dee028ba47f4756910b25b043505e1 URL: https://github.com/llvm/llvm-project/commit/61f09bcf11dee028ba47f4756910b25b043505e1 DIFF: https://github.com/llvm/llvm-project/commit/61f09bcf11dee028ba47f4756910b25b043505e1.diff

[clang] 574ad2a - [clang-format] Use prefix operator--. NFC.

Author: Marek Kurdej Date: 2022-02-02T14:01:48+01:00 New Revision: 574ad2a84626ffb0e7a64559e9862f20aadc013a URL: https://github.com/llvm/llvm-project/commit/574ad2a84626ffb0e7a64559e9862f20aadc013a DIFF: https://github.com/llvm/llvm-project/commit/574ad2a84626ffb0e7a64559e9862f20aadc013a.diff

[clang] ccf02cd - [clang][NFC] Remove unreachable code

Author: Nathan Sidwell Date: 2022-02-02T05:14:26-08:00 New Revision: ccf02cdf17d68a7dd4411daa74b81fa5b48d0a0c URL: https://github.com/llvm/llvm-project/commit/ccf02cdf17d68a7dd4411daa74b81fa5b48d0a0c DIFF: https://github.com/llvm/llvm-project/commit/ccf02cdf17d68a7dd4411daa74b81fa5b48d0a0c.diff

[PATCH] D118704: [clang][NFC] Remove unreachable code

This revision was automatically updated to reflect the committed changes. Closed by commit rGccf02cdf17d6: [clang][NFC] Remove unreachable code (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D118608: [NFC] Increase initial size of FoldingSets used in ASTContext and CodeGenTypes

serge-sans-paille added a comment. Thanks, that's helpful. Any hint about why this particular values? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118608/new/ https://reviews.llvm.org/D118608 ___ cfe-co

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

nikic added a comment. Would it be possible to share a complete new-style cmake invocation that is supposed to work? If I only point LLVM_DIR to the cmake directory, then LLVM_MAIN_SRC_DIR ends up being empty (it is set to MAIN_SRC_DIR, which, as far as I can tell, is only initialized in the LL

[PATCH] D118781: Reduce dependencies on llvm/BinaryFormat/Dwarf.h

serge-sans-paille created this revision. serge-sans-paille added reviewers: RKSimon, MaskRay, mehdi_amini, lenary. Herald added subscribers: awarzynski, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, foad, dcaballe, cota, teijeong, frasercrmck, dexonsmith, rdzhabarov, tatianashp, msifontes, jurahul,

[clang] 10243d0 - [clang-format] Simplify use of StringRef::substr(). NFC.

Author: Marek Kurdej Date: 2022-02-02T14:36:00+01:00 New Revision: 10243d0dfd36b0fb912276b2686a038b952e03c8 URL: https://github.com/llvm/llvm-project/commit/10243d0dfd36b0fb912276b2686a038b952e03c8 DIFF: https://github.com/llvm/llvm-project/commit/10243d0dfd36b0fb912276b2686a038b952e03c8.diff

[clang] b3af2ef - [clang-format] Factor out loop variable. NFC.

Author: Marek Kurdej Date: 2022-02-02T14:36:00+01:00 New Revision: b3af2ef963b1c94ab40d940c5e2774a2ac9ec230 URL: https://github.com/llvm/llvm-project/commit/b3af2ef963b1c94ab40d940c5e2774a2ac9ec230 DIFF: https://github.com/llvm/llvm-project/commit/b3af2ef963b1c94ab40d940c5e2774a2ac9ec230.diff

[clang] 630c736 - [clang-format] Elide unnecessary braces. NFC.

Author: Marek Kurdej Date: 2022-02-02T14:36:01+01:00 New Revision: 630c736047a3191a5d3150bcc825064ab84e9fb5 URL: https://github.com/llvm/llvm-project/commit/630c736047a3191a5d3150bcc825064ab84e9fb5 DIFF: https://github.com/llvm/llvm-project/commit/630c736047a3191a5d3150bcc825064ab84e9fb5.diff

[PATCH] D118428: [clang-cl] Support the /JMC flag

hans added inline comments. Comment at: llvm/lib/CodeGen/CommandFlags.cpp:462 + static cl::opt EnableJMCInstrument( + "enable-jmc-instrument", + cl::desc("Instrument functions with a call to __CheckForDebuggerJustMyCode"), ychen wrote: > hans wrote: >

[PATCH] D117461: [clangd] IncludeCleaner: Attach "insert prgama keep" fix-it to diagnostic

kbobyrev updated this revision to Diff 405238. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117461/new/ https://reviews.llvm.org/D117461 Files: clang-

[PATCH] D118782: clangd: Add a break for every case in the PopulateSwitch tweak

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fall-through is no

[PATCH] D118782: clangd: Add a break for every case in the PopulateSwitch tweak

ckandeler updated this revision to Diff 405240. ckandeler added a comment. Fixed unintentional whitespace change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118782/new/ https://reviews.llvm.org/D118782 Files: clang-tools-extra/clangd/refactor

[PATCH] D118070: Make lld-link work in a non-MSVC shell

aganea added a comment. In D118070#3289227 , @MaskRay wrote: > I know that you want a place to be accessed by both clang driver and > lld-link but I am a bit nervous about the clang-driver style MSVC library > sitting inside llvm/lib/Support/. > Is the

[PATCH] D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token

egorzhdan accepted this revision. egorzhdan added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116052/new/ https://reviews.llvm.org/D116052 ___ cfe-commits mailing list cfe-co

[clang] d079995 - [clang-format] Elide unnecessary braces. NFC.

Author: Marek Kurdej Date: 2022-02-02T15:28:53+01:00 New Revision: d079995dd032e991bac295fb1a879efd32f20460 URL: https://github.com/llvm/llvm-project/commit/d079995dd032e991bac295fb1a879efd32f20460 DIFF: https://github.com/llvm/llvm-project/commit/d079995dd032e991bac295fb1a879efd32f20460.diff

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-const-correctness-transform-pointer-as-values.cpp:12 + // CHECK-MESSAGES: [[@LINE-1]]:3: warning: variable 'p_local0' of type 'double *' can be declared 'const' + // CHEC

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille added a comment. @rsmith : once the licensing issue has been fixed, can we merge that patch or do you have any other thought? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https://reviews.llvm.org/D112916 ___ cf

[PATCH] D60380: Also document -arch as -arch is mac specific

sylvestre.ledru updated this revision to Diff 405259. sylvestre.ledru added a comment. Take in account Serge's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60380/new/ https://reviews.llvm.org/D60380 Files: clang/docs/CommandGuide/clang.

[PATCH] D60380: Also document -arch as -arch is mac specific

sylvestre.ledru updated this revision to Diff 405262. sylvestre.ledru added a comment. add . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60380/new/ https://reviews.llvm.org/D60380 Files: clang/docs/CommandGuide/clang.rst Index: clang/docs/Co

[PATCH] D60380: Also document -arch as -arch is mac specific

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. Thanks o/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60380/new/ https://reviews.llvm.org/D60380 __

  1   2   >