ashwin98 added inline comments.
================ Comment at: llvm/test/CodeGen/RISCV/xray-attribute-instrumentation.ll:1-2 +; RUN: llc -mtriple=riscv32-unknown-elf -mattr=+d -verify-machineinstrs < %s | FileCheck --check-prefix=CHECK %s +; RUN: llc -mtriple=riscv32-unknown-linux-gnu -mattr=+d -verify-machineinstrs < %s | FileCheck --check-prefix=CHECK %s +; RUN: llc -mtriple=riscv64-unknown-elf -mattr=+d -verify-machineinstrs < %s | FileCheck --check-prefix=CHECK --check-prefix=CHECK-RISCV64 %s ---------------- jrtc27 wrote: > Triples are overly verbose; riscv32-unknown-elf is normally just written > riscv32, and riscv32-unknown-linux-gnu as riscv64-linux-gnu, though I don't > see what point having both serves, we normally only use the bare-metal > triples unless something has an OS-specific aspect I will cut it down to just the ones with linux. Clang has a check to see if the OS is Linux when passed the flag for XRay instrumentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117929/new/ https://reviews.llvm.org/D117929 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
