MaskRay added a comment.

In D118804#3292176 <https://reviews.llvm.org/D118804#3292176>, @xbolva00 wrote:

>>> Reintroducing an optimization like this with an additional check that the 
>>> allocation size is large enough should be valid everywhere.
>
> Should not be hard, could you do it? Then LGTM.

@xbolva00 While I appreciate you contribution to the optimizations, I am not 
sure the burden of fixing a broken optimization lays on the issue reporter...
The revert is the safest choice both for origin/main and the now created 
origin/release/14.x.
If you are still motivated to improve the situation, you can contribute after 
the original broken patch is reverted...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118804/new/

https://reviews.llvm.org/D118804

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to