[clang] c816be2 - Add release note for aarch64-none-elf driver change.

Author: Kristof Beyls Date: 2022-01-26T09:13:22+01:00 New Revision: c816be2026af3641f9b648482c48dd1f18a73dd1 URL: https://github.com/llvm/llvm-project/commit/c816be2026af3641f9b648482c48dd1f18a73dd1 DIFF: https://github.com/llvm/llvm-project/commit/c816be2026af3641f9b648482c48dd1f18a73dd1.diff

[clang] 72e29ca - [clang-format] Fix regression in parsing pointers to arrays.

Author: Marek Kurdej Date: 2022-01-26T09:27:38+01:00 New Revision: 72e29caf039fd81bc6948e16d6f71d1581615469 URL: https://github.com/llvm/llvm-project/commit/72e29caf039fd81bc6948e16d6f71d1581615469 DIFF: https://github.com/llvm/llvm-project/commit/72e29caf039fd81bc6948e16d6f71d1581615469.diff

[PATCH] D118106: [clang-format] Fix regression in parsing pointers to arrays.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72e29caf039f: [clang-format] Fix regression in parsing pointers to arrays. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! LG with a couple of optional nits. Cut should be on 2022-02-01 or thereabouts, best to land after that if it's not a problem. Comment at: clang-tools-extra/cla

[PATCH] D118220: [clang-format] Correctly format lambdas with variadic template parameters.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/53405. Repository: rG LLVM

[PATCH] D118220: [clang-format] Correctly format lambdas with variadic template parameters.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118220/new/ https://reviews.llvm.org/D118220 ___

[PATCH] D118223: [NFC] [AST] Move isSame* check in ASTReader to ASTContext

ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, aaron.ballman, urnathan, erichkeane. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. Currently we are trying to implement the semantics of C++ Modules. A big

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu planned changes to this revision. ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2852 -if (RedundantDefaultArg) { +if (RedundantDefaultArg && !IsOldParamFromModule) { // C++ [temp.param]p12: urnathan wrote:

[PATCH] D118224: [clang-tidy] bugprone-signal-handler improvements: display call chain

balazske created this revision. Herald added subscribers: carlosgalvezp, steakhal, martong, gamesh411, Szelethus, dkrupp, xazax.hun. balazske requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Display notes for a possible call cha

[PATCH] D118225: [RISCV] Decouple Zve* extensions.

jacquesguan created this revision. jacquesguan added reviewers: craig.topper, eopXD, asb, luismarques, frasercrmck, HsiangKai, khchen, benshi001. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, joce

[PATCH] D118226: [clang][dataflow] Assign aggregate storage locations to union stmts

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This patch ensures that the dataflow analysis framework does not crash when it enco

[PATCH] D118211: Add missing namespace to PPCLinux.cpp

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118211/new/ https://reviews.llvm.org/D118211 __

[clang] 600c671 - [clang][syntax] Replace `std::vector` use

Author: Jan Svoboda Date: 2022-01-26T11:20:18+01:00 New Revision: 600c6714ac77915b7b656b860cf71494a7c9ec7f URL: https://github.com/llvm/llvm-project/commit/600c6714ac77915b7b656b860cf71494a7c9ec7f DIFF: https://github.com/llvm/llvm-project/commit/600c6714ac77915b7b656b860cf71494a7c9ec7f.diff L

[PATCH] D118109: [clang][syntax] Replace `std::vector` use

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG600c6714ac77: [clang][syntax] Replace `std::vector` use (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 76cb4cd - [clang] Fix serialized diagnostics edge-cases

Author: Jan Svoboda Date: 2022-01-26T11:21:51+01:00 New Revision: 76cb4cd074a6816f3801fd4a2bd8854597748239 URL: https://github.com/llvm/llvm-project/commit/76cb4cd074a6816f3801fd4a2bd8854597748239 DIFF: https://github.com/llvm/llvm-project/commit/76cb4cd074a6816f3801fd4a2bd8854597748239.diff L

[PATCH] D118150: [clang] Fix serialized diagnostics edge-cases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76cb4cd074a6: [clang] Fix serialized diagnostics edge-cases (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

balazske abandoned this revision. balazske added a comment. Herald added subscribers: carlosgalvezp, steakhal. A new implementation is in D118224 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97960/new/ https://r

[clang] 188d28f - [clang][dataflow] Assign aggregate storage locations to union stmts

Author: Stanislav Gatev Date: 2022-01-26T10:36:49Z New Revision: 188d28f73cc7b7891c182a85fdb6e274123b5b69 URL: https://github.com/llvm/llvm-project/commit/188d28f73cc7b7891c182a85fdb6e274123b5b69 DIFF: https://github.com/llvm/llvm-project/commit/188d28f73cc7b7891c182a85fdb6e274123b5b69.diff LO

[PATCH] D118226: [clang][dataflow] Assign aggregate storage locations to union stmts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG188d28f73cc7: [clang][dataflow] Assign aggregate storage locations to union stmts (authored by sgatev). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D117137: [Driver] Add CUDA support for --offload param

linjamaki added a comment. In D117137#3269365 , @yaxunl wrote: > Does that mean only "spirv{64}-unknown-unknown" is acceptable, or > "spirv{64}-amd-unknown-unknown" is also acceptable? Having a vendor component in the triple seems to be acceptable for t

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen updated this revision to Diff 403187. steffenlarsen marked an inline comment as done. steffenlarsen added a comment. Removing top-level `const` and adjusting style. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114439/new/ https://reviews.llvm.org/D114439 Files: clang/i

[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117753/new/ https://reviews.llvm.org/D117753 ___

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen marked 2 inline comments as done. steffenlarsen added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:497 +// Pack expansion is only allowed in the variadic argument at the end. +const size_t attrNumArgs = attributeNumberOfArguments(*AttrN

[clang-tools-extra] 19eaad9 - [clang-tidy] Cache the locations of NOLINTBEGIN/END blocks

Author: Salman Javed Date: 2022-01-27T00:12:16+13:00 New Revision: 19eaad94c47f92dd23989b0b6832bb6751dde979 URL: https://github.com/llvm/llvm-project/commit/19eaad94c47f92dd23989b0b6832bb6751dde979 DIFF: https://github.com/llvm/llvm-project/commit/19eaad94c47f92dd23989b0b6832bb6751dde979.diff

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19eaad94c47f: [clang-tidy] Cache the locations of NOLINTBEGIN/END blocks (authored by salman-javed-nz). Changed prior to commit: https://reviews.l

[clang] 04754af - Fix MSVC 'not all control paths return a value' warning. NFC.

Author: Simon Pilgrim Date: 2022-01-26T11:33:37Z New Revision: 04754af925053efdc91fd0cbe045feb7578ad1ae URL: https://github.com/llvm/llvm-project/commit/04754af925053efdc91fd0cbe045feb7578ad1ae DIFF: https://github.com/llvm/llvm-project/commit/04754af925053efdc91fd0cbe045feb7578ad1ae.diff LOG:

[clang] d3597ec - [clang][dataflow] Enable merging distinct values in Environment::join

Author: Stanislav Gatev Date: 2022-01-26T11:40:51Z New Revision: d3597ec0aaad11a670f45b42428628531d4b2c05 URL: https://github.com/llvm/llvm-project/commit/d3597ec0aaad11a670f45b42428628531d4b2c05 DIFF: https://github.com/llvm/llvm-project/commit/d3597ec0aaad11a670f45b42428628531d4b2c05.diff LO

[PATCH] D118038: [clang][dataflow] Enable merging distinct values in Environment::join

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3597ec0aaad: [clang][dataflow] Enable merging distinct values in Environment::join (authored by sgatev). Changed prior to commit: https://reviews.llvm.org/D118038?vs=402550&id=403201#toc Repository:

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM, cheers! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115501/new/ https://reviews.llvm.org/D115501

[clang-tools-extra] 8e29d19 - Revert "[clang-tidy] Cache the locations of NOLINTBEGIN/END blocks"

Author: Salman Javed Date: 2022-01-27T00:52:44+13:00 New Revision: 8e29d19b8d29db1ad60af3a8921aad7bbfc24435 URL: https://github.com/llvm/llvm-project/commit/8e29d19b8d29db1ad60af3a8921aad7bbfc24435 DIFF: https://github.com/llvm/llvm-project/commit/8e29d19b8d29db1ad60af3a8921aad7bbfc24435.diff

[PATCH] D118223: [NFC] [AST] Move isSame* check in ASTReader to ASTContext

urnathan added a comment. I'm insufficiently confident to review this kind of code motion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118223/new/ https://reviews.llvm.org/D118223 ___ cfe-commits maili

[clang-tools-extra] 5da7c04 - Re-land "Cache the locations of NOLINTBEGIN/END blocks" with fix for build bot

Author: Salman Javed Date: 2022-01-27T01:03:27+13:00 New Revision: 5da7c040030c4af72dcc21220f579098469c554e URL: https://github.com/llvm/llvm-project/commit/5da7c040030c4af72dcc21220f579098469c554e DIFF: https://github.com/llvm/llvm-project/commit/5da7c040030c4af72dcc21220f579098469c554e.diff

[PATCH] D118225: [RISCV] Decouple Zve* extensions.

eopXD added a comment. Not sure if this simplifies things. Users and the compiler can use the macro __riscv_v_elen and __riscv_v_elen_fp to do things to the vector-related target feature. Other than that I dont hold any strong objection to this refactoring. Repository: rG LLVM Github Monor

[PATCH] D118236: [clang][dataflow] Add a transfer function for CXXBoolLiteralExpr

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A

[PATCH] D118084: [CUDA, NVPTX] Pass byval aggregates directly

lebedev.ri added a comment. In D118084#3271110 , @tra wrote: > In D118084#3271073 , @jdoerfert > wrote: > >> @lebedev.ri wanted to teach SROA how to deal with dynamic indices before, >> IIRC. It seems to be gene

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

nemanjai added a comment. This is causing buildbot failures with `-Werror` (i.e. https://lab.llvm.org/buildbot/#/builders/57/builds/14322/steps/5/logs/stdio). Please fix or revert. The failure is: .../llvm-project/clang-tools-extra/clang-tidy/NoLintDirectiveHandler.cpp:204:38: error: moving

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

nemanjai added a comment. In D116085#3272200 , @nemanjai wrote: > This is causing buildbot failures with `-Werror` (i.e. > https://lab.llvm.org/buildbot/#/builders/57/builds/14322/steps/5/logs/stdio). > Please fix or revert. The failure is: > > > ...

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

salman-javed-nz added a comment. In D116085#3272200 , @nemanjai wrote: > This is causing buildbot failures with `-Werror` (i.e. > https://lab.llvm.org/buildbot/#/builders/57/builds/14322/steps/5/logs/stdio). > Please fix or revert. Thanks for the heads

[PATCH] D116753: Default to -fno-math-errno for musl too

alxu added subscribers: MaskRay, pirama, srhines. alxu added a comment. Hi, can someone take a look at this? @MaskRay, @pirama, @srhines? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116753/new/ https://reviews.llvm.org/D116753 __

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

nikic added a comment. Approach looks reasonable to me. Comment at: clang/lib/CodeGen/Address.h:29 +// so we fallback to storing the alignment separately. +template = 8> class AddressImpl {}; + Why do we need the extra T parameter? Comment at

[clang-tools-extra] c283c8d - Rewrite Doxygen comment to resolve -Wdocumentation warning (NFC)

Author: Salman Javed Date: 2022-01-27T02:21:05+13:00 New Revision: c283c8dfb5a9770126f06f55644c6208b5582c19 URL: https://github.com/llvm/llvm-project/commit/c283c8dfb5a9770126f06f55644c6208b5582c19 DIFF: https://github.com/llvm/llvm-project/commit/c283c8dfb5a9770126f06f55644c6208b5582c19.diff

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118110/new/ https://reviews.llvm.org/D118110 _

[PATCH] D118224: [clang-tidy] bugprone-signal-handler improvements: display call chain

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:199-200 +const FunctionDecl *HandlerDecl, const Expr *HandlerRef) { + int CallLevel = Itr.getPathLength() - 2; + const CallGraphNode *Caller = Itr.getPath(CallLevel

[PATCH] D118223: [NFC] [AST] Move isSame* check in ASTReader to ASTContext

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This seems fine to me, no reason it cannot live in ASTContext if it makes future code easier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D117864: [clangd] Enable hover on character literal.

hokein added a comment. friendly ping, I think it would be nice to get it in before 14 release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117864/new/ https://reviews.llvm.org/D117864 ___ cfe-commits

[PATCH] D118245: [clang][DeclPrinter] Fix printing for noexcept expressions

kadircet created this revision. kadircet added a reviewer: kbobyrev. Herald added a subscriber: usaxena95. kadircet requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. We are already building into the final result, no need to appe

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp updated this revision to Diff 403244. JesApp added a comment. As requested by @carlosgalvezp, this update uses the get_tidy_invocation function, rather than building it's own test invocation. I chose to pass all arguments of the script, in case any of them ever have an impact on what is

[PATCH] D118224: [clang-tidy] bugprone-signal-handler improvements: display call chain

balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:199-200 +const FunctionDecl *HandlerDecl, const Expr *HandlerRef) { + int CallLevel = Itr.getPathLength() - 2; + const CallGraphNode *Caller = Itr.getPath(CallLevel + 1)

[PATCH] D118245: [clang][DeclPrinter] Fix printing for noexcept expressions

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118245/new/ https://reviews.llvm.org/D118245

[PATCH] D117864: [clangd] Enable hover on character literal.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:1254 + [](HoverInfo &HI) { + HI.Name = "expression", HI.Type = "char"; +

[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33c3ef2fbeec: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover (authored by sammccall). Repository: rG LLVM Github

[clang] 33c3ef2 - [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

Author: Sam McCall Date: 2022-01-26T15:51:17+01:00 New Revision: 33c3ef2fbeec4ede5fc303b09cdca99ae2c0522a URL: https://github.com/llvm/llvm-project/commit/33c3ef2fbeec4ede5fc303b09cdca99ae2c0522a DIFF: https://github.com/llvm/llvm-project/commit/33c3ef2fbeec4ede5fc303b09cdca99ae2c0522a.diff LO

[clang] f720272 - [clang][lex] Include tracking: simplify and move to preprocessor

Author: Jan Svoboda Date: 2022-01-26T15:56:26+01:00 New Revision: f7202723304461c4f94399b906333d6ede85579a URL: https://github.com/llvm/llvm-project/commit/f7202723304461c4f94399b906333d6ede85579a DIFF: https://github.com/llvm/llvm-project/commit/f7202723304461c4f94399b906333d6ede85579a.diff L

[PATCH] D114095: [clang][lex] Include tracking: simplify and move to preprocessor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf72027233044: [clang][lex] Include tracking: simplify and move to preprocessor (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CH

[PATCH] D118247: [clang] NFC: Use flush() idiomatically

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. kbobyrev requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using both `raw_ostream::flush()` and `raw_ostream::str()` consecutively is redundant. The alternatives are: - Us

[PATCH] D117939: [clang-tidy] Add more documentation about check development

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:362 +Private custom matchers are a good example of auxiliary support code for your check +that is best tested with a unit test. It will be easier to test your matchers or +other

[clang] b777d35 - [clang][DeclPrinter] Fix printing for noexcept expressions

Author: Kadir Cetinkaya Date: 2022-01-26T16:04:24+01:00 New Revision: b777d354f6703afd58b1803fdfb6d43a607d8fd6 URL: https://github.com/llvm/llvm-project/commit/b777d354f6703afd58b1803fdfb6d43a607d8fd6 DIFF: https://github.com/llvm/llvm-project/commit/b777d354f6703afd58b1803fdfb6d43a607d8fd6.dif

[PATCH] D118245: [clang][DeclPrinter] Fix printing for noexcept expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb777d354f670: [clang][DeclPrinter] Fix printing for noexcept expressions (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D118224: [clang-tidy] bugprone-signal-handler improvements: display call chain

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:199-200 +const FunctionDecl *HandlerDecl, const Expr *HandlerRef) { + int CallLevel = Itr.getPathLength() - 2; + const CallGraphNode *Caller = Itr.getPath(CallLevel

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

carlosgalvezp added a comment. Looks good to me! A general comment not related to this patch is that the `get_tidy_invocation` is very error prone when called like that, since all arguments are strings. It would be better to specify the arguments: get_tidy_invocation(name="", clang_tidy_binar

[clang] 93948c5 - [clang-format] Correctly format lambdas with variadic template parameters.

Author: Marek Kurdej Date: 2022-01-26T16:10:52+01:00 New Revision: 93948c5299d7ee446aa707221751a0af2b87c12b URL: https://github.com/llvm/llvm-project/commit/93948c5299d7ee446aa707221751a0af2b87c12b DIFF: https://github.com/llvm/llvm-project/commit/93948c5299d7ee446aa707221751a0af2b87c12b.diff

[PATCH] D118220: [clang-format] Correctly format lambdas with variadic template parameters.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93948c5299d7: [clang-format] Correctly format lambdas with variadic template parameters. (authored by curdeius). Repository: rG LLVM Github Monore

[PATCH] D118178: [clang][dataflow] Allow clients to disable built-in transfer functions.

sgatev accepted this revision. sgatev added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.h:44 class TypeErasedDataflowAnalysis { + // Determines whether to apply the built-in

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. I'm new to phabricator, buildkite, your whole setup. Any idea why the patch fails? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/ https://reviews.llvm.org/D118104 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

carlosgalvezp added a comment. Perhaps the patch was applied on a too old baseline, could you try rebasing on top of latest main? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/ https://reviews.llvm.org/D118104 ___ cfe-commits mail

[PATCH] D112915: [clang][modules] Track included files per submodule

jansvoboda11 updated this revision to Diff 403263. jansvoboda11 added a comment. Rebase, update unnecessary `auto`, run `clang-format` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112915/new/ https://reviews.llvm.org/D112915 Files: clang/includ

[clang] 75c22b3 - [clang][dataflow] Add a transfer function for CXXBoolLiteralExpr

Author: Stanislav Gatev Date: 2022-01-26T15:33:00Z New Revision: 75c22b382f2a7b0bb9499215a3d64e146e3f02cc URL: https://github.com/llvm/llvm-project/commit/75c22b382f2a7b0bb9499215a3d64e146e3f02cc DIFF: https://github.com/llvm/llvm-project/commit/75c22b382f2a7b0bb9499215a3d64e146e3f02cc.diff LO

[PATCH] D118236: [clang][dataflow] Add a transfer function for CXXBoolLiteralExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75c22b382f2a: [clang][dataflow] Add a transfer function for CXXBoolLiteralExpr (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D118070: Add /winsysroot support to lld

pkasting updated this revision to Diff 403265. pkasting added a comment. Herald added subscribers: cfe-commits, dexonsmith, mstorsjo. Herald added a project: clang. Adds autodetection and full support for other clang-cl switches, but doesn't work: config->machine is not set this early, so it's al

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

aaron.ballman added a comment. There's a testing issue on Windows: TEST 'Clang :: Headers/mm_malloc.c' FAILED Script: -- : 'RUN: at line 1'; c:\ws\w2\llvm-project\premerge-checks\build\bin\clang.exe -emit-llvm -std=c11 -x c C:\ws\w2\llvm-proj

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed. Don't test with O1 , add the dummy include folder to the include path (`clang/test/Headers/Inputs/include`), stdlib.h is already the

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

probinson added a comment. > I think we should assume that PS4 will as well. Yes, please. We are essentially locked to the ABI as of clang 3.2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117616/new/ https://reviews.llvm.org/D117616 __

[PATCH] D118253: [RISCV] Add the passthru operand for some RVV nomask unary and nullary intrinsics.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, frasercrmck, kito-cheng, arcbbb, monkchiang, eopXD. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewe

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers updated this revision to Diff 403276. vabridgers added a comment. - update test case - add initial Loc bitwidth check for evalBinOpLL for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118050/new/ https://reviews.llvm.org/D118050

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers added a comment. I updated the test case after verifying I can reproduce the crash without the fix. I also experimented with adding a bitwidth check for the lhs and rhs loc parameters to evalBinOpLL, and verified this assert catches the negative (crash) case. I explored adding a 'me

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers marked an inline comment as done. vabridgers added inline comments. Comment at: clang/test/Analysis/cstring-checker-addressspace.c:14 +// Copy from host to device memory. +DEVICE void *memcpy(DEVICE void *dst, const void *src, unsigned long len); + ste

[PATCH] D118224: [clang-tidy] bugprone-signal-handler improvements: display call chain

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:192-193 diag(CallOrRef->getBeginLoc(), - "%0 may not be asynchronous-safe; " - "calling it from a signal handler may be dangerous") - << CalledFunction; -

[PATCH] D56303: [clang-tidy] Recognize labelled statements when simplifying boolean exprs

aaron.ballman added a comment. In D56303#3270090 , @LegalizeAdulthood wrote: > In D56303#3266252 , @njames93 wrote: > >> A large portion of the changes, especially in the checks implementation >> file, appear to b

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. @aaron.ballman I think I incorporated all of your feedback. Is this okay for me to merge to main? I would like to get it in before the feature branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://revie

[PATCH] D118257: [AArch64] Generate fcmps when appropriate for neon intrinsics

john.brawn created this revision. john.brawn added reviewers: kpn, cameron.mcinally, dmgreen, t.p.northover. Herald added a subscriber: kristof.beyls. john.brawn requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D11825

[PATCH] D118225: [RISCV] Decouple Zve* extensions.

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:747 // Could not implement Zve* extension and the V extension at the same time. - if (HasZve32x && HasV) + if (HasZve && HasV) return createStringError( Now we need to che

[PATCH] D111100: enable plugins for clang-tidy

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks for the fixes, this LGTM! However, if @alexfh can sign off as well as code owner, I'd appreciate it; this is a pretty big directional change and I think he should be on bo

[clang] b797d5e - [CMake] [Clang] Add option to specify PowerPC long double format

Author: Qiu Chaofan Date: 2022-01-27T00:50:53+08:00 New Revision: b797d5e6b21b3af3d581642c9a535327aa0764a7 URL: https://github.com/llvm/llvm-project/commit/b797d5e6b21b3af3d581642c9a535327aa0764a7 DIFF: https://github.com/llvm/llvm-project/commit/b797d5e6b21b3af3d581642c9a535327aa0764a7.diff L

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb797d5e6b21b: [CMake] [Clang] Add option to specify PowerPC long double format (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D118178: [clang][dataflow] Allow clients to disable built-in transfer functions.

ymandel updated this revision to Diff 403296. ymandel added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118178/new/ https://reviews.llvm.org/D118178 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalys

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn created this revision. john.brawn added reviewers: kpn, cameron.mcinally, dmgreen, t.p.northover. Herald added a subscriber: kristof.beyls. john.brawn requested review of this revision. Herald added a project: clang. This test no longer fails during isel, but does need the expected outp

[PATCH] D118260: [clangd][Hover] Suppress initializers with many tokens

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This results in excessive memor

[PATCH] D118158: [OpenCL] opencl-c.h: refactor named addrspace builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM, aside from the name that can be fixed on a final commit! Comment at: clang/lib/Headers/opencl-c-base.h:78 +// space overloads for builtin functions that take a po

[clang] a2fe81f - [clang] NFC: Use flush() idiomatically

Author: Kirill Bobyrev Date: 2022-01-26T18:24:38+01:00 New Revision: a2fe81f32c3a2772e49cbd5978db4e5812a3 URL: https://github.com/llvm/llvm-project/commit/a2fe81f32c3a2772e49cbd5978db4e5812a3 DIFF: https://github.com/llvm/llvm-project/commit/a2fe81f32c3a2772e49cbd5978db4e5812a3.diff

[PATCH] D118247: [clang] NFC: Use flush() idiomatically

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2fe81f32c3a: [clang] NFC: Use flush() idiomatically (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang] 3595189 - [clang][dataflow] Allow clients to disable built-in transfer functions.

Author: Yitzhak Mandelbaum Date: 2022-01-26T17:24:59Z New Revision: 3595189217e684fcdaa87a78077d97f29549f560 URL: https://github.com/llvm/llvm-project/commit/3595189217e684fcdaa87a78077d97f29549f560 DIFF: https://github.com/llvm/llvm-project/commit/3595189217e684fcdaa87a78077d97f29549f560.diff

[PATCH] D118178: [clang][dataflow] Allow clients to disable built-in transfer functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3595189217e6: [clang][dataflow] Allow clients to disable built-in transfer functions. (authored by ymandel). Changed prior to commit: https://revi

[PATCH] D118070: Add /winsysroot support to lld

pkasting updated this revision to Diff 403316. pkasting edited the summary of this revision. pkasting added a comment. Functional, but not yet refactored to share code with clang-cl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https:/

[PATCH] D116753: Default to -fno-math-errno for musl too

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Verified with the docs from musl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116753/new/ https://reviews.llvm.org/D116753

[PATCH] D115415: [clang][macho] add clang frontend support for emitting macho files with two build version load commands

zhaoyangli added a comment. I saw another change trying to add a separate runtime for Mac Catalyst in compiler-rt: https://reviews.llvm.org/D117924. I patched that one in and it looks worked for us. Also friendly pinging for this change (and catalyst support in compiler-rt). We were kind of bl

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. This looks reasonable to me, though I'd prefer we keep the forward declare. The scalar->vector transform is mechanical and the `if (Args.hasArg(options::OPT_fopenmp_new_drive

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

aeubanks updated this revision to Diff 403323. aeubanks added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117262/new/ https://reviews.llvm.org/D117262 Files: clang/lib/CodeGen/Address.h Index: clang/lib/CodeGen/Add

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

aeubanks added inline comments. Comment at: clang/lib/CodeGen/Address.h:29 +// so we fallback to storing the alignment separately. +template = 8> class AddressImpl {}; + nikic wrote: > Why do we need the extra T parameter? without it we end up instantiating `Addr

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LG from my side Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117262/new/ https://reviews.llvm.org/D117262 __

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

JonChesterfield requested changes to this revision. JonChesterfield added a comment. This revision now requires changes to proceed. I don't think this works for multiple files. The test only tries one and misses all the parsing handling. Comment at: clang/include/clang/Basic/C

  1   2   >