carlosgalvezp added a comment. Looks good to me! A general comment not related to this patch is that the `get_tidy_invocation` is very error prone when called like that, since all arguments are strings. It would be better to specify the arguments:
get_tidy_invocation(name="", clang_tidy_binary=args.clang_tidy_binary,...) I haven't reviewed this file much and I'm quite new as reviewer so perhaps it's good that someone else takes another look and agrees with the change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/ https://reviews.llvm.org/D118104 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
