nikic added a comment.
Approach looks reasonable to me.
================
Comment at: clang/lib/CodeGen/Address.h:29
+// so we fallback to storing the alignment separately.
+template <typename T, bool = alignof(llvm::Value *) >= 8> class AddressImpl {};
+
----------------
Why do we need the extra T parameter?
================
Comment at: clang/lib/CodeGen/Address.h:70
+ unsigned AlignLog = (Pointer.getInt() << 3) | ElementType.getInt();
+ return CharUnits::fromQuantity(1 << AlignLog);
+ }
----------------
This should probably be `1UL` to avoid UB for large alignments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117262/new/
https://reviews.llvm.org/D117262
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
