[clang] 49d3118 - [clang-format] Missing space after cast in a macro

Author: mydeveloperday Date: 2022-01-06T08:07:03Z New Revision: 49d311874edc928831ccaddd621801a4dbee580d URL: https://github.com/llvm/llvm-project/commit/49d311874edc928831ccaddd621801a4dbee580d DIFF: https://github.com/llvm/llvm-project/commit/49d311874edc928831ccaddd621801a4dbee580d.diff LOG

[PATCH] D116592: [clang-format] Missing space after cast in a macro

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG49d311874edc: [clang-format] Missing space after cast in a macro (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca added a comment. In D114601#3223155 , @tra wrote: > Ping. @mojca, do you need help landing the patch? Yes, please. I don't have commit access yet. You can attribute it to mojca at macports.org, for example. We also need a fix for unit tests on the

[PATCH] D116726: [clang-format] Fix a crash (assertion) in qualifier alignment when matching template closer is null

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: owenpan, curdeius, HazardyKnusperkeks, JohelEGP. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/53008 template using A = quan

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca added a comment. Also, I would like to get to do some further "baby steps" towards better support of CUDA on Windows in particular, but I would need some guidelines. I requested a special channel that would allow a bit of discussion https://discord.com/channels/636084430946959380/. What wo

[clang] e8b98a5 - [CodeGen] Emit elementtype attributes for indirect inline asm constraints

Author: Nikita Popov Date: 2022-01-06T09:29:22+01:00 New Revision: e8b98a5216dbfdaa31f7016955f9586cef94a626 URL: https://github.com/llvm/llvm-project/commit/e8b98a5216dbfdaa31f7016955f9586cef94a626 DIFF: https://github.com/llvm/llvm-project/commit/e8b98a5216dbfdaa31f7016955f9586cef94a626.diff

[PATCH] D116666: [CodeGen] Emit elementtype attributes for indirect inline asm constraints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8b98a5216db: [CodeGen] Emit elementtype attributes for indirect inline asm constraints (authored by nikic). Herald added a project: clang. Herald ad

[PATCH] D116351: Update Bug report URL to Github Issues

jhenderson accepted this revision. jhenderson added a comment. LGTM, from my point of view. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D116726: [clang-format] Fix a crash (assertion) in qualifier alignment when matching template closer is null

MyDeveloperDay updated this revision to Diff 397806. MyDeveloperDay added a comment. The cause is because Next is a comment, not a template opener, handle that case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116726/new/ https://reviews.llvm.org/D116726 Files: clang/lib/Format/Qua

[PATCH] D116726: [clang-format] Fix a crash (assertion) in qualifier alignment when matching template closer is null

curdeius added inline comments. Comment at: clang/unittests/Format/QualifierFixerTest.cpp:830 + verifyFormat("template using A = quantity, 1>;", Style); + verifyFormat("template using A = quantity /**/, 1>;", + Style); Could you test with a line

[PATCH] D116726: [clang-format] Fix a crash (assertion) in qualifier alignment when matching template closer is null

curdeius added inline comments. Comment at: clang/unittests/Format/QualifierFixerTest.cpp:830 + verifyFormat("template using A = quantity, 1>;", Style); + verifyFormat("template using A = quantity /**/, 1>;", + Style); curdeius wrote: > curdeius

[PATCH] D116701: Respect -fsanitize-memory-param-retval flag.

vitalybuka added a comment. >> Implementation of flag introduced in https://reviews.llvm.org/D116633 It's not implementation, the goal of -sanitize-memory-param-retval to setup Msan pass with proper parameters This part usability improvement to avoid one flag, which I slightly like, but @eugeni

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

vitalybuka added a comment. we probably should to move clang parts from D116634 into this patch? Comment at: clang/include/clang/Basic/CodeGenOptions.def:234 ///< destructors are emitted. +CODEGEN

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille updated this revision to Diff 397813. serge-sans-paille added a comment. Fix some parts of the bidi algorithm, and add extra test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 Files: clang-tools-extra/clang-tidy/mis

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

MyDeveloperDay added a comment. I would say for the `ColumnLimit:0` case, we don't have to wrap a single import like this: for `JavaScriptWrapImports :true` import { Get } from '@nestjs/common'; For more than one import then I'd say it should do: import { Get, Req } fr

[PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu added a comment. It looks like @asl isn't here and many experienced guys accepted this. So I think it might should be good to commit this one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 _

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Owen I think we should push ahead with this rather than D95168: [clang-format] Add Insert/Remove Braces option as I've looked at what you've d

[libunwind] bbce75e - Update Bug report URL to Github Issues

Author: Chuanqi Xu Date: 2022-01-06T17:33:25+08:00 New Revision: bbce75e352be0637305a1b59ac5eca7175bceece URL: https://github.com/llvm/llvm-project/commit/bbce75e352be0637305a1b59ac5eca7175bceece DIFF: https://github.com/llvm/llvm-project/commit/bbce75e352be0637305a1b59ac5eca7175bceece.diff LO

[PATCH] D116351: Update Bug report URL to Github Issues

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbce75e352be: Update Bug report URL to Github Issues (authored by

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

owenpan added a comment. In D116316#3224591 , @MyDeveloperDay wrote: > Owen I think we should push ahead with this rather than D95168: > [clang-format] Add Insert/Remove Braces option > as I've looked at what you've do

[PATCH] D116731: [Clang] Make Clang copy its CMake modules into the build dir

awarzynski created this revision. Herald added subscribers: Chia-hungDuan, rriddle, mgorny. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, stephenneuendorffer. Herald added a project: clang. LLVM has a documented mechanism for passing configuration information

[PATCH] D116378: [clang-tidy] Disable clang-tidy warnings from system macros

salman-javed-nz added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:23-40 +namespace { +class VaArgPPCallbacks : public PPCallbacks { +public: + VaArgPPCallbacks(ProTypeVarargCheck *Check) : Check(Check) {} + + void MacroExp

[PATCH] D116731: [Clang] Make Clang copy its CMake modules into the build dir

awarzynski added a comment. For a bit of context - this came up in a discussion for https://reviews.llvm.org/D116566/. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116731/new/ https://reviews.llvm.org/D116731

[PATCH] D112913: Misleading bidirectional detection

upsuper added a comment. I think the core algorithm looks correct now. I'll leave the code review to LLVM reviewers. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 ___ cfe-commits mailing l

[PATCH] D116599: Simplify AttrBuilder storage for target dependent attributes

serge-sans-paille updated this revision to Diff 397831. serge-sans-paille added a comment. Minor updates CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116599/new/ https://reviews.llvm.org/D116599 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBuiltin.cpp clang/lib/Code

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

ChuanqiXu updated this revision to Diff 397835. ChuanqiXu added a comment. Herald added a reviewer: aaron.ballman. Address comments: - Update warning message as Mathias's suggestion. - Update document. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115867/new/ https://reviews.llvm.org/D

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

curdeius accepted this revision. curdeius added a comment. LGTM with some nits. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:435-454 +bool UnwrappedLineParser::precededByCommentOrPPDirective() const { + const size_t size = Lines.size(); + if (size > 0 && Lines[size -

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

estan added a comment. @carlosgalvezp Oh yes, that would be even better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88833/new/ https://reviews.llvm.org/D88833 ___ cfe-commits mailing list cfe-commits@

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

estan added a comment. In D88833#3222829 , @estan wrote: > Sounds good @aaron.ballman, let's wait for @fiesh. > > Though I realize now that the scope of this patch is probably not enough to > solve a problem we have in our code base. The check will warn a

[PATCH] D115936: [Clang] Add isInNamespace() to check if a Decl in a specific namespace

junaire updated this revision to Diff 397842. junaire added a comment. After Aarron's comments, I realize what I really want to do is add a new ASTMatcher that matches declarations what in the top level namespace like std. This update fixed previous broken one, added some comments and unit tests.

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

jacquesguan added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106518/new/ https://reviews.llvm.org/D106518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D116736: [Clang] Add __builtin_reduce_or and __builtin_reduce_and

junaire created this revision. junaire added a reviewer: fhahn. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements two builtins specified in D111529 . The last __builtin_reduce_a

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2021 + // fields imported) at that time without multiple AST import passes. + To->setCompleteDefinition(true); // Complete the definition even if error is returned. balazske wrote: > ba

[PATCH] D116726: [clang-format] Fix a crash (assertion) in qualifier alignment when matching template closer is null

MyDeveloperDay updated this revision to Diff 397853. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Use getNextNonComment() which has some const-ness knock ons (but probably not a bad thing) address the review concerns by adding more tests (which indeed highligh

[PATCH] D116378: [clang-tidy] Disable clang-tidy warnings from system macros

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:23-40 +namespace { +class VaArgPPCallbacks : public PPCallbacks { +public: + VaArgPPCallbacks(ProTypeVarargCheck *Check) : Check(Check) {} + + void MacroExpan

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

andmis added a comment. Thanks for the feedback. Two things: 1. Force-breaking at >= 2 imports and not breaking at 1 import feels has the advantage of being simple to state, implement, document, and test, but I don't think it's actually the behavior people will want. For example, the original

[PATCH] D114787: [clang][PR51931] Enable `-Wdeclaration-after-statement` for all C versions

zero9178 updated this revision to Diff 397857. zero9178 added a comment. Addressed reviewer comments: Added tests for cases when the diagnostic should not be emitted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114787/new/ https://reviews.llvm.org/D114787 Files: clang/include/clan

[PATCH] D114787: [clang][PR51931] Enable `-Wdeclaration-after-statement` for all C versions

zero9178 marked an inline comment as done. zero9178 added inline comments. Comment at: clang/test/Sema/warn-mixed-decls.c:1-4 +/* RUN: %clang_cc1 -fsyntax-only -verify -std=c89 -pedantic %s + */ +/* RUN: %clang_cc1 -fsyntax-only -verify -std=c99 -Wdeclaration-after-statement %s

[PATCH] D116636: [WIP] Enable `-Wstrict-calls-without-prototype` by default

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. I don't see a justification for enabling this diagnostic by default in C89 mode. I can imagine users wanting to opt into this behavior for C89, but it certainly shouldn

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5529 +def warn_call_function_without_prototype : Warning< + "calling function %0 with arguments when function has no prototype">, InGroup< + DiagGroup<"strict-calls-without-protot

[PATCH] D116329: [clang-check] Adjust argument adjusters for clang-check to strip options blocking the static analyzer

sammccall added inline comments. Comment at: clang/tools/clang-check/ClangCheck.cpp:217 +if (!AnalyzerOutput.empty()) { + Tool.appendArgumentsAdjuster(getInsertArgumentAdjuster("-o")); + Tool.appendArgumentsAdjuster( you can pass a vector to getInse

[PATCH] D116378: [clang-tidy] Disable clang-tidy warnings from system macros

carlosgalvezp updated this revision to Diff 397859. carlosgalvezp added a comment. Revert formatting, clarify necessary changes to existing check in the commit message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116378/new/ https://reviews.llvm.org/D116378 Files: clang-tools-extr

[PATCH] D116378: [clang-tidy] Disable clang-tidy warnings from system macros

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:23-40 +namespace { +class VaArgPPCallbacks : public PPCallbacks { +public: + VaArgPPCallbacks(ProTypeVarargCheck *Check) : Check(Check) {} + + void MacroExpan

[PATCH] D114787: [clang][PR51931] Enable `-Wdeclaration-after-statement` for all C versions

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9865 def ext_mixed_decls_code : Extension< "ISO C90 forbids mixing declarations and code">, + InGroup; In the other review, I left a comment about the diagnosti

[PATCH] D116726: [clang-format] Fix a crash (assertion) in qualifier alignment when matching template closer is null

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM! Thanks :). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116726/new/ https://reviews.llvm.org/D116726 ___ cfe-commits mailing li

[PATCH] D116726: [clang-format] Fix a crash (assertion) in qualifier alignment when matching template closer is null

curdeius added a comment. Just a last thought, you can maybe minimize some of the test cases. It seems that even: using X = Y /**/ <>; reproduces the issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116726/new/ https://reviews.llvm.org/D116726 __

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik updated this revision to Diff 397866. philnik marked 3 inline comments as done. philnik added a comment. - Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 Files: clang/docs/Re

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

MyDeveloperDay added a comment. > (1) very few people use... I don't think it's actually the behavior people > will want Subjective or Objective opinion? https://github.com/search?o=desc&q=%22ColumnLimit%3A+0%22&s=indexed&type=Code 95,000+ occurrences of "ColumnLimit" in github YAML files

[PATCH] D55134: [CTU] Add triple/lang mismatch handling

martong added a comment. In D55134#3224339 , @ychen wrote: > FWIW, ASTUnit seems to save an effective triple while the current AST uses > the nominal triple. (for example, `armv7a-xx-xx-eabihf` vs > `armv7a-xx-xx-eabi`). I'm not sure if there is a good s

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

curdeius added inline comments. Comment at: clang/include/clang/Format/Format.h:2620 + /// + /// * If ``ColumnWidth`` is 0 (no limit on the number of columns), + /// then import statements will keep the number of lines they Please change all occurrences of `

[PATCH] D116513: [clang-tidy] Fix bugs in misc-unused-parameters for Constructors calls site

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-unused-parameters.cpp:157-159 // CHECK-FIXES: C() {} C(int i) {} // CHECK-MESSAGES: :[[@LINE-1]]:9: warning mehdi_amini wrote: > aaron.ballman wrote: > > I thin

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

andmis added a comment. My guess that `ColumnLimit: 0` is rarely used for JS is based on the objective fact that JS import formatting is (IMO very) buggy with the column limit set that way, and it took several years for us to hear a bug report about it. And "we should not make assumptions about

[PATCH] D116512: [clang-tidy] Limit non-Strict mode to public functions

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-unused-parameters.rst:43 + a human reader, and there's basically no place for a bug to hide. On the other + hand for non-public functions, all the call-sites are visible and the

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan added inline comments. Comment at: clang/test/ASTMerge/codegen-body/test.c:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/body1.c Jake-Egan wrote: > shchenz wrote: > > Jake-Egan wrote: > > > shchenz wrote: > > >

[PATCH] D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does

thakis added inline comments. Comment at: clang/test/SemaCXX/MicrosoftCompatibility.cpp:4 // RUN: %clang_cc1 %s -triple i686-pc-win32 -fsyntax-only -std=c++11 -Wmicrosoft -verify -fms-compatibility -fexceptions -fcxx-exceptions -fms-compatibility-version=19.00 // RUN: %clang_

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added a comment. ping: Requesting review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman updated this revision to Diff 397882. dgoldman added a comment. Improve double-quotes.m test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115183/new/ https://reviews.llvm.org/D115183 Files: clang/include/clang/Lex/HeaderSearch.h clan

[PATCH] D116673: [Clang][NVPTX]Add NVPTX intrinsics and builtins for CUDA PTX cvt sm80 instructions

JackAKirk updated this revision to Diff 397884. JackAKirk added a comment. Made suggested change to naming convention. Added a few missing lines from the original patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116673/new/ https://reviews.llvm.org/D116673 Files: clang/include/c

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille updated this revision to Diff 397885. serge-sans-paille added a comment. rebased on main branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/cla

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added a comment. Thanks @upsuper! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] d5ba066 - [clang][lex] NFC: Move some HeaderSearch functions to .cpp file

Author: Jan Svoboda Date: 2022-01-06T16:32:02+01:00 New Revision: d5ba066cb6641d1923dca90bb4e1a1cecbcd02b7 URL: https://github.com/llvm/llvm-project/commit/d5ba066cb6641d1923dca90bb4e1a1cecbcd02b7 DIFF: https://github.com/llvm/llvm-project/commit/d5ba066cb6641d1923dca90bb4e1a1cecbcd02b7.diff L

[PATCH] D112913: Misleading bidirectional detection

aaron.ballman added a comment. Has this been tested against any large code bases that use bidirectional characters to see what the false positive rate is? Also, have you seen the latest Unicode guidance on this topic: https://unicode.org/L2/L2022/22007-avoiding-spoof.pdf to make sure we're fol

[PATCH] D115521: [Templight] Don't display empty strings for names of unnamed template parameters

martong added inline comments. Comment at: clang/lib/Frontend/FrontendActions.cpp:501 + +if (const auto *Decl = dyn_cast(NamedTemplate)) { + if (const auto *R = dyn_cast(Decl)) { martong wrote: > Should this handle `EnumDecl`s as well? An enum declaratio

[PATCH] D116337: [clang] set __NO_MATH_ERRNO__ if -fno-math-errno

aaron.ballman added a comment. It looks like precommit CI is still failing on `Clang :: Preprocessor/predefined-macros.c` on Windows (the Debian failures look unrelated, but you should double-check just to be sure). https://buildkite.com/llvm-project/premerge-checks/builds/72399#4ba61c84-15ff-4

[clang] f558acf - Reland "[clang][ObjC] Add fix it for missing methods in impl"

Author: David Goldman Date: 2022-01-06T10:55:02-05:00 New Revision: f558acf49201a843df3f0d3dd7e77bb5ea91568c URL: https://github.com/llvm/llvm-project/commit/f558acf49201a843df3f0d3dd7e77bb5ea91568c DIFF: https://github.com/llvm/llvm-project/commit/f558acf49201a843df3f0d3dd7e77bb5ea91568c.diff

[PATCH] D116748: [AArch64][ARM][Clang] PerfMon Extension Added

mubashar_ created this revision. mubashar_ added a reviewer: lenary. Herald added subscribers: hiraditya, kristof.beyls. mubashar_ requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Performance monitor architecture extension

[clang] e3e8799 - [AST] ASTContext::mergeTypes - pull out repeated getAs<> calls. NFC.

Author: Simon Pilgrim Date: 2022-01-06T16:04:36Z New Revision: e3e8799bebd0e624de21b9e93e358b9396bf4ace URL: https://github.com/llvm/llvm-project/commit/e3e8799bebd0e624de21b9e93e358b9396bf4ace DIFF: https://github.com/llvm/llvm-project/commit/e3e8799bebd0e624de21b9e93e358b9396bf4ace.diff LOG:

[PATCH] D116748: [AArch64][ARM][Clang] PerfMon Extension Added

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. I'm happy with this patch, but you could update the description to be clearer that you're adding an option to allow PMU v3.4 to be enabled/disabled separately to the architecture - not adding

[PATCH] D116726: [clang-format] Fix a crash (assertion) in qualifier alignment when matching template closer is null

MyDeveloperDay updated this revision to Diff 397898. MyDeveloperDay added a comment. Simplify down the test to make it easier to read, keep perhaps slightly duplicated tests to just ensure we have the coverage CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116726/new/ https://reviews.ll

[PATCH] D116750: [clang][lex] Keep search directory indices up-to-date

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, ahoppen. Herald added a subscriber: mgorny. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `HeaderSearch::SearchDirToHSEntry` map ref

[PATCH] D116751: [clang][lex] NFC: Extract module creation into function

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, ahoppen. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch extracts the construction of `Module` within `ModuleMap` into a separ

[PATCH] D113676: WIP: [clang][lex] Fix search path usage remark with modules

jansvoboda11 updated this revision to Diff 397902. jansvoboda11 added a comment. Rebase on top of extracted patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113676/new/ https://reviews.llvm.org/D113676 Files: clang/include/clang/Lex/Header

[clang] 2ccf0b7 - Fix build failure with GCC 11 in C++20 mode

Author: Evgeny Mandrikov Date: 2022-01-06T17:20:26+01:00 New Revision: 2ccf0b76bcaf0895e04f14e3ff53c59dd96f9f0f URL: https://github.com/llvm/llvm-project/commit/2ccf0b76bcaf0895e04f14e3ff53c59dd96f9f0f DIFF: https://github.com/llvm/llvm-project/commit/2ccf0b76bcaf0895e04f14e3ff53c59dd96f9f0f.di

[PATCH] D115355: Fix build failure with GCC 11 in C++20 mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ccf0b76bcaf: Fix build failure with GCC 11 in C++20 mode (authored by Godin, committed by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115355/new

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

balazske added a comment. The functions `asctime` and `asctime_r` are discouraged according to CERT MSC33-C rule. These could be added to this check as well. There is a clang SA checker `SecuritySyntaxChecker` that contains other obsolete functions (and the whole check looks like it can be done

[PATCH] D104830: AST: Create __va_list in the std namespace even in C.

jrtc27 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104830/new/ https://reviews.llvm.org/D104830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D113676: [clang][lex] Fix search path usage remark with modules

jansvoboda11 marked an inline comment as done. jansvoboda11 added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:95 + if (HS.CurrentSearchPathIdx != ~0U) +HS.ModuleToSearchDirIdx[M] = HS.CurrentSearchPathIdx; +} ahoppen wrote: > Thes

[PATCH] D116670: [ASan] Driver changes to always link-in asan_static library.

kstoimenov updated this revision to Diff 397908. kstoimenov added a comment. Lint if statement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116670/new/ https://reviews.llvm.org/D116670 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/

[PATCH] D116731: [Clang] Make Clang copy its CMake modules into the build dir

PeteSteinfeld accepted this revision. PeteSteinfeld added a comment. This revision is now accepted and ready to land. Thanks for doing this! After adopting this change, I did an in tree build followed by an out of tree build -- both without creating or using the install area. Both builds were

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam added a comment. In D116549#3218281 , @jdoerfert wrote: > Can you make the test check for the diagnose message? Also, do we have a test > to verify an isa trait is properly handled? I don't see a point in adding a diagnostic message when a feat

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

saiislam updated this revision to Diff 397912. saiislam added a comment. Herald added a subscriber: jvesely. Added target specific tests for ISA traits, for CPU as well as GPU. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116549/new/ https://revie

[PATCH] D113676: [clang][lex] Fix search path usage remark with modules

jansvoboda11 marked an inline comment as done. jansvoboda11 added a comment. I'm starting to think it could be fine to keep doing things as outlined by this patch: only marking search paths that discovered a module as used when its `Module` gets returned from `HeaderSearch` (and ignoring `Module

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added a comment. @aaron.ballman unfortunately I don't know any of those. If I recall correctly we found no software in the RedHat collection actually using those control characters :-/ My understanding is that we are inline with the document you mention, except the fact that 1

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added a comment. Note that if there's a consensus on it, I can implement LRM character support. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 ___ cfe-commits mailing list cfe-comm

[PATCH] D116753: Default to -fno-math-errno for musl too

alxu created this revision. alxu added a project: clang. alxu requested review of this revision. Herald added a subscriber: cfe-commits. musl does not set errno in math functions: https://wiki.musl-libc.org/mathematical-library.html, https://github.com/ifduyue/musl/blob/cfdfd5ea3ce14c6abf7fb22a5

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

steakhal added a comment. In D91000#3225369 , @balazske wrote: > The functions `asctime` and `asctime_r` are discouraged according to CERT > MSC33-C rule. These could be added to this check as well. There is a clang SA > checker `SecuritySyntaxChecker` t

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:5475 + if (IndexVT.getVectorElementType() == MVT::i64 && XLenVT == MVT::i32) { +report_fatal_error("The V extension does not support EEW=64 for index " Can we trunc

[PATCH] D116755: Revert "[CodeGen] Mark fma as const for Android"

alxu created this revision. alxu added a project: clang. Herald added a subscriber: danielkiss. alxu requested review of this revision. Herald added a subscriber: cfe-commits. This code is intended to give a special exception for platforms which set errno in some math functions but not fma. This

[PATCH] D116726: [clang-format] Fix a crash (assertion) in qualifier alignment when matching template closer is null

curdeius added a comment. Cool. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116726/new/ https://reviews.llvm.org/D116726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D116337: [clang] set __NO_MATH_ERRNO__ if -fno-math-errno

alxu updated this revision to Diff 397922. alxu added a comment. Correct logic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116337/new/ https://reviews.llvm.org/D116337 Files: clang/lib/Frontend/InitPreprocessor.cpp clang/test/Preprocessor/predefined-macros.c Index: clang/test/

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. @Bigcheese I am sorry - after a lot of further investigation, it was due to an odd interaction with some downstream changes. I will re-land your changes, with correct attribution to you. Rep

[PATCH] D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

jdoerfert added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2533 +std::function DiagUnknownTrait = [this, Loc]( +StringRef ISATrait) {}; +TargetOMPContext OMPCtx(ASTContext, std::move(DiagUnknownTrai

[PATCH] D116755: Revert "[CodeGen] Mark fma as const for Android"

pirama accepted this revision. pirama added a subscriber: srhines. pirama added a comment. This revision is now accepted and ready to land. Thanks for the cleanup here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116755/new/ https://reviews.llvm.

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman added a comment. Thank you for your patience! I finally had the chance to go through this a bit more. I identified a bunch of tiny nits (the review feedback may look scary, but most should be trivial changes), but a few larger things about the design as well that are worth thinkin

[PATCH] D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does

akhuang updated this revision to Diff 397930. akhuang marked an inline comment as done. akhuang added a comment. Add std=c++17 to the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116256/new/ https://reviews.llvm.org/D116256 Files: clang/i

[PATCH] D116337: [clang] set __NO_MATH_ERRNO__ if -fno-math-errno

aaron.ballman added a comment. Getting closer! Now there are new CI pipeline failures (some tests look like they need updating). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116337/new/ https://reviews.llvm.org/D116337 ___ cfe-commits maili

[PATCH] D116337: [clang] set __NO_MATH_ERRNO__ if -fno-math-errno

alxu updated this revision to Diff 397937. alxu added a comment. Herald added subscribers: aheejin, dschuff. Update init.c, init-aarch64.c tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116337/new/ https://reviews.llvm.org/D116337 Files: clang/lib/Frontend/InitPreprocessor.cpp

[PATCH] D116337: [clang] set __NO_MATH_ERRNO__ if -fno-math-errno

alxu updated this revision to Diff 397938. alxu added a comment. Re-add context lines. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116337/new/ https://reviews.llvm.org/D116337 Files: clang/lib/Frontend/InitPreprocessor.cpp clang/test/Preprocessor/init-aarch64.c clang/test/Prepr

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

delcypher added inline comments. Comment at: clang/test/Sema/warn-calls-without-prototype.c:39 + return a + b +c; +} + NoQ wrote: > delcypher wrote: > > delcypher wrote: > > > delcypher wrote: > > > > @NoQ Any ideas about this? It seems kind of weird that when

[PATCH] D116378: [clang-tidy] Disable clang-tidy warnings from system macros

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor nit, thanks! This was a good catch. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:32-33 + Chec

  1   2   >