estan added a comment. In D88833#3222829 <https://reviews.llvm.org/D88833#3222829>, @estan wrote:
> Sounds good @aaron.ballman, let's wait for @fiesh. > > Though I realize now that the scope of this patch is probably not enough to > solve a problem we have in our code base. The check will warn about (for > example) things like this: > > In a third party lib outside our control: > > void f(double out[3]); > > In our code: > > double out[3]; > f(out); > > Include paths for the third party lib are added with -isystem. > > Am I right that we're still going to get warnings for this with this patch? > > Full disclosure. The third party lib is VTK, which is littered with APIs like > these. @aaron.ballman BTW, would you guys be open to a patch that makes the check not warn in cases like the above, or at least an option to make it not warn? We like the spirit of this check, to make sure we use gsl::array_view/std::span instead of (T *data, int size) style interfaces in our own APIs. But we cannot change the (T*) APIs of our third party libraries. Having to litter our code with hundreds of casts is not very nice. It would be great if there was an option to tell the check to ignore all decays that occur in calls to functions in system headers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88833/new/ https://reviews.llvm.org/D88833 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
