zero9178 marked an inline comment as done. zero9178 added inline comments.
================ Comment at: clang/test/Sema/warn-mixed-decls.c:1-4 +/* RUN: %clang_cc1 -fsyntax-only -verify -std=c89 -pedantic %s + */ +/* RUN: %clang_cc1 -fsyntax-only -verify -std=c99 -Wdeclaration-after-statement %s + */ ---------------- aaron.ballman wrote: > I'd also like to see RUN lines for when we expect the diagnostic to not be > enabled: > ``` > /* RUN: %clang_cc1 -fsyntax-only -verify=none -std=c99 %s */ > /* RUN: %clang_cc1 -fsyntax-only -verify=none -x c++ %s */ > /* RUN: %clang_cc1 -fsyntax-only -verify=none -x c++ > -Wdeclaration-after-statement %s */ > > /* none-no-diagnostics */ > ``` > I should note that the last RUN line will give different behavior between > Clang and GCC: https://godbolt.org/z/o1PKo7dhM, but I think that's a more > general issue that doesn't need to be addressed in this patch. (We don't have > a way to flag a diagnostic as requiring a particular language mode.) The `*/` on the next line seems to be necessary so as lit seems to otherwise add `*/` to the command line of the `RUN` command. At least this is the case on my Windows machine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114787/new/ https://reviews.llvm.org/D114787 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
