[PATCH] D114859: [clang-format] Add better support for co-routinues

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57b95aed2a04: [clang-format] Add better support for co-routinues (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 57b95ae - [clang-format] Add better support for co-routinues

Author: mydeveloperday Date: 2021-12-02T08:06:43Z New Revision: 57b95aed2a04f00dc84c4c4926c506528081196d URL: https://github.com/llvm/llvm-project/commit/57b95aed2a04f00dc84c4c4926c506528081196d DIFF: https://github.com/llvm/llvm-project/commit/57b95aed2a04f00dc84c4c4926c506528081196d.diff LOG

[PATCH] D114864: [clangd] IncludeClenaer: Don't mark forward declarations of a class if it's declared in the main file

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:131 + const auto *MostRecent = RD->getMostRecentDecl(); + if (SM.isInMainFile(MostRecent->

[PATCH] D114864: [clangd] IncludeClenaer: Don't mark forward declarations of a class if it's declared in the main file

kbobyrev updated this revision to Diff 391249. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114864/new/ https://reviews.llvm.org/D114864 Files: clang-t

[clang-tools-extra] d3a4ef3 - [clangd] IncludeClenaer: Don't mark forward declarations of a class if it's declared in the main file

Author: Kirill Bobyrev Date: 2021-12-02T10:26:08+01:00 New Revision: d3a4ef35685c6aaad74294b678e77e1b75af1918 URL: https://github.com/llvm/llvm-project/commit/d3a4ef35685c6aaad74294b678e77e1b75af1918 DIFF: https://github.com/llvm/llvm-project/commit/d3a4ef35685c6aaad74294b678e77e1b75af1918.diff

[PATCH] D114864: [clangd] IncludeClenaer: Don't mark forward declarations of a class if it's declared in the main file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3a4ef35685c: [clangd] IncludeClenaer: Don't mark forward declarations of a class if it's… (authored by kbobyrev). Repository: rG LLVM Github Mono

[PATCH] D114937: [PowerPC] [Clang] Fix alignment adjustment of single-elemented float128

qiucf created this revision. qiucf added reviewers: jsji, nemanjai, rjmccall, shchenz, PowerPC, hubert.reinterpretcast. Herald added a subscriber: kbarton. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This does similar thing to D9

[PATCH] D114938: [Analyzer] SValBuilder: Simlify a SymExpr to the absolute simplest form

martong created this revision. martong added a reviewer: steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. martong requested review of

[PATCH] D114938: [Analyzer] SValBuilder: Simlify a SymExpr to the absolute simplest form

martong added a comment. Measurement results are attached, I think there is no relevant difference. F20847935: another_fixpoint_before_merge_2.png F20847949: stats.html Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen added inline comments. Comment at: clang/include/clang/Basic/Attr.td:544-546 + // Set to true for attributes that support parameter pack expansion in its + // arguments. + bit ParmExpansionArgsSupport = 0; aaron.ballman wrote: > From a design per

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:447 + } + ArgExpr = Actions.ActOnPackExpansion(ArgExpr.get(), ConsumeToken()); +} steffenlarsen wrote: > erichkeane wrote: > > Do you have a test for somethin

[PATCH] D113896: [clangd] cleanup of header guard names

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/PathMapping.h:2 +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_PATHMAPPING_H +#define LLVM_CLANG_TOOLS_EXTRA_CLANGD_PATHMAPPING_H + Please move the header guard after the comment like we do in the other

[clang] 69deb13 - Use cc/c++ instead of gcc/g++ on FreeBSD.

Author: Frederic Cambus Date: 2021-12-02T11:52:40+01:00 New Revision: 69deb1371fd4cd2fbf37a82cbc21df79c6d51c70 URL: https://github.com/llvm/llvm-project/commit/69deb1371fd4cd2fbf37a82cbc21df79c6d51c70 DIFF: https://github.com/llvm/llvm-project/commit/69deb1371fd4cd2fbf37a82cbc21df79c6d51c70.dif

[PATCH] D114530: [clang][scan-build] Use cc/c++ instead of gcc/g++ on FreeBSD.

This revision was automatically updated to reflect the committed changes. Closed by commit rG69deb1371fd4: Use cc/c++ instead of gcc/g++ on FreeBSD. (authored by fcambus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114530/new/ https://reviews.llv

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

glider added a comment. Given this is a minor change that only affects users of disable_sanitizer_instrumentation, I'm inclined towards landing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114421/new/ https://reviews.llvm.org/D114421 ___

[PATCH] D113896: [clangd] cleanup of header guard names

kadircet added a comment. LG apart from closing comments, some of the files have it and some don't (apart from the newly introduced ones, it didn't add it to the files that didn't have a closing comment, but updated the ones that had). The code from the tidy check looks like it should be handlin

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

krisb added inline comments. Comment at: clang/lib/Driver/ToolChains/MSP430.cpp:223-224 + MCUData LoadedMCUData; + if (const Arg *MCUArg = Args.getLastArg(options::OPT_mmcu_EQ)) +LoadedMCUData = getMCUData(MCUArg->getValue()); + It might be worth moving thi

[clang] 3b44264 - [VE][Clang][NFC] Disable VE toolchain tests on Windows

Author: Simon Moll Date: 2021-12-02T13:33:46+01:00 New Revision: 3b442644e278b53e351addf349c75b995b10f029 URL: https://github.com/llvm/llvm-project/commit/3b442644e278b53e351addf349c75b995b10f029 DIFF: https://github.com/llvm/llvm-project/commit/3b442644e278b53e351addf349c75b995b10f029.diff LO

[PATCH] D112707: [clangd] IncludeCleaner: Be more conservative in marking RecordDecl usage

kbobyrev added a comment. @sammccall There is one part of your comment that I couldn't understand, could you please clarify what you mean bi this? > we can't skip based on a definition (main file or class) that can't stand > alone, usually because of qualifiers. e.g. void foo::bar() {}. FWIW

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

Anastasia added a comment. In D110618#3152939 , @linjamaki wrote: > In D110618#3148501 , @Anastasia > wrote: > >> Could you please clarify the interface to SPIRV-LLVM-Translator tool, >> specifically: >> >> - Do

[PATCH] D112110: [OpenCL] queue_t and ndrange_t can't be defined in program scope.

Anastasia added inline comments. Herald added a subscriber: Naghasan. Comment at: clang/test/SemaOpenCL/invalid-types.cl:10 + +typedef image2d_t test; +global test qtt; // expected-error {{the '__global ndrange_t' type cannot be used to declare a program scope variable}} ---

[PATCH] D112626: Convert float to double on __builtin_dump_struct

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2090-2094 +// Variadic functions expect the caller to promote float to double. +if (CanonicalType == Context.FloatTy) { + FieldPtr = + CGF.Builder.CreateFPExt(FieldPtr, CGF.Conv

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a9487df73e9: Add new clang-tidy check for string_view(nullptr) (authored by CJ-Johnson, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang-tools-extra] 6a9487d - Add new clang-tidy check for string_view(nullptr)

Author: CJ Johnson Date: 2021-12-02T13:25:28Z New Revision: 6a9487df73e917c4faf5e060f2bb33c6ade3f967 URL: https://github.com/llvm/llvm-project/commit/6a9487df73e917c4faf5e060f2bb33c6ade3f967 DIFF: https://github.com/llvm/llvm-project/commit/6a9487df73e917c4faf5e060f2bb33c6ade3f967.diff LOG: Ad

[PATCH] D114809: Fix documentation for `forEachLambdaCapture` and `hasAnyCapture`

ymandel added a comment. In D114809#3165214 , @aaron.ballman wrote: > LGTM! I had no idea... > > (As a follow-up question, should we be removing the `using` declarations > starting around line 141 or so? Many of them are not used, and if the > document

[clang] 4e9e2f2 - Fix documentation for `forEachLambdaCapture` and `hasAnyCapture`

Author: James King Date: 2021-12-02T13:28:05Z New Revision: 4e9e2f24178077d7055c0f667d13f887fef508d5 URL: https://github.com/llvm/llvm-project/commit/4e9e2f24178077d7055c0f667d13f887fef508d5 DIFF: https://github.com/llvm/llvm-project/commit/4e9e2f24178077d7055c0f667d13f887fef508d5.diff LOG: Fi

[PATCH] D114809: Fix documentation for `forEachLambdaCapture` and `hasAnyCapture`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e9e2f241780: Fix documentation for `forEachLambdaCapture` and `hasAnyCapture` (authored by jcking1034, committed by ymandel). Repository: rG LLVM

[PATCH] D114621: [clangd] Show parameters for construct.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks LGTM! let me know if I should land this for you. Comment at: clang-tools-extra/clangd/Hover.cpp:1054 // editor, as they might be long. - if (ReturnType) { + i

[clang] f4d3cb4 - [HIPSPV] Add CUDA->SPIR-V address space mapping

Author: Anastasia Stulova Date: 2021-12-02T13:34:27Z New Revision: f4d3cb4ca833d0b165d199e78ed8f1d59a8032eb URL: https://github.com/llvm/llvm-project/commit/f4d3cb4ca833d0b165d199e78ed8f1d59a8032eb DIFF: https://github.com/llvm/llvm-project/commit/f4d3cb4ca833d0b165d199e78ed8f1d59a8032eb.diff

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4d3cb4ca833: [HIPSPV] Add CUDA->SPIR-V address space mapping (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://rev

[PATCH] D114809: Fix documentation for `forEachLambdaCapture` and `hasAnyCapture`

aaron.ballman added a comment. In D114809#3166602 , @ymandel wrote: > In D114809#3165214 , @aaron.ballman > wrote: > >> LGTM! I had no idea... >> >> (As a follow-up question, should we be removing the `using` dec

[PATCH] D110155: [OpenCL] Allow optional __generic in __remove_address_space utility

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110155/new/ https://reviews.llvm.org/D110155 ___ cfe-commits mailing list

[PATCH] D114949: [clangd] IncludeCleaner: Do not require forward declarations of RecordDecls when definition is available

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This makes IncludeCleaner more u

[PATCH] D112707: [clangd] IncludeCleaner: Be more conservative in marking RecordDecl usage

sammccall added a comment. In D112707#3166535 , @kbobyrev wrote: > @sammccall > > There is one part of your comment that I couldn't understand, could you > please clarify what you mean bi this? > >> we can't skip based on a definition (main file or class

[PATCH] D112707: [clangd] IncludeCleaner: Be more conservative in marking RecordDecl usage

kbobyrev added a comment. In D112707#3166703 , @sammccall wrote: > In D112707#3166535 , @kbobyrev > wrote: > >> @sammccall >> >> There is one part of your comment that I couldn't understand, could you >> please

[PATCH] D113896: [clangd] cleanup of header guard names

kuhnel updated this revision to Diff 391301. kuhnel marked 4 inline comments as done. kuhnel added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113896/new/ https://reviews.llvm.org/D113896 Files: clang-tools

[PATCH] D113896: [clangd] cleanup of header guard names

kuhnel added a comment. @kadircet looks like clang-tidy does not detect missing comments in `#endif`. It does complain about missing comments for namespaces. E.g. in `Serialization.h` the `#endif` comment is missing, but without a finding. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D114952: [clang-cl] Define _MSVC_LANG for -std=c++2b

thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. This matches the value that msvc v19.29 VS16.11 uses for _MSVC_LANG with /std:c++latest. https://reviews.llvm.org/D114952 Files: clang/lib/Basic/Targets/OSTargets.cpp clang/test/Preprocess

[PATCH] D114952: [clang-cl] Define _MSVC_LANG for -std=c++2b

thakis added a comment. (for reference: https://godbolt.org/z/W6n6jqz4Y) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114952/new/ https://reviews.llvm.org/D114952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D114938: [Analyzer] SValBuilder: Simlify a SymExpr to the absolute simplest form

steakhal added a comment. I don't think there is any time concern with this patch. It's NFC. You should retitle accordingly. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:51 + // sub-trees and if a value is a constant we do the constant folding. + SVal simp

[PATCH] D114887: [Analyzer][solver] Simplification: Do a fixpoint iteration before the eq class merge

steakhal added a comment. In D114887#3165415 , @martong wrote: > In D114887#3165397 , @steakhal > wrote: > >> Also, please provide the coverage of the new test case (only excercising the >> new test case not the

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau marked an inline comment as done. MattDevereau added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1325 setOperationAction(ISD::MLOAD, VT, Custom); + setOperationAction(ISD::INSERT_SUBVECTOR, VT, Custom); }

[PATCH] D114949: [clangd] IncludeCleaner: Do not require forward declarations of RecordDecls when definition is available

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:151 + if (SM.isInMainFile(RD->getMostRecentDecl()->getLocation())) { +if (Definition) Result.insert(Definition->getLocation()); if we made it here, we

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

foad created this revision. foad added reviewers: arsenm, rampitec, critson, yaxunl, b-sumner. Herald added subscribers: kerbowa, hiraditya, t-tye, tpr, dstuttard, nhaehnle, jvesely, kzhuravl. foad requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wdng. Herald

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

foad added a comment. This is a flag-day change to the signatures of the LLVM intrinsics and the OpenCL builtins. Is that OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114957/new/ https://reviews.llvm.org/D114957 _

[PATCH] D114952: [clang-cl] Define _MSVC_LANG for -std=c++2b

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114952/new/ https://reviews.llvm.org/D114952 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D114890: [OpenMP] Make the new device runtime the default

gregrodgers accepted this revision. gregrodgers added a comment. This revision is now accepted and ready to land. this is ok as is Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114890/new/ https://reviews.llvm.org/D114890 _

[clang-tools-extra] c006ea6 - [clang-tidy] Fix build broken by commit 6a9487df73e917c4faf5e060f2bb33c6ade3f967 (D113148)

Author: Yitzhak Mandelbaum Date: 2021-12-02T14:41:00Z New Revision: c006ea6bde234153abadc8927557da9b8e0dc029 URL: https://github.com/llvm/llvm-project/commit/c006ea6bde234153abadc8927557da9b8e0dc029 DIFF: https://github.com/llvm/llvm-project/commit/c006ea6bde234153abadc8927557da9b8e0dc029.diff

[PATCH] D114446: [clang] Fix wrong -Wunused-local-typedef warning if use is a dependent qialified identifier

krisb updated this revision to Diff 391312. krisb added a comment. Simplified diagnostic condition in TemplateDeclInstantiator::InstantiateTypedefNameDecl(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114446/new/ https://reviews.llvm.org/D11444

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

yaxunl added a comment. In D114957#3166817 , @foad wrote: > This is a flag-day change to the signatures of the LLVM intrinsics and the > OpenCL builtins. Is that OK? This breaks users' code. If we have to do this, at least let clang emit a pre-defined

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

arsenm added a comment. In D114957#3166858 , @yaxunl wrote: > In D114957#3166817 , @foad wrote: > >> This is a flag-day change to the signatures of the LLVM intrinsics and the >> OpenCL builtins. Is that OK? > >

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire updated this revision to Diff 391316. junaire added a comment. I didn't know if I understand Aaron's words right, but I think I can update the patch first... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114688/new/ https://reviews.llvm.org/D114688 Files: clang/include/clang

[PATCH] D113638: [xray] Add support for hexagon architecture

sidneym added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113638/new/ https://reviews.llvm.org/D113638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews added a comment. Thanks for the reviews @dylanmckay and @rjmccall ! I agree that moving the logic for functions pointers to `getTargetAddressSpace` makes sense. However, I'm not sure what the consequences are, since that increases the impact of this change quite a bit. I'm not sure if

[PATCH] D64008: [RISCV] Avoid save-restore target feature warning

jrtc27 added a comment. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, sameer.abuasal, s.egerton, MaskRay. For historical documentation purposes: I don't think this ever actually fully worked. Whilst it stops passing the fea

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

yaxunl added a comment. In D114957#3166861 , @arsenm wrote: > In D114957#3166858 , @yaxunl wrote: > >> In D114957#3166817 , @foad wrote: >> >>> This is a flag-day change t

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

svenvh requested changes to this revision. svenvh added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/Driver.cpp:3728 + // Linking separate translation units for SPIR-V is not supported yet. + // It can be done either by LLVM IR

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

b-sumner added a comment. In D114957#3166882 , @yaxunl wrote: > In D114957#3166861 , @arsenm wrote: > >> In D114957#3166858 , @yaxunl wrote: >> >>> In D114957#3166817

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

foad added a comment. In D114957#3166858 , @yaxunl wrote: > In D114957#3166817 , @foad wrote: > >> This is a flag-day change to the signatures of the LLVM intrinsics and the >> OpenCL builtins. Is that OK? > > Th

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

b-sumner added a comment. In D114957#3166936 , @foad wrote: > In D114957#3166858 , @yaxunl wrote: > >> In D114957#3166817 , @foad wrote: >> >>> This is a flag-day change t

[PATCH] D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after pars

jamesfarrell updated this revision to Diff 391323. jamesfarrell added a comment. Don't use the preprocessor to hide test cases, so we can at least tell if it compiles when testing on platforms other than Apple and AIX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

foad added a comment. In D114957#3166948 , @b-sumner wrote: > In D114957#3166936 , @foad wrote: > >> In D114957#3166858 , @yaxunl wrote: >> >>> In D114957#3166817

[PATCH] D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.

Meinersbur added a comment. In D114413#3160044 , @peixin wrote: > In D114413#3159095 , @Meinersbur > wrote: > >> In D114413#3154936 , @peixin wrote: >> >>> > > `getPrehe

[clang] 89d645d - [Clang] Fix LTO pipeline test after 770a50b28c00211f9a.

Author: Florian Hahn Date: 2021-12-02T15:42:52Z New Revision: 89d645dd3a60cd5bb3cc9a78ad17d3b063cc98bf URL: https://github.com/llvm/llvm-project/commit/89d645dd3a60cd5bb3cc9a78ad17d3b063cc98bf DIFF: https://github.com/llvm/llvm-project/commit/89d645dd3a60cd5bb3cc9a78ad17d3b063cc98bf.diff LOG:

[PATCH] D113896: [clangd] cleanup of header guard names

kbobyrev added a comment. Also, please mention the In D113896#3166732 , @kuhnel wrote: > @kadircet looks like clang-tidy does not detect missing comments in `#endif`. > It does complain about missing comments for namespaces. E.g. in > `Serialization.h`

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

yaxunl added a comment. In D114957#3166974 , @foad wrote: > In D114957#3166948 , @b-sumner > wrote: > >> In D114957#3166936 , @foad wrote: >> >>> In D114957#3166858

[clang-tools-extra] 5bd643d - [clangd] cleanup of header guard names

Author: Christian Kühnel Date: 2021-12-02T15:58:35Z New Revision: 5bd643d31d11e96bcae833025b241681370e527c URL: https://github.com/llvm/llvm-project/commit/5bd643d31d11e96bcae833025b241681370e527c DIFF: https://github.com/llvm/llvm-project/commit/5bd643d31d11e96bcae833025b241681370e527c.diff L

[PATCH] D113896: [clangd] cleanup of header guard names

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5bd643d31d11: [clangd] cleanup of header guard names (authored by kuhnel). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

aaron.ballman added a comment. In D114688#3166870 , @junaire wrote: > I didn't know if I understand Aaron's words right, but I think I can update > the patch first... I think you understood my suggestion pretty well, thanks! Comment

[PATCH] D114890: [OpenMP] Make the new device runtime the default

JonChesterfield accepted this revision. JonChesterfield added a comment. The consensus internally seems to be to land this and see what happens on the amdgpu buildbot. Go for it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114890/new/ https://rev

[clang] c99407e - [OpenMP] Make the new device runtime the default

Author: Joseph Huber Date: 2021-12-02T11:11:45-05:00 New Revision: c99407e31c3977bf397531bf115a63b0fda68e4d URL: https://github.com/llvm/llvm-project/commit/c99407e31c3977bf397531bf115a63b0fda68e4d DIFF: https://github.com/llvm/llvm-project/commit/c99407e31c3977bf397531bf115a63b0fda68e4d.diff

[PATCH] D114890: [OpenMP] Make the new device runtime the default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc99407e31c39: [OpenMP] Make the new device runtime the default (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D114890: [OpenMP] Make the new device runtime the default

JonChesterfield added a comment. Fails on CI pretty much like it fails locally https://lab.llvm.org/buildbot/#/builders/193/builds/2569 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114890/new/ https://reviews.llvm.org/D114890

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel added a comment. Looking at the documentation, this looks like a bug in the clang-tidy check: https://releases.llvm.org/13.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability-qualified-auto.html The rule `llvm-qualified-auto` should not add a `const` qualifier. Repository: r

[clang] 53adfa8 - [clang] Do not duplicate "EnableSplitLTOUnit" module flag

Author: David Greene Date: 2021-12-02T08:24:56-08:00 New Revision: 53adfa8750eaf4558c41a50f699616545eb0151b URL: https://github.com/llvm/llvm-project/commit/53adfa8750eaf4558c41a50f699616545eb0151b DIFF: https://github.com/llvm/llvm-project/commit/53adfa8750eaf4558c41a50f699616545eb0151b.diff

[PATCH] D112177: [clang] Do not duplicate "EnableSplitLTOUnit" module flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG53adfa8750ea: [clang] Do not duplicate "EnableSplitLTOUnit" module flag (authored by greened). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112177/new/ htt

[PATCH] D114890: [OpenMP] Make the new device runtime the default

ronlieb added a comment. thx for trying it out, please revert so we can look into it more on the AMDGPU target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114890/new/ https://reviews.llvm.org/D114890

[PATCH] D114890: [OpenMP] Make the new device runtime the default

jhuber6 added a comment. In D114890#3167061 , @ronlieb wrote: > thx for trying it out, please revert so we can look into it more on the > AMDGPU target I'm going to make a new revision to make AMDGPU use the old runtime by default, SG? Repository:

[PATCH] D114890: [OpenMP] Make the new device runtime the default

ronlieb added a comment. yes, thanks, sounds good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114890/new/ https://reviews.llvm.org/D114890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:544-546 + // Set to true for attributes that support parameter pack expansion in its + // arguments. + bit ParmExpansionArgsSupport = 0; steffenlarsen wrote: > aaron.ballman wro

[PATCH] D114718: [analyzer] Implement a new checker for Strict Aliasing Rule.

ASDenysPetrov added a comment. @xazax.hun Updated the summary for better undersanding differencies between the Standards. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114718/new/ https://reviews.llvm.org/D114718

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

erichkeane added inline comments. Comment at: clang/include/clang/Basic/Attr.td:544-546 + // Set to true for attributes that support parameter pack expansion in its + // arguments. + bit ParmExpansionArgsSupport = 0; aaron.ballman wrote: > steffenlarsen wrote:

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

martong added a comment. Here is a smaller reproducer: void bar(short k) { ++k; // k1 = k0 + 1 assert(k == 1); // k1 == 1 --> k0 == 0 (long)k << 16; // k0 + 1 << 16 } And the explanation is the following. With this patch, when the analyzer evaluates the `(long)k

[PATCH] D113896: [clangd] cleanup of header guard names

kadircet added a comment. > This looks to be a deliberate decision: > https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/llvm/HeaderGuardCheck.h#L32 > > Looking at the code under `clang/include`, it looks like most headers don't > have the `#endif // COMMENT`, so this mi

[clang] 2a2b3a3 - [clang-cl] Define _MSVC_LANG for -std=c++2b

Author: Nico Weber Date: 2021-12-02T12:09:20-05:00 New Revision: 2a2b3a3e3df7b89e18be9ffab1e08d7ca578cf57 URL: https://github.com/llvm/llvm-project/commit/2a2b3a3e3df7b89e18be9ffab1e08d7ca578cf57 DIFF: https://github.com/llvm/llvm-project/commit/2a2b3a3e3df7b89e18be9ffab1e08d7ca578cf57.diff LO

[PATCH] D114952: [clang-cl] Define _MSVC_LANG for -std=c++2b

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a2b3a3e3df7: [clang-cl] Define _MSVC_LANG for -std=c++2b (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D114938: [Analyzer] SValBuilder: Simlify a SymExpr to the absolute simplest form

martong updated this revision to Diff 391352. martong marked 2 inline comments as done. martong added a comment. - Rename simplifySValImpl to simplifySValOnce - Remove a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114938/new/ https://revi

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kbobyrev added a comment. In D113898#3167050 , @kuhnel wrote: > Looking at the documentation, this looks like a bug in the clang-tidy check: > https://releases.llvm.org/13.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability-qualified-auto.html

[PATCH] D114965: [OpenMP] Remove the new runtime default for AMDGPU

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tianshilei1992, gregrodgers, ronlieb. Herald added subscribers: dang, kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. jhuber6 requested review of this revision. Herald added subscrib

[PATCH] D114966: [clang][deps] Split filesystem caches

jansvoboda11 created this revision. Herald added subscribers: dexonsmith, hiraditya. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114966 Fil

[PATCH] D114965: [OpenMP] Remove the new runtime default for AMDGPU

jhuber6 added a comment. I feel like I should make these options only enabled if we're in an OpenMP device. I just realized that this will probably enable it for anything that goes through here, even non-OpenMP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D114965: [OpenMP] Remove the new runtime default for AMDGPU

jhuber6 added a comment. In D114965#3167241 , @jhuber6 wrote: > I feel like I should make these options only enabled if we're in an OpenMP > device. I just realized that this will probably enable it for anything that > goes through here, even non-OpenMP

[clang] 96ff74a - [OpenMP] Remove the new runtime default for AMDGPU

Author: Joseph Huber Date: 2021-12-02T12:35:58-05:00 New Revision: 96ff74a0d5982cb70ac25883f3b0d5bb99947aa9 URL: https://github.com/llvm/llvm-project/commit/96ff74a0d5982cb70ac25883f3b0d5bb99947aa9 DIFF: https://github.com/llvm/llvm-project/commit/96ff74a0d5982cb70ac25883f3b0d5bb99947aa9.diff

[PATCH] D114965: [OpenMP] Remove the new runtime default for AMDGPU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96ff74a0d598: [OpenMP] Remove the new runtime default for AMDGPU (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D114968: [clang][deps] Avoid reading file for stat calls

jansvoboda11 created this revision. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D114966 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114968 Files: clan

[PATCH] D114971: [clang][deps] Handle symlinks in minimizing FS

jansvoboda11 created this revision. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D114968 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114971 Files: clan

[PATCH] D114966: [clang][deps] Split filesystem caches

jansvoboda11 updated this revision to Diff 391369. jansvoboda11 added a comment. Add unit test, IWYU. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114966/new/ https://reviews.llvm.org/D114966 Files: clang/include/clang/Tooling/DependencyScannin

[PATCH] D114968: [clang][deps] Avoid reading file for stat calls

jansvoboda11 updated this revision to Diff 391370. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114968/new/ https://reviews.llvm.org/D114968 Files: clang/include/clang/Tooling/DependencyScanning/DependencySc

[PATCH] D114971: [clang][deps] Handle symlinks in minimizing FS

jansvoboda11 updated this revision to Diff 391371. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114971/new/ https://reviews.llvm.org/D114971 Files: clang/include/clang/Tooling/DependencyScanning/DependencySc

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

krisb added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113743/new/ https://reviews.llvm.org/D113743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

  1   2   3   >