steakhal added a comment.
I don't think there is any time concern with this patch. It's NFC. You should
retitle accordingly.
================
Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:51
+ // sub-trees and if a value is a constant we do the constant folding.
+ SVal simplifySValImpl(ProgramStateRef State, SVal V);
+
----------------
What about calling this `simplifySValOnce()`
================
Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1137
+ SVal SimplifiedVal = simplifySValImpl(State, Val);
+ // Do the simplification until we can.
+ while (SimplifiedVal != Val) {
----------------
You can remove this comment. Not really useful anyway.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114938/new/
https://reviews.llvm.org/D114938
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
