aaron.ballman added a comment.
In D114688#3166870 <https://reviews.llvm.org/D114688#3166870>, @junaire wrote:
> I didn't know if I understand Aaron's words right, but I think I can update
> the patch first...
I think you understood my suggestion pretty well, thanks!
================
Comment at: clang/lib/Sema/SemaChecking.cpp:2107
+
+ auto CheckArgType = [this](CallExpr *TheCall) -> bool {
+ QualType ArgTy = TheCall->getArg(0)->getType();
----------------
I don't think using a lambda here (or below) adds a whole lot of value given
that it's only called once. I think it'd cleaner to hoist the lambda logic into
the case block directly. WDYT?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114688/new/
https://reviews.llvm.org/D114688
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
