[clang] 8804d08 - Revert "[clang][AST] Check context of record in structural equivalence."

Author: Balázs Kéri Date: 2021-11-25T09:31:41+01:00 New Revision: 8804d08e9921b86eb96e993af5d753f63f3c8829 URL: https://github.com/llvm/llvm-project/commit/8804d08e9921b86eb96e993af5d753f63f3c8829 DIFF: https://github.com/llvm/llvm-project/commit/8804d08e9921b86eb96e993af5d753f63f3c8829.diff L

[PATCH] D114521: [clang-format] [PR47936] AfterControlStatement: MultiLine breaks AllowShortFunctionsOnASingleLine

MyDeveloperDay added a comment. The if/for/while case is way more involved and requires a change in a separate piece of code, I'm going to land this and we can handle 52598 separately Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114521/new/ https

[PATCH] D114539: [clang-tidy] performance-unnecessary-copy-initialization: handle pointer containers.

courbet updated this revision to Diff 389667. courbet added a comment. Add more comments on the approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114539/new/ https://reviews.llvm.org/D114539 Files: clang-tools-extra/clang-tidy/performance/

[clang] 72e4f4a - [clang-format] [PR47936] AfterControlStatement: MultiLine breaks AllowShortFunctionsOnASingleLine

Author: mydeveloperday Date: 2021-11-25T08:30:31Z New Revision: 72e4f4a2a117f97118692857d91210fc62c066b0 URL: https://github.com/llvm/llvm-project/commit/72e4f4a2a117f97118692857d91210fc62c066b0 DIFF: https://github.com/llvm/llvm-project/commit/72e4f4a2a117f97118692857d91210fc62c066b0.diff LOG

[PATCH] D114521: [clang-format] [PR47936] AfterControlStatement: MultiLine breaks AllowShortFunctionsOnASingleLine

This revision was automatically updated to reflect the committed changes. Closed by commit rG72e4f4a2a117: [clang-format] [PR47936] AfterControlStatement: MultiLine breaks… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca updated this revision to Diff 389678. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114326/new/ https://reviews.llvm.org/D114326 Files: clang/lib/Driver/ToolChains/Cuda.cpp Index: clang/lib/Driver/ToolChains/Cuda.cpp ==

[PATCH] D114519: [clang-format] [PR52595] clang-format does not recognize rvalue references to array

MyDeveloperDay updated this revision to Diff 389679. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Add more test combinations CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114519/new/ https://reviews.llvm.org/D114519 Files: clang/lib/Format/TokenAnn

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

MyDeveloperDay updated this revision to Diff 389682. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Address review comments, guard against eof CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114151/new/ https://reviews.llvm.org/D114151 Files: clang/doc

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:3274 + llvm::SmallVector FilesToLookFor; + // User provided clang-format file using -style=file:/path/to/format/file + // Check for explicit config filename part of me wonders if thi

[PATCH] D114519: [clang-format] [PR52595] clang-format does not recognize rvalue references to array

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114519/new/ https://reviews.llvm.org/D114519 ___ cfe-commits mailing list cfe-comm

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

bader added a comment. LGTM, with a couple of minor suggestions. Comment at: clang/lib/Sema/SemaSYCL.cpp:68-75 +bool ErrorFound = false; +if (isZeroSizedArray(*this, TypeToCheck)) { + SYCLDiagIfDeviceCode(UsedAt, diag::err_sycl_zero_array_size); + ErrorFound =

[PATCH] D113251: [analyzer][doc] Add user documenation for taint analysis

gamesh411 updated this revision to Diff 389684. gamesh411 added a comment. update with `arc diff $(git merge-base HEAD upstream) --update D113251` in order to satisfy workflow `pre-merge checks` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113251/n

[PATCH] D114326: Update the list of CUDA versions up to 11.5

carlosgalvezp accepted this revision. carlosgalvezp added a comment. LGTM but I think @tra should have the final word. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1

[PATCH] D114519: [clang-format] [PR52595] clang-format does not recognize rvalue references to array

lichray added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:317 // void (&FunctionReference)(void); // void (^ObjCBlock)(void); bool MightBeFunctionType = !Contexts[Contexts.size() - 2].IsExpression; Code does not match comment.

[PATCH] D114539: [clang-tidy] performance-unnecessary-copy-initialization: handle pointer containers.

courbet updated this revision to Diff 389690. courbet marked an inline comment as done. courbet added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114539/new/ https://reviews.llvm.org/D114539 Files: clang-tools-extra/

[clang-tools-extra] cdd37e2 - [clangd] Disable hicpp-invalid-access-moved inside clangd

Author: Kadir Cetinkaya Date: 2021-11-25T10:27:45+01:00 New Revision: cdd37e2e47f757d2130f741d8e720098bf920c40 URL: https://github.com/llvm/llvm-project/commit/cdd37e2e47f757d2130f741d8e720098bf920c40 DIFF: https://github.com/llvm/llvm-project/commit/cdd37e2e47f757d2130f741d8e720098bf920c40.dif

[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

courbet added a comment. Yes, I think the new approach is what we want. The comments also make it much clearer. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-narrowing-conversions-bitfields.cpp:1 +// RUN: %check_clang_tidy %s cppcoreguidelines-narro

[clang] 3e67cf2 - [clang][driver] Add -fplugin-arg- to pass arguments to plugins

Author: Timm Bäder Date: 2021-11-25T10:47:55+01:00 New Revision: 3e67cf21a19a0e8917bdbab6f0cecd4880f3fbe2 URL: https://github.com/llvm/llvm-project/commit/3e67cf21a19a0e8917bdbab6f0cecd4880f3fbe2 DIFF: https://github.com/llvm/llvm-project/commit/3e67cf21a19a0e8917bdbab6f0cecd4880f3fbe2.diff LO

[PATCH] D113250: [clang][driver] Add -fplugin-arg- to pass arguments to plugins

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e67cf21a19a: [clang][driver] Add -fplugin-arg- to pass arguments to plugins (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113250/new/

[PATCH] D114576: [PR52549][clang-cl] Predefine _MSVC_EXECUTION_CHARACTER_SET

zero9178 created this revision. zero9178 added reviewers: rnk, CaseyCarter, hans, thakis. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since VS 2022 17.1 MSVC predefines _MSVC_EXECUTION_CHARACTER_SET to inform the users of the

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

djtodoro added a comment. This looks reasonable to me (some nits included). Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:4513 Scope.addPrivate(Pair.first, [Replacement]() { return Replacement; }); +if (auto *DI = CGF.getDebugInfo()) { + DI->EmitDecla

[PATCH] D114576: [PR52549][clang-cl] Predefine _MSVC_EXECUTION_CHARACTER_SET

mstorsjo added a comment. Would it be possible to move setting of this flag to somewhere else (e.g. somewhere in Driver/ToolChains/MSVC.cpp), so that it would be picked up also when building with the gcc-style driver with `--target=*-windows-msvc`? Overall in earlier discussions, there's been m

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

SixWeining updated this revision to Diff 389696. SixWeining added a comment. diff1 and diff2 are the same, but diff1 build pass while diff2 build fail. So weird. Just reupload the patch to have a try. Sorry for the noise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114505/new/ https:

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

alok added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:4513 Scope.addPrivate(Pair.first, [Replacement]() { return Replacement; }); +if (auto *DI = CGF.getDebugInfo()) { + DI->EmitDeclareOfAutoVariable(Pair.first, Pair.second.getPointe

[PATCH] D114576: [PR52549][clang-cl] Predefine _MSVC_EXECUTION_CHARACTER_SET

zero9178 updated this revision to Diff 389698. zero9178 added a comment. Enable the macro for all MSVC targets, regardless of driver in use. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114576/new/ https://reviews.llvm.org/D114576 Files: clang/lib/Driver/ToolChains/MSVC.cpp clang/

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

alok updated this revision to Diff 389699. alok added a comment. Re-based and incorporated comments from @djtodoro CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114504/new/ https://reviews.llvm.org/D114504 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/debug_private.c

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

alok added a comment. Thanks @djtodoro . I have incorporated all your comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114504/new/ https://reviews.llvm.org/D114504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang-tools-extra] e2cad4d - [clangd] Add ObjC method support to prepareCallHierarchy

Author: Sheldon Neuberger Date: 2021-11-25T11:23:24+01:00 New Revision: e2cad4df22a6a411e7f7fcbc9bff0bd789545136 URL: https://github.com/llvm/llvm-project/commit/e2cad4df22a6a411e7f7fcbc9bff0bd789545136 DIFF: https://github.com/llvm/llvm-project/commit/e2cad4df22a6a411e7f7fcbc9bff0bd789545136.d

[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2cad4df22a6: [clangd] Add ObjC method support to prepareCallHierarchy (authored by sheldonneuberger-sc, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 389702. linjamaki added a comment. Disable debug info generation for device code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files: clang/include/clang/Basic

[PATCH] D114576: [PR52549][clang-cl] Predefine _MSVC_EXECUTION_CHARACTER_SET

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. Thanks! This LGTM - but maybe wait a while if someone else has something to say. (Although I guess americans are on holiday today, so there's probably not many that will see and care today

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

balazske reopened this revision. balazske added a comment. This revision is now accepted and ready to land. Windows test failures occurred because wrong AST matchers in the tests. Tests will be updated to use named match. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

balazske updated this revision to Diff 389709. balazske added a comment. Using correct AST match in the tests to fix failures on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113118/new/ https://reviews.llvm.org/D113118 Files: clang/lib

[PATCH] D114576: [PR52549][clang-cl] Predefine _MSVC_EXECUTION_CHARACTER_SET

CaseyCarter accepted this revision. CaseyCarter added a comment. LGTM - thanks for the quick response! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114576/new/ https://reviews.llvm.org/D114576 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

steakhal updated this revision to Diff 389711. steakhal marked an inline comment as done. steakhal added a comment. Added the `test_parameter_passing()` tests, demonstrating the implicit conversion triggered by parameter passing. It turns out my previous revision suppressed a useful report. Now,

[clang] c94667a - [clang-format] [PR52595] clang-format does not recognize rvalue references to array

Author: mydeveloperday Date: 2021-11-25T11:05:46Z New Revision: c94667a810e44c44fd355f9f014ffe161d75d761 URL: https://github.com/llvm/llvm-project/commit/c94667a810e44c44fd355f9f014ffe161d75d761 DIFF: https://github.com/llvm/llvm-project/commit/c94667a810e44c44fd355f9f014ffe161d75d761.diff LOG

[PATCH] D114519: [clang-format] [PR52595] clang-format does not recognize rvalue references to array

This revision was automatically updated to reflect the committed changes. Closed by commit rGc94667a810e4: [clang-format] [PR52595] clang-format does not recognize rvalue references to… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

steakhal added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-narrowing-conversions-bitfields.cpp:1 +// RUN: %check_clang_tidy %s cppcoreguidelines-narrowing-conversions %t \ +// RUN: -std=c++17 -- -target x86_64-unknown-linux ---

[clang] d44f2a6 - [clang-format]NFC improve the comment to match the code

Author: mydeveloperday Date: 2021-11-25T11:11:30Z New Revision: d44f2a6db2c71be04a588431a8ffb80d2d9e76f1 URL: https://github.com/llvm/llvm-project/commit/d44f2a6db2c71be04a588431a8ffb80d2d9e76f1 DIFF: https://github.com/llvm/llvm-project/commit/d44f2a6db2c71be04a588431a8ffb80d2d9e76f1.diff LOG

[PATCH] D114576: [PR52549][clang-cl] Predefine _MSVC_EXECUTION_CHARACTER_SET

zero9178 added a comment. Seems like this is causing failures in a test for clang-tidy if the triple used is an MSVC one. Let me see what I can do about it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114576/new/ https://reviews.llvm.org/D114576 __

[clang] c2fe2b5 - [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

Author: mydeveloperday Date: 2021-11-25T11:51:21Z New Revision: c2fe2b5a63bb7ec82d0a221bd144f6ce04661f90 URL: https://github.com/llvm/llvm-project/commit/c2fe2b5a63bb7ec82d0a221bd144f6ce04661f90 DIFF: https://github.com/llvm/llvm-project/commit/c2fe2b5a63bb7ec82d0a221bd144f6ce04661f90.diff LOG

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2fe2b5a63bb: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D114579: [clang-tidy] Exempt _MSVC_EXECUTION_CHARACTER_SET from cppcoreguidelines-macro-usage

zero9178 created this revision. zero9178 added reviewers: MaskRay, aaron.ballman, lebedev.ri, JonasToth, hokein. Herald added subscribers: carlosgalvezp, shchenz, kbarton, xazax.hun, nemanjai. zero9178 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subs

[clang-tools-extra] 59e4a67 - [clangd] Move IncludeCleaner tracer to the actual computation

Author: Kirill Bobyrev Date: 2021-11-25T13:19:01+01:00 New Revision: 59e4a6708152b42a55653bd8a44a6e0781fd4caf URL: https://github.com/llvm/llvm-project/commit/59e4a6708152b42a55653bd8a44a6e0781fd4caf DIFF: https://github.com/llvm/llvm-project/commit/59e4a6708152b42a55653bd8a44a6e0781fd4caf.diff

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

djtodoro accepted this revision. djtodoro added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114504/new/ https://reviews.llvm.org/D114504 ___ cfe-commits mailing list cfe-commi

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. @rjmccall thanks for having a look, I will clarify the comments with your suggestions. In D114025#3152900 , @tstellar wrote: > @ZarkoCA If you are planning to do a lot of this, it might be good to write a > script (or a clang-t

[PATCH] D114562: [clang][docs] Inclusive language: remove use of sanity check in option description

ZarkoCA updated this revision to Diff 389737. ZarkoCA added a comment. - Fix description - Remove `three` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114562/new/ https://reviews.llvm.org/D114562 Files: clang/docs/ThreadSafetyAnalysis.rst Ind

[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

courbet accepted this revision. courbet added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-narrowing-conversions-bitfields.cpp:62 +void take(T); +void test_parameter_passing(NoBitfield x) { + take(x.id); [nit] newlin

[PATCH] D114418: [clang][ASTImporter] Update lookup table correctly at deduction guides.

martong added a comment. > Probably this is a bug in the AST creation but currently it works this way. I don't think this is a bug, deduction guides have a convoluted implementation. See the related DeclContext issue with them when local typdefs are involved: https://reviews.llvm.org/D92209 =

[PATCH] D114256: [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114256/new/ https://reviews.llvm.org/D114256 __

[PATCH] D114418: [clang][ASTImporter] Update lookup table correctly at deduction guides.

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:6082-6085 + // "from" context. Because these DeclContext values look already not stable + // and unimportant this change looks acceptable. + // For these reasons the old DeclContext must be saved to chan

[clang] 36cb747 - [clang][OpenMP][DebugInfo] Debug support for private variables inside an OpenMP task construct

Author: Alok Kumar Sharma Date: 2021-11-25T19:55:22+05:30 New Revision: 36cb7477d1d43de1d97a4c2b4ba0eb5ae29cbafd URL: https://github.com/llvm/llvm-project/commit/36cb7477d1d43de1d97a4c2b4ba0eb5ae29cbafd DIFF: https://github.com/llvm/llvm-project/commit/36cb7477d1d43de1d97a4c2b4ba0eb5ae29cbafd.d

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG36cb7477d1d4: [clang][OpenMP][DebugInfo] Debug support for private variables inside an OpenMP… (authored by alok). Repository: rG LLVM Github Mono

[PATCH] D114418: [clang][ASTImporter] Update lookup table correctly at deduction guides.

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:6082-6085 + // "from" context. Because these DeclContext values look already not stable + // and unimportant this change looks acceptable. + // For these reasons the old DeclContext must be saved to chang

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay added a comment. Thank you for the patch, Do you need help committing this? if so we need your name and email address to do so https://llvm.org/docs/DeveloperPolicy.html#commit-messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D114522: [clangd] Add canonical type to hover

sammccall added a comment. I agree we often show the wrong amount of sugar, and with the thrust of this patch. Some pareto-improments are possible with a single type, but we can't solve this problem satisfactorily: - the right amount of sugar can vary for the same code pattern (`vector::itera

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 389773. sgatev added a comment. Put typed and type-erased interfaces in separate files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files: clang/include/clang/An

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 389774. sgatev added a comment. Rename Environment.h to DataflowEnvironment.h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files: clang/include/clang/Analysis/Fl

[PATCH] D40319: [libcxx] Support getentropy as a source of randomness for std::random_device

jwakely added inline comments. Herald added a subscriber: abrachet. Comment at: libcxx/trunk/src/random.cpp:29 +#if defined(_LIBCPP_USING_GETENTROPY) +#include +#elif defined(_LIBCPP_USING_DEV_RANDOM) musl only declares `getentropy` in `` not ``. Glibc declares

[PATCH] D114540: Big-endian version of vpermxor

tislam updated this revision to Diff 389775. tislam edited the summary of this revision. tislam added a comment. - Added test for `vpermxor_be` in `clang/test/CodeGen/builtins-ppc-crypto.c`. - Placed `vpermxor_be` under `[HasVSX, HasP8Altivec]` in `llvm/lib/Target/PowerPC/PPCInstrVSX.td`. - Updat

[PATCH] D40319: [libcxx] Support getentropy as a source of randomness for std::random_device

jwakely added inline comments. Comment at: libcxx/trunk/src/random.cpp:29 +#if defined(_LIBCPP_USING_GETENTROPY) +#include +#elif defined(_LIBCPP_USING_DEV_RANDOM) jwakely wrote: > musl only declares `getentropy` in `` not ``. Glibc > declares it in both. Shoul

[PATCH] D114418: [clang][ASTImporter] Update lookup table correctly at deduction guides.

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:6082-6085 + // "from" context. Because these DeclContext values look already not stable + // and unimportant this change looks acceptable. + // For these reasons the old DeclContext must be saved to chan

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

jessesna added a comment. In D114320#3153795 , @MyDeveloperDay wrote: > Thank you for the patch, Do you need help committing this? if so we need your > name and email address to do so > > https://llvm.org/docs/DeveloperPolicy.html#commit-messages Thank

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

jrtc27 added a comment. This seems like it should not apply to non-integral address spaces? Comment at: llvm/docs/LangRef.rst:10999 +with this instruction. Conversion of pointers to different address spaces +are legal, but may result in undefined behaviour where such a reinter

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3274 + llvm::SmallVector FilesToLookFor; + // User provided clang-format file using -style=file:/path/to/format/file + // Check for explicit config filename MyDeveloperDay wrote:

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay added a comment. The reason I have picked this us was because of: https://twitter.com/bruxisma/status/1462987809879257101 This slightly annoys me because : a) What they were talking about was in my view is disrespectful and inaccurate. b) I thought we'd already landed this (which

[PATCH] D114100: [NFC][clang-tools-extra] Inclusive language: replace master with main

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry, LG! (I'm not very familiar with clang-modularize, but this seems to be the only place the term is used) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D114583: [clang-format] Adjust braced list detection

MyDeveloperDay added a comment. FormatsBracedListsInColumnLayout is actually failing in its own test... it now produces void foo() { { // asdf { int a; } } { { int b; } } } rather than previously void foo() { {// asdf {int a; } } { { int b;

[PATCH] D114583: [clang-format] Adjust braced list detection

MyDeveloperDay added a comment. The other failure is -class C extends {} {} +class C extends {} +{} I'm slightly struggling to work out in both cases if its the test that is wrong @cpplearner what do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D114525: [clang] Change ordering of PreableCallbacks to make sure PP can be referenced in them

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Yeah this change definitely looks safe: - we've moving it across BeginSourceFile only, which doesn't seem to do anything for the usual parse that we'd use when building preambles. - Befo

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca created this revision. mojca added reviewers: tra, carlosgalvezp, Hahnfeld. mojca added a project: clang. Herald added a subscriber: yaxunl. mojca requested review of this revision. Herald added a subscriber: cfe-commits. This is heavily related to https://reviews.llvm.org/D114326 and uses a

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:48 +/// Type-erased base class for dataflow analyses built on a single lattice type. +class DataflowAnalysisDynamic { +public: xazax.hun wrote: > Does the `Dy

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added a comment. I opened https://reviews.llvm.org/D114601. I wasn't sure if that's something that should have been combined with this ticket or not because it can be merged or rejected independently. I also opened a ticket for Microsoft STL on https://github.com/microsoft/STL/issues/235

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:138 } else if (HostTriple.isOSWindows()) { -for (const char *Ver : Versions) - Candidates.emplace_back( - D.SysRoot + "/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v" + -

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

sammccall added a comment. Thanks, this mostly LG now. I'd consider splitting out the new infra change (IncludeStructure) from the feature change (include-cleaner treatment). In case the latter causes some problems... Comment at: clang-tools-extra/clangd/Headers.cpp:92

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

sammccall added a comment. I can't remember how we discussed this offline, but my plan was to land this and address the limitations as followups rather than extend the scope of this patch. So I think this is ready for review, though certainly not urgent. Repository: rG LLVM Github Monorepo

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca updated this revision to Diff 389808. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114601/new/ https://reviews.llvm.org/D114601 Files: clang/lib/Driver/ToolChains/Cuda.cpp Index: clang/lib/Driver/ToolChains/Cuda.cpp =

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca updated this revision to Diff 389811. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114601/new/ https://reviews.llvm.org/D114601 Files: clang/lib/Driver/ToolChains/Cuda.cpp Index: clang/lib/Driver/ToolChains/Cuda.cpp =

[PATCH] D114602: [clang-tidy] Improve documentation of bugprone-unhandled-exception-at-new [NFC]

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp, xazax.hun. balazske requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revie

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

vhscampos added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2979 +def warn_unsupported_branch_protection_spec : Warning< + "unsupported branch protection specification '%0'">, InGroup; + Still need to remove extraneous whitesp

[PATCH] D114583: [clang-format] Adjust braced list detection

MyDeveloperDay added a comment. For your test I think its your test that is wrong, looking at the simpler versions (using clang-format-12) void foo() { { { int a; } } } void foo() { { int a; } } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

chill added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:6377 + +static const char *SignReturnAddrStr[] = {"none", "non-leaf", "all"}; +Fn->addFnAttr("sign-return-address", vhscampos wrote: > I reckon selecting the string using a

[PATCH] D114100: [NFC][clang-tools-extra] Inclusive language: replace master with main

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3dc6b081da6: [NFC][clang-tools-extra] Inclusive language: replace master with main (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11410

[clang-tools-extra] c3dc6b0 - [NFC][clang-tools-extra] Inclusive language: replace master with main

Author: Quinn Pham Date: 2021-11-25T11:01:16-06:00 New Revision: c3dc6b081da6ba503e67d260033f81f61eb38ea3 URL: https://github.com/llvm/llvm-project/commit/c3dc6b081da6ba503e67d260033f81f61eb38ea3 DIFF: https://github.com/llvm/llvm-project/commit/c3dc6b081da6ba503e67d260033f81f61eb38ea3.diff LO

[PATCH] D114602: [clang-tidy] Improve documentation of bugprone-unhandled-exception-at-new [NFC]

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-exception-at-new.rst:31 + + + Two excessive newlines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

arsenm added a comment. In D114533#3153924 , @jrtc27 wrote: > This seems like it should not apply to non-integral address spaces? No, it shouldn’t care about the individual address spaces. It’s a reinterpret of the bits, the type meanings don’t matter

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added a comment. Somewhat off-topic from a discussion earlier in the thread. What's the purpose of the following code then if users are supposed to explicitly specify the `-L` flag anyway? c++ if (HostTriple.isArch64Bit() && FS.exists(InstallPath + "/lib64")) LibPath = Inst

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

jrtc27 added a comment. In D114533#3154225 , @arsenm wrote: > In D114533#3153924 , @jrtc27 wrote: > >> This seems like it should not apply to non-integral address spaces? > > No, it shouldn’t care about the indivi

[PATCH] D114564: Fix the use of -fno-approx-func along with -Ofast or -ffast-math

masoud.ataei updated this revision to Diff 389820. masoud.ataei edited the summary of this revision. masoud.ataei added a comment. Updated the test combining -ffast-math and -fno-approx-func options. @andrew.w.kaylor I hope you don't mind that I put those tests on `clang/test/Driver/fast-math.c`

[PATCH] D114583: [clang-format] Adjust braced list detection

cpplearner updated this revision to Diff 389822. cpplearner added a comment. Fixed tests. Since in JavaScript, the thing after `extends` must be an expression, and the thing after `implements` must be an object type, I decided to parse both as braced lists without going through `tryToParseBrace

[PATCH] D114564: Fix the use of -fno-approx-func along with -Ofast or -ffast-math

masoud.ataei marked 2 inline comments as done. masoud.ataei added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2760 case options::OPT_fno_honor_nans: HonorNaNs = false;break; case options::OPT_fapprox_func: ApproxFunc = true;

[PATCH] D114583: [clang-format] Adjust braced list detection

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I ran the examples from https://bugs.llvm.org/show_bug.cgi?id=38314 and its so much better than the previous state! Thanks for this patch, LGTM namespace n { void foo() {

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay added a comment. one of us can commit it for you but we need to do the following to attribute it to you commit --amend --author="John Doe " So I need your name and email address. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114320

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

jessesna added a comment. Great. Thanks a lot. It's Jesses Gott and jesses.gott.na+l...@gmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114320/new/ https://reviews.llvm.org/D114320 ___ cfe-commit

[PATCH] D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang

gandhi21299 updated this revision to Diff 389833. gandhi21299 added a comment. - added order argument in the builtins and changed the tests accordingly - adding Sema test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114553/new/ https://reviews.llv

[PATCH] D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang

gandhi21299 updated this revision to Diff 389834. gandhi21299 added a comment. - applied clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114553/new/ https://reviews.llvm.org/D114553 Files: clang/include/clang/AST/Expr.h clang/includ

[PATCH] D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang

gandhi21299 added a comment. Passed internal CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114553/new/ https://reviews.llvm.org/D114553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan added inline comments. Comment at: clang/test/ClangScanDeps/modules-full-by-mod-name.cpp:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: rm -rf %t.dir jsji wrote: > there is no `fmodule-format=obj` here, why are we failing here? > They have the same erro

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 389849. Jake-Egan added a comment. Removed some tests already disabled by D114481 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D11304

[PATCH] D114609: [clang] Fix crash on broken parameter declarators

kadircet created this revision. kadircet added reviewers: sammccall, hokein. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114609 Files: clang/lib/Parse/ParseDec

  1   2   >