sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
Yeah this change definitely looks safe: - we've moving it across BeginSourceFile only, which doesn't seem to do anything for the usual parse that we'd use when building preambles. - BeforeExecute isn't widely used Also it seems saner: Before/AfterExecute are now consistently nested inside Begin/EndSourceFile. I don't have particular insight into the original motivation, but I guess it was just driven by what was needed: why go for the "more powerful" thing if we only needed to inspect the CompilerInstance? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114525/new/ https://reviews.llvm.org/D114525 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
