[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki updated this revision to Diff 387506. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109818/new/ https://reviews.llvm.org/D109818 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGenHIP/hipspv-

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki updated this revision to Diff 387507. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Driver/Driver.cpp

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 387508. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/inclu

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki updated this revision to Diff 387509. linjamaki added a comment. Herald added a subscriber: asavonic. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622 Files: clang/include/clang/Basic/C

[PATCH] D110685: [HIPSPV][4/4] Add option to use llc to emit SPIR-V

linjamaki updated this revision to Diff 387510. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110685/new/ https://reviews.llvm.org/D110685 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolCha

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm added a comment. In D110257#3133838 , @JonChesterfield wrote: > Please change the commit message to say why this change is necessary / an > improvement on what we have now. > > My recollection is that the amdgpu backend crashes on some IR and thi

[PATCH] D111047: CUDA/HIP: Allow __int128 on the host side

linjamaki updated this revision to Diff 387511. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111047/new/ https://reviews.llvm.org/D111047 Files: clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaType.cpp clang/te

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

JonChesterfield added a comment. In D110257#3133866 , @hsmhsm wrote: > This is not something specific to AMDGPU backend, but AMDGPU backend at > present requires this canonical form. Undocumented and not checked by the IR verifier. Canonical form seems

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm added a comment. In D110257#3133879 , @JonChesterfield wrote: > In D110257#3133866 , @hsmhsm wrote: > >> This is not something specific to AMDGPU backend, but AMDGPU backend at >> present requires this c

[PATCH] D113942: [NFC][clang] Inclusive language: replace master with main in convert_arm_neon.py

kristof.beyls accepted this revision. kristof.beyls added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113942/new/ https://reviews.llvm.org/D113942

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

JonChesterfield added a comment. In D110257#3133895 , @hsmhsm wrote: > In D110257#3133879 , > @JonChesterfield wrote: > >> In D110257#3133866 , @hsmhsm wrote: >> >>> This

[PATCH] D113848: [clang-tidy][NFC] Refactor ClangTidyDiagnosticConsumer files

carlosgalvezp updated this revision to Diff 387519. carlosgalvezp marked 4 inline comments as done. carlosgalvezp added a comment. - Rebased. - Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113848/new/ https://reviews.llvm.org/D113848 Files: clang-tools-extra/clan

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm added a comment. In D110257#3133934 , @JonChesterfield wrote: > In D110257#3133895 , @hsmhsm wrote: > >> In D110257#3133879 , >> @JonChesterfield wrote: >> >>> In

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

JonChesterfield added a comment. So you won't articulate or document the new invariant and you think there's a llvm-dev discussion that says we can't verify the invariant which you won't reference, but means you won't add this to the verifier. Request changes doesn't really work after you've ap

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1315 + if ((SrcType->isHalfType() || iSFloat16Allowed) && + !CGF.getContext().getLangOpts().NativeHalfType) { // Cast to FP using the intrinsic if the half type itself isn't supported. --

[PATCH] D113972: [RFC] [C++20] [Module] Support module partitions initially

ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, aaron.ballman, urnathan, hubert.reinterpretcast, erichkeane. ChuanqiXu added a project: clang. Herald added a subscriber: dexonsmith. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. This file

[PATCH] D113974: [clangd] Put additional qualifiers to enum constants not declared as "enum class"

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is a cheap "fix" of the pro

[PATCH] D113974: [clangd] Put additional qualifiers to enum constants not declared as "enum class"

kbobyrev planned changes to this revision. kbobyrev added a comment. Actually, I'm not sure this change is worth it. Maybe the intent of not having `enum class` is actually making the constants discoverable from the outer scope. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. Btw can't we just have a license disclaimer like it's done for HiCPP? https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/hicpp/LICENSE.TXT CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730/new/ https://reviews.llvm.org/D112730

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerContainsCheck.cpp:49 + + // Find containment checks which use `count` + Finder->addMatcher(implicitCastExpr(hasImplicitDestinationType(booleanType()), Same comment

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

whisperity added a comment. In D112646#3104236 , @avogelsgesang wrote: > So I guess the name would have to be `container-count-begin-end-contains` or > similar... which would be a bit much in my opinion Yeah, that would be too much indeed. However, co

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerContainsCheck.cpp:105-108 + const auto *PositiveCheck = Result.Nodes.getNodeAs("positive"); + const auto *NegativeCheck = Result.Nodes.getNodeAs("negative"); + bool Negated = Negat

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

ChuanqiXu created this revision. ChuanqiXu added reviewers: Quuxplusone, ldionne. ChuanqiXu added projects: clang, libc++. Herald added a subscriber: lxfind. ChuanqiXu requested review of this revision. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. Since w

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 387554. mizvekov added a comment. - Fix rebuilding Template Specializations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang/include/clang/AST/ASTConte

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 387566. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h

[PATCH] D112453: [Sema] When dereferencing a pointer of dependent type, infer the result type.

courbet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112453/new/ https://reviews.llvm.org/D112453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang-tools-extra] 738e7f1 - Fix false positive in `bugprone-throw-keyword-missing` check

Author: Fabian Wolff Date: 2021-11-16T07:09:17-05:00 New Revision: 738e7f1231949ec248c1d8d154783338215613d1 URL: https://github.com/llvm/llvm-project/commit/738e7f1231949ec248c1d8d154783338215613d1 DIFF: https://github.com/llvm/llvm-project/commit/738e7f1231949ec248c1d8d154783338215613d1.diff

[PATCH] D113585: [clang-tidy] Fix false positive in `bugprone-throw-keyword-missing` check

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in 738e7f1231949ec248c1d8d154783338215613d1 , thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D106876: Remove non-affecting module maps from PCM files.

jansvoboda11 added a comment. In D106876#3066924 , @ilyakuteev wrote: > Hello everyone, can somebody please help me commit this patch to trunk? Hi, I'm happy to commit this for you. What author name and email would you like to be associated with the co

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev added a comment. Hi, I am very glad for your help. :) Author name: `Ilya Kuteev` email: `ilyakut...@icloud.com` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 _

[clang-tools-extra] d2da1a2 - [NFC][clangd] cleaning up unused "using"

Author: Christian Kühnel Date: 2021-11-16T13:09:49Z New Revision: d2da1a2f400ab54a874c1ba5430adc07a5249563 URL: https://github.com/llvm/llvm-project/commit/d2da1a2f400ab54a874c1ba5430adc07a5249563 DIFF: https://github.com/llvm/llvm-project/commit/d2da1a2f400ab54a874c1ba5430adc07a5249563.diff L

[PATCH] D113891: [NFC][clangd] cleaning up unused "using"

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2da1a2f400a: [NFC][clangd] cleaning up unused "using" (authored by kuhnel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113891/new/ https://reviews.llvm.

[PATCH] D113892: [NFC][clangd] cleanup llvm-else-after-return findings

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Discussed offline, I believe the plan is to NOLINT the locations where we're handling several cases exhaustively. Comment at: clang-tools-extra/clangd/Selection.cpp:35

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

rriddle updated this revision to Diff 387386. rriddle added a comment. Herald added subscribers: lldb-commits, hiraditya. Herald added a project: LLDB. resolve comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113641/new/ https://reviews.llvm.

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM from the libc++ perspective. Unsubscribing to reduce spam, please ping me on Discord if you need further input. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 387579. mizvekov added a comment. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. This revision now requires review to proceed. - Run libcxx CI Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D113889: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. This looks the best we can do, please address Kirill's comment. I spotted a related crash bug (https://github.com/clangd/clangd/issues/929) in clangd, but I think this patch should be fine to

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

arsenm added a comment. In D110257#3133866 , @hsmhsm wrote: > This is not something specific to AMDGPU backend, but AMDGPU backend at > present requires this canonical form. I must emphasize this is not a hard requirement, just a nice to have Reposit

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

arsenm added a comment. In D110257#3134001 , @JonChesterfield wrote: > So you won't articulate or document the new invariant and you think there's a > llvm-dev discussion that says we can't verify the invariant which you won't > reference, but means yo

[PATCH] D113993: WIP: [clang] customizable build-id style

kwk created this revision. kwk added reviewers: tbaeder, tstellar. kwk added projects: clang, lld. Herald added a subscriber: mgorny. kwk requested review of this revision. Herald added a subscriber: cfe-commits. **This is work in progress. I'm evaluating the patch now.** This change introduces t

[PATCH] D113925: [HIP] Add HIP scope atomic operations

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:1347-1348 break; // Avoid crashing on code with undefined behavior +if (!OrderFail) + llvm::errs() << "FOO\n"; EmitAtomicOp(*this, E, Dest, Ptr, Val1, Val2, IsWeak, Order

[PATCH] D113993: WIP: [clang] customizable build-id style

kwk updated this revision to Diff 387606. kwk edited the summary of this revision. kwk added a comment. Renamed: `ENABLE_LINKER_BUILD_ID_STYLE` to `DEFAULT_LINKER_BUILD_ID_STYLE`. Fixed issues with CMake (not done yet) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[clang] 83727f2 - [AArch64][SVE] Remove arm-registered-target requirement on bfloat tests

Author: Matt Devereau Date: 2021-11-16T14:38:21Z New Revision: 83727f27719d3f319f746b473ce09be7e1d99b32 URL: https://github.com/llvm/llvm-project/commit/83727f27719d3f319f746b473ce09be7e1d99b32 DIFF: https://github.com/llvm/llvm-project/commit/83727f27719d3f319f746b473ce09be7e1d99b32.diff LOG:

[PATCH] D113489: [AArch64][SVE] Instcombine SVE LD1/ST1 to stock LLVM IR

MattDevereau added a comment. This caused buildbot failures which failed on the bfloat tests. Pushed commit 83727f27719d3f319f746b473ce09be7e1d99b32 to fix the issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D113993: WIP: [clang] customizable build-id style

kwk updated this revision to Diff 387608. kwk added a comment. Use correct CMake variable type: BOOLEAN -> BOOL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113993/new/ https://reviews.llvm.org/D113993 Files: clang/CMakeLists.txt Index: clang

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM with some suggestions, thanks for adding this notice! Comment at: clang/include/clang/Basic/DiagnosticGroups.td:57-59 +def DeprecatedCorotuine : + DiagGroup<"deprecat

[PATCH] D113993: WIP: [clang] customizable build-id style

kwk updated this revision to Diff 387610. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113993/new/ https://reviews.llvm.org/D113993 Files: clang/CMakeLists.txt clang/include/clang/Config/config.h.cmake clang/lib/Driver/ToolChains/Hurd.cpp I

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. These are the trigrams for quer

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 387615. kbobyrev added a comment. Add a small comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-tools-extra/clangd/index/dex/Trigram.cpp clan

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

JonChesterfield added a comment. If the amdgpu backend doesn't require this then it doesn't matter much if other passes undo it. If it's not an invariant, we don't need the verifier to alert people to passes that break it. Git blame on the new code in clang will lead people here where they may

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113538/new/ https://reviews.llvm.org/D113538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Apologies, I thought I had already accepted this. Thanks for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113538/new/ https://reviews.llvm.org/D113538 _

[PATCH] D113999: [clangd] Fix assertion crashes on unmatched NOLINTBEGIN comments.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. The overload shouldSuppre

[clang-tools-extra] 274f12a - [NFC][clangd] fix llvm-namespace-comment finding

Author: Christian Kühnel Date: 2021-11-16T15:10:32Z New Revision: 274f12a44c606ecd20152f3e63c4f186793d9a8c URL: https://github.com/llvm/llvm-project/commit/274f12a44c606ecd20152f3e63c4f186793d9a8c DIFF: https://github.com/llvm/llvm-project/commit/274f12a44c606ecd20152f3e63c4f186793d9a8c.diff L

[PATCH] D113895: [NFC][clangd] fix llvm-namespace-comment finding

This revision was automatically updated to reflect the committed changes. Closed by commit rG274f12a44c60: [NFC][clangd] fix llvm-namespace-comment finding (authored by kuhnel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113895/new/ https://revie

[clang] 4c8b8e0 - [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays

Author: Ahsan Saghir Date: 2021-11-16T09:14:41-06:00 New Revision: 4c8b8e0154f075e463428acc0640388c40d60097 URL: https://github.com/llvm/llvm-project/commit/4c8b8e0154f075e463428acc0640388c40d60097 DIFF: https://github.com/llvm/llvm-project/commit/4c8b8e0154f075e463428acc0640388c40d60097.diff

[PATCH] D113306: [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c8b8e0154f0: [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays (authored by saghir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113306

[clang-tools-extra] 75a0784 - [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h

Author: Christian Kühnel Date: 2021-11-16T15:25:43Z New Revision: 75a078455fc71cddc5e04b709b349125b610e1bb URL: https://github.com/llvm/llvm-project/commit/75a078455fc71cddc5e04b709b349125b610e1bb DIFF: https://github.com/llvm/llvm-project/commit/75a078455fc71cddc5e04b709b349125b610e1bb.diff L

[PATCH] D113889: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG75a078455fc7: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h (authored by kuhnel). Changed prior to commit: https://reviews.llvm.org/D113889?vs=387239&id=387634#toc Reposi

[PATCH] D113889: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h

kuhnel added a comment. I just checked with my local clangd and it does not crash on this file... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113889/new/ https://reviews.llvm.org/D113889 ___ cfe-commit

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

Mordante accepted this revision. Mordante added a comment. Thanks for working on this and landing the coroutines. LGTM after applying @ldionne's suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113977/new/ https://reviews.llvm.org/D11397

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

Quuxplusone requested changes to this revision. Quuxplusone added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11015-11017 + "Found deprecated std::experimental::%0. Consider to update your libc++ "

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

DaanDeMeyer created this revision. DaanDeMeyer added reviewers: eduucaldas, beccadax, sammccall, kadircet. DaanDeMeyer added a project: clang. Herald added a subscriber: usaxena95. DaanDeMeyer requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. When using cla

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

DaanDeMeyer added a comment. Added some people that were recent reviewers of changes to this file and some clangd folks. I don't have the time to properly test this unfortunately (aside from verifying that it fixes all the clangd crashes I'm having), but putting the patch up anyway in case any

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

NeHuang marked 7 inline comments as done. NeHuang added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1020 +// We can only do the optimization for the "reg + reg" form. +if (!(LiMI1 && (Opcode1 == PPC::LI || Opcode1 == PPC::LI8))) +

[clang] d4b28a0 - [NFC][clang] Inclusive language: replace master with main in convert_arm_neon.py

Author: Quinn Pham Date: 2021-11-16T10:11:06-06:00 New Revision: d4b28a0fe6857e0404d07b0989eeced05eaa45e7 URL: https://github.com/llvm/llvm-project/commit/d4b28a0fe6857e0404d07b0989eeced05eaa45e7 DIFF: https://github.com/llvm/llvm-project/commit/d4b28a0fe6857e0404d07b0989eeced05eaa45e7.diff LO

[PATCH] D113942: [NFC][clang] Inclusive language: replace master with main in convert_arm_neon.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4b28a0fe685: [NFC][clang] Inclusive language: replace master with main in convert_arm_neon.py (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D113993: WIP: [clang] customizable build-id style

kwk updated this revision to Diff 387650. kwk added a comment. enabled DEFAULT_LINKER_BUILD_ID_STYLE in linux Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113993/new/ https://reviews.llvm.org/D113993 Files: clang/CMakeLists.txt clang/include/

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

NeHuang updated this revision to Diff 387652. NeHuang added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111434/new/ https://reviews.llvm.org/D111434 Files: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp llvm/t

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

amyk accepted this revision. amyk added a comment. Thanks for addressing the review comments and answering my question. This LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111434/new/ https://reviews.llvm.org/D111434 _

[PATCH] D113433: [NFC][clang] Inclusive language: Rename myMaster in testcase

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113433/new/ https://reviews.llvm.org/D113433 _

[PATCH] D114006: [analyzer]{NFC} Enable access to CodeGenOptions from analyzer's instances.

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: martong, steakhal, Charusso, Szelethus, NoQ. ASDenysPetrov added a project: clang. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. ASDenysPetrov req

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

DaanDeMeyer updated this revision to Diff 387667. DaanDeMeyer added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114003/new/ https://reviews.llvm.org/D114003 Files: clang/lib/Lex/LiteralSupport.cpp Index: clang/lib/Lex

[PATCH] D113925: [HIP] Add HIP scope atomic operations

gandhi21299 updated this revision to Diff 387668. gandhi21299 marked an inline comment as done. gandhi21299 added a comment. - removed debug code - some macro definitions need to be defined for HIP-only compilation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

rnk added a comment. In D110257#3134001 , @JonChesterfield wrote: > So you won't articulate or document the new invariant and you think there's a > llvm-dev discussion that says we can't verify the invariant which you won't > reference, but means you w

[clang] 5ed404a - [NFC][clang] Inclusive language: Rename myMaster in testcase

Author: Quinn Pham Date: 2021-11-16T11:46:43-06:00 New Revision: 5ed404a4abd3fc3559ecc9dfc6cee83fcc3796e6 URL: https://github.com/llvm/llvm-project/commit/5ed404a4abd3fc3559ecc9dfc6cee83fcc3796e6 DIFF: https://github.com/llvm/llvm-project/commit/5ed404a4abd3fc3559ecc9dfc6cee83fcc3796e6.diff LO

[PATCH] D113433: [NFC][clang] Inclusive language: Rename myMaster in testcase

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ed404a4abd3: [NFC][clang] Inclusive language: Rename myMaster in testcase (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

beccadax requested changes to this revision. beccadax added a comment. This revision now requires changes to proceed. err_lexing_string’s message is “failure when lexing a string”

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:73 static bool DecodeAArch64Features(const Driver &D, StringRef text, std::vector &Features, llvm::AArch64::ArchKind Ar

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

bsmith added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:73 static bool DecodeAArch64Features(const Driver &D, StringRef text, std::vector &Features, llvm::AArch64::ArchKind ArchK

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:73 static bool DecodeAArch64Features(const Driver &D, StringRef text, std::vector &Features, llvm::AArch64::ArchKind Ar

[PATCH] D112374: [clang] WIP: Implement ElaboratedType sugaring for types written bare

mizvekov created this revision. Herald added subscribers: lxfind, jdoerfert. mizvekov updated this revision to Diff 382454. mizvekov added a comment. Herald added subscribers: carlosgalvezp, arphaman. mizvekov edited the summary of this revision. Herald added a subscriber: kristof.beyls. mizvekov u

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. Yes, this header does everything Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang updated this revision to Diff 387698. avogelsgesang marked 11 inline comments as done. avogelsgesang added a comment. Address review comments by @whisperity: - "containment" -> "membership" - "C++ 20" -> "C++20" - double-backticks in rst files - additonal test cases (both positive a

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 387699. mizvekov retitled this revision from "[clang] WIP: Implement ElaboratedType sugaring for types written bare" to "[clang] Implement ElaboratedType sugaring for types written bare". mizvekov edited the summary of this revision. mizvekov added a comment

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang marked 2 inline comments as not done. avogelsgesang added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerContainsCheck.cpp:105-108 + const auto *PositiveCheck = Result.Nodes.getNodeAs("positive"); + const auto *NegativeCheck = Resu

[clang] 4c484f1 - [llvm] Add a SFINAE template parameter to DenseMapInfo

Author: River Riddle Date: 2021-11-16T18:54:14Z New Revision: 4c484f11d355e4293f7b245a9330f0a1e89630ac URL: https://github.com/llvm/llvm-project/commit/4c484f11d355e4293f7b245a9330f0a1e89630ac DIFF: https://github.com/llvm/llvm-project/commit/4c484f11d355e4293f7b245a9330f0a1e89630ac.diff LOG:

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

michaelrj updated this revision to Diff 387703. michaelrj marked 6 inline comments as done. michaelrj added a comment. clean up the code and remove debug statements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113946/new/ https://reviews.llvm.org/

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

michaelrj added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp:13 +#include + sivachandra wrote: > Eugene.Zelenko wrote: > > Should be `` and without newline separation form rest of headers. > Looks like this is pr

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1315 + if ((SrcType->isHalfType() || iSFloat16Allowed) && + !CGF.getContext().getLangOpts().NativeHalfType) { // Cast to FP using the intrinsic if the half type itself isn't supported. -

[PATCH] D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances.

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Sweet! I think commit titles are not punctuated, even though they start with an uppercase letter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c484f11d355: [llvm] Add a SFINAE template parameter to DenseMapInfo (authored by rriddle). Changed prior to commit: https://reviews.llvm.org/D113

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

hans added a comment. We're seeing a diagnostic change in Chromium which looks funny. For the following code (span<> is our own class): int WontCompile() { const std::vector v; span s = make_span(v); } the diagnostic changes from: fatal error: no viable conversion from 'span' to

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae27ca9a6783: [PowerPC] PPC backend optimization on conditional trap intrustions (authored by NeHuang). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

michaelrj updated this revision to Diff 387713. michaelrj added a comment. add test for the new lint behavior: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113946/new/ https://reviews.llvm.org/D113946 Files: clang-tools-extra/clang-tidy/llvmlib

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

DaanDeMeyer updated this revision to Diff 387723. DaanDeMeyer added a comment. Addressed comments by adding two new errors, one for character literals and one for numeric literals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114003/new/ https://

[PATCH] D114011: Add a clang-transformer tutorial

ymandel created this revision. Herald added a subscriber: arphaman. ymandel updated this revision to Diff 387719. ymandel added a comment. ymandel edited the summary of this revision. ymandel added reviewers: gribozavr2, aaron.ballman. ymandel changed the edit policy from "All Users" to "Only User:

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

sivachandra accepted this revision. sivachandra added a comment. For libc requirements, LGTM. Please wait for @aaron.ballman for stamping the clang-tidy parts. Comment at: clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp:39 +// intercepted. +static const char *FU

[PATCH] D113889: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h

hokein added a comment. In D113889#3134857 , @kuhnel wrote: > I just checked with my local clangd and it does not crash on this file... yeah, this file is fine, the crash only occurs if you use an assertion-enabled clangd and the code has an unmatched `

[PATCH] D113840: [Driver][Android] Remove unneeded isNoExecStackDefault

pirama edited reviewers, added: srhines; removed: pirama. pirama added a comment. Will defer to Dan's review. I think these changes are safe for the Android platform (where we only use lld). The NDK only supports lld but that does not preclude external users from using other linkers. Reposit

  1   2   >