sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
Discussed offline, I believe the plan is to NOLINT the locations where we're handling several cases exhaustively. ================ Comment at: clang-tools-extra/clangd/Selection.cpp:350 } + /* fall through and treat as part of the macro body */ } ---------------- sammccall wrote: > FWIW I find this one *much* less clear :-( > I'd personally prefer to ignore the rule in this case, but curious what > others think I think this is a nolint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113892/new/ https://reviews.llvm.org/D113892 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits